170288 2017-03-30 11:55:48 -0700 We are spending a lot of time bzero'ing AudioChannel buffers on uni-watch.com 2017-03-30 13:46:09 -0700 1 1 1 Unclassified WebKit Web Audio WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez eric.carlson jer.noble oldest_to_newest 1292831 0 cdumez 2017-03-30 11:55:48 -0700 We are spending a lot of time bzero'ing AudioChannel buffers on uni-watch.com due to doubleclick ads using WebAudio with a 0-gain GainNode. We should optimize the 0-gain case as much as possible. 1292832 1 cdumez 2017-03-30 11:56:01 -0700 <rdar://problem/31289132> 1292843 2 305871 cdumez 2017-03-30 12:07:11 -0700 Created attachment 305871 Patch 1292911 3 305871 cdumez 2017-03-30 13:46:08 -0700 Comment on attachment 305871 Patch Clearing flags on attachment: 305871 Committed r214620: <http://trac.webkit.org/changeset/214620> 1292912 4 cdumez 2017-03-30 13:46:09 -0700 All reviewed patches have been landed. Closing bug. 305871 2017-03-30 12:07:11 -0700 2017-03-30 13:46:08 -0700 Patch bug-170288-20170330120708.patch text/plain 4642 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0NTYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTQ1ODllYjdkN2JmNWI0 NzE0OTgwNTkxZGE0Yzg1Zjc3MjJjZGQ2NC4uNjRmM2RmMTg4NTM4YTg4Y2I3ZTU2NmY4NGVmMjFk ZGE3ZWZmNzNjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDE3LTAzLTMwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgV2UgYXJlIHNwZW5kaW5nIGEg bG90IG9mIHRpbWUgYnplcm8naW5nIEF1ZGlvQ2hhbm5lbCBidWZmZXJzIG9uIHVuaS13YXRjaC5j b20KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDI4 OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzEyODkxMzI+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgYXJlIHNwZW5kaW5nIGEgbG90IG9mIHRp bWUgYnplcm8naW5nIEF1ZGlvQ2hhbm5lbCBidWZmZXJzIG9uIHVuaS13YXRjaC5jb20gZHVlCisg ICAgICAgIHRvIGRvdWJsZWNsaWNrIGFkcyB1c2luZyBXZWJBdWRpbyB3aXRoIGEgMC1nYWluIEdh aW5Ob2RlLiBXZSBzaG91bGQgb3B0aW1pemUgdGhlCisgICAgICAgIDAtZ2FpbiBjYXNlIGFzIG11 Y2ggYXMgcG9zc2libGUuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBvbmx5IGFuIG9wdGltaXph dGlvbi4KKworICAgICAgICAqIE1vZHVsZXMvd2ViYXVkaW8vQXVkaW9Ob2RlLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkF1ZGlvTm9kZTo6cHJvY2Vzc0lmTmVjZXNzYXJ5KToKKyAgICAgICAgRHJv cCBjYWxsIHRvIHVuc2lsZW5jZU91dHB1dHMoKSBiZWZvcmUgY2FsbGluZyBBdWRpb05vZGU6OnBy b2Nlc3MoKS4gVGhlIEF1ZGlvQ2hhbm5lbAorICAgICAgICBBUEkgYWxyZWFkeSB0YWtlcyBjYXJl IG9mIGNsZWFyaW5nIGl0cyAnc2lsZW50JyBmbGFnIHdoZW5ldmVyIGl0cyBidWZmZXIgY2hhbmdl cyBzbworICAgICAgICB0aGVyZSBzaG91bGQgYmUgbm8gbmVlZCB0byBleHBsaWNpdGx5IGNsZWFy aW5nIHRoZSAnc2lsZW50JyBmbGFnIGJlZm9yZSBjYWxsaW5nCisgICAgICAgIHByb2Nlc3MoKS4g VGhpcyB3YXMgY2F1c2luZyB1cyB0byB6ZXJvIG91dCBidWZmZXJzIHRoYXQgd2VyZSBhbHJlYWR5 IGZpbGxlZCB3aXRoCisgICAgICAgIHplcm9zIGJlY2F1c2UgQXVkaW9DaGFubmVsOjp6ZXJvKCkg d291bGQgbm8gbG9uZ2VyIHJldHVybiBlYXJseSwgbm90IGtub3dpbmcgdGhlCisgICAgICAgIGNo YW5uZWwgaXMgYWxyZWFkeSBzaWxlbnQuIFRoaXMgcmVkdWNlcyB0aGUgbnVtYmVyIG9mIGJ6ZXJv KCkgY2FsbHMgYnkgfjMuNXggb24KKyAgICAgICAgdW5pLXdhdGNoLmNvbSAoZnJvbSAxMDAgY2Fs bHMgZXZlcnkgfjIwbXMgdG8gMTAwIGNhbGxzIGV2ZXJ5IH43MG1zLgorCisgICAgICAgICogTW9k dWxlcy93ZWJhdWRpby9BdWRpb05vZGUuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9hdWRpby9tYWMv QXVkaW9EZXN0aW5hdGlvbk1hYy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBdWRpb0Rlc3RpbmF0 aW9uTWFjOjpyZW5kZXIpOgorICAgICAgICBBdm9pZCBjbGFtcGluZyB0aGUgdmFsdWVzIGluIHRo ZSBjaGFubmVsIGJ1ZmZlciBpZiB0aGUgY2hhbm5lbCBpcyBzaWxlbnQgc2luY2UgdGhpcworICAg ICAgICB3aWxsIGhhdmUgbm8gZWZmZWN0IChnaXZlbiB0aGF0IHRoZSBidWZmZXIgb25seSBjb250 YWlucyB6ZXJvcykuCisKIDIwMTctMDMtMjkgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNv bT4KIAogICAgICAgICBBbmltYXRlZCBTVkcgaW1hZ2VzIGFyZSBub3QgcGF1c2VkIGluIHBhZ2Vz IGxvYWRlZCBpbiB0aGUgYmFja2dyb3VuZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9k dWxlcy93ZWJhdWRpby9BdWRpb05vZGUuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJh dWRpby9BdWRpb05vZGUuY3BwCmluZGV4IDVjZDViODUwODg1NTE5MzcyNzE3MmJjNDQxYzA2NDU2 YTIyNjEzMzYuLmRhNTllYjFlMjkwOTQ2YjFjODI2YTk4ZTIzMzI3YjRjY2FkYTcwNWQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Ob2RlLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvTm9kZS5jcHAKQEAgLTMwNCwx MyArMzA0LDggQEAgdm9pZCBBdWRpb05vZGU6OnByb2Nlc3NJZk5lY2Vzc2FyeShzaXplX3QgZnJh bWVzVG9Qcm9jZXNzKQogCiAgICAgICAgIGlmIChzaWxlbnRJbnB1dHMgJiYgcHJvcGFnYXRlc1Np bGVuY2UoKSkKICAgICAgICAgICAgIHNpbGVuY2VPdXRwdXRzKCk7Ci0gICAgICAgIGVsc2Ugewot ICAgICAgICAgICAgLy8gVW5zaWxlbmNlIHRoZSBvdXRwdXRzIGZpcnN0IGJlY2F1c2UgdGhlIHBy b2Nlc3Npbmcgb2YgdGhlIG5vZGUgbWF5IGNhdXNlIHRoZSBvdXRwdXRzCi0gICAgICAgICAgICAv LyB0byBnbyBzaWxlbnQgYW5kIHdlIHdhbnQgdG8gcHJvcGFnYXRlIHRoYXQgaGludCB0byB0aGUg ZG93bnN0cmVhbSBub2RlcyEgIChGb3IKLSAgICAgICAgICAgIC8vIGV4YW1wbGUsIGEgR2FpbiBu b2RlIHdpdGggYSBnYWluIG9mIDAgd2lsbCB3YW50IHRvIHNpbGVuY2UgaXRzIG91dHB1dC4pCi0g ICAgICAgICAgICB1bnNpbGVuY2VPdXRwdXRzKCk7CisgICAgICAgIGVsc2UKICAgICAgICAgICAg IHByb2Nlc3MoZnJhbWVzVG9Qcm9jZXNzKTsKLSAgICAgICAgfQogICAgIH0KIH0KIApAQCAtMzU3 LDEyICszNTIsNiBAQCB2b2lkIEF1ZGlvTm9kZTo6c2lsZW5jZU91dHB1dHMoKQogICAgICAgICBv dXRwdXQtPmJ1cygpLT56ZXJvKCk7CiB9CiAKLXZvaWQgQXVkaW9Ob2RlOjp1bnNpbGVuY2VPdXRw dXRzKCkKLXsKLSAgICBmb3IgKGF1dG8mIG91dHB1dCA6IG1fb3V0cHV0cykKLSAgICAgICAgb3V0 cHV0LT5idXMoKS0+Y2xlYXJTaWxlbnRGbGFnKCk7Ci19Ci0KIHZvaWQgQXVkaW9Ob2RlOjplbmFi bGVPdXRwdXRzSWZOZWNlc3NhcnkoKQogewogICAgIGlmIChtX2lzRGlzYWJsZWQgJiYgbV9jb25u ZWN0aW9uUmVmQ291bnQgPiAwKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L3dlYmF1ZGlvL0F1ZGlvTm9kZS5oIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJhdWRpby9B dWRpb05vZGUuaAppbmRleCA3MmY4YTRhZjc5MzVlZjFjMjFiZGQ1YTdmNTNmMWZhNGE2MmMxYTc4 Li5mYmJjNWUwZjUwMzNkM2EyM2QyZDU4MWMwZGVkNjU0NGRkOGFlNGM4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmF1ZGlvL0F1ZGlvTm9kZS5oCisrKyBiL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvd2ViYXVkaW8vQXVkaW9Ob2RlLmgKQEAgLTE1Niw3ICsxNTYsNiBAQCBw dWJsaWM6CiAgICAgdmlydHVhbCBib29sIHByb3BhZ2F0ZXNTaWxlbmNlKCkgY29uc3Q7CiAgICAg Ym9vbCBpbnB1dHNBcmVTaWxlbnQoKTsKICAgICB2b2lkIHNpbGVuY2VPdXRwdXRzKCk7Ci0gICAg dm9pZCB1bnNpbGVuY2VPdXRwdXRzKCk7CiAKICAgICB2b2lkIGVuYWJsZU91dHB1dHNJZk5lY2Vz c2FyeSgpOwogICAgIHZvaWQgZGlzYWJsZU91dHB1dHNJZk5lY2Vzc2FyeSgpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vbWFjL0F1ZGlvRGVzdGluYXRpb25NYWMu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vbWFjL0F1ZGlvRGVzdGluYXRpb25N YWMuY3BwCmluZGV4IDY4MzQ0ZTA3ZDk5NjIxYTdjY2E1YzNmYWU4OTVhZGIyNjBlOGUxYzIuLjc2 NGEzNDdmOTgyOWUxZTg0NzViZDJlYTEyODBhYTE3NTAyNmVjZmMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL21hYy9BdWRpb0Rlc3RpbmF0aW9uTWFjLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9tYWMvQXVkaW9EZXN0aW5hdGlvbk1hYy5j cHAKQEAgLTE2Nyw3ICsxNjcsOCBAQCBPU1N0YXR1cyBBdWRpb0Rlc3RpbmF0aW9uTWFjOjpyZW5k ZXIoVUludDMyIG51bWJlck9mRnJhbWVzLCBBdWRpb0J1ZmZlckxpc3QqIGlvRAogICAgIC8vIENs YW1wIHZhbHVlcyBhdCAwZGIgKGkuZS4sIFstMS4wLCAxLjBdKQogICAgIGZvciAodW5zaWduZWQg aSA9IDA7IGkgPCBtX3JlbmRlckJ1cy0+bnVtYmVyT2ZDaGFubmVscygpOyArK2kpIHsKICAgICAg ICAgQXVkaW9DaGFubmVsKiBjaGFubmVsID0gbV9yZW5kZXJCdXMtPmNoYW5uZWwoaSk7Ci0gICAg ICAgIFZlY3Rvck1hdGg6OnZjbGlwKGNoYW5uZWwtPmRhdGEoKSwgMSwgJmtMb3dUaHJlc2hvbGQs ICZrSGlnaFRocmVzaG9sZCwgY2hhbm5lbC0+bXV0YWJsZURhdGEoKSwgMSwgbnVtYmVyT2ZGcmFt ZXMpOworICAgICAgICBpZiAoIWNoYW5uZWwtPmlzU2lsZW50KCkpCisgICAgICAgICAgICBWZWN0 b3JNYXRoOjp2Y2xpcChjaGFubmVsLT5kYXRhKCksIDEsICZrTG93VGhyZXNob2xkLCAma0hpZ2hU aHJlc2hvbGQsIGNoYW5uZWwtPm11dGFibGVEYXRhKCksIDEsIG51bWJlck9mRnJhbWVzKTsKICAg ICB9CiAKICAgICByZXR1cm4gbm9FcnI7Cg==