170286 2017-03-30 09:20:47 -0700 NetworkConnectionToWebProcess should stop web sockets when being destroyed 2017-04-05 10:56:54 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf achristensen beidson commit-queue oldest_to_newest 1292800 0 youennf 2017-03-30 09:20:47 -0700 If the Web Process is crashing, we should stop all web socket networking 1292801 1 305863 youennf 2017-03-30 09:22:06 -0700 Created attachment 305863 Patch 1292815 2 youennf 2017-03-30 09:39:01 -0700 (In reply to youenn fablet from comment #1) > Created attachment 305863 [details] > Patch I did manual testing to ensure this patch is working. We should probably write a test for it, like a unit test which would access a web socket server. 1292823 3 beidson 2017-03-30 10:00:29 -0700 (In reply to youenn fablet from comment #2) > (In reply to youenn fablet from comment #1) > > Created attachment 305863 [details] > > Patch > > I did manual testing to ensure this patch is working. > We should probably write a test for it, like a unit test which would access > a web socket server. We currently don't have the ability to write unit tests (e.g. API tests) that utilize HTTP. We only have an httpd available in layout tests. 1292851 4 305863 beidson 2017-03-30 12:39:14 -0700 Comment on attachment 305863 Patch ALEX! I TOLD YOU TO MAKE SURE THIS DIDN'T HAPPEN!!!!! 1292874 5 305863 commit-queue 2017-03-30 13:09:09 -0700 Comment on attachment 305863 Patch Clearing flags on attachment: 305863 Committed r214616: <http://trac.webkit.org/changeset/214616> 1292875 6 commit-queue 2017-03-30 13:09:11 -0700 All reviewed patches have been landed. Closing bug. 1294564 7 achristensen 2017-04-05 10:56:54 -0700 😳 305863 2017-03-30 09:22:06 -0700 2017-03-30 13:09:09 -0700 Patch bug-170286-20170330092205.patch text/plain 2295 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0NTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjE0ZDJhZDgzNTAyNmRk ZDFiZDhmODQxYTM1ODM3Yjk0OGQ1ZjQ1Mi4uYjRlMjQ3NGQyZTJjZjFlZGFmYmNlZWVkZjIyMjdl NDc2NmU5NTA5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTAzLTMwICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBOZXR3b3JrQ29ubmVjdGlv blRvV2ViUHJvY2VzcyBzaG91bGQgc3RvcCB3ZWIgc29ja2V0cyB3aGVuIGJlaW5nIGRlc3Ryb3ll ZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwMjg2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBOZXR3 b3JrUHJvY2Vzcy9OZXR3b3JrU29ja2V0U3RyZWFtLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TmV0 d29ya1NvY2tldFN0cmVhbTo6fk5ldHdvcmtTb2NrZXRTdHJlYW0pOiBTdG9wcGluZyB0aGUgc29j a2V0IGhhbmRsZSBpZiBub3QgZG9uZSBhbHJlYWR5LgorICAgICAgICAqIE5ldHdvcmtQcm9jZXNz L05ldHdvcmtTb2NrZXRTdHJlYW0uaDoKKwogMjAxNy0wMy0yOSAgQW50dGkgS29pdmlzdG8gIDxh bnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgSW5jcmVtZW50IHRoZSBsYXN0IHN0YWJsZSBuZXR3 b3JrIGNhY2hlIHZlcnNpb24gb24gTWFjCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3 b3JrUHJvY2Vzcy9OZXR3b3JrU29ja2V0U3RyZWFtLmNwcCBiL1NvdXJjZS9XZWJLaXQyL05ldHdv cmtQcm9jZXNzL05ldHdvcmtTb2NrZXRTdHJlYW0uY3BwCmluZGV4IGNlZGU1NGI2NzJkNDc3NjY0 N2NjNzQwMjM5NDRhMzBkYTUyYjYxMTUuLjI1OGI4ZTE1Yzc0N2E0OGFlNjEwOTRkOGE2ZTQwZTA3 Y2IxYTFmMjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdv cmtTb2NrZXRTdHJlYW0uY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05l dHdvcmtTb2NrZXRTdHJlYW0uY3BwCkBAIC01OSw2ICs1OSwxMSBAQCB2b2lkIE5ldHdvcmtTb2Nr ZXRTdHJlYW06OmNsb3NlKCkKICAgICBtX2ltcGwtPnBsYXRmb3JtQ2xvc2UoKTsKIH0KIAorTmV0 d29ya1NvY2tldFN0cmVhbTo6fk5ldHdvcmtTb2NrZXRTdHJlYW0oKQoreworICAgIGNsb3NlKCk7 Cit9CisKIHZvaWQgTmV0d29ya1NvY2tldFN0cmVhbTo6ZGlkT3BlblNvY2tldFN0cmVhbShTb2Nr ZXRTdHJlYW1IYW5kbGUmIGhhbmRsZSkKIHsKICAgICBBU1NFUlRfVU5VU0VEKGhhbmRsZSwgJmhh bmRsZSA9PSBtX2ltcGwucHRyKCkpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvTmV0d29y a1Byb2Nlc3MvTmV0d29ya1NvY2tldFN0cmVhbS5oIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1By b2Nlc3MvTmV0d29ya1NvY2tldFN0cmVhbS5oCmluZGV4IGYwYmMyNjA1YTBiYzRkYzczN2U2YTQ2 OWI3NTIzYjdiYTMxOTg4YmYuLjIwMmY0M2ZhMDk5NzYyYjNkNGEwMWE1MTQ5MjQ0ZjQ1YjVkYzEz MzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL05ldHdvcmtTb2Nr ZXRTdHJlYW0uaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9OZXR3b3JrU29j a2V0U3RyZWFtLmgKQEAgLTQ3LDcgKzQ3LDggQEAgbmFtZXNwYWNlIFdlYktpdCB7CiBjbGFzcyBO ZXR3b3JrU29ja2V0U3RyZWFtIDogcHVibGljIFJlZkNvdW50ZWQ8TmV0d29ya1NvY2tldFN0cmVh bT4sIHB1YmxpYyBJUEM6Ok1lc3NhZ2VTZW5kZXIsIHB1YmxpYyBJUEM6Ok1lc3NhZ2VSZWNlaXZl ciwgcHVibGljIFdlYkNvcmU6OlNvY2tldFN0cmVhbUhhbmRsZUNsaWVudCB7CiBwdWJsaWM6CiAg ICAgc3RhdGljIFJlZjxOZXR3b3JrU29ja2V0U3RyZWFtPiBjcmVhdGUoV2ViQ29yZTo6VVJMJiYs IFdlYkNvcmU6OlNlc3Npb25JRCwgY29uc3QgU3RyaW5nJiBjcmVkZW50aWFsUGFydGl0aW9uLCB1 aW50NjRfdCwgSVBDOjpDb25uZWN0aW9uJik7Ci0gICAgCisgICAgfk5ldHdvcmtTb2NrZXRTdHJl YW0oKTsKKwogICAgIHZvaWQgZGlkUmVjZWl2ZU1lc3NhZ2UoSVBDOjpDb25uZWN0aW9uJiwgSVBD OjpEZWNvZGVyJik7CiAKICAgICB2b2lkIHNlbmREYXRhKGNvbnN0IElQQzo6RGF0YVJlZmVyZW5j ZSYsIHVpbnQ2NF90KTsK