<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>170282</bug_id>
          
          <creation_ts>2017-03-30 05:16:23 -0700</creation_ts>
          <short_desc>[Webrtc] Mock realtime sources factories should be static after r213941</short_desc>
          <delta_ts>2017-04-05 10:16:00 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alejandro G. Castro">alex</reporter>
          <assigned_to name="Alejandro G. Castro">alex</assigned_to>
          <cc>achristensen</cc>
    
    <cc>clopez</cc>
    
    <cc>commit-queue</cc>
    
    <cc>jer.noble</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1292772</commentid>
    <comment_count>0</comment_count>
    <who name="Alejandro G. Castro">alex</who>
    <bug_when>2017-03-30 05:16:23 -0700</bug_when>
    <thetext>After r213941 there are factories to create RealtimeMediaSources, we have to make them static to avoid returning a local variable.RealtimeMediaSources,</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1292774</commentid>
    <comment_count>1</comment_count>
      <attachid>305858</attachid>
    <who name="Alejandro G. Castro">alex</who>
    <bug_when>2017-03-30 05:26:12 -0700</bug_when>
    <thetext>Created attachment 305858
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1294539</commentid>
    <comment_count>2</comment_count>
      <attachid>305858</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-04-05 10:15:59 -0700</bug_when>
    <thetext>Comment on attachment 305858
Patch

Clearing flags on attachment: 305858

Committed r214949: &lt;http://trac.webkit.org/changeset/214949&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1294540</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-04-05 10:16:00 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>305858</attachid>
            <date>2017-03-30 05:26:12 -0700</date>
            <delta_ts>2017-04-05 10:15:59 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-170282-20170330142534.patch</filename>
            <type>text/plain</type>
            <size>2329</size>
            <attacher name="Alejandro G. Castro">alex</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0NjAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzRmNzM2YmIyNTAxNDc1
OGQ5ZTNlMGM2Y2QyMzJjZGIxYWY1ZThjOS4uODZhYWI1MjNkOWMwNDU1ZmMyOTdhMWJhN2QxMzQx
M2Q3OTg0MTRkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTAzLTMwICBBbGVq
YW5kcm8gRy4gQ2FzdHJvICA8YWxleEBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXZWJydGNdIE1v
Y2sgcmVhbHRpbWUgc291cmNlcyBmYWN0b3JpZXMgc2hvdWxkIGJlIHN0YXRpYyBhZnRlciByMjEz
OTQxCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzAy
ODIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJZiB3
ZSBkb24ndCBtYWtlIHRoZSB2YXJpYWJsZXMgc3RhdGljIHdlIHdvdWxkIGJlIHJldHVybmluZyBh
CisgICAgICAgIGxvY2FsIHZhcmlhYmxlLgorCisgICAgICAgICogcGxhdGZvcm0vbW9jay9Nb2Nr
UmVhbHRpbWVBdWRpb1NvdXJjZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNb2NrUmVhbHRpbWVB
dWRpb1NvdXJjZTo6ZmFjdG9yeSk6CisgICAgICAgICogcGxhdGZvcm0vbW9jay9Nb2NrUmVhbHRp
bWVWaWRlb1NvdXJjZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNb2NrUmVhbHRpbWVWaWRlb1Nv
dXJjZTo6ZmFjdG9yeSk6CisKIDIwMTctMDMtMjkgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtp
dC5vcmc+CiAKICAgICAgICAgRGlzY29ubmVjdGluZyBhIEhUTUxPYmplY3RFbGVtZW50IGRvZXMg
bm90IGFsd2F5cyB1bmxvYWQgaXRzIGNvbnRlbnQgZG9jdW1lbnQKZGlmZiAtLWdpdCBhL1NvdXJj
ZS9XZWJDb3JlL3BsYXRmb3JtL21vY2svTW9ja1JlYWx0aW1lQXVkaW9Tb3VyY2UuY3BwIGIvU291
cmNlL1dlYkNvcmUvcGxhdGZvcm0vbW9jay9Nb2NrUmVhbHRpbWVBdWRpb1NvdXJjZS5jcHAKaW5k
ZXggMjA2NmVjNzA5ZGUzYWFjNzRmNjZhZTM1ZTc1ODU2MDYzMWEzMjE0Mi4uYmU2YmRiZmJlZWE1
YTBmYTJkNjA4MDQ3YjkyODkxNzQ0YzBlNzRmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv
cGxhdGZvcm0vbW9jay9Nb2NrUmVhbHRpbWVBdWRpb1NvdXJjZS5jcHAKKysrIGIvU291cmNlL1dl
YkNvcmUvcGxhdGZvcm0vbW9jay9Nb2NrUmVhbHRpbWVBdWRpb1NvdXJjZS5jcHAKQEAgLTcwLDcg
KzcwLDcgQEAgUmVmUHRyPE1vY2tSZWFsdGltZUF1ZGlvU291cmNlPiBNb2NrUmVhbHRpbWVBdWRp
b1NvdXJjZTo6Y3JlYXRlTXV0ZWQoY29uc3QgU3RyaW4KIAogUmVhbHRpbWVNZWRpYVNvdXJjZTo6
Q2FwdHVyZUZhY3RvcnkmIE1vY2tSZWFsdGltZUF1ZGlvU291cmNlOjpmYWN0b3J5KCkKIHsKLSAg
ICBOZXZlckRlc3Ryb3llZDxNb2NrUmVhbHRpbWVBdWRpb1NvdXJjZUZhY3Rvcnk+IGZhY3Rvcnk7
CisgICAgc3RhdGljIE5ldmVyRGVzdHJveWVkPE1vY2tSZWFsdGltZUF1ZGlvU291cmNlRmFjdG9y
eT4gZmFjdG9yeTsKICAgICByZXR1cm4gZmFjdG9yeS5nZXQoKTsKIH0KIApkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbW9jay9Nb2NrUmVhbHRpbWVWaWRlb1NvdXJjZS5jcHAg
Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tb2NrL01vY2tSZWFsdGltZVZpZGVvU291cmNlLmNw
cAppbmRleCAzODZiNGUzYzZjNzEzYzk5YzY0MWE0YzRjYzZhNDg2NWQ3ZGNiYmRjLi4zM2ZiYjE3
YjkxNGY2Y2VkMWI5OThiMzgyMDk4ZGI3ZjdjODc2ZDIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi
Q29yZS9wbGF0Zm9ybS9tb2NrL01vY2tSZWFsdGltZVZpZGVvU291cmNlLmNwcAorKysgYi9Tb3Vy
Y2UvV2ViQ29yZS9wbGF0Zm9ybS9tb2NrL01vY2tSZWFsdGltZVZpZGVvU291cmNlLmNwcApAQCAt
NzcsNyArNzcsNyBAQCBSZWZQdHI8TW9ja1JlYWx0aW1lVmlkZW9Tb3VyY2U+IE1vY2tSZWFsdGlt
ZVZpZGVvU291cmNlOjpjcmVhdGVNdXRlZChjb25zdCBTdHJpbgogCiBSZWFsdGltZU1lZGlhU291
cmNlOjpDYXB0dXJlRmFjdG9yeSYgTW9ja1JlYWx0aW1lVmlkZW9Tb3VyY2U6OmZhY3RvcnkoKQog
ewotICAgIE5ldmVyRGVzdHJveWVkPE1vY2tSZWFsdGltZVZpZGVvU291cmNlRmFjdG9yeT4gZmFj
dG9yeTsKKyAgICBzdGF0aWMgTmV2ZXJEZXN0cm95ZWQ8TW9ja1JlYWx0aW1lVmlkZW9Tb3VyY2VG
YWN0b3J5PiBmYWN0b3J5OwogICAgIHJldHVybiBmYWN0b3J5LmdldCgpOwogfQogCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>