170279 2017-03-30 03:28:18 -0700 Web Inspector: Assertion failure in InspectorStyleProperty::setRawTextFromStyleDeclaration 2017-03-30 15:37:38 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue hyatt inspector-bugzilla-changes oldest_to_newest 1292759 0 mattbaker 2017-03-30 03:28:18 -0700 Summary: Assertion failure in InspectorStyleProperty::setRawTextFromStyleDeclaration. InspectorStyleSheet.h:111: ASSERT(end <= styleDeclaration.length()); InspectorStyleProperty is being created with an invalid range end. The assertion is harmless, as String::substring checks the passed in length. Reproduced Test Case: <html> <style>html{-webkit-text-size-adjust:none}</style> </html> 1292760 1 mattbaker 2017-03-30 03:29:05 -0700 <rdar://problem/30200492> 1292762 2 305853 mattbaker 2017-03-30 03:54:02 -0700 Created attachment 305853 Patch 1292817 3 305853 bburg 2017-03-30 09:47:32 -0700 Comment on attachment 305853 Patch Please add a test case that asserts without this change. 1292854 4 305875 mattbaker 2017-03-30 12:44:25 -0700 Created attachment 305875 Patch 1292869 5 mattbaker 2017-03-30 12:50:59 -0700 Added a stylesheet to inspector/css/getAllStyleSheets.html, which did not cause the test to timeout when running with --debug, as I expected. Inspecting the test page in a debug build asserts as expected. 1292969 6 305875 hyatt 2017-03-30 15:15:32 -0700 Comment on attachment 305875 Patch r=me 1292981 7 305875 commit-queue 2017-03-30 15:37:37 -0700 Comment on attachment 305875 Patch Clearing flags on attachment: 305875 Committed r214634: <http://trac.webkit.org/changeset/214634> 1292982 8 commit-queue 2017-03-30 15:37:38 -0700 All reviewed patches have been landed. Closing bug. 305853 2017-03-30 03:54:02 -0700 2017-03-30 12:44:22 -0700 Patch bug-170279-20170330035404.patch text/plain 2336 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0NTQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWQzZWUyNzA2ZDUwMzU5 M2JhZTg4NDc2MmI0MzJjMjU0NDQ5NWQ0Zi4uMDM2ZGI1NTE2ZWFjNTAzNzg0ZTI4MGUwNDc0MzVi NDY4NzE5M2FiYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTAzLTMwICBNYXR0 IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBB c3NlcnRpb24gZmFpbHVyZSBpbiBJbnNwZWN0b3JTdHlsZVByb3BlcnR5OjpzZXRSYXdUZXh0RnJv bVN0eWxlRGVjbGFyYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE3MDI3OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzAyMDA0OTI+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIFNvdXJjZVJh bmdlIGZvciBhIENTU1Byb3BlcnR5U291cmNlRGF0YSBzaG91bGQgYmUgcmVsYXRpdmUgdG8gdGhl IHN0YXJ0CisgICAgICAgIG9mIHRoZSBkZWNsYXJhdGlvbiBib2R5LCBub3QgdGhlIHN0YXJ0IG9m IHRoZSBTdHlsZVNoZWV0SGFuZGxlcuKAmXMgcGFyc2VkCisgICAgICAgIHRleHQuIFRoaXMgb25s eSBhZmZlY3RlZCB0aGUgcmFuZ2VzIG9mIHVucGFyc2VkIChwYXJzZWRPSyA9PSBmYWxzZSkgcHJv cGVydGllcworICAgICAgICBsYWNraW5nIGEgdHJhaWxpbmcgc2VtaS1jb2xvbi4KKworICAgICAg ICBUaGlzIHBhdGNoIGRvZXNuJ3QgY2hhbmdlIHRoZSBiZWhhdmlvciBvZiBJbnNwZWN0b3JTdHls ZVNoZWV0IG90aGVyIHRoYW4KKyAgICAgICAgc2lsZW5jaW5nIGFuIGlya3NvbWUgYXNzZXJ0LCBh cyBTdHJpbmc6OnN1YnN0cmluZyBkb2VzIGEgc2FmZXR5IGNoZWNrIG9uCisgICAgICAgIHRoZSBw YXNzZWQgaW4gbGVuZ3RoLgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvclN0eWxlU2hl ZXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Zml4VW5wYXJzZWRQcm9wZXJ0aWVzKToKKwogMjAx Ny0wMy0yOSAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29tPgogCiAgICAgICAgIFtN b2Rlcm4gTWVkaWEgQ29udHJvbHNdIFZvbHVtZSBzbGlkZXIgaXMgaW5pdGlhbGx5IGVtcHR5CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yU3R5bGVTaGVldC5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yU3R5bGVTaGVldC5jcHAKaW5k ZXggYjBjNzI1YWUyZmY0YTM0ZjcyZjA3OWM1ZDUyNjVkMjk2ZmVjZDNlNy4uNmIwYThlZTdiYTJj ZmQ4ODhlNDkwNTY3Y2FhNGYxODc2N2QzMzk1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL0luc3BlY3RvclN0eWxlU2hlZXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9JbnNwZWN0b3JTdHlsZVNoZWV0LmNwcApAQCAtMjc4LDkgKzI3OCw5IEBAIHN0YXRp YyBpbmxpbmUgdm9pZCBmaXhVbnBhcnNlZFByb3BlcnRpZXMoY29uc3QgQ2hhcmFjdGVyVHlwZSog Y2hhcmFjdGVycywgQ1NTUnVsCiAgICAgICAgICAgICAtLXByb3BlcnR5RW5kOwogICAgICAgICAK ICAgICAgICAgLy8gcHJvcGVydHlFbmQgcG9pbnRzIGF0IHRoZSBsYXN0IHByb3BlcnR5IHRleHQg Y2hhcmFjdGVyLgotICAgICAgICB1bnNpZ25lZCBuZXdQcm9wZXJ0eUVuZCA9IHByb3BlcnR5RW5k ICsgc3R5bGVTdGFydCArIDE7Ci0gICAgICAgIGlmIChjdXJyZW50RGF0YS0+cmFuZ2UuZW5kICE9 IG5ld1Byb3BlcnR5RW5kKSB7Ci0gICAgICAgICAgICBjdXJyZW50RGF0YS0+cmFuZ2UuZW5kID0g bmV3UHJvcGVydHlFbmQ7CisgICAgICAgIHVuc2lnbmVkIG5ld1JhbmdlRW5kID0gKHByb3BlcnR5 RW5kIC0gc3R5bGVTdGFydCkgKyAxOworICAgICAgICBpZiAoY3VycmVudERhdGEtPnJhbmdlLmVu ZCAhPSBuZXdSYW5nZUVuZCkgeworICAgICAgICAgICAgY3VycmVudERhdGEtPnJhbmdlLmVuZCA9 IG5ld1JhbmdlRW5kOwogICAgICAgICAgICAgdW5zaWduZWQgdmFsdWVTdGFydCA9IHN0eWxlU3Rh cnQgKyBjdXJyZW50RGF0YS0+cmFuZ2Uuc3RhcnQgKyBjdXJyZW50RGF0YS0+bmFtZS5sZW5ndGgo KTsKICAgICAgICAgICAgIHdoaWxlICh2YWx1ZVN0YXJ0IDwgcHJvcGVydHlFbmQgJiYgY2hhcmFj dGVyc1t2YWx1ZVN0YXJ0XSAhPSAnOicpCiAgICAgICAgICAgICAgICAgKyt2YWx1ZVN0YXJ0Owo= 305875 2017-03-30 12:44:25 -0700 2017-03-30 15:37:37 -0700 Patch bug-170279-20170330124427.patch text/plain 4442 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0NjAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzRmNzM2YmIyNTAxNDc1 OGQ5ZTNlMGM2Y2QyMzJjZGIxYWY1ZThjOS4uYzlmZWRhNGUwYjVmOWRjYzNmYjQ2MDU1ODQxYjA5 NjZiODhkY2Q0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE3LTAzLTMwICBNYXR0 IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBB c3NlcnRpb24gZmFpbHVyZSBpbiBJbnNwZWN0b3JTdHlsZVByb3BlcnR5OjpzZXRSYXdUZXh0RnJv bVN0eWxlRGVjbGFyYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE3MDI3OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzAyMDA0OTI+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIFNvdXJjZVJh bmdlIGZvciBhIENTU1Byb3BlcnR5U291cmNlRGF0YSBzaG91bGQgYmUgcmVsYXRpdmUgdG8gdGhl IHN0YXJ0CisgICAgICAgIG9mIHRoZSBkZWNsYXJhdGlvbiBib2R5LCBub3QgdGhlIHN0YXJ0IG9m IHRoZSBTdHlsZVNoZWV0SGFuZGxlcuKAmXMgcGFyc2VkCisgICAgICAgIHRleHQuIFRoaXMgb25s eSBhZmZlY3RlZCB0aGUgcmFuZ2VzIG9mIHVucGFyc2VkIChwYXJzZWRPSyA9PSBmYWxzZSkgcHJv cGVydGllcworICAgICAgICBsYWNraW5nIGEgdHJhaWxpbmcgc2VtaS1jb2xvbi4KKworICAgICAg ICBUaGlzIHBhdGNoIGRvZXNuJ3QgY2hhbmdlIHRoZSBiZWhhdmlvciBvZiBJbnNwZWN0b3JTdHls ZVNoZWV0IG90aGVyIHRoYW4KKyAgICAgICAgc2lsZW5jaW5nIGFuIGlya3NvbWUgYXNzZXJ0LCBh cyBTdHJpbmc6OnN1YnN0cmluZyBkb2VzIGEgc2FmZXR5IGNoZWNrIG9uCisgICAgICAgIHRoZSBw YXNzZWQgaW4gbGVuZ3RoLgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvclN0eWxlU2hl ZXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Zml4VW5wYXJzZWRQcm9wZXJ0aWVzKToKKwogMjAx Ny0wMy0yOSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBEaXNj b25uZWN0aW5nIGEgSFRNTE9iamVjdEVsZW1lbnQgZG9lcyBub3QgYWx3YXlzIHVubG9hZCBpdHMg Y29udGVudCBkb2N1bWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0lu c3BlY3RvclN0eWxlU2hlZXQuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv clN0eWxlU2hlZXQuY3BwCmluZGV4IGIwYzcyNWFlMmZmNGEzNGY3MmYwNzljNWQ1MjY1ZDI5NmZl Y2QzZTcuLjZiMGE4ZWU3YmEyY2ZkODg4ZTQ5MDU2N2NhYTRmMTg3NjdkMzM5NWEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JTdHlsZVNoZWV0LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yU3R5bGVTaGVldC5jcHAKQEAgLTI3 OCw5ICsyNzgsOSBAQCBzdGF0aWMgaW5saW5lIHZvaWQgZml4VW5wYXJzZWRQcm9wZXJ0aWVzKGNv bnN0IENoYXJhY3RlclR5cGUqIGNoYXJhY3RlcnMsIENTU1J1bAogICAgICAgICAgICAgLS1wcm9w ZXJ0eUVuZDsKICAgICAgICAgCiAgICAgICAgIC8vIHByb3BlcnR5RW5kIHBvaW50cyBhdCB0aGUg bGFzdCBwcm9wZXJ0eSB0ZXh0IGNoYXJhY3Rlci4KLSAgICAgICAgdW5zaWduZWQgbmV3UHJvcGVy dHlFbmQgPSBwcm9wZXJ0eUVuZCArIHN0eWxlU3RhcnQgKyAxOwotICAgICAgICBpZiAoY3VycmVu dERhdGEtPnJhbmdlLmVuZCAhPSBuZXdQcm9wZXJ0eUVuZCkgewotICAgICAgICAgICAgY3VycmVu dERhdGEtPnJhbmdlLmVuZCA9IG5ld1Byb3BlcnR5RW5kOworICAgICAgICB1bnNpZ25lZCBuZXdS YW5nZUVuZCA9IChwcm9wZXJ0eUVuZCAtIHN0eWxlU3RhcnQpICsgMTsKKyAgICAgICAgaWYgKGN1 cnJlbnREYXRhLT5yYW5nZS5lbmQgIT0gbmV3UmFuZ2VFbmQpIHsKKyAgICAgICAgICAgIGN1cnJl bnREYXRhLT5yYW5nZS5lbmQgPSBuZXdSYW5nZUVuZDsKICAgICAgICAgICAgIHVuc2lnbmVkIHZh bHVlU3RhcnQgPSBzdHlsZVN0YXJ0ICsgY3VycmVudERhdGEtPnJhbmdlLnN0YXJ0ICsgY3VycmVu dERhdGEtPm5hbWUubGVuZ3RoKCk7CiAgICAgICAgICAgICB3aGlsZSAodmFsdWVTdGFydCA8IHBy b3BlcnR5RW5kICYmIGNoYXJhY3RlcnNbdmFsdWVTdGFydF0gIT0gJzonKQogICAgICAgICAgICAg ICAgICsrdmFsdWVTdGFydDsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBiZWU1NWUyNTkyYzRjZWFmYjczZDlmMmNjNmZhNjY1 NWE4MzIwZmI2Li5jN2UzODBjYTQ1YjU0MzQ3MGNhZDAyODllNWQ1YWFhNTVkMjFhNTFiIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTQgQEAKKzIwMTctMDMtMzAgIE1hdHQgQmFrZXIgIDxtYXR0YmFrZXJAYXBw bGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEFzc2VydGlvbiBmYWlsdXJlIGluIElu c3BlY3RvclN0eWxlUHJvcGVydHk6OnNldFJhd1RleHRGcm9tU3R5bGVEZWNsYXJhdGlvbgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwMjc5CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS8zMDIwMDQ5Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9jc3MvZ2V0QWxsU3R5bGVTaGVldHMu aHRtbDoKKyAgICAgICAgQWRkIHN0eWxlc2hlZXQgd2l0aCBhbiAidW5wYXJzZWQiIHByb3BlcnR5 IGhhdmluZyBubyBmaW5hbCBzZW1pY29sb24uCisKIDIwMTctMDMtMzAgIFBlciBBcm5lIFZvbGxh biAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ofnIyMTIzMjIpOiBM YXlvdXRUZXN0IG1lZGlhL3RyYWNrL3RyYWNrLWN1ZS1jb250YWluZXItcmVuZGVyaW5nLXBvc2l0 aW9uLmh0bWwgaXMgYSBmbGFreSB0aW1lb3V0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNw ZWN0b3IvY3NzL2dldEFsbFN0eWxlU2hlZXRzLmh0bWwgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3Iv Y3NzL2dldEFsbFN0eWxlU2hlZXRzLmh0bWwKaW5kZXggNTNmNWMyYTQzZDlhMDk5NDQ3ZGQ4ZDRm YzJlMzQ5ZDhiNzIwNzllOC4uNWIxYTUxZGVhYzQzY2NlNzFkMDk4ODc3ZWZhZmY1NmFkNzU2Mzkw YyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2Nzcy9nZXRBbGxTdHlsZVNoZWV0 cy5odG1sCisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9jc3MvZ2V0QWxsU3R5bGVTaGVldHMu aHRtbApAQCAtNCw2ICs0LDEyIEBACiA8c2NyaXB0IHNyYz0iLi4vLi4vaHR0cC90ZXN0cy9pbnNw ZWN0b3IvcmVzb3VyY2VzL2luc3BlY3Rvci10ZXN0LmpzIj48L3NjcmlwdD4KIDxsaW5rIHJlbD0i c3R5bGVzaGVldCIgaHJlZj0icmVzb3VyY2VzL2V4dGVybmFsLmNzcyI+CiA8c3R5bGU+Ym9keSB7 IGNvbG9yOiBibHVlOyB9PC9zdHlsZT4KKzxzdHlsZT4KK2h0bWwgeworICAgIC8qIFNlbWljb2xv biBhZnRlciB2YWx1ZSBpbnRlbnRpb25hbGx5IG9taXR0ZWQuIFRlc3QgZm9yIGh0dHBzOi8vd2Vi a2l0Lm9yZy9iLzE3MDI3OS4gKi8KKyAgICAtd2Via2l0LXRleHQtc2l6ZS1hZGp1c3Q6IG5vbmUK K30KKzwvc3R5bGU+CiA8c2NyaXB0PgogdmFyIHN0eWxlID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVu dCgic3R5bGUiKTsKIHN0eWxlLnRleHRDb250ZW50ID0gImJvZHkgeyBjb2xvcjogZ3JheTsgfSI7 CkBAIC0yMCw3ICsyNiw3IEBAIGZ1bmN0aW9uIHRlc3QoKQogICAgIFdlYkluc3BlY3Rvci5jc3NT dHlsZU1hbmFnZXIuZmV0Y2hTdHlsZVNoZWV0c0lmTmVlZGVkKCk7CiAgICAgSW5zcGVjdG9yQmFj a2VuZC5ydW5BZnRlclBlbmRpbmdEaXNwYXRjaGVzKGZ1bmN0aW9uKCkgewogICAgICAgICBsZXQg c3R5bGVTaGVldHMgPSBXZWJJbnNwZWN0b3IuY3NzU3R5bGVNYW5hZ2VyLnN0eWxlU2hlZXRzOwot ICAgICAgICBJbnNwZWN0b3JUZXN0LmV4cGVjdFRoYXQoc3R5bGVTaGVldHMubGVuZ3RoID09PSAz LCAiVGhlcmUgc2hvdWxkIGJlIHRocmVlIHN0eWxlc2hlZXRzLiIpOworICAgICAgICBJbnNwZWN0 b3JUZXN0LmV4cGVjdFRoYXQoc3R5bGVTaGVldHMubGVuZ3RoID09PSA0LCAiVGhlcmUgc2hvdWxk IGJlIGZvdXIgc3R5bGVzaGVldHMuIik7CiAKICAgICAgICAgZm9yIChsZXQgc3R5bGVTaGVldCBv ZiBzdHlsZVNoZWV0cykgewogICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5sb2coIiIpOwo=