170277 2017-03-30 02:41:59 -0700 [Modern Media Controls] Invalid placard icon is not visible for short video 2017-03-30 10:06:27 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=167935 InRadar P2 Normal --- 1 graouts graouts commit-queue eric.carlson webkit-bug-importer oldest_to_newest 1292754 0 graouts 2017-03-30 02:41:59 -0700 A video with a relatively short height may not show the invalid placard icon due to https://bugs.webkit.org/show_bug.cgi?id=167935. 1292755 1 graouts 2017-03-30 02:42:14 -0700 <rdar://problem/31327955> 1292757 2 305852 graouts 2017-03-30 03:01:37 -0700 Created attachment 305852 Patch 1292826 3 305852 commit-queue 2017-03-30 10:06:24 -0700 Comment on attachment 305852 Patch Clearing flags on attachment: 305852 Committed r214611: <http://trac.webkit.org/changeset/214611> 1292827 4 commit-queue 2017-03-30 10:06:27 -0700 All reviewed patches have been landed. Closing bug. 305852 2017-03-30 03:01:37 -0700 2017-03-30 10:06:24 -0700 Patch bug-170277-20170330120136.patch text/plain 7201 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0NTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWEzNTNlMjI3MjBmMWE5 ZmU4OGUyZjFjZjQ3NzMxODY2NTQzYTVkYi4uY2FmMWU1Y2Y5ODMxMjVkMTA5MzI5OGJmZjg2ZTQ3 MTA1ZWU4YTJmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE3LTAzLTMwICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgW01vZGVybiBNZWRpYSBD b250cm9sc10gSW52YWxpZCBwbGFjYXJkIGljb24gaXMgbm90IHZpc2libGUgZm9yIHNob3J0IHZp ZGVvCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzAy NzcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMxMzI3OTU1PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1ha2UgdGhlIG1pbmltdW0gZGltZW5zaW9u IG5lZWRlZCB0byBkaXNwbGF5IGEgcGxhY2FyZCBpY29uIGNvbmZpZ3VyYWJsZSBhbmQgbGV0IHRo ZQorICAgICAgICBpbnZhbGlkIHBsYWNhcmQgdXNlIGEgNTBwdCBkaW1lbnNpb24uIFdlIGFsc28g bWFrZSBhIGRyaXZlLWJ5IGZpeCB0byByZXNldCAidGV4dC1hbGlnbiIKKyAgICAgICAgZm9yIG1l ZGlhIGNvbnRyb2xzIGFzIGhhdmluZyBhICJ0ZXh0LWFsaWduOiBjZW50ZXIiIGluaGVyaXRlZCB2 YWx1ZSB3b3VsZCBtZXNzIHVwCisgICAgICAgIHBvc2l0aW9uaW5nIG9mIHRoZSBwbGFjYXJkIGlj b24gYW5kIG1ha2UgaXQgZmx1c2ggdG8gdGhlIHJpZ2h0IG9mIHRoZSBwbGFjYXJkLgorCisgICAg ICAgIFRlc3Q6IG1lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy9pbnZhbGlkLXBsYWNhcmQvaW52 YWxpZC1wbGFjYXJkLWNvbnN0cmFpbmVkLW1ldHJpY3MuaHRtbAorCisgICAgICAgICogTW9kdWxl cy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvY29udHJvbHMvaW52YWxpZC1wbGFjYXJkLmpzOgorICAg ICAgICAoSW52YWxpZFBsYWNhcmQpOgorICAgICAgICAqIE1vZHVsZXMvbW9kZXJuLW1lZGlhLWNv bnRyb2xzL2NvbnRyb2xzL21lZGlhLWNvbnRyb2xzLmNzczoKKyAgICAgICAgKC5tZWRpYS1jb250 cm9scyk6CisgICAgICAgICogTW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvY29udHJvbHMv cGxhY2FyZC5qczoKKyAgICAgICAgKFBsYWNhcmQucHJvdG90eXBlLmxheW91dCk6CisKIDIwMTct MDMtMjkgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAg TGlua3Mgd2l0aCBlbXB0eSBocmVmcyBzaG91bGQgbm90IGJlIGRyYWcgc291cmNlcwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvY29udHJv bHMvaW52YWxpZC1wbGFjYXJkLmpzIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tb2Rlcm4tbWVk aWEtY29udHJvbHMvY29udHJvbHMvaW52YWxpZC1wbGFjYXJkLmpzCmluZGV4IDE4ZDNhZjI5YjNl ZWJiYTFiMzUyMjYxZGYyMzU4OTQ5MGFmZmQ0YjguLjRhMDczYzViZTQ0MmNkYmYyYjhiN2MwOTc0 NmJhMDMwYTUyY2FkZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbW9kZXJu LW1lZGlhLWNvbnRyb2xzL2NvbnRyb2xzL2ludmFsaWQtcGxhY2FyZC5qcworKysgYi9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9jb250cm9scy9pbnZhbGlkLXBs YWNhcmQuanMKQEAgLTMyLDYgKzMyLDggQEAgY2xhc3MgSW52YWxpZFBsYWNhcmQgZXh0ZW5kcyBQ bGFjYXJkCiAgICAgICAgICAgICBpY29uTmFtZTogSWNvbnMuSW52YWxpZFBsYWNhcmQsCiAgICAg ICAgICAgICBsYXlvdXREZWxlZ2F0ZQogICAgICAgICB9KTsKKworICAgICAgICB0aGlzLm1pbkRp bWVuc2lvblRvRGlzcGxheUljb24gPSA1MDsKICAgICB9CiAKIH0KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL01vZHVsZXMvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL2NvbnRyb2xzL21lZGlhLWNv bnRyb2xzLmNzcyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbW9kZXJuLW1lZGlhLWNvbnRyb2xz L2NvbnRyb2xzL21lZGlhLWNvbnRyb2xzLmNzcwppbmRleCBlZDljOWQxMGYyMzg3M2IxN2FjYjk1 Yjc5YTU4MGE2NjRlN2ZmNjc1Li5kY2QxOWZjY2U4OTNhODE3ZDVjM2I1MmZmZTczYmM5N2MwYmNl OTYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21vZGVybi1tZWRpYS1jb250 cm9scy9jb250cm9scy9tZWRpYS1jb250cm9scy5jc3MKKysrIGIvU291cmNlL1dlYkNvcmUvTW9k dWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHMvY29udHJvbHMvbWVkaWEtY29udHJvbHMuY3NzCkBA IC03MCw2ICs3MCw3IEBACiAgICAgZm9udC1mYW1pbHk6IC1hcHBsZS1zeXN0ZW07CiAgICAgLXdl YmtpdC11c2VyLXNlbGVjdDogbm9uZTsKICAgICB3aGl0ZS1zcGFjZTogbm93cmFwOworICAgIHRl eHQtYWxpZ246IGluaXRpYWw7CiAgICAgY3Vyc29yOiBkZWZhdWx0OwogfQogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9jb250cm9scy9w bGFjYXJkLmpzIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tb2Rlcm4tbWVkaWEtY29udHJvbHMv Y29udHJvbHMvcGxhY2FyZC5qcwppbmRleCA1NTY0YmEzYWQ3ZWVlZmZmYjVhZTRiZGM5ZjAwODY1 MmI5YWU1ZGUzLi4zYjBmMGZkNGQxM2Q2MjgzNWY3NWY0ZTJjMTM2YjhlOWIxMmFiNzYxIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21vZGVybi1tZWRpYS1jb250cm9scy9jb250 cm9scy9wbGFjYXJkLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbW9kZXJuLW1lZGlh LWNvbnRyb2xzL2NvbnRyb2xzL3BsYWNhcmQuanMKQEAgLTIzLDggKzIzLDYgQEAKICAqIE9GIFRI SVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBE QU1BR0UuCiAgKi8KIAotY29uc3QgTWluV2lkdGhUb0Rpc3BsYXlJY29uID0gMTcwOwotY29uc3Qg TWluSGVpZ2h0VG9EaXNwbGF5SWNvbiA9IDE3MDsKIGNvbnN0IE1pbkhlaWdodFRvRGlzcGxheURl c2NyaXB0aW9uID0gMTAwOwogY29uc3QgTWluSGVpZ2h0VG9EaXNwbGF5VGl0bGUgPSA0MDsKIApA QCAtNTEsNiArNDksOCBAQCBjbGFzcyBQbGFjYXJkIGV4dGVuZHMgTGF5b3V0SXRlbQogICAgICAg ICBpZiAoISFkZXNjcmlwdGlvbikKICAgICAgICAgICAgIHRoaXMuX2Rlc2NyaXB0aW9uTm9kZSA9 IG5ldyBMYXlvdXROb2RlKGA8ZGl2IGNsYXNzPSJkZXNjcmlwdGlvbiI+JHtkZXNjcmlwdGlvbn08 L2Rpdj5gKTsKIAorICAgICAgICB0aGlzLm1pbkRpbWVuc2lvblRvRGlzcGxheUljb24gPSAxNzA7 CisKICAgICAgICAgdGhpcy53aWR0aCA9IHdpZHRoOwogICAgICAgICB0aGlzLmhlaWdodCA9IGhl aWdodDsKICAgICB9CkBAIC02Myw3ICs2Myw3IEBAIGNsYXNzIFBsYWNhcmQgZXh0ZW5kcyBMYXlv dXRJdGVtCiAKICAgICAgICAgY29uc3QgY2hpbGRyZW4gPSBbXTsKIAotICAgICAgICBpZiAodGhp cy5faWNvbkJ1dHRvbiAmJiB0aGlzLndpZHRoID49IE1pbldpZHRoVG9EaXNwbGF5SWNvbiAmJiB0 aGlzLmhlaWdodCA+PSBNaW5IZWlnaHRUb0Rpc3BsYXlJY29uKQorICAgICAgICBpZiAodGhpcy5f aWNvbkJ1dHRvbiAmJiB0aGlzLndpZHRoID49IHRoaXMubWluRGltZW5zaW9uVG9EaXNwbGF5SWNv biAmJiB0aGlzLmhlaWdodCA+PSB0aGlzLm1pbkRpbWVuc2lvblRvRGlzcGxheUljb24pCiAgICAg ICAgICAgICBjaGlsZHJlbi5wdXNoKHRoaXMuX2ljb25CdXR0b24pOwogCiAgICAgICAgIGlmICh0 aGlzLl90aXRsZU5vZGUgJiYgdGhpcy5oZWlnaHQgPj0gTWluSGVpZ2h0VG9EaXNwbGF5VGl0bGUp CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKaW5kZXggZmZhYWFhMDcxMjg4NjAyYmExMWJmZGZlY2UwM2JjMWFiZWU3MDMzYS4uYzFiZmIw MzEzYjU1MmY5ODZkMTg3YjM5MTcxZDNhYzZkMzBhOWYxNiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBA CisyMDE3LTAzLTMwICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAg ICAgW01vZGVybiBNZWRpYSBDb250cm9sc10gSW52YWxpZCBwbGFjYXJkIGljb24gaXMgbm90IHZp c2libGUgZm9yIHNob3J0IHZpZGVvCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xNzAyNzcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMxMzI3OTU1Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIG5l dyB0ZXN0IHRvIGNoZWNrIHRoYXQgd2UgY29ycmVjdGx5IGhpZGUgdGhlIGludmFsaWQgaWNvbiBv bmx5IHdoZW4KKyAgICAgICAgdGhlcmUgaXMgbm8gc3BhY2UgbGVmdCB0byBkaXNwbGF5IGl0Lgor CisgICAgICAgICogbWVkaWEvbW9kZXJuLW1lZGlhLWNvbnRyb2xzL2ludmFsaWQtcGxhY2FyZC9p bnZhbGlkLXBsYWNhcmQtY29uc3RyYWluZWQtbWV0cmljcy1leHBlY3RlZC50eHQ6IEFkZGVkLgor ICAgICAgICAqIG1lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy9pbnZhbGlkLXBsYWNhcmQvaW52 YWxpZC1wbGFjYXJkLWNvbnN0cmFpbmVkLW1ldHJpY3MuaHRtbDogQWRkZWQuCisKIDIwMTctMDMt MjkgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4KIAogICAgICAgICBQ b3N0LWNvbW1pdCB0ZXN0IGdhcmRlbmluZyBhZnRlciByMjE0NTQ2CmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9tZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvaW52YWxpZC1wbGFjYXJkL2ludmFs aWQtcGxhY2FyZC1jb25zdHJhaW5lZC1tZXRyaWNzLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3Rz L21lZGlhL21vZGVybi1tZWRpYS1jb250cm9scy9pbnZhbGlkLXBsYWNhcmQvaW52YWxpZC1wbGFj YXJkLWNvbnN0cmFpbmVkLW1ldHJpY3MtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjYyMmRlOWEz OGM0NWI2ZjgxOGRlYmU0M2Q2N2Y0OWRiMmQ4NjFhZTcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlv dXRUZXN0cy9tZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJvbHMvaW52YWxpZC1wbGFjYXJkL2ludmFs aWQtcGxhY2FyZC1jb25zdHJhaW5lZC1tZXRyaWNzLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDE3 IEBACitUZXN0aW5nIHRoZSBpbnZhbGlkIHBsYWNhcmQgd2l0aCBjb25zdHJhaW5lZCBtZXRyaWNz LgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2Vz LCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworU2V0dGluZyB3aWR0aCBhbmQgaGVp Z2h0IHRvIDUwCitQQVNTIHBsYWNhcmQuY2hpbGRyZW5bMF0uY2hpbGRyZW4ubGVuZ3RoIGlzIDEK K1BBU1MgcGxhY2FyZC5jaGlsZHJlblswXS5jaGlsZHJlbi5sZW5ndGggaXMgMQorUEFTUyBwbGFj YXJkLmNoaWxkcmVuWzBdLmNoaWxkcmVuWzBdIGluc3RhbmNlb2YgSWNvbkJ1dHRvbiBpcyB0cnVl CisKK1NldHRpbmcgd2lkdGggYW5kIGhlaWdodCB0byA0OQorUEFTUyBwbGFjYXJkLmNoaWxkcmVu WzBdLmNoaWxkcmVuLmxlbmd0aCBpcyAwCisKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRy dWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9tZWRpYS9tb2Rl cm4tbWVkaWEtY29udHJvbHMvaW52YWxpZC1wbGFjYXJkL2ludmFsaWQtcGxhY2FyZC1jb25zdHJh aW5lZC1tZXRyaWNzLmh0bWwgYi9MYXlvdXRUZXN0cy9tZWRpYS9tb2Rlcm4tbWVkaWEtY29udHJv bHMvaW52YWxpZC1wbGFjYXJkL2ludmFsaWQtcGxhY2FyZC1jb25zdHJhaW5lZC1tZXRyaWNzLmh0 bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMC4uNTdiMjJjOGI4YmYzNzFkNTQ5ZDM3NDljNzU4OWUxOTRhZDc1OTQ3OAot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL21lZGlhL21vZGVybi1tZWRpYS1jb250cm9s cy9pbnZhbGlkLXBsYWNhcmQvaW52YWxpZC1wbGFjYXJkLWNvbnN0cmFpbmVkLW1ldHJpY3MuaHRt bApAQCAtMCwwICsxLDI3IEBACis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vcmVzb3VyY2VzL2pzLXRl c3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMvbWVkaWEtY29u dHJvbHMtbG9hZGVyLmpzIiB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPjwvc2NyaXB0PgorPGJvZHk+ Cis8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CisKK2Rlc2NyaXB0aW9uKCJUZXN0aW5n IHRoZSBpbnZhbGlkIHBsYWNhcmQgd2l0aCBjb25zdHJhaW5lZCBtZXRyaWNzLiIpOworCitjb25z dCBwbGFjYXJkID0gbmV3IEludmFsaWRQbGFjYXJkKHsgbGF5b3V0VHJhaXRzOiBMYXlvdXRUcmFp dHMubWFjT1MgfSk7CisKK2RlYnVnKCJTZXR0aW5nIHdpZHRoIGFuZCBoZWlnaHQgdG8gNTAiKTsK K3BsYWNhcmQud2lkdGggPSA1MDsKK3BsYWNhcmQuaGVpZ2h0ID0gNTA7CitzaG91bGRCZSgicGxh Y2FyZC5jaGlsZHJlblswXS5jaGlsZHJlbi5sZW5ndGgiLCAiMSIpOworc2hvdWxkQmUoInBsYWNh cmQuY2hpbGRyZW5bMF0uY2hpbGRyZW4ubGVuZ3RoIiwgIjEiKTsKK3Nob3VsZEJlVHJ1ZSgicGxh Y2FyZC5jaGlsZHJlblswXS5jaGlsZHJlblswXSBpbnN0YW5jZW9mIEljb25CdXR0b24iKTsKKwor ZGVidWcoIiIpOworZGVidWcoIlNldHRpbmcgd2lkdGggYW5kIGhlaWdodCB0byA0OSIpOworcGxh Y2FyZC53aWR0aCA9IDQ5OworcGxhY2FyZC5oZWlnaHQgPSA0OTsKK3Nob3VsZEJlKCJwbGFjYXJk LmNoaWxkcmVuWzBdLmNoaWxkcmVuLmxlbmd0aCIsICIwIik7CisKK2RlYnVnKCIiKTsKKworPC9z Y3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+ PC9zY3JpcHQ+Cis8L2JvZHk+Cg==