170255 2017-03-29 13:51:43 -0700 webkitpy: Robust test clean-up 2017-03-31 16:38:54 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard ap buildbot commit-queue dbates glenn lforschler webkit-bug-importer oldest_to_newest 1292555 0 jbedard 2017-03-29 13:51:43 -0700 Currently when running layouts tests, clean-up only occurs if setup has been successful. If setup throws an exception, this can result in file or programs left running. This is of particular concern for something like an iOS Simulator. We should run teardown even if setup throws an exception and we should teardown all devices even if one or more of them throws an exception while being torn down. 1292556 1 webkit-bug-importer 2017-03-29 13:52:09 -0700 <rdar://problem/31329367> 1292560 2 305782 jbedard 2017-03-29 13:56:44 -0700 Created attachment 305782 Patch 1292602 3 jbedard 2017-03-29 15:14:45 -0700 EWS failure is unrelated to this patch and is a problem on the bot. 1292614 4 305782 commit-queue 2017-03-29 15:44:45 -0700 Comment on attachment 305782 Patch Clearing flags on attachment: 305782 Committed r214569: <http://trac.webkit.org/changeset/214569> 1292615 5 commit-queue 2017-03-29 15:44:48 -0700 All reviewed patches have been landed. Closing bug. 1293364 6 jbedard 2017-03-31 16:38:54 -0700 https://trac.webkit.org/changeset/214698/webkit has a minor fix to this patch. 305782 2017-03-29 13:56:44 -0700 2017-03-29 15:44:45 -0700 Patch bug-170255-20170329135644.patch text/plain 3670 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNDU2MCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE5IEBACisyMDE3LTAzLTI5ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICB3ZWJraXRweTogUm9idXN0IHRlc3QgY2xlYW4tdXAKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDI1NQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9uLWRldmljZSB0ZXN0aW5nIGlz IHRoZSBtb3RpdmF0aW9uIGZvciB0aGlzIGNoYW5nZS4gIEZhaWx1cmUgdG8gcnVuIGNsZWFuLXVw IGZ1bmN0aW9ucyBjYW4KKyAgICAgICAgcmVzdWx0IGluIHpvbWJpZSBwcm9jZXNzZXMsIHJlc2lk dWFsIE5GUyBtb3VudHMgYW5kIG90aGVyIHVuZGVzaXJhYmxlIHJlbW5hbnRzIGZyb20gYSBmYWls ZWQKKyAgICAgICAgdGVzdCBydW4uICBNYWtlIGFuIGVmZm9ydCB0byBjbGVhbi11cCBldmVuIGlm IGV4Y2VwdGlvbnMgYXJlIHRocm93biBkdXJpbmcgc2V0LXVwIG9yIGNsZWFuLXVwLgorCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlci5w eToKKyAgICAgICAgKE1hbmFnZXIuX3NldF91cF9ydW4pOiBDbGVhbiB1cCB0ZXN0IHJ1biBpZiBz ZXQtdXAgZmFpbHMuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L2lvcy5weToKKyAg ICAgICAgKElPU1BvcnQuY2xlYW5fdXBfdGVzdF9ydW4pOiBDb250aW51ZSBjbGVhbmluZyB1cCBk ZXZpY2VzIGV2ZW4gYWZ0ZXIgYW4gZXhjZXB0aW9uIGlzIHRocm93bi4KKwogMjAxNy0wMy0yOSAg Sm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgd2Via2l0cHk6 IFN0YW5kYXJkaXplIHdlYi1zZXJ2ZXIgcG9ydCBkZWZpbml0aW9ucwpJbmRleDogVG9vbHMvU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlci5weQo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9t YW5hZ2VyLnB5CShyZXZpc2lvbiAyMTQ1NjApCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xODgs NyArMTg4LDExIEBAIGNsYXNzIE1hbmFnZXIob2JqZWN0KToKICAgICAgICAgIyBDcmVhdGUgdGhl IG91dHB1dCBkaXJlY3RvcnkgaWYgaXQgZG9lc24ndCBhbHJlYWR5IGV4aXN0LgogICAgICAgICBz ZWxmLl9wb3J0Lmhvc3QuZmlsZXN5c3RlbS5tYXliZV9tYWtlX2RpcmVjdG9yeShzZWxmLl9yZXN1 bHRzX2RpcmVjdG9yeSkKIAotICAgICAgICBzZWxmLl9wb3J0LnNldHVwX3Rlc3RfcnVuKHNlbGYu X29wdGlvbnMuZGV2aWNlX2NsYXNzKQorICAgICAgICB0cnk6CisgICAgICAgICAgICBzZWxmLl9w b3J0LnNldHVwX3Rlc3RfcnVuKHNlbGYuX29wdGlvbnMuZGV2aWNlX2NsYXNzKQorICAgICAgICBl eGNlcHQ6CisgICAgICAgICAgICBzZWxmLl9wb3J0LmNsZWFuX3VwX3Rlc3RfcnVuKCkKKyAgICAg ICAgICAgIHJhaXNlCiAgICAgICAgIHJldHVybiBUcnVlCiAKICAgICBkZWYgcnVuKHNlbGYsIGFy Z3MpOgpJbmRleDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2lvcy5weQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvaW9zLnB5CShyZXZpc2lvbiAyMTQ1NjAp CisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvaW9zLnB5CSh3b3JraW5nIGNvcHkpCkBA IC0yMSw2ICsyMSw3IEBACiAjIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBU SEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCiAKIGltcG9ydCBsb2dnaW5nCitpbXBvcnQg dHJhY2ViYWNrCiAKIGZyb20gd2Via2l0cHkuY29tbW9uLm1lbW9pemVkIGltcG9ydCBtZW1vaXpl ZAogZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVzdHMubW9kZWxzLnRlc3RfY29uZmlndXJhdGlvbiBp bXBvcnQgVGVzdENvbmZpZ3VyYXRpb24KQEAgLTEyNCw1ICsxMjUsMjYgQEAgY2xhc3MgSU9TUG9y dChEYXJ3aW5Qb3J0KToKICAgICBkZWYgY2xlYW5fdXBfdGVzdF9ydW4oc2VsZik6CiAgICAgICAg IHN1cGVyKElPU1BvcnQsIHNlbGYpLmNsZWFuX3VwX3Rlc3RfcnVuKCkKIAorICAgICAgICAjIEJl c3QgZWZmb3J0IHRvIGxldCBldmVyeSBkZXZpY2UgdGVhcmRvd24gYmVmb3JlIHRocm93aW5nIGFu eSBleGNlcHRpb25zIGhlcmUuCisgICAgICAgICMgRmFpbHVyZSB0byB0ZWFyZG93biBkZXZpY2Vz IGNhbiBsZWF2ZSB0aGluZ3MgaW4gYSBiYWQgc3RhdGUuCisgICAgICAgIGV4Y2VwdGlvbl9saXN0 ID0gW10KICAgICAgICAgZm9yIGkgaW4geHJhbmdlKHNlbGYuY2hpbGRfcHJvY2Vzc2VzKCkpOgot ICAgICAgICAgICAgc2VsZi5kZXZpY2VfZm9yX3dvcmtlcl9udW1iZXIoaSkuZmluaXNoZWRfdGVz dGluZygpCisgICAgICAgICAgICBkZXZpY2UgPSBzZWxmLmRldmljZV9mb3Jfd29ya2VyX251bWJl cihpKQorICAgICAgICAgICAgdHJ5OgorICAgICAgICAgICAgICAgIHNlbGYuZGV2aWNlX2Zvcl93 b3JrZXJfbnVtYmVyKGkpLmZpbmlzaGVkX3Rlc3RpbmcoKQorICAgICAgICAgICAgZXhjZXB0IEJh c2VFeGNlcHRpb24gYXMgZToKKyAgICAgICAgICAgICAgICB0cmFjZSA9IHRyYWNlYmFjay5mb3Jt YXRfZXhjKCkKKyAgICAgICAgICAgICAgICBpZiBpc2luc3RhbmNlKGUsIEV4Y2VwdGlvbik6Cisg ICAgICAgICAgICAgICAgICAgIGV4Y2VwdGlvbl9saXN0LmFwcGVuZChbZSwgdHJhY2VdKQorICAg ICAgICAgICAgICAgIGVsc2U6CisgICAgICAgICAgICAgICAgICAgIGV4Y2VwdGlvbl9saXN0LmFw cGVuZChbRXhjZXB0aW9uKCdFeGNlcHRpb24gdGVhcmluZyBkb3duIHt9Jy5mb3JtYXQoZGV2aWNl KSksIHRyYWNlXSkKKyAgICAgICAgaWYgbGVuKGV4Y2VwdGlvbl9saXN0KSA9PSAxOgorICAgICAg ICAgICAgcmFpc2UKKyAgICAgICAgZWxpZiBsZW4oZXhjZXB0aW9uX2xpc3QpID4gMToKKyAgICAg ICAgICAgIHByaW50ICdcbicKKyAgICAgICAgICAgIGZvciBleGNlcHRpb24gaW4gZXhjZXB0aW9u X2xpc3Q6CisgICAgICAgICAgICAgICAgX2xvZy5lcnJvcigne30gcmFpc2VkOiB7fScuZm9ybWF0 KGV4Y2VwdGlvblswXS5fX2NsYXNzX18uX19uYW1lX18sIGV4Y2VwdGlvblswXSkpCisgICAgICAg ICAgICAgICAgX2xvZy5lcnJvcihleGNlcHRpb25bMV0pCisgICAgICAgICAgICAgICAgX2xvZy5l cnJvcignLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0n KQorCisgICAgICAgICAgICByYWlzZSBSdW50aW1lRXJyb3IoJ011bHRpcGxlIGZhaWx1cmVzIHdo ZW4gdGVhcmRvd24gZGV2aWNlcycpCg==