170244 2017-03-29 10:08:40 -0700 WebAssembly: pack OpcodeOrigin to fit in a pointer 2017-03-29 10:29:00 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keith_miller keith_miller buildbot mark.lam msaboff saam oldest_to_newest 1292453 0 keith_miller 2017-03-29 10:08:40 -0700 WebAssembly: pack OpcodeOrigin to fit in a pointer 1292456 1 305753 keith_miller 2017-03-29 10:15:09 -0700 Created attachment 305753 Patch 1292464 2 305753 msaboff 2017-03-29 10:23:55 -0700 Comment on attachment 305753 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305753&action=review r=me > Source/JavaScriptCore/ChangeLog:8 > + This makes it so we don't have to have different allocate the OpcodeOrigin for B3. Think this sentence needs a little work. 1292466 3 keith_miller 2017-03-29 10:27:30 -0700 Committed r214544: <http://trac.webkit.org/changeset/214544> 1292469 4 305753 keith_miller 2017-03-29 10:29:00 -0700 Comment on attachment 305753 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305753&action=review >> Source/JavaScriptCore/ChangeLog:8 >> + This makes it so we don't have to have different allocate the OpcodeOrigin for B3. > > Think this sentence needs a little work. I changed it to: This patch makes it so we don't have to have allocate OpcodeOrigins and can just pack all the data into the pointer B3::Origin already has. 305753 2017-03-29 10:15:09 -0700 2017-03-29 10:23:55 -0700 Patch bug-170244-20170329101509.patch text/plain 5104 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0NTM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx MzBjZGFlYzhlMWM0ZjlmYmNmOGUwZmYzYjMyYWUyZDE1ZjdjODk0Li43YTJjMGZmM2VlZDdlMWJk MmQwNzQ0MmYwMGRjYzc4N2QzYjFmMDk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxNy0wMy0yOSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBXZWJBc3NlbWJseTogcGFjayBPcGNvZGVPcmlnaW4gdG8gZml0IGlu IGEgcG9pbnRlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTcwMjQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhpcyBtYWtlcyBpdCBzbyB3ZSBkb24ndCBoYXZlIHRvIGhhdmUgZGlmZmVyZW50IGFsbG9j YXRlIHRoZSBPcGNvZGVPcmlnaW4gZm9yIEIzLgorCisgICAgICAgICogd2FzbS9XYXNtQjNJUkdl bmVyYXRvci5jcHA6CisgICAgICAgIChKU0M6Oldhc206OnBhcnNlQW5kQ29tcGlsZSk6CisgICAg ICAgICogd2FzbS9XYXNtT3Bjb2RlT3JpZ2luLmNwcDoKKyAgICAgICAgKEpTQzo6V2FzbTo6T3Bj b2RlT3JpZ2luOjpkdW1wKToKKyAgICAgICAgKiB3YXNtL1dhc21PcGNvZGVPcmlnaW4uaDoKKyAg ICAgICAgKEpTQzo6V2FzbTo6T3Bjb2RlT3JpZ2luOjpPcGNvZGVPcmlnaW4pOgorICAgICAgICAo SlNDOjpXYXNtOjpPcGNvZGVPcmlnaW46Om9wY29kZSk6CisgICAgICAgIChKU0M6Oldhc206Ok9w Y29kZU9yaWdpbjo6bG9jYXRpb24pOgorCiAyMDE3LTAzLTI4ICBTYWFtIEJhcmF0aSAgPHNiYXJh dGlAYXBwbGUuY29tPgogCiAgICAgICAgIEFzc2VtYmx5SGVscGVycyBzaG91bGQgbm90IGhhdmUg YSBWTSBmaWVsZApkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbUIz SVJHZW5lcmF0b3IuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbUIzSVJHZW5l cmF0b3IuY3BwCmluZGV4IDEyNGYwMDcxOGI0NWVkNWE2NzMzODJmOGM3NTMzMWFkNjY4MmQ1OWUu LmI5ZjM2MTUzZmI0ZmQ3MzBlNjg5MTU1ZGIwZGY2MDM1ZTIxZGNkODQgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21CM0lSR2VuZXJhdG9yLmNwcAorKysgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtQjNJUkdlbmVyYXRvci5jcHAKQEAgLTIzNSw3ICsy MzUsNiBAQCBwcml2YXRlOgogICAgIEJhc2ljQmxvY2sqIG1fY3VycmVudEJsb2NrOwogICAgIFZl Y3RvcjxWYXJpYWJsZSo+IG1fbG9jYWxzOwogICAgIFZlY3RvcjxVbmxpbmtlZFdhc21Ub1dhc21D YWxsPiYgbV91bmxpbmtlZFdhc21Ub1dhc21DYWxsczsgLy8gTGlzdCBlYWNoIGNhbGwgc2l0ZSBh bmQgdGhlIGZ1bmN0aW9uIGluZGV4IHdob3NlIGFkZHJlc3MgaXQgc2hvdWxkIGJlIHBhdGNoZWQg d2l0aC4KLSAgICBWZWN0b3I8c3RkOjp1bmlxdWVfcHRyPE9wY29kZU9yaWdpbj4+IG1fb3JpZ2lu czsKICAgICBHUFJSZWcgbV9tZW1vcnlCYXNlR1BSOwogICAgIEdQUlJlZyBtX21lbW9yeVNpemVH UFI7CiAgICAgR1BSUmVnIG1fd2FzbUNvbnRleHRHUFI7CkBAIC0xMjcyLDEwICsxMjcxLDcgQEAg c3RhdGljIHZvaWQgY3JlYXRlSlNUb1dhc21XcmFwcGVyKENvbXBpbGF0aW9uQ29udGV4dCYgY29t cGlsYXRpb25Db250ZXh0LCBXYXNtSW4KIAogYXV0byBCM0lSR2VuZXJhdG9yOjpvcmlnaW4oKSAt PiBPcmlnaW4KIHsKLSAgICBpZiAobV9vcmlnaW5zLmlzRW1wdHkoKSB8fCBtX29yaWdpbnMubGFz dCgpLT5sb2NhdGlvbiAhPSBtX3BhcnNlci0+Y3VycmVudE9wY29kZVN0YXJ0aW5nT2Zmc2V0KCkp Ci0gICAgICAgIG1fb3JpZ2lucy5hcHBlbmQoc3RkOjptYWtlX3VuaXF1ZTxPcGNvZGVPcmlnaW4+ KG1fcGFyc2VyLT5jdXJyZW50T3Bjb2RlKCksIG1fcGFyc2VyLT5jdXJyZW50T3Bjb2RlU3RhcnRp bmdPZmZzZXQoKSkpOwotCi0gICAgcmV0dXJuIE9yaWdpbihtX29yaWdpbnMubGFzdCgpLmdldCgp KTsKKyAgICByZXR1cm4gYml0d2lzZV9jYXN0PE9yaWdpbj4oT3Bjb2RlT3JpZ2luKG1fcGFyc2Vy LT5jdXJyZW50T3Bjb2RlKCksIG1fcGFyc2VyLT5jdXJyZW50T3Bjb2RlU3RhcnRpbmdPZmZzZXQo KSkpOwogfQogCiBFeHBlY3RlZDxzdGQ6OnVuaXF1ZV9wdHI8V2FzbUludGVybmFsRnVuY3Rpb24+ LCBTdHJpbmc+IHBhcnNlQW5kQ29tcGlsZShWTSYgdm0sIENvbXBpbGF0aW9uQ29udGV4dCYgY29t cGlsYXRpb25Db250ZXh0LCBjb25zdCB1aW50OF90KiBmdW5jdGlvblN0YXJ0LCBzaXplX3QgZnVu Y3Rpb25MZW5ndGgsIGNvbnN0IFNpZ25hdHVyZSogc2lnbmF0dXJlLCBWZWN0b3I8VW5saW5rZWRX YXNtVG9XYXNtQ2FsbD4mIHVubGlua2VkV2FzbVRvV2FzbUNhbGxzLCBjb25zdCBNb2R1bGVJbmZv cm1hdGlvbiYgaW5mbywgY29uc3QgVmVjdG9yPFNpZ25hdHVyZUluZGV4PiYgbW9kdWxlU2lnbmF0 dXJlSW5kaWNlc1RvVW5pcXVlZFNpZ25hdHVyZUluZGljZXMsIE1lbW9yeU1vZGUgbW9kZSwgdW5z aWduZWQgb3B0TGV2ZWwpCkBAIC0xMjg5LDcgKzEyODUsNyBAQCBFeHBlY3RlZDxzdGQ6OnVuaXF1 ZV9wdHI8V2FzbUludGVybmFsRnVuY3Rpb24+LCBTdHJpbmc+IHBhcnNlQW5kQ29tcGlsZShWTSYg dm0sCiAKICAgICBwcm9jZWR1cmUuc2V0T3JpZ2luUHJpbnRlcihbXSAoUHJpbnRTdHJlYW0mIG91 dCwgT3JpZ2luIG9yaWdpbikgewogICAgICAgICBpZiAob3JpZ2luLmRhdGEoKSkKLSAgICAgICAg ICAgIG91dC5wcmludCgiV2FzbTogIiwgKmJpdHdpc2VfY2FzdDxPcGNvZGVPcmlnaW4qPihvcmln aW4uZGF0YSgpKSk7CisgICAgICAgICAgICBvdXQucHJpbnQoIldhc206ICIsIGJpdHdpc2VfY2Fz dDxPcGNvZGVPcmlnaW4+KG9yaWdpbikpOwogICAgIH0pOwogCiAgICAgQjNJUkdlbmVyYXRvciBj b250ZXh0KHZtLCBpbmZvLCBwcm9jZWR1cmUsIHJlc3VsdC5nZXQoKSwgdW5saW5rZWRXYXNtVG9X YXNtQ2FsbHMsIG1vZGUpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20v V2FzbU9wY29kZU9yaWdpbi5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtT3Bj b2RlT3JpZ2luLmNwcAppbmRleCBhMTE4ODJmNzA2NWVkNzVlYjFhNjE4Y2RmMjk4OGJlNGFkODFj MjdmLi5jN2ZmYzVkMmFkMDY1NDQ1NmJmN2Q2MmU2YjE0NTkzNjkyMDQ1ZWI5IDEwMDY0NAotLS0g YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtT3Bjb2RlT3JpZ2luLmNwcAorKysgYi9T b3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtT3Bjb2RlT3JpZ2luLmNwcApAQCAtMzIsNyAr MzIsNyBAQCBuYW1lc3BhY2UgSlNDIHsgbmFtZXNwYWNlIFdhc20gewogCiB2b2lkIE9wY29kZU9y aWdpbjo6ZHVtcChQcmludFN0cmVhbSYgb3V0KSBjb25zdAogewotICAgIG91dC5wcmludCgie29w Y29kZTogIiwgbWFrZVN0cmluZyhvcGNvZGUpLCAiLCBsb2NhdGlvbjogIiwgbG9jYXRpb24sICJ9 Iik7CisgICAgb3V0LnByaW50KCJ7b3Bjb2RlOiAiLCBtYWtlU3RyaW5nKG9wY29kZSgpKSwgIiwg bG9jYXRpb246ICIsIGxvY2F0aW9uKCksICJ9Iik7CiB9CiAKIH0gfSAvLyBuYW1lc3BhY2UgSlND OjpXYXNtCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtT3Bjb2Rl T3JpZ2luLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtT3Bjb2RlT3JpZ2luLmgK aW5kZXggNGIxZGMwNzZmYTEwZDQ3MDM4ZDY4NTMxMmQ4ODFiM2I2MTlkMWIxOS4uZjhhMmU5Y2M2 NmZkMjA5MGFhYzEwZTFiOWEwZWUxMTUzNmQzMTgwYiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3dhc20vV2FzbU9wY29kZU9yaWdpbi5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS93YXNtL1dhc21PcGNvZGVPcmlnaW4uaApAQCAtMjgsMjIgKzI4LDI4IEBACiAjaW5jbHVk ZSAiQjNPcmlnaW4uaCIKICNpbmNsdWRlICJXYXNtRm9ybWF0LmgiCiAKKyNpbmNsdWRlIDx3dGYv Rm9yYmlkSGVhcEFsbG9jYXRpb24uaD4KKwogbmFtZXNwYWNlIEpTQyB7IG5hbWVzcGFjZSBXYXNt IHsKIAogY2xhc3MgT3Bjb2RlT3JpZ2luIHsKLSAgICBXVEZfTUFLRV9GQVNUX0FMTE9DQVRFRDsK LSAgICBXVEZfTUFLRV9OT05DT1BZQUJMRShPcGNvZGVPcmlnaW4pOworICAgIFdURl9GT1JCSURf SEVBUF9BTExPQ0FUSU9OOwogcHVibGljOgotICAgIE9wY29kZU9yaWdpbihPcFR5cGUgb3AsIHNp emVfdCBvZmZzZXQpCi0gICAgICAgIDogb3Bjb2RlKG9wKQotICAgICAgICAsIGxvY2F0aW9uKG9m ZnNldCkKKyAgICBPcGNvZGVPcmlnaW4oKSA9IGRlZmF1bHQ7CisgICAgT3Bjb2RlT3JpZ2luKE9w VHlwZSBvcGNvZGUsIHNpemVfdCBvZmZzZXQpCiAgICAgeworICAgICAgICBBU1NFUlQoc3RhdGlj X2Nhc3Q8dWludDMyX3Q+KG9mZnNldCkgPT0gb2Zmc2V0KTsKKyAgICAgICAgcGFja2VkRGF0YSA9 IChzdGF0aWNfY2FzdDx1aW50NjRfdD4ob3Bjb2RlKSA8PCAzMikgfCBvZmZzZXQ7CiAgICAgfQog CiAgICAgdm9pZCBkdW1wKFByaW50U3RyZWFtJikgY29uc3Q7CiAKLSAgICBjb25zdCBPcFR5cGUg b3Bjb2RlOwotICAgIGNvbnN0IHNpemVfdCBsb2NhdGlvbjsKKyAgICBPcFR5cGUgb3Bjb2RlKCkg Y29uc3QgeyByZXR1cm4gc3RhdGljX2Nhc3Q8T3BUeXBlPihwYWNrZWREYXRhID4+IDMyKTsgfQor ICAgIHNpemVfdCBsb2NhdGlvbigpIGNvbnN0IHsgcmV0dXJuIHN0YXRpY19jYXN0PHVpbnQzMl90 PihwYWNrZWREYXRhKTsgfQorCitwcml2YXRlOgorICAgIHN0YXRpY19hc3NlcnQoc2l6ZW9mKHZv aWQqKSA9PSBzaXplb2YodWludDY0X3QpLCAidGhpcyBwYWNraW5nIGRvZXNuJ3Qgd29yayBpZiB0 aGlzIGlzbid0IHRoZSBjYXNlIik7CisgICAgdWludDY0X3QgcGFja2VkRGF0YSB7IDAgfTsKIH07 CiAKIH0gfSAvLyBuYW1lc3BhY2UgSlNDOjpXYXNtCg==