170213 2017-03-28 16:59:16 -0700 The Mutator should not be able to steal the conn if the Collector hasn't reached the NotRunning phase yet. 2017-03-28 17:43:53 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam buildbot fpizlo jfbastien keith_miller msaboff saam webkit-bug-importer oldest_to_newest 1292196 0 mark.lam 2017-03-28 16:59:16 -0700 The current condition for stealing the conn isn't tight enough. Patch coming. <rdar://problem/30755345> 1292199 1 305674 mark.lam 2017-03-28 17:03:58 -0700 Created attachment 305674 proposed patch. 1292232 2 mark.lam 2017-03-28 17:43:53 -0700 Thanks for the review. Landed in r214509: <http://trac.webkit.org/r214509>. 305674 2017-03-28 17:03:58 -0700 2017-03-28 17:09:49 -0700 proposed patch. bug-170213.patch text/plain 1797 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjE0NTA3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE3LTAzLTI4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBU aGUgTXV0YXRvciBzaG91bGQgbm90IGJlIGFibGUgdG8gc3RlYWwgdGhlIGNvbm4gaWYgdGhlIENv bGxlY3RvciBoYXNuJ3QgcmVhY2hlZCB0aGUgTm90UnVubmluZyBwaGFzZSB5ZXQuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzAyMTMKKyAgICAgICAg PHJkYXI6Ly9wcm9ibGVtLzMwNzU1MzQ1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoZSBjdXJyZW50IGNvbmRpdGlvbiBmb3Igc3RlYWxpbmcgdGhl IGNvbm4gaXNuJ3QgdGlnaHQgZW5vdWdoLiAgUmVzdHJpY3RpbmcgdGhlCisgICAgICAgIHN0ZWFs aW5nIHRvIHdoZW4gbV9jdXJyZW50UGhhc2UgPT0gTm90UnVubmluZyBlbnN1cmVzIHRoYXQgdGhl IENvbGxlY3RvciBpcworICAgICAgICByZWFsbHkgZG9uZSBydW5uaW5nLgorCisgICAgICAgIE5v IHRlc3QgYmVjYXVzZSB0aGlzIGlzc3VlIG9ubHkgbWFuaWZlc3RzIHdpdGggYSByYWNlIGNvbmRp dGlvbiB0aGF0IGlzIGRpZmZpY3VsdAorICAgICAgICB0byByZXByb2R1Y2Ugb24gZGVtYW5kLgor CisgICAgICAgICogaGVhcC9IZWFwLmNwcDoKKyAgICAgICAgKEpTQzo6SGVhcDo6cmVxdWVzdENv bGxlY3Rpb24pOgorCiAyMDE3LTAzLTI4ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBw bGUuY29tPgogCiAgICAgICAgIFdlYkFzc2VtYmx5OiBNYWtlIFdlYkFzc2VtYmx5Lmluc3RhbnRp YXRlL2NvbXBpbGUgdHJ1bHkgYXN5bmNocm9ub3VzCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENv cmUvaGVhcC9IZWFwLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVh cC9IZWFwLmNwcAkocmV2aXNpb24gMjE0NTA3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2hl YXAvSGVhcC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE5NjEsNyArMTk2MSw3IEBAIEhlYXA6OlRp Y2tldCBIZWFwOjpyZXF1ZXN0Q29sbGVjdGlvbihzdGQKICAgICAvLyByaWdodCBub3cuIFRoaXMg aXMgYW4gb3B0aW1pemF0aW9uIHRoYXQgcHJldmVudHMgdGhlIGNvbGxlY3RvciB0aHJlYWQgZnJv bSBldmVyIHN0YXJ0aW5nIGluIG1vc3QKICAgICAvLyBjYXNlcy4KICAgICBBU1NFUlQobV9sYXN0 U2VydmVkVGlja2V0IDw9IG1fbGFzdEdyYW50ZWRUaWNrZXQpOwotICAgIGlmIChtX2xhc3RTZXJ2 ZWRUaWNrZXQgPT0gbV9sYXN0R3JhbnRlZFRpY2tldCkgeworICAgIGlmICgobV9sYXN0U2VydmVk VGlja2V0ID09IG1fbGFzdEdyYW50ZWRUaWNrZXQpICYmIChtX2N1cnJlbnRQaGFzZSA9PSBDb2xs ZWN0b3JQaGFzZTo6Tm90UnVubmluZykpIHsKICAgICAgICAgaWYgKGZhbHNlKQogICAgICAgICAg ICAgZGF0YUxvZygiVGFraW5nIHRoZSBjb25uLlxuIik7CiAgICAgICAgIG1fd29ybGRTdGF0ZS5l eGNoYW5nZU9yKG11dGF0b3JIYXNDb25uQml0KTsK