<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>17020</bug_id>
          
          <creation_ts>2008-01-26 04:45:33 -0800</creation_ts>
          <short_desc>Function.toString does not parenthesise numbers for the bracket accessor</short_desc>
          <delta_ts>2008-02-11 17:02:21 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.4</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>HasReduction</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>13638</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Oliver Hunt">oliver</reporter>
          <assigned_to name="Oliver Hunt">oliver</assigned_to>
          <cc>darin</cc>
    
    <cc>jruderman</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>68289</commentid>
    <comment_count>0</comment_count>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2008-01-26 04:45:33 -0800</bug_when>
    <thetext>In the example
function f() {
    (-1)[0];
}

f.toString() produces:
function f() {
    -1[0];
}

which is invalid JS</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>68291</commentid>
    <comment_count>1</comment_count>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2008-01-26 05:36:39 -0800</bug_when>
    <thetext>Hmm, it would appear we get it wrong for all of the bracket nodes..</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>68292</commentid>
    <comment_count>2</comment_count>
      <attachid>18707</attachid>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2008-01-26 05:44:40 -0800</bug_when>
    <thetext>Created attachment 18707
Fixeration</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>68295</commentid>
    <comment_count>3</comment_count>
      <attachid>18707</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2008-01-26 08:15:01 -0800</bug_when>
    <thetext>Comment on attachment 18707
Fixeration

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>68311</commentid>
    <comment_count>4</comment_count>
      <attachid>18710</attachid>
    <who name="Sam Weinig">sam</who>
    <bug_when>2008-01-26 11:23:03 -0800</bug_when>
    <thetext>Created attachment 18710
updated patch

Since I broke Ollie&apos;s patch with a little cleanup, I went ahead and updated this patch to work with the new code.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>68329</commentid>
    <comment_count>5</comment_count>
      <attachid>18713</attachid>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2008-01-26 17:03:26 -0800</bug_when>
    <thetext>Created attachment 18713
Updated fix

This is a minor update to the prior patch to ensure &quot;new (1)()&quot; will work</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>68330</commentid>
    <comment_count>6</comment_count>
      <attachid>18713</attachid>
    <who name="Maciej Stachowiak">mjs</who>
    <bug_when>2008-01-26 18:12:51 -0800</bug_when>
    <thetext>Comment on attachment 18713
Updated fix

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>68331</commentid>
    <comment_count>7</comment_count>
    <who name="Oliver Hunt">oliver</who>
    <bug_when>2008-01-26 18:17:45 -0800</bug_when>
    <thetext>Fixed in r29813</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>18707</attachid>
            <date>2008-01-26 05:44:40 -0800</date>
            <delta_ts>2008-01-26 17:03:26 -0800</delta_ts>
            <desc>Fixeration</desc>
            <filename>bracketaccessfix.patch</filename>
            <type>text/plain</type>
            <size>8006</size>
            <attacher name="Oliver Hunt">oliver</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No
YW5nZUxvZwppbmRleCBmNTc5NjM4Li5mYjkwMDUxIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y
ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg
QEAKKzIwMDgtMDEtMjYgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KKworICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggQnVnIDE3MDIwOiBG
dW5jdGlvbi50b1N0cmluZyBkb2VzIG5vdCBwYXJlbnRoZXNpc2UgbnVtYmVycyBmb3IgdGhlIGJy
YWNrZXQgYWNjZXNzb3IKKworICAgICAgICBJdCB0dXJucyBvdXQgdGhhdCBsb2dpYyB3YXMgdGhl
cmUgZm9yIGFsbCBvZiB0aGUgZG90IGFjY2Vzc29yIG5vZGVzIHRvIG1ha2UgbnVtYmVycyBiZQor
ICAgICAgICBwYXJlbnRoZXNpc2VkIHByb3Blcmx5LCBzbyBpdCB3YXMgYSB0cml2aWFsIGV4dGVu
c2lvbiB0byBleHRlbmQgdGhhdCB0byB0aGUgYnJhY2tldCBub2Rlcy4KKyAgICAgICAgSSByZW5h
bWVkIHRoZSBlbnVtIHR5cGUgdG8gcmVmbGVjdCB0aGUgZmFjdCB0aGF0IGl0IGlzIG5vdyB1c2Vk
IGZvciBib3RoIGRvdCBhbmQgYnJhY2tldAorICAgICAgICBhY2Nlc3NvcnMuCisKKyAgICAgICAg
KiBranMvbm9kZXMyc3RyaW5nLmNwcDoKKyAgICAgICAgKEtKUzo6QnJhY2tldEFjY2Vzc29yTm9k
ZTo6c3RyZWFtVG8pOgorICAgICAgICAoS0pTOjpGdW5jdGlvbkNhbGxCcmFja2V0Tm9kZTo6c3Ry
ZWFtVG8pOgorICAgICAgICAoS0pTOjpEZWxldGVCcmFja2V0Tm9kZTo6c3RyZWFtVG8pOgorICAg
ICAgICAoS0pTOjpQcmVmaXhCcmFja2V0Tm9kZTo6c3RyZWFtVG8pOgorICAgICAgICAoS0pTOjpQ
cmVmaXhEb3ROb2RlOjpzdHJlYW1Ubyk6CisgICAgICAgIChLSlM6OlJlYWRNb2RpZnlCcmFja2V0
Tm9kZTo6c3RyZWFtVG8pOgorICAgICAgICAoS0pTOjpBc3NpZ25CcmFja2V0Tm9kZTo6c3RyZWFt
VG8pOgorICAgICAgICAoS0pTOjpSZWFkTW9kaWZ5RG90Tm9kZTo6c3RyZWFtVG8pOgorCiAyMDA4
LTAxLTI2ICBNYXJrIFJvd2UgIDxtcm93ZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg
YnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9ranMvbm9kZXMyc3Ry
aW5nLmNwcCBiL0phdmFTY3JpcHRDb3JlL2tqcy9ub2RlczJzdHJpbmcuY3BwCmluZGV4IDA0MzJi
N2YuLjJlZDk0MGUgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL2tqcy9ub2RlczJzdHJpbmcu
Y3BwCisrKyBiL0phdmFTY3JpcHRDb3JlL2tqcy9ub2RlczJzdHJpbmcuY3BwCkBAIC0zNyw3ICsz
Nyw3IEBAIG5hbWVzcGFjZSBLSlMgewogZW51bSBFbmRsVHlwZSB7IEVuZGwgfTsKIGVudW0gSW5k
ZW50VHlwZSB7IEluZGVudCB9OwogZW51bSBVbmluZGVudFR5cGUgeyBVbmluZGVudCB9OwotZW51
bSBEb3RFeHByVHlwZSB7IERvdEV4cHIgfTsKK2VudW0gUHJvcGVydHlBY2Nlc3NUeXBlIHsgUHJv
cGVydHlBY2Nlc3MgfTsKIAogY2xhc3MgU291cmNlU3RyZWFtIHsKIHB1YmxpYzoKQEAgLTUxLDcg
KzUxLDcgQEAgcHVibGljOgogICAgIFNvdXJjZVN0cmVhbSYgb3BlcmF0b3I8PChFbmRsVHlwZSk7
CiAgICAgU291cmNlU3RyZWFtJiBvcGVyYXRvcjw8KEluZGVudFR5cGUpOwogICAgIFNvdXJjZVN0
cmVhbSYgb3BlcmF0b3I8PChVbmluZGVudFR5cGUpOwotICAgIFNvdXJjZVN0cmVhbSYgb3BlcmF0
b3I8PChEb3RFeHByVHlwZSk7CisgICAgU291cmNlU3RyZWFtJiBvcGVyYXRvcjw8KFByb3BlcnR5
QWNjZXNzVHlwZSk7CiAgICAgU291cmNlU3RyZWFtJiBvcGVyYXRvcjw8KFByZWNlZGVuY2UpOwog
ICAgIFNvdXJjZVN0cmVhbSYgb3BlcmF0b3I8PChjb25zdCBOb2RlKik7CiAgICAgdGVtcGxhdGUg
PHR5cGVuYW1lIFQ+IFNvdXJjZVN0cmVhbSYgb3BlcmF0b3I8PChjb25zdCBSZWZQdHI8VD4mIG4p
IHsgcmV0dXJuICp0aGlzIDw8IG4uZ2V0KCk7IH0KQEAgLTIzNSw3ICsyMzUsNyBAQCBTb3VyY2VT
dHJlYW0mIFNvdXJjZVN0cmVhbTo6b3BlcmF0b3I8PChVbmluZGVudFR5cGUpCiAgICAgcmV0dXJu
ICp0aGlzOwogfQogCi1pbmxpbmUgU291cmNlU3RyZWFtJiBTb3VyY2VTdHJlYW06Om9wZXJhdG9y
PDwoRG90RXhwclR5cGUpCitpbmxpbmUgU291cmNlU3RyZWFtJiBTb3VyY2VTdHJlYW06Om9wZXJh
dG9yPDwoUHJvcGVydHlBY2Nlc3NUeXBlKQogewogICAgIG1fbnVtYmVyTmVlZHNQYXJlbnMgPSB0
cnVlOwogICAgIHJldHVybiAqdGhpczsKQEAgLTM4MiwxMiArMzgyLDEyIEBAIHZvaWQgUHJvcGVy
dHlOb2RlOjpzdHJlYW1UbyhTb3VyY2VTdHJlYW0mIHMpIGNvbnN0CiAKIHZvaWQgQnJhY2tldEFj
Y2Vzc29yTm9kZTo6c3RyZWFtVG8oU291cmNlU3RyZWFtJiBzKSBjb25zdAogewotICAgIHMgPDwg
UHJlY0NhbGwgPDwgZXhwcjEgPDwgIlsiIDw8IGV4cHIyIDw8ICJdIjsKKyAgICBzIDw8IFByb3Bl
cnR5QWNjZXNzIDw8IFByZWNDYWxsIDw8IGV4cHIxIDw8ICJbIiA8PCBleHByMiA8PCAiXSI7CiB9
CiAKIHZvaWQgRG90QWNjZXNzb3JOb2RlOjpzdHJlYW1UbyhTb3VyY2VTdHJlYW0mIHMpIGNvbnN0
CiB7Ci0gICAgcyA8PCBEb3RFeHByIDw8IFByZWNDYWxsIDw8IGV4cHIgPDwgIi4iIDw8IGlkZW50
OworICAgIHMgPDwgUHJvcGVydHlBY2Nlc3MgPDwgUHJlY0NhbGwgPDwgZXhwciA8PCAiLiIgPDwg
aWRlbnQ7CiB9CiAKIHZvaWQgQXJndW1lbnRMaXN0Tm9kZTo6c3RyZWFtVG8oU291cmNlU3RyZWFt
JiBzKSBjb25zdApAQCAtNDE5LDEyICs0MTksMTIgQEAgdm9pZCBGdW5jdGlvbkNhbGxSZXNvbHZl
Tm9kZTo6c3RyZWFtVG8oU291cmNlU3RyZWFtJiBzKSBjb25zdAogCiB2b2lkIEZ1bmN0aW9uQ2Fs
bEJyYWNrZXROb2RlOjpzdHJlYW1UbyhTb3VyY2VTdHJlYW0mIHMpIGNvbnN0CiB7Ci0gICAgcyA8
PCBQcmVjQ2FsbCA8PCBiYXNlIDw8ICJbIiA8PCBzdWJzY3JpcHQgPDwgIl0iIDw8IGFyZ3M7Cisg
ICAgcyA8PCBQcm9wZXJ0eUFjY2VzcyA8PCBQcmVjQ2FsbCA8PCBiYXNlIDw8ICJbIiA8PCBzdWJz
Y3JpcHQgPDwgIl0iIDw8IGFyZ3M7CiB9CiAKIHZvaWQgRnVuY3Rpb25DYWxsRG90Tm9kZTo6c3Ry
ZWFtVG8oU291cmNlU3RyZWFtJiBzKSBjb25zdAogewotICAgIHMgPDwgRG90RXhwciA8PCBQcmVj
Q2FsbCA8PCBiYXNlIDw8ICIuIiA8PCBpZGVudCA8PCBhcmdzOworICAgIHMgPDwgUHJvcGVydHlB
Y2Nlc3MgPDwgUHJlY0NhbGwgPDwgYmFzZSA8PCAiLiIgPDwgaWRlbnQgPDwgYXJnczsKIH0KIAog
dm9pZCBQb3N0SW5jUmVzb2x2ZU5vZGU6OnN0cmVhbVRvKFNvdXJjZVN0cmVhbSYgcykgY29uc3QK
QEAgLTQzOSw3ICs0MzksNyBAQCB2b2lkIFBvc3REZWNSZXNvbHZlTm9kZTo6c3RyZWFtVG8oU291
cmNlU3RyZWFtJiBzKSBjb25zdAogCiB2b2lkIFBvc3RmaXhCcmFja2V0Tm9kZTo6c3RyZWFtVG8o
U291cmNlU3RyZWFtJiBzKSBjb25zdAogewotICAgIHMgPDwgUHJlY0NhbGwgPDwgbV9iYXNlIDw8
ICJbIiA8PCBtX3N1YnNjcmlwdCA8PCAiXSI7CisgICAgcyA8PCBQcm9wZXJ0eUFjY2VzcyA8PCBQ
cmVjQ2FsbCA8PCBtX2Jhc2UgPDwgIlsiIDw8IG1fc3Vic2NyaXB0IDw8ICJdIjsKICAgICBpZiAo
aXNJbmNyZW1lbnQoKSkKICAgICAgICAgcyA8PCAiKysiOwogICAgIGVsc2UKQEAgLTQ0OCw3ICs0
NDgsNyBAQCB2b2lkIFBvc3RmaXhCcmFja2V0Tm9kZTo6c3RyZWFtVG8oU291cmNlU3RyZWFtJiBz
KSBjb25zdAogCiB2b2lkIFBvc3RmaXhEb3ROb2RlOjpzdHJlYW1UbyhTb3VyY2VTdHJlYW0mIHMp
IGNvbnN0CiB7Ci0gICAgcyA8PCBEb3RFeHByIDw8IFByZWNDYWxsIDw8IG1fYmFzZSA8PCAiLiIg
PDwgbV9pZGVudDsKKyAgICBzIDw8IFByb3BlcnR5QWNjZXNzIDw8IFByZWNDYWxsIDw8IG1fYmFz
ZSA8PCAiLiIgPDwgbV9pZGVudDsKICAgICBpZiAoaXNJbmNyZW1lbnQoKSkKICAgICAgICAgcyA8
PCAiKysiOwogICAgIGVsc2UKQEAgLTQ3MSwxMiArNDcxLDEyIEBAIHZvaWQgRGVsZXRlUmVzb2x2
ZU5vZGU6OnN0cmVhbVRvKFNvdXJjZVN0cmVhbSYgcykgY29uc3QKIAogdm9pZCBEZWxldGVCcmFj
a2V0Tm9kZTo6c3RyZWFtVG8oU291cmNlU3RyZWFtJiBzKSBjb25zdAogewotICAgIHMgPDwgImRl
bGV0ZSAiIDw8IFByZWNDYWxsIDw8IG1fYmFzZSA8PCAiWyIgPDwgbV9zdWJzY3JpcHQgPDwgIl0i
OworICAgIHMgPDwgImRlbGV0ZSAiIDw8IFByb3BlcnR5QWNjZXNzIDw8IFByZWNDYWxsIDw8IG1f
YmFzZSA8PCAiWyIgPDwgbV9zdWJzY3JpcHQgPDwgIl0iOwogfQogCiB2b2lkIERlbGV0ZURvdE5v
ZGU6OnN0cmVhbVRvKFNvdXJjZVN0cmVhbSYgcykgY29uc3QKIHsKLSAgICBzIDw8ICJkZWxldGUg
IiA8PCBEb3RFeHByIDw8IFByZWNDYWxsIDw8IG1fYmFzZSA8PCAiLiIgPDwgbV9pZGVudDsKKyAg
ICBzIDw8ICJkZWxldGUgIiA8PCBQcm9wZXJ0eUFjY2VzcyA8PCBQcmVjQ2FsbCA8PCBtX2Jhc2Ug
PDwgIi4iIDw8IG1faWRlbnQ7CiB9CiAKIHZvaWQgRGVsZXRlVmFsdWVOb2RlOjpzdHJlYW1UbyhT
b3VyY2VTdHJlYW0mIHMpIGNvbnN0CkBAIC01MTUsNyArNTE1LDcgQEAgdm9pZCBQcmVmaXhCcmFj
a2V0Tm9kZTo6c3RyZWFtVG8oU291cmNlU3RyZWFtJiBzKSBjb25zdAogICAgICAgICBzIDw8ICIr
KyI7CiAgICAgZWxzZQogICAgICAgICBzIDw8ICItLSI7Ci0gICAgcyA8PCBQcmVjQ2FsbCA8PCBt
X2Jhc2UgPDwgIlsiIDw8IG1fc3Vic2NyaXB0IDw8ICJdIjsKKyAgICBzIDw8IFByb3BlcnR5QWNj
ZXNzIDw8IFByZWNDYWxsIDw8IG1fYmFzZSA8PCAiWyIgPDwgbV9zdWJzY3JpcHQgPDwgIl0iOwog
fQogCiB2b2lkIFByZWZpeERvdE5vZGU6OnN0cmVhbVRvKFNvdXJjZVN0cmVhbSYgcykgY29uc3QK
QEAgLTUyNCw3ICs1MjQsNyBAQCB2b2lkIFByZWZpeERvdE5vZGU6OnN0cmVhbVRvKFNvdXJjZVN0
cmVhbSYgcykgY29uc3QKICAgICAgICAgcyA8PCAiKysiOwogICAgIGVsc2UKICAgICAgICAgcyA8
PCAiLS0iOwotICAgIHMgPDwgRG90RXhwciA8PCBQcmVjQ2FsbCA8PCBtX2Jhc2UgPDwgIi4iIDw8
IG1faWRlbnQ7CisgICAgcyA8PCBQcm9wZXJ0eUFjY2VzcyA8PCBQcmVjQ2FsbCA8PCBtX2Jhc2Ug
PDwgIi4iIDw8IG1faWRlbnQ7CiB9CiAKIHZvaWQgUHJlZml4RXJyb3JOb2RlOjpzdHJlYW1UbyhT
b3VyY2VTdHJlYW0mIHMpIGNvbnN0CkBAIC02ODksMjQgKzY4OSwyNCBAQCB2b2lkIEFzc2lnblJl
c29sdmVOb2RlOjpzdHJlYW1UbyhTb3VyY2VTdHJlYW0mIHMpIGNvbnN0CiAKIHZvaWQgUmVhZE1v
ZGlmeUJyYWNrZXROb2RlOjpzdHJlYW1UbyhTb3VyY2VTdHJlYW0mIHMpIGNvbnN0CiB7Ci0gICAg
cyA8PCBQcmVjQ2FsbCA8PCBtX2Jhc2UgPDwgJ1snIDw8IG1fc3Vic2NyaXB0IDw8ICJdICIKKyAg
ICBzIDw8IFByb3BlcnR5QWNjZXNzIDw8IFByZWNDYWxsIDw8IG1fYmFzZSA8PCAnWycgPDwgbV9z
dWJzY3JpcHQgPDwgIl0gIgogICAgICAgICA8PCBvcGVyYXRvclN0cmluZyhtX29wZXIpIDw8ICcg
JyA8PCBQcmVjQXNzaWdubWVudCA8PCBtX3JpZ2h0OwogfQogCiB2b2lkIEFzc2lnbkJyYWNrZXRO
b2RlOjpzdHJlYW1UbyhTb3VyY2VTdHJlYW0mIHMpIGNvbnN0CiB7Ci0gICAgcyA8PCBQcmVjQ2Fs
bCA8PCBtX2Jhc2UgPDwgJ1snIDw8IG1fc3Vic2NyaXB0IDw8ICJdID0gIiA8PCBQcmVjQXNzaWdu
bWVudCA8PCBtX3JpZ2h0OworICAgIHMgPDwgUHJvcGVydHlBY2Nlc3MgPDwgIFByZWNDYWxsIDw8
IG1fYmFzZSA8PCAnWycgPDwgbV9zdWJzY3JpcHQgPDwgIl0gPSAiIDw8IFByZWNBc3NpZ25tZW50
IDw8IG1fcmlnaHQ7CiB9CiAKIHZvaWQgUmVhZE1vZGlmeURvdE5vZGU6OnN0cmVhbVRvKFNvdXJj
ZVN0cmVhbSYgcykgY29uc3QKIHsKLSAgICBzIDw8IERvdEV4cHIgPDwgUHJlY0NhbGwgPDwgbV9i
YXNlIDw8ICIuIiA8PCBtX2lkZW50IDw8ICcgJworICAgIHMgPDwgUHJvcGVydHlBY2Nlc3MgPDwg
UHJlY0NhbGwgPDwgbV9iYXNlIDw8ICIuIiA8PCBtX2lkZW50IDw8ICcgJwogICAgICAgICA8PCBv
cGVyYXRvclN0cmluZyhtX29wZXIpIDw8ICcgJyA8PCBQcmVjQXNzaWdubWVudCA8PCBtX3JpZ2h0
OwogfQogCiB2b2lkIEFzc2lnbkRvdE5vZGU6OnN0cmVhbVRvKFNvdXJjZVN0cmVhbSYgcykgY29u
c3QKIHsKLSAgICBzIDw8IERvdEV4cHIgPDwgUHJlY0NhbGwgPDwgbV9iYXNlIDw8ICIuIiA8PCBt
X2lkZW50IDw8ICIgPSAiIDw8IFByZWNBc3NpZ25tZW50IDw8IG1fcmlnaHQ7CisgICAgcyA8PCBQ
cm9wZXJ0eUFjY2VzcyA8PCBQcmVjQ2FsbCA8PCBtX2Jhc2UgPDwgIi4iIDw8IG1faWRlbnQgPDwg
IiA9ICIgPDwgUHJlY0Fzc2lnbm1lbnQgPDwgbV9yaWdodDsKIH0KIAogdm9pZCBBc3NpZ25FcnJv
ck5vZGU6OnN0cmVhbVRvKFNvdXJjZVN0cmVhbSYgcykgY29uc3QKZGlmZiAtLWdpdCBhL0xheW91
dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCBmMDNhZjJiLi5i
MGJlZGE0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVz
dHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTEgQEAKKzIwMDgtMDEtMjYgIE9saXZlciBIdW50ICA8
b2xpdmVyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K
KworICAgICAgICBUZXN0IGNhc2VzIGZvciBidWcgMTcwMjAKKworICAgICAgICAqIGZhc3QvanMv
cmVzb3VyY2VzL2Z1bmN0aW9uLXRvU3RyaW5nLXBhcmVudGhlc2VzLmpzOgorCiAyMDA4LTAxLTI2
ICBEYXJpbiBBZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBP
bGl2ZXIuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2pzL3Jlc291cmNlcy9mdW5jdGlv
bi10b1N0cmluZy1wYXJlbnRoZXNlcy5qcyBiL0xheW91dFRlc3RzL2Zhc3QvanMvcmVzb3VyY2Vz
L2Z1bmN0aW9uLXRvU3RyaW5nLXBhcmVudGhlc2VzLmpzCmluZGV4IDNhZWJmZWIuLmIxNWUwYzYg
MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvanMvcmVzb3VyY2VzL2Z1bmN0aW9uLXRvU3Ry
aW5nLXBhcmVudGhlc2VzLmpzCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvanMvcmVzb3VyY2VzL2Z1
bmN0aW9uLXRvU3RyaW5nLXBhcmVudGhlc2VzLmpzCkBAIC0xMzcsNiArMTM3LDEyIEBAIHNob3Vs
ZEJlKCJjb21waWxlQW5kU2VyaWFsaXplKCcoIWEpKysnKSIsICInKCFhKSsrJyIpOwogc2hvdWxk
QmUoImNvbXBpbGVBbmRTZXJpYWxpemUoJyFhLS0nKSIsICInIWEtLSciKTsKIHNob3VsZEJlKCJj
b21waWxlQW5kU2VyaWFsaXplKCchKGEtLSknKSIsICInIWEtLSciKTsKIHNob3VsZEJlKCJjb21w
aWxlQW5kU2VyaWFsaXplKCcoIWEpLS0nKSIsICInKCFhKS0tJyIpOworc2hvdWxkQmUoImNvbXBp
bGVBbmRTZXJpYWxpemUoJygtMSlbYV0nKSIsICInKC0xKVthXSciKTsKK3Nob3VsZEJlKCJjb21w
aWxlQW5kU2VyaWFsaXplKCcoLTEpW2FdID0gYicpIiwgIicoLTEpW2FdID0gYiciKTsKK3Nob3Vs
ZEJlKCJjb21waWxlQW5kU2VyaWFsaXplKCcoLTEpW2FdICs9IGInKSIsICInKC0xKVthXSArPSBi
JyIpOworc2hvdWxkQmUoImNvbXBpbGVBbmRTZXJpYWxpemUoJygtMSlbYV0rKycpIiwgIicoLTEp
W2FdKysnIik7CitzaG91bGRCZSgiY29tcGlsZUFuZFNlcmlhbGl6ZSgnKysoLTEpW2FdJykiLCAi
JysrKC0xKVthXSciKTsKK3Nob3VsZEJlKCJjb21waWxlQW5kU2VyaWFsaXplKCcoLTEpW2FdKCkn
KSIsICInKC0xKVthXSgpJyIpOwogc2hvdWxkQmUoImNvbXBpbGVBbmRTZXJpYWxpemVMZWZ0bW9z
dFRlc3QoJyh7IH0pLngnKSIsICInKHsgfSkueCciKTsKIHNob3VsZEJlKCJjb21waWxlQW5kU2Vy
aWFsaXplTGVmdG1vc3RUZXN0KCd4ID0geyB9JykiLCAiJ3ggPSB7IH0nIik7CiBzaG91bGRCZSgi
Y29tcGlsZUFuZFNlcmlhbGl6ZUxlZnRtb3N0VGVzdCgnKGZ1bmN0aW9uICgpIHsgfSkoKScpIiwg
IicoZnVuY3Rpb24gKCkgeyB9KSgpJyIpOwo=
</data>
<flag name="review"
          id="8169"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>18710</attachid>
            <date>2008-01-26 11:23:03 -0800</date>
            <delta_ts>2008-01-26 17:03:26 -0800</delta_ts>
            <desc>updated patch</desc>
            <filename>updatedPatch.diff</filename>
            <type>text/plain</type>
            <size>6110</size>
            <attacher name="Sam Weinig">sam</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI5ODEwKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMDgtMDEtMjYgIE9saXZlciBI
dW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxl
ci4KKworICAgICAgICBGaXggZm9yIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTE3MDIwCisgICAgICAgIEZ1bmN0aW9uLnRvU3RyaW5nIGRvZXMgbm90IHBhcmVudGhlc2lz
ZSBudW1iZXJzIGZvciB0aGUgYnJhY2tldCBhY2Nlc3NvcgorCisgICAgICAgIEl0IHR1cm5zIG91
dCB0aGF0IGxvZ2ljIHdhcyB0aGVyZSBmb3IgYWxsIG9mIHRoZSBkb3QgYWNjZXNzb3Igbm9kZXMg
dG8gbWFrZSBudW1iZXJzIGJlCisgICAgICAgIHBhcmVudGhlc2lzZWQgcHJvcGVybHksIHNvIGl0
IHdhcyBhIHRyaXZpYWwgZXh0ZW5zaW9uIHRvIGV4dGVuZCB0aGF0IHRvIHRoZSBicmFja2V0IG5v
ZGVzLgorICAgICAgICBJIHJlbmFtZWQgdGhlIGVudW0gdHlwZSB0byByZWZsZWN0IHRoZSBmYWN0
IHRoYXQgaXQgaXMgbm93IHVzZWQgZm9yIGJvdGggZG90IGFuZCBicmFja2V0CisgICAgICAgIGFj
Y2Vzc29ycy4KKworICAgICAgICAqIGtqcy9ub2RlczJzdHJpbmcuY3BwOgorICAgICAgICAoS0pT
OjpTb3VyY2VTdHJlYW06Om9wZXJhdG9yPDwpOgorICAgICAgICAoS0pTOjpicmFja2V0Tm9kZVN0
cmVhbVRvKToKKyAgICAgICAgKEtKUzo6ZG90Tm9kZVN0cmVhbVRvKToKKyAgICAgICAgKEtKUzo6
QnJhY2tldEFjY2Vzc29yTm9kZTo6c3RyZWFtVG8pOgorICAgICAgICAoS0pTOjpEb3RBY2Nlc3Nv
ck5vZGU6OnN0cmVhbVRvKToKKwogMjAwOC0wMS0yNiAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBs
ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCkluZGV4OiBKYXZhU2Ny
aXB0Q29yZS9ranMvbm9kZXMyc3RyaW5nLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29y
ZS9ranMvbm9kZXMyc3RyaW5nLmNwcAkocmV2aXNpb24gMjk4MDkpCisrKyBKYXZhU2NyaXB0Q29y
ZS9ranMvbm9kZXMyc3RyaW5nLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzcsNyArMzcsNyBAQCBu
YW1lc3BhY2UgS0pTIHsKIGVudW0gRW5kbFR5cGUgeyBFbmRsIH07CiBlbnVtIEluZGVudFR5cGUg
eyBJbmRlbnQgfTsKIGVudW0gVW5pbmRlbnRUeXBlIHsgVW5pbmRlbnQgfTsKLWVudW0gRG90RXhw
clR5cGUgeyBEb3RFeHByIH07CitlbnVtIFByb3BlcnR5QWNjZXNzVHlwZSB7IFByb3BlcnR5QWNj
ZXNzIH07CiAKIGNsYXNzIFNvdXJjZVN0cmVhbSB7CiBwdWJsaWM6CkBAIC01MSw3ICs1MSw3IEBA
IHB1YmxpYzoKICAgICBTb3VyY2VTdHJlYW0mIG9wZXJhdG9yPDwoRW5kbFR5cGUpOwogICAgIFNv
dXJjZVN0cmVhbSYgb3BlcmF0b3I8PChJbmRlbnRUeXBlKTsKICAgICBTb3VyY2VTdHJlYW0mIG9w
ZXJhdG9yPDwoVW5pbmRlbnRUeXBlKTsKLSAgICBTb3VyY2VTdHJlYW0mIG9wZXJhdG9yPDwoRG90
RXhwclR5cGUpOworICAgIFNvdXJjZVN0cmVhbSYgb3BlcmF0b3I8PChQcm9wZXJ0eUFjY2Vzc1R5
cGUpOwogICAgIFNvdXJjZVN0cmVhbSYgb3BlcmF0b3I8PChQcmVjZWRlbmNlKTsKICAgICBTb3Vy
Y2VTdHJlYW0mIG9wZXJhdG9yPDwoY29uc3QgTm9kZSopOwogICAgIHRlbXBsYXRlIDx0eXBlbmFt
ZSBUPiBTb3VyY2VTdHJlYW0mIG9wZXJhdG9yPDwoY29uc3QgUmVmUHRyPFQ+JiBuKSB7IHJldHVy
biAqdGhpcyA8PCBuLmdldCgpOyB9CkBAIC0yMzUsNyArMjM1LDcgQEAgU291cmNlU3RyZWFtJiBT
b3VyY2VTdHJlYW06Om9wZXJhdG9yPDwoVQogICAgIHJldHVybiAqdGhpczsKIH0KIAotaW5saW5l
IFNvdXJjZVN0cmVhbSYgU291cmNlU3RyZWFtOjpvcGVyYXRvcjw8KERvdEV4cHJUeXBlKQoraW5s
aW5lIFNvdXJjZVN0cmVhbSYgU291cmNlU3RyZWFtOjpvcGVyYXRvcjw8KFByb3BlcnR5QWNjZXNz
VHlwZSkKIHsKICAgICBtX251bWJlck5lZWRzUGFyZW5zID0gdHJ1ZTsKICAgICByZXR1cm4gKnRo
aXM7CkBAIC0yNjMsMTIgKzI2MywxMiBAQCB0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4gc3RhdGljIGlu
bGluZSB2b2lkCiAKIHN0YXRpYyBpbmxpbmUgdm9pZCBicmFja2V0Tm9kZVN0cmVhbVRvKFNvdXJj
ZVN0cmVhbSYgcywgY29uc3QgUmVmUHRyPEV4cHJlc3Npb25Ob2RlPiYgYmFzZSwgY29uc3QgUmVm
UHRyPEV4cHJlc3Npb25Ob2RlPiYgc3Vic2NyaXB0KQogewotICAgIHMgPDwgUHJlY0NhbGwgPDwg
YmFzZS5nZXQoKSA8PCAiWyIgPDwgc3Vic2NyaXB0LmdldCgpIDw8ICJdIjsKKyAgICBzIDw8IFBy
b3BlcnR5QWNjZXNzIDw8IFByZWNDYWxsIDw8IGJhc2UuZ2V0KCkgPDwgIlsiIDw8IHN1YnNjcmlw
dC5nZXQoKSA8PCAiXSI7CiB9CiAKIHN0YXRpYyBpbmxpbmUgdm9pZCBkb3ROb2RlU3RyZWFtVG8o
U291cmNlU3RyZWFtJiBzLCBjb25zdCBSZWZQdHI8RXhwcmVzc2lvbk5vZGU+JiBiYXNlLCBjb25z
dCBJZGVudGlmaWVyJiBpZGVudCkKIHsKLSAgICBzIDw8IERvdEV4cHIgPDwgUHJlY0NhbGwgPDwg
YmFzZS5nZXQoKSA8PCAiLiIgPDwgaWRlbnQ7CisgICAgcyA8PCBQcm9wZXJ0eUFjY2VzcyA8PCBQ
cmVjQ2FsbCA8PCBiYXNlLmdldCgpIDw8ICIuIiA8PCBpZGVudDsKIH0KIAogLy8gLS0tLS0tLS0K
QEAgLTM5MiwxMiArMzkyLDEyIEBAIHZvaWQgUHJvcGVydHlOb2RlOjpzdHJlYW1UbyhTb3VyY2VT
dHJlYW0KIAogdm9pZCBCcmFja2V0QWNjZXNzb3JOb2RlOjpzdHJlYW1UbyhTb3VyY2VTdHJlYW0m
IHMpIGNvbnN0CiB7Ci0gICAgcyA8PCBQcmVjQ2FsbCA8PCBleHByMSA8PCAiWyIgPDwgZXhwcjIg
PDwgIl0iOworICAgIGJyYWNrZXROb2RlU3RyZWFtVG8ocywgZXhwcjEsIGV4cHIyKTsKIH0KIAog
dm9pZCBEb3RBY2Nlc3Nvck5vZGU6OnN0cmVhbVRvKFNvdXJjZVN0cmVhbSYgcykgY29uc3QKIHsK
LSAgICBzIDw8IERvdEV4cHIgPDwgUHJlY0NhbGwgPDwgZXhwciA8PCAiLiIgPDwgaWRlbnQ7Cisg
ICAgZG90Tm9kZVN0cmVhbVRvKHMsIGV4cHIsIGlkZW50KTsKIH0KIAogdm9pZCBBcmd1bWVudExp
c3ROb2RlOjpzdHJlYW1UbyhTb3VyY2VTdHJlYW0mIHMpIGNvbnN0CkluZGV4OiBMYXlvdXRUZXN0
cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lv
biAyOTgxMCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDEzIEBACisyMDA4LTAxLTI2ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCisKKyAgICAgICAgVGVzdCBjYXNlcyBm
b3IgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwMjAKKyAgICAgICAg
RnVuY3Rpb24udG9TdHJpbmcgZG9lcyBub3QgcGFyZW50aGVzaXNlIG51bWJlcnMgZm9yIHRoZSBi
cmFja2V0IGFjY2Vzc29yCisKKyAgICAgICAgKiBmYXN0L2pzL2Z1bmN0aW9uLXRvU3RyaW5nLXBh
cmVudGhlc2VzLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2pzL3Jlc291cmNlcy9mdW5j
dGlvbi10b1N0cmluZy1wYXJlbnRoZXNlcy5qczoKKwogMjAwOC0wMS0yNiAgRGFyaW4gQWRsZXIg
IDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2xpdmVyLgpJbmRleDog
TGF5b3V0VGVzdHMvZmFzdC9qcy9mdW5jdGlvbi10b1N0cmluZy1wYXJlbnRoZXNlcy1leHBlY3Rl
ZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9qcy9mdW5jdGlvbi10b1N0cmlu
Zy1wYXJlbnRoZXNlcy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDI5ODEwKQorKysgTGF5b3V0VGVz
dHMvZmFzdC9qcy9mdW5jdGlvbi10b1N0cmluZy1wYXJlbnRoZXNlcy1leHBlY3RlZC50eHQJKHdv
cmtpbmcgY29weSkKQEAgLTQwMiw2ICs0MDIsMTIgQEAgUEFTUyBjb21waWxlQW5kU2VyaWFsaXpl
KCcoIWEpKysnKSBpcyAnKAogUEFTUyBjb21waWxlQW5kU2VyaWFsaXplKCchYS0tJykgaXMgJyFh
LS0nCiBQQVNTIGNvbXBpbGVBbmRTZXJpYWxpemUoJyEoYS0tKScpIGlzICchYS0tJwogUEFTUyBj
b21waWxlQW5kU2VyaWFsaXplKCcoIWEpLS0nKSBpcyAnKCFhKS0tJworUEFTUyBjb21waWxlQW5k
U2VyaWFsaXplKCcoLTEpW2FdJykgaXMgJygtMSlbYV0nCitQQVNTIGNvbXBpbGVBbmRTZXJpYWxp
emUoJygtMSlbYV0gPSBiJykgaXMgJygtMSlbYV0gPSBiJworUEFTUyBjb21waWxlQW5kU2VyaWFs
aXplKCcoLTEpW2FdICs9IGInKSBpcyAnKC0xKVthXSArPSBiJworUEFTUyBjb21waWxlQW5kU2Vy
aWFsaXplKCcoLTEpW2FdKysnKSBpcyAnKC0xKVthXSsrJworUEFTUyBjb21waWxlQW5kU2VyaWFs
aXplKCcrKygtMSlbYV0nKSBpcyAnKysoLTEpW2FdJworUEFTUyBjb21waWxlQW5kU2VyaWFsaXpl
KCcoLTEpW2FdKCknKSBpcyAnKC0xKVthXSgpJwogUEFTUyBjb21waWxlQW5kU2VyaWFsaXplTGVm
dG1vc3RUZXN0KCcoeyB9KS54JykgaXMgJyh7IH0pLngnCiBQQVNTIGNvbXBpbGVBbmRTZXJpYWxp
emVMZWZ0bW9zdFRlc3QoJ3ggPSB7IH0nKSBpcyAneCA9IHsgfScKIFBBU1MgY29tcGlsZUFuZFNl
cmlhbGl6ZUxlZnRtb3N0VGVzdCgnKGZ1bmN0aW9uICgpIHsgfSkoKScpIGlzICcoZnVuY3Rpb24g
KCkgeyB9KSgpJwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9qcy9yZXNvdXJjZXMvZnVuY3Rpb24t
dG9TdHJpbmctcGFyZW50aGVzZXMuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9q
cy9yZXNvdXJjZXMvZnVuY3Rpb24tdG9TdHJpbmctcGFyZW50aGVzZXMuanMJKHJldmlzaW9uIDI5
ODEwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9qcy9yZXNvdXJjZXMvZnVuY3Rpb24tdG9TdHJpbmct
cGFyZW50aGVzZXMuanMJKHdvcmtpbmcgY29weSkKQEAgLTEzNyw2ICsxMzcsMTIgQEAgc2hvdWxk
QmUoImNvbXBpbGVBbmRTZXJpYWxpemUoJyghYSkrKycpIgogc2hvdWxkQmUoImNvbXBpbGVBbmRT
ZXJpYWxpemUoJyFhLS0nKSIsICInIWEtLSciKTsKIHNob3VsZEJlKCJjb21waWxlQW5kU2VyaWFs
aXplKCchKGEtLSknKSIsICInIWEtLSciKTsKIHNob3VsZEJlKCJjb21waWxlQW5kU2VyaWFsaXpl
KCcoIWEpLS0nKSIsICInKCFhKS0tJyIpOworc2hvdWxkQmUoImNvbXBpbGVBbmRTZXJpYWxpemUo
JygtMSlbYV0nKSIsICInKC0xKVthXSciKTsKK3Nob3VsZEJlKCJjb21waWxlQW5kU2VyaWFsaXpl
KCcoLTEpW2FdID0gYicpIiwgIicoLTEpW2FdID0gYiciKTsKK3Nob3VsZEJlKCJjb21waWxlQW5k
U2VyaWFsaXplKCcoLTEpW2FdICs9IGInKSIsICInKC0xKVthXSArPSBiJyIpOworc2hvdWxkQmUo
ImNvbXBpbGVBbmRTZXJpYWxpemUoJygtMSlbYV0rKycpIiwgIicoLTEpW2FdKysnIik7CitzaG91
bGRCZSgiY29tcGlsZUFuZFNlcmlhbGl6ZSgnKysoLTEpW2FdJykiLCAiJysrKC0xKVthXSciKTsK
K3Nob3VsZEJlKCJjb21waWxlQW5kU2VyaWFsaXplKCcoLTEpW2FdKCknKSIsICInKC0xKVthXSgp
JyIpOwogc2hvdWxkQmUoImNvbXBpbGVBbmRTZXJpYWxpemVMZWZ0bW9zdFRlc3QoJyh7IH0pLngn
KSIsICInKHsgfSkueCciKTsKIHNob3VsZEJlKCJjb21waWxlQW5kU2VyaWFsaXplTGVmdG1vc3RU
ZXN0KCd4ID0geyB9JykiLCAiJ3ggPSB7IH0nIik7CiBzaG91bGRCZSgiY29tcGlsZUFuZFNlcmlh
bGl6ZUxlZnRtb3N0VGVzdCgnKGZ1bmN0aW9uICgpIHsgfSkoKScpIiwgIicoZnVuY3Rpb24gKCkg
eyB9KSgpJyIpOwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>18713</attachid>
            <date>2008-01-26 17:03:26 -0800</date>
            <delta_ts>2008-01-26 18:12:51 -0800</delta_ts>
            <desc>Updated fix</desc>
            <filename>numfix.patch</filename>
            <type>text/plain</type>
            <size>6533</size>
            <attacher name="Oliver Hunt">oliver</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No
YW5nZUxvZwppbmRleCA5NTFiMGM1Li45NDczZTMwIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y
ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjEg
QEAKIDIwMDgtMDEtMjYgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAorICAgICAg
ICBSZXZpZXdlZCBieSBOT0JPRFkoT09QUyEpLgorCisgICAgICAgIEZpeCBmb3IgaHR0cDovL2J1
Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwMjAKKyAgICAgICAgRnVuY3Rpb24udG9T
dHJpbmcgZG9lcyBub3QgcGFyZW50aGVzaXNlIG51bWJlcnMgZm9yIHRoZSBicmFja2V0IGFjY2Vz
c29yCisKKyAgICAgICAgSXQgdHVybnMgb3V0IHRoYXQgbG9naWMgd2FzIHRoZXJlIGZvciBhbGwg
b2YgdGhlIGRvdCBhY2Nlc3NvciBub2RlcyB0byBtYWtlIG51bWJlcnMgYmUKKyAgICAgICAgcGFy
ZW50aGVzaXNlZCBwcm9wZXJseSwgc28gaXQgd2FzIGEgdHJpdmlhbCBleHRlbnNpb24gdG8gZXh0
ZW5kIHRoYXQgdG8gdGhlIGJyYWNrZXQgbm9kZXMuCisgICAgICAgIEkgcmVuYW1lZCB0aGUgZW51
bSB0eXBlIHRvIHJlZmxlY3QgdGhlIGZhY3QgdGhhdCBpdCBpcyBub3cgdXNlZCBmb3IgYm90aCBk
b3QgYW5kIGJyYWNrZXQKKyAgICAgICAgYWNjZXNzb3JzLgorCisgICAgICAgICoga2pzL25vZGVz
MnN0cmluZy5jcHA6CisgICAgICAgIChLSlM6OmJyYWNrZXROb2RlU3RyZWFtVG8pOgorICAgICAg
ICAoS0pTOjpCcmFja2V0QWNjZXNzb3JOb2RlOjpzdHJlYW1Ubyk6CisKKzIwMDgtMDEtMjYgIE9s
aXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KKwogICAgICAgICBSZXZpZXdlZCBieSBEYXJp
bi4KIAogICAgICAgICBGaXggQnVnIDE3MDE4OiBJbmNvcnJlY3QgY29kZSBnZW5lcmF0ZWQgZnJv
bSBGdW5jdGlvbi50b1N0cmluZyBmb3IgZ2V0L3NldHRlcnMgaW4gb2JqZWN0IGxpdGVyYWxzCmRp
ZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9ranMvbm9kZXMyc3RyaW5nLmNwcCBiL0phdmFTY3Jp
cHRDb3JlL2tqcy9ub2RlczJzdHJpbmcuY3BwCmluZGV4IDM0YzYzMmYuLjIyMmNjZGIgMTAwNjQ0
Ci0tLSBhL0phdmFTY3JpcHRDb3JlL2tqcy9ub2RlczJzdHJpbmcuY3BwCisrKyBiL0phdmFTY3Jp
cHRDb3JlL2tqcy9ub2RlczJzdHJpbmcuY3BwCkBAIC0zNyw3ICszNyw3IEBAIG5hbWVzcGFjZSBL
SlMgewogZW51bSBFbmRsVHlwZSB7IEVuZGwgfTsKIGVudW0gSW5kZW50VHlwZSB7IEluZGVudCB9
OwogZW51bSBVbmluZGVudFR5cGUgeyBVbmluZGVudCB9OwotZW51bSBEb3RFeHByVHlwZSB7IERv
dEV4cHIgfTsKK2VudW0gT2JqZWN0QWNjZXNzVHlwZSB7IE9iamVjdEFjY2VzcyB9OwogCiBjbGFz
cyBTb3VyY2VTdHJlYW0gewogcHVibGljOgpAQCAtNTEsNyArNTEsNyBAQCBwdWJsaWM6CiAgICAg
U291cmNlU3RyZWFtJiBvcGVyYXRvcjw8KEVuZGxUeXBlKTsKICAgICBTb3VyY2VTdHJlYW0mIG9w
ZXJhdG9yPDwoSW5kZW50VHlwZSk7CiAgICAgU291cmNlU3RyZWFtJiBvcGVyYXRvcjw8KFVuaW5k
ZW50VHlwZSk7Ci0gICAgU291cmNlU3RyZWFtJiBvcGVyYXRvcjw8KERvdEV4cHJUeXBlKTsKKyAg
ICBTb3VyY2VTdHJlYW0mIG9wZXJhdG9yPDwoT2JqZWN0QWNjZXNzVHlwZSk7CiAgICAgU291cmNl
U3RyZWFtJiBvcGVyYXRvcjw8KFByZWNlZGVuY2UpOwogICAgIFNvdXJjZVN0cmVhbSYgb3BlcmF0
b3I8PChjb25zdCBOb2RlKik7CiAgICAgdGVtcGxhdGUgPHR5cGVuYW1lIFQ+IFNvdXJjZVN0cmVh
bSYgb3BlcmF0b3I8PChjb25zdCBSZWZQdHI8VD4mIG4pIHsgcmV0dXJuICp0aGlzIDw8IG4uZ2V0
KCk7IH0KQEAgLTIzNSw3ICsyMzUsNyBAQCBTb3VyY2VTdHJlYW0mIFNvdXJjZVN0cmVhbTo6b3Bl
cmF0b3I8PChVbmluZGVudFR5cGUpCiAgICAgcmV0dXJuICp0aGlzOwogfQogCi1pbmxpbmUgU291
cmNlU3RyZWFtJiBTb3VyY2VTdHJlYW06Om9wZXJhdG9yPDwoRG90RXhwclR5cGUpCitpbmxpbmUg
U291cmNlU3RyZWFtJiBTb3VyY2VTdHJlYW06Om9wZXJhdG9yPDwoT2JqZWN0QWNjZXNzVHlwZSkK
IHsKICAgICBtX251bWJlck5lZWRzUGFyZW5zID0gdHJ1ZTsKICAgICByZXR1cm4gKnRoaXM7CkBA
IC0yNjMsMTIgKzI2MywxMiBAQCB0ZW1wbGF0ZSA8dHlwZW5hbWUgVD4gc3RhdGljIGlubGluZSB2
b2lkIHN0cmVhbUxlZnRBc3NvY2lhdGl2ZUJpbmFyeU9wZXJhdG9yKFNvdQogCiBzdGF0aWMgaW5s
aW5lIHZvaWQgYnJhY2tldE5vZGVTdHJlYW1UbyhTb3VyY2VTdHJlYW0mIHMsIGNvbnN0IFJlZlB0
cjxFeHByZXNzaW9uTm9kZT4mIGJhc2UsIGNvbnN0IFJlZlB0cjxFeHByZXNzaW9uTm9kZT4mIHN1
YnNjcmlwdCkKIHsKLSAgICBzIDw8IFByZWNDYWxsIDw8IGJhc2UuZ2V0KCkgPDwgIlsiIDw8IHN1
YnNjcmlwdC5nZXQoKSA8PCAiXSI7CisgICAgcyA8PCBPYmplY3RBY2Nlc3MgPDwgUHJlY0NhbGwg
PDwgYmFzZS5nZXQoKSA8PCAiWyIgPDwgc3Vic2NyaXB0LmdldCgpIDw8ICJdIjsKIH0KIAogc3Rh
dGljIGlubGluZSB2b2lkIGRvdE5vZGVTdHJlYW1UbyhTb3VyY2VTdHJlYW0mIHMsIGNvbnN0IFJl
ZlB0cjxFeHByZXNzaW9uTm9kZT4mIGJhc2UsIGNvbnN0IElkZW50aWZpZXImIGlkZW50KQogewot
ICAgIHMgPDwgRG90RXhwciA8PCBQcmVjQ2FsbCA8PCBiYXNlLmdldCgpIDw8ICIuIiA8PCBpZGVu
dDsKKyAgICBzIDw8IE9iamVjdEFjY2VzcyA8PCBQcmVjQ2FsbCA8PCBiYXNlLmdldCgpIDw8ICIu
IiA8PCBpZGVudDsKIH0KIAogLy8gLS0tLS0tLS0KQEAgLTM5MiwxMiArMzkyLDEyIEBAIHZvaWQg
UHJvcGVydHlOb2RlOjpzdHJlYW1UbyhTb3VyY2VTdHJlYW0mIHMpIGNvbnN0CiAKIHZvaWQgQnJh
Y2tldEFjY2Vzc29yTm9kZTo6c3RyZWFtVG8oU291cmNlU3RyZWFtJiBzKSBjb25zdAogewotICAg
IHMgPDwgUHJlY0NhbGwgPDwgZXhwcjEgPDwgIlsiIDw8IGV4cHIyIDw8ICJdIjsKKyAgICBicmFj
a2V0Tm9kZVN0cmVhbVRvKHMsIGV4cHIxLCBleHByMik7CiB9CiAKIHZvaWQgRG90QWNjZXNzb3JO
b2RlOjpzdHJlYW1UbyhTb3VyY2VTdHJlYW0mIHMpIGNvbnN0CiB7Ci0gICAgcyA8PCBEb3RFeHBy
IDw8IFByZWNDYWxsIDw8IGV4cHIgPDwgIi4iIDw8IGlkZW50OworICAgIGRvdE5vZGVTdHJlYW1U
byhzLCBleHByLCBpZGVudCk7CiB9CiAKIHZvaWQgQXJndW1lbnRMaXN0Tm9kZTo6c3RyZWFtVG8o
U291cmNlU3RyZWFtJiBzKSBjb25zdApAQCAtNDE0LDcgKzQxNCw3IEBAIHZvaWQgQXJndW1lbnRz
Tm9kZTo6c3RyZWFtVG8oU291cmNlU3RyZWFtJiBzKSBjb25zdAogCiB2b2lkIE5ld0V4cHJOb2Rl
OjpzdHJlYW1UbyhTb3VyY2VTdHJlYW0mIHMpIGNvbnN0CiB7Ci0gICAgcyA8PCAibmV3ICIgPDwg
UHJlY01lbWJlciA8PCBleHByIDw8IGFyZ3M7CisgICAgcyA8PCAibmV3ICIgPDwgT2JqZWN0QWNj
ZXNzIDw8IFByZWNNZW1iZXIgPDwgZXhwciA8PCBhcmdzOwogfQogCiB2b2lkIEZ1bmN0aW9uQ2Fs
bFZhbHVlTm9kZTo6c3RyZWFtVG8oU291cmNlU3RyZWFtJiBzKSBjb25zdApkaWZmIC0tZ2l0IGEv
TGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDA1Yjk1
MzguLjVjODM2YjggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlv
dXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNSBAQAogMjAwOC0wMS0yNiAgT2xpdmVyIEh1
bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWShPT1BT
ISkuCisKKyAgICAgICAgVGVzdCBjYXNlcyBmb3IgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9MTcwMjAKKyAgICAgICAgRnVuY3Rpb24udG9TdHJpbmcgZG9lcyBub3QgcGFy
ZW50aGVzaXNlIG51bWJlcnMgZm9yIHRoZSBicmFja2V0IGFjY2Vzc29yCisKKyAgICAgICAgKiBm
YXN0L2pzL2Z1bmN0aW9uLXRvU3RyaW5nLXBhcmVudGhlc2VzLWV4cGVjdGVkLnR4dDoKKyAgICAg
ICAgKiBmYXN0L2pzL3Jlc291cmNlcy9mdW5jdGlvbi10b1N0cmluZy1wYXJlbnRoZXNlcy5qczoK
KworMjAwOC0wMS0yNiAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgorCiAgICAgICAg
IFJldmlld2VkIGJ5IERhcmluLgogCiAgICAgICAgIEFkZCB0ZXN0IGZvciBnZXR0ZXJzIGFuZCBz
ZXR0ZXJzIGFzIHBhcnQgb2YgZml4IGZvciBidWcgIzE3MDE4CmRpZmYgLS1naXQgYS9MYXlvdXRU
ZXN0cy9mYXN0L2pzL2Z1bmN0aW9uLXRvU3RyaW5nLXBhcmVudGhlc2VzLWV4cGVjdGVkLnR4dCBi
L0xheW91dFRlc3RzL2Zhc3QvanMvZnVuY3Rpb24tdG9TdHJpbmctcGFyZW50aGVzZXMtZXhwZWN0
ZWQudHh0CmluZGV4IGQ1ZjFmM2YuLjcwYTJiOTkgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zh
c3QvanMvZnVuY3Rpb24tdG9TdHJpbmctcGFyZW50aGVzZXMtZXhwZWN0ZWQudHh0CisrKyBiL0xh
eW91dFRlc3RzL2Zhc3QvanMvZnVuY3Rpb24tdG9TdHJpbmctcGFyZW50aGVzZXMtZXhwZWN0ZWQu
dHh0CkBAIC00MDIsNiArNDAyLDEyIEBAIFBBU1MgY29tcGlsZUFuZFNlcmlhbGl6ZSgnKCFhKSsr
JykgaXMgJyghYSkrKycKIFBBU1MgY29tcGlsZUFuZFNlcmlhbGl6ZSgnIWEtLScpIGlzICchYS0t
JwogUEFTUyBjb21waWxlQW5kU2VyaWFsaXplKCchKGEtLSknKSBpcyAnIWEtLScKIFBBU1MgY29t
cGlsZUFuZFNlcmlhbGl6ZSgnKCFhKS0tJykgaXMgJyghYSktLScKK1BBU1MgY29tcGlsZUFuZFNl
cmlhbGl6ZSgnKC0xKVthXScpIGlzICcoLTEpW2FdJworUEFTUyBjb21waWxlQW5kU2VyaWFsaXpl
KCcoLTEpW2FdID0gYicpIGlzICcoLTEpW2FdID0gYicKK1BBU1MgY29tcGlsZUFuZFNlcmlhbGl6
ZSgnKC0xKVthXSArPSBiJykgaXMgJygtMSlbYV0gKz0gYicKK1BBU1MgY29tcGlsZUFuZFNlcmlh
bGl6ZSgnKC0xKVthXSsrJykgaXMgJygtMSlbYV0rKycKK1BBU1MgY29tcGlsZUFuZFNlcmlhbGl6
ZSgnKysoLTEpW2FdJykgaXMgJysrKC0xKVthXScKK1BBU1MgY29tcGlsZUFuZFNlcmlhbGl6ZSgn
KC0xKVthXSgpJykgaXMgJygtMSlbYV0oKScKIFBBU1MgY29tcGlsZUFuZFNlcmlhbGl6ZUxlZnRt
b3N0VGVzdCgnKHsgfSkueCcpIGlzICcoeyB9KS54JwogUEFTUyBjb21waWxlQW5kU2VyaWFsaXpl
TGVmdG1vc3RUZXN0KCd4ID0geyB9JykgaXMgJ3ggPSB7IH0nCiBQQVNTIGNvbXBpbGVBbmRTZXJp
YWxpemVMZWZ0bW9zdFRlc3QoJyhmdW5jdGlvbiAoKSB7IH0pKCknKSBpcyAnKGZ1bmN0aW9uICgp
IHsgfSkoKScKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvanMvcmVzb3VyY2VzL2Z1bmN0
aW9uLXRvU3RyaW5nLXBhcmVudGhlc2VzLmpzIGIvTGF5b3V0VGVzdHMvZmFzdC9qcy9yZXNvdXJj
ZXMvZnVuY3Rpb24tdG9TdHJpbmctcGFyZW50aGVzZXMuanMKaW5kZXggM2FlYmZlYi4uNDFhMGMx
MiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9qcy9yZXNvdXJjZXMvZnVuY3Rpb24tdG9T
dHJpbmctcGFyZW50aGVzZXMuanMKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9qcy9yZXNvdXJjZXMv
ZnVuY3Rpb24tdG9TdHJpbmctcGFyZW50aGVzZXMuanMKQEAgLTEzNyw2ICsxMzcsMTMgQEAgc2hv
dWxkQmUoImNvbXBpbGVBbmRTZXJpYWxpemUoJyghYSkrKycpIiwgIicoIWEpKysnIik7CiBzaG91
bGRCZSgiY29tcGlsZUFuZFNlcmlhbGl6ZSgnIWEtLScpIiwgIichYS0tJyIpOwogc2hvdWxkQmUo
ImNvbXBpbGVBbmRTZXJpYWxpemUoJyEoYS0tKScpIiwgIichYS0tJyIpOwogc2hvdWxkQmUoImNv
bXBpbGVBbmRTZXJpYWxpemUoJyghYSktLScpIiwgIicoIWEpLS0nIik7CitzaG91bGRCZSgiY29t
cGlsZUFuZFNlcmlhbGl6ZSgnKC0xKVthXScpIiwgIicoLTEpW2FdJyIpOworc2hvdWxkQmUoImNv
bXBpbGVBbmRTZXJpYWxpemUoJygtMSlbYV0gPSBiJykiLCAiJygtMSlbYV0gPSBiJyIpOworc2hv
dWxkQmUoImNvbXBpbGVBbmRTZXJpYWxpemUoJygtMSlbYV0gKz0gYicpIiwgIicoLTEpW2FdICs9
IGInIik7CitzaG91bGRCZSgiY29tcGlsZUFuZFNlcmlhbGl6ZSgnKC0xKVthXSsrJykiLCAiJygt
MSlbYV0rKyciKTsKK3Nob3VsZEJlKCJjb21waWxlQW5kU2VyaWFsaXplKCcrKygtMSlbYV0nKSIs
ICInKysoLTEpW2FdJyIpOworc2hvdWxkQmUoImNvbXBpbGVBbmRTZXJpYWxpemUoJygtMSlbYV0o
KScpIiwgIicoLTEpW2FdKCknIik7CitzaG91bGRCZSgiY29tcGlsZUFuZFNlcmlhbGl6ZSgnbmV3
ICgtMSkoKScpIiwgIiduZXcgKC0xKSgpJyIpOwogc2hvdWxkQmUoImNvbXBpbGVBbmRTZXJpYWxp
emVMZWZ0bW9zdFRlc3QoJyh7IH0pLngnKSIsICInKHsgfSkueCciKTsKIHNob3VsZEJlKCJjb21w
aWxlQW5kU2VyaWFsaXplTGVmdG1vc3RUZXN0KCd4ID0geyB9JykiLCAiJ3ggPSB7IH0nIik7CiBz
aG91bGRCZSgiY29tcGlsZUFuZFNlcmlhbGl6ZUxlZnRtb3N0VGVzdCgnKGZ1bmN0aW9uICgpIHsg
fSkoKScpIiwgIicoZnVuY3Rpb24gKCkgeyB9KSgpJyIpOwo=
</data>
<flag name="review"
          id="8173"
          type_id="1"
          status="+"
          setter="mjs"
    />
          </attachment>
      

    </bug>

</bugzilla>