170193 2017-03-28 13:06:38 -0700 Fix Dashboard test _presentPopoverForJavaScriptCoreTestRegressions 2017-03-28 15:15:59 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=170158 P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue ddkilzer jmarcell lforschler webkit oldest_to_newest 1292032 0 aakash_jain 2017-03-28 13:06:38 -0700 _presentPopoverForJavaScriptCoreTestRegressions dashboard test fails with error "undefined is not an object". 1292036 1 305628 aakash_jain 2017-03-28 13:10:04 -0700 Created attachment 305628 Proposed patch 1292040 2 305629 aakash_jain 2017-03-28 13:12:53 -0700 Created attachment 305629 Updated patch 1292081 3 jmarcell 2017-03-28 14:10:15 -0700 Confirmed that all tests are passing after applying 170191 & 170193. 1292112 4 305629 commit-queue 2017-03-28 14:56:30 -0700 Comment on attachment 305629 Updated patch Rejecting attachment 305629 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 305629, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 214493 = b6cf2c6d60a2136c3c2f2518f65a3a1fe5de9953 r214494 = 2e3de94ceb111c23b31bcb4963d08d13a90f9339 r214495 = 99443ce429ff7bb437a4791d790c15bbdb1c7298 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/3429426 1292124 5 aakash_jain 2017-03-28 15:15:41 -0700 Committed https://trac.webkit.org/changeset/214497/webkit 305628 2017-03-28 13:10:04 -0700 2017-03-28 13:12:53 -0700 Proposed patch patch_dashboard_jsc text/plain 2071 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNDQ4OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE3LTAzLTI4ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBGaXggRGFzaGJvYXJkIHRlc3QgX3ByZXNlbnRQb3BvdmVyRm9ySmF2YVNj cmlwdENvcmVUZXN0UmVncmVzc2lvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE3MDE5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25m aWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvdGVzdHMvcmVzb3VyY2VzL3Rlc3RzLmpz OgorICAgICAgICBGaXhlZCB0aGUgb3JkZXIgb2YgYXJndW1lbnRzLgorCiAyMDE3LTAzLTI4ICBK b25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICB3ZWJraXRweTog VXNlIGhvc3QgcGF0dGVybiBmb3IgZGV2aWNlcwpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMv dGVzdHMvcmVzb3VyY2VzL3Rlc3RzLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3Jp cHRzL3Rlc3RzL3Jlc291cmNlcy90ZXN0cy5qcwkocmV2aXNpb24gMjE0NDg2KQorKysgVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFz aGJvYXJkL1NjcmlwdHMvdGVzdHMvcmVzb3VyY2VzL3Rlc3RzLmpzCSh3b3JraW5nIGNvcHkpCkBA IC0zMTgsNyArMzE4LDcgQEAgdGVzdCgiX3ByZXNlbnRQb3BvdmVyRm9ySmF2YVNjcmlwdENvcmVU ZQogICAgIGl0ZXJhdGlvbi5qYXZhU2NyaXB0Q29yZVRlc3RSZXN1bHRzID0gbmV3IE1vY2tCdWls ZGJvdFRlc3RSZXN1bHRzKCk7CiAKICAgICB2YXIgdmlldyA9IG5ldyBCdWlsZGJvdFF1ZXVlVmll dygpOwotICAgIHZpZXcuX3ByZXNlbnRQb3BvdmVyRm9ySmF2YVNjcmlwdENvcmVUZXN0UmVncmVz c2lvbnMoZWxlbWVudCwgcG9wb3ZlciwgaXRlcmF0aW9uLCAianNjb3JlLXRlc3QiKTsKKyAgICB2 aWV3Ll9wcmVzZW50UG9wb3ZlckZvckphdmFTY3JpcHRDb3JlVGVzdFJlZ3Jlc3Npb25zKCAianNj b3JlLXRlc3QiLCBlbGVtZW50LCBwb3BvdmVyLCBpdGVyYXRpb24pOwogCiAgICAgSlNPTi5sb2Fk KCJyZXNvdXJjZXMvdGVzdC1qc2MtcmVzdWx0cy5qc29uIiwgZnVuY3Rpb24oZGF0YSkKICAgICB7 CkBAIC0zNjIsNyArMzYyLDcgQEAgdGVzdCgiX3ByZXNlbnRQb3BvdmVyRm9ySmF2YVNjcmlwdENv cmVUZQogICAgIGl0ZXJhdGlvbi5qYXZhU2NyaXB0Q29yZVRlc3RSZXN1bHRzID0geyJyZWdyZXNz aW9ucyI6IFsidW5vIiwgImRvcyIsICJ0cmVzIl19OwogCiAgICAgdmFyIHZpZXcgPSBuZXcgQnVp bGRib3RRdWV1ZVZpZXcoKTsKLSAgICB2aWV3Ll9wcmVzZW50UG9wb3ZlckZvckphdmFTY3JpcHRD b3JlVGVzdFJlZ3Jlc3Npb25zKGVsZW1lbnQsIHBvcG92ZXIsIGl0ZXJhdGlvbiwgImpzY29yZS10 ZXN0Iik7CisgICAgdmlldy5fcHJlc2VudFBvcG92ZXJGb3JKYXZhU2NyaXB0Q29yZVRlc3RSZWdy ZXNzaW9ucygianNjb3JlLXRlc3QiLCBlbGVtZW50LCBwb3BvdmVyLCBpdGVyYXRpb24pOwogCiAg ICAgdmFyIG51bUNoaWxkcmVuSW5FbXB0eVBvcG92ZXJDb250ZW50ID0gMjsKICAgICBzdHJpY3RF cXVhbChwb3BvdmVyLl9jb250ZW50LmNoaWxkTm9kZXMubGVuZ3RoIC0gbnVtQ2hpbGRyZW5JbkVt cHR5UG9wb3ZlckNvbnRlbnQsCg== 305629 2017-03-28 13:12:53 -0700 2017-03-28 15:15:59 -0700 Updated patch patch_dashboard_jsc_v2 text/plain 2070 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNDQ4OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE3LTAzLTI4ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBGaXggRGFzaGJvYXJkIHRlc3QgX3ByZXNlbnRQb3BvdmVyRm9ySmF2YVNj cmlwdENvcmVUZXN0UmVncmVzc2lvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE3MDE5MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25m aWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvdGVzdHMvcmVzb3VyY2VzL3Rlc3RzLmpz OgorICAgICAgICBGaXhlZCB0aGUgb3JkZXIgb2YgYXJndW1lbnRzLgorCiAyMDE3LTAzLTI4ICBK b25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAgICAgICB3ZWJraXRweTog VXNlIGhvc3QgcGF0dGVybiBmb3IgZGV2aWNlcwpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMv dGVzdHMvcmVzb3VyY2VzL3Rlc3RzLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3Jp cHRzL3Rlc3RzL3Jlc291cmNlcy90ZXN0cy5qcwkocmV2aXNpb24gMjE0NDg2KQorKysgVG9vbHMv QnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFz aGJvYXJkL1NjcmlwdHMvdGVzdHMvcmVzb3VyY2VzL3Rlc3RzLmpzCSh3b3JraW5nIGNvcHkpCkBA IC0zMTgsNyArMzE4LDcgQEAgdGVzdCgiX3ByZXNlbnRQb3BvdmVyRm9ySmF2YVNjcmlwdENvcmVU ZQogICAgIGl0ZXJhdGlvbi5qYXZhU2NyaXB0Q29yZVRlc3RSZXN1bHRzID0gbmV3IE1vY2tCdWls ZGJvdFRlc3RSZXN1bHRzKCk7CiAKICAgICB2YXIgdmlldyA9IG5ldyBCdWlsZGJvdFF1ZXVlVmll dygpOwotICAgIHZpZXcuX3ByZXNlbnRQb3BvdmVyRm9ySmF2YVNjcmlwdENvcmVUZXN0UmVncmVz c2lvbnMoZWxlbWVudCwgcG9wb3ZlciwgaXRlcmF0aW9uLCAianNjb3JlLXRlc3QiKTsKKyAgICB2 aWV3Ll9wcmVzZW50UG9wb3ZlckZvckphdmFTY3JpcHRDb3JlVGVzdFJlZ3Jlc3Npb25zKCJqc2Nv cmUtdGVzdCIsIGVsZW1lbnQsIHBvcG92ZXIsIGl0ZXJhdGlvbik7CiAKICAgICBKU09OLmxvYWQo InJlc291cmNlcy90ZXN0LWpzYy1yZXN1bHRzLmpzb24iLCBmdW5jdGlvbihkYXRhKQogICAgIHsK QEAgLTM2Miw3ICszNjIsNyBAQCB0ZXN0KCJfcHJlc2VudFBvcG92ZXJGb3JKYXZhU2NyaXB0Q29y ZVRlCiAgICAgaXRlcmF0aW9uLmphdmFTY3JpcHRDb3JlVGVzdFJlc3VsdHMgPSB7InJlZ3Jlc3Np b25zIjogWyJ1bm8iLCAiZG9zIiwgInRyZXMiXX07CiAKICAgICB2YXIgdmlldyA9IG5ldyBCdWls ZGJvdFF1ZXVlVmlldygpOwotICAgIHZpZXcuX3ByZXNlbnRQb3BvdmVyRm9ySmF2YVNjcmlwdENv cmVUZXN0UmVncmVzc2lvbnMoZWxlbWVudCwgcG9wb3ZlciwgaXRlcmF0aW9uLCAianNjb3JlLXRl c3QiKTsKKyAgICB2aWV3Ll9wcmVzZW50UG9wb3ZlckZvckphdmFTY3JpcHRDb3JlVGVzdFJlZ3Jl c3Npb25zKCJqc2NvcmUtdGVzdCIsIGVsZW1lbnQsIHBvcG92ZXIsIGl0ZXJhdGlvbik7CiAKICAg ICB2YXIgbnVtQ2hpbGRyZW5JbkVtcHR5UG9wb3ZlckNvbnRlbnQgPSAyOwogICAgIHN0cmljdEVx dWFsKHBvcG92ZXIuX2NvbnRlbnQuY2hpbGROb2Rlcy5sZW5ndGggLSBudW1DaGlsZHJlbkluRW1w dHlQb3BvdmVyQ29udGVudCwK