170191 2017-03-28 12:52:12 -0700 Dashboard tests fails to fetch the revision from commits 2017-03-28 14:56:18 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=168624 https://bugs.webkit.org/show_bug.cgi?id=170158 P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue ddkilzer jmarcell lforschler webkit oldest_to_newest 1292013 0 aakash_jain 2017-03-28 12:52:12 -0700 Many dashboard tests (e.g: nextRevision, indexOfRevision, commitsOnBranchLaterThanRevision, commitsOnBranchInRevisionRange) fails as they fails to fetch the revision from commits. 1292020 1 305625 aakash_jain 2017-03-28 12:58:05 -0700 Created attachment 305625 Proposed patch 1292082 2 jmarcell 2017-03-28 14:10:18 -0700 Confirmed that all tests are passing after applying 170191 & 170193. 1292110 3 305625 commit-queue 2017-03-28 14:56:14 -0700 Comment on attachment 305625 Proposed patch Clearing flags on attachment: 305625 Committed r214496: <http://trac.webkit.org/changeset/214496> 1292111 4 commit-queue 2017-03-28 14:56:18 -0700 All reviewed patches have been landed. Closing bug. 305625 2017-03-28 12:58:05 -0700 2017-03-28 14:56:14 -0700 Proposed patch patch_dashboard_fetch_revision text/plain 5004 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNDQ4NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE3LTAzLTI4ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBEYXNoYm9hcmQgdGVzdHMgZmFpbHMgdG8gZmV0Y2ggdGhlIHJldmlzaW9u IGZyb20gY29tbWl0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTcwMTkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNf aHRtbC9kYXNoYm9hcmQvU2NyaXB0cy90ZXN0cy9yZXNvdXJjZXMvTW9ja1RyYWMuanM6CisgICAg ICAgIEFkZGVkIHJlY29yZGVkQ29tbWl0SW5kaWNlc0J5UmV2aXNpb25OdW1iZXIuCisgICAgICAg ICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwv ZGFzaGJvYXJkL1NjcmlwdHMvdGVzdHMvcmVzb3VyY2VzL3Rlc3RzLmpzOgorICAgICAgICAoc2V0 dXApOiBQb3B1bGF0ZWQgdHJhYy5yZWNvcmRlZENvbW1pdEluZGljZXNCeVJldmlzaW9uTnVtYmVy IHNpbmNlIHRoZSBkYXNoYm9hcmQgY29kZSB1c2VzIHRoaXMgdmFyaWFibGUuCisKIDIwMTctMDMt MjggIEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAgIHdlYmtp dHB5OiBVc2UgaG9zdCBwYXR0ZXJuIGZvciBkZXZpY2VzCkluZGV4OiBUb29scy9CdWlsZFNsYXZl U3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2Ny aXB0cy90ZXN0cy9yZXNvdXJjZXMvTW9ja1RyYWMuanMKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVp bGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJv YXJkL1NjcmlwdHMvdGVzdHMvcmVzb3VyY2VzL01vY2tUcmFjLmpzCShyZXZpc2lvbiAyMTQyMzcp CisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJs aWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy90ZXN0cy9yZXNvdXJjZXMvTW9ja1RyYWMuanMJKHdv cmtpbmcgY29weSkKQEAgLTEwNiw0ICsxMDYsMTUgQEAgTW9ja1RyYWMuRVhBTVBMRV9UUkFDX0NP TU1JVFMgPSBbCiAgICAgICAgICJjb250YWluc0JyYW5jaExvY2F0aW9uIjogdHJ1ZSwKICAgICAg ICAgImJyYW5jaGVzIjogWyJ0cnVuayJdCiAgICAgfQotXTsKXCBObyBuZXdsaW5lIGF0IGVuZCBv ZiBmaWxlCitdOworCitNb2NrVHJhYy5yZWNvcmRlZENvbW1pdEluZGljZXNCeVJldmlzaW9uTnVt YmVyID0geworICAgIDMzMDE4OiAwLAorICAgIDMzMDE5OiAxLAorICAgIDMzMDIwOiAyLAorICAg IDMzMDIxOiAzLAorICAgIDMzMDIyOiA0LAorICAgIDMzMDIzOiA1LAorICAgIDMzMDI0OiA2LAor ICAgIDMzMDI1OiA3Cit9OwpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Vi a2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvdGVzdHMvcmVzb3Vy Y2VzL3Rlc3RzLmpzCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxk LndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL3Rlc3RzL3Jl c291cmNlcy90ZXN0cy5qcwkocmV2aXNpb24gMjE0NDg2KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1 cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1Njcmlw dHMvdGVzdHMvcmVzb3VyY2VzL3Rlc3RzLmpzCSh3b3JraW5nIGNvcHkpCkBAIC05MSw2ICs5MSw3 IEBAIHRlc3QoIl9wYXJzZVJldmlzaW9uRnJvbVVSTCIsIGZ1bmN0aW9uKCkKIHRlc3QoIm5leHRS ZXZpc2lvbiIsIGZ1bmN0aW9uKCkKIHsKICAgICB0aGlzLnRyYWMucmVjb3JkZWRDb21taXRzID0g TW9ja1RyYWMuRVhBTVBMRV9UUkFDX0NPTU1JVFM7CisgICAgdGhpcy50cmFjLnJlY29yZGVkQ29t bWl0SW5kaWNlc0J5UmV2aXNpb25OdW1iZXIgPSBNb2NrVHJhYy5yZWNvcmRlZENvbW1pdEluZGlj ZXNCeVJldmlzaW9uTnVtYmVyOwogICAgIHN0cmljdEVxdWFsKHRoaXMudHJhYy5uZXh0UmV2aXNp b24oInRydW5rIiwgIjMzMDIwIiksICIzMzAyMiIsICJuZXh0UmV2aXNpb24gc2FtZSBicmFuY2gi KTsKICAgICBzdHJpY3RFcXVhbCh0aGlzLnRyYWMubmV4dFJldmlzaW9uKCJ0cnVuayIsICIzMzAx OSIpLCAiMzMwMjAiLCAibmV4dFJldmlzaW9uIGRpZmZlcmVudCBicmFuY2giKTsKIH0pOwpAQCAt OTgsMTIgKzk5LDE0IEBAIHRlc3QoIm5leHRSZXZpc2lvbiIsIGZ1bmN0aW9uKCkKIHRlc3QoImlu ZGV4T2ZSZXZpc2lvbiIsIGZ1bmN0aW9uKCkKIHsKICAgICB0aGlzLnRyYWMucmVjb3JkZWRDb21t aXRzID0gTW9ja1RyYWMuRVhBTVBMRV9UUkFDX0NPTU1JVFM7CisgICAgdGhpcy50cmFjLnJlY29y ZGVkQ29tbWl0SW5kaWNlc0J5UmV2aXNpb25OdW1iZXIgPSBNb2NrVHJhYy5yZWNvcmRlZENvbW1p dEluZGljZXNCeVJldmlzaW9uTnVtYmVyOwogICAgIHN0cmljdEVxdWFsKHRoaXMudHJhYy5pbmRl eE9mUmV2aXNpb24oIjMzMDIwIiksIDIsICJpbmRleE9mUmV2aXNpb24iKTsKIH0pOwogCiB0ZXN0 KCJjb21taXRzT25CcmFuY2hMYXRlclRoYW5SZXZpc2lvbiIsIGZ1bmN0aW9uKCkKIHsKICAgICB0 aGlzLnRyYWMucmVjb3JkZWRDb21taXRzID0gTW9ja1RyYWMuRVhBTVBMRV9UUkFDX0NPTU1JVFM7 CisgICAgdGhpcy50cmFjLnJlY29yZGVkQ29tbWl0SW5kaWNlc0J5UmV2aXNpb25OdW1iZXIgPSBN b2NrVHJhYy5yZWNvcmRlZENvbW1pdEluZGljZXNCeVJldmlzaW9uTnVtYmVyOwogICAgIHZhciBj b21taXRzID0gdGhpcy50cmFjLmNvbW1pdHNPbkJyYW5jaExhdGVyVGhhblJldmlzaW9uKCJ0cnVu ayIsICIzMzAyMCIpOwogICAgIGVxdWFsKGNvbW1pdHMubGVuZ3RoLCAxLCAiZ3JlYXRlciB0aGFu IDMzMDIwIik7CiB9KTsKQEAgLTExMSw2ICsxMTQsNyBAQCB0ZXN0KCJjb21taXRzT25CcmFuY2hM YXRlclRoYW5SZXZpc2lvbiIsCiB0ZXN0KCJjb21taXRzT25CcmFuY2hMYXRlclRoYW5SZXZpc2lv biBubyBjb21taXRzIiwgZnVuY3Rpb24oKQogewogICAgIHRoaXMudHJhYy5yZWNvcmRlZENvbW1p dHMgPSBNb2NrVHJhYy5FWEFNUExFX1RSQUNfQ09NTUlUUzsKKyAgICB0aGlzLnRyYWMucmVjb3Jk ZWRDb21taXRJbmRpY2VzQnlSZXZpc2lvbk51bWJlciA9IE1vY2tUcmFjLnJlY29yZGVkQ29tbWl0 SW5kaWNlc0J5UmV2aXNpb25OdW1iZXI7CiAgICAgdmFyIGNvbW1pdHMgPSB0aGlzLnRyYWMuY29t bWl0c09uQnJhbmNoTGF0ZXJUaGFuUmV2aXNpb24oInNvbWVPdGhlckJyYW5jaCIsICIzMzAyMSIp OwogICAgIGVxdWFsKGNvbW1pdHMubGVuZ3RoLCAwLCAiZ3JlYXRlciB0aGFuIDMzMDIxIik7CiB9 KTsKQEAgLTExOCw2ICsxMjIsNyBAQCB0ZXN0KCJjb21taXRzT25CcmFuY2hMYXRlclRoYW5SZXZp c2lvbiBuCiB0ZXN0KCJjb21taXRzT25CcmFuY2hJblJldmlzaW9uUmFuZ2UiLCBmdW5jdGlvbigp CiB7CiAgICAgdGhpcy50cmFjLnJlY29yZGVkQ29tbWl0cyA9IE1vY2tUcmFjLkVYQU1QTEVfVFJB Q19DT01NSVRTOworICAgIHRoaXMudHJhYy5yZWNvcmRlZENvbW1pdEluZGljZXNCeVJldmlzaW9u TnVtYmVyID0gTW9ja1RyYWMucmVjb3JkZWRDb21taXRJbmRpY2VzQnlSZXZpc2lvbk51bWJlcjsK ICAgICB2YXIgY29tbWl0cyA9IHRoaXMudHJhYy5jb21taXRzT25CcmFuY2hJblJldmlzaW9uUmFu Z2UoInRydW5rIiwgIjMzMDIwIiwgIjMzMDIyIik7CiAgICAgZXF1YWwoY29tbWl0cy5sZW5ndGgs IDIsICJpbiByYW5nZSAzMzAyMCwgMzMwMjIiKTsKIH0pOwpAQCAtMTU2LDYgKzE2MSw3IEBAIG1v ZHVsZSgiQnVpbGRCb3RRdWV1ZVZpZXciLCB7CiAgICAgc2V0dXA6IGZ1bmN0aW9uKCkgewogICAg ICAgICB0aGlzLnRyYWMgPSBuZXcgTW9ja1RyYWMoKTsKICAgICAgICAgdGhpcy50cmFjLnJlY29y ZGVkQ29tbWl0cyA9IE1vY2tUcmFjLkVYQU1QTEVfVFJBQ19DT01NSVRTOworICAgICAgICB0aGlz LnRyYWMucmVjb3JkZWRDb21taXRJbmRpY2VzQnlSZXZpc2lvbk51bWJlciA9IE1vY2tUcmFjLnJl Y29yZGVkQ29tbWl0SW5kaWNlc0J5UmV2aXNpb25OdW1iZXI7CiAgICAgICAgIHRoaXMucXVldWUg PSBuZXcgTW9ja0J1aWxkYm90UXVldWUoKTsKICAgICAgICAgdGhpcy50cnVua0JyYW5jaCA9IHsK ICAgICAgICAgICAgIG5hbWU6ICJ0cnVuayIsCkBAIC0zODIsNiArMzg4LDcgQEAgbW9kdWxlKCJC dWlsZEJvdFF1ZXVlIiwgewogICAgIHNldHVwOiBmdW5jdGlvbigpIHsKICAgICAgICAgRGFzaGJv YXJkLlJlcG9zaXRvcnkuT3BlblNvdXJjZS50cmFjID0gbmV3IE1vY2tUcmFjKCk7CiAgICAgICAg IERhc2hib2FyZC5SZXBvc2l0b3J5Lk9wZW5Tb3VyY2UudHJhYy5yZWNvcmRlZENvbW1pdHMgPSBN b2NrVHJhYy5FWEFNUExFX1RSQUNfQ09NTUlUUzsKKyAgICAgICAgRGFzaGJvYXJkLlJlcG9zaXRv cnkuT3BlblNvdXJjZS50cmFjLnJlY29yZGVkQ29tbWl0SW5kaWNlc0J5UmV2aXNpb25OdW1iZXIg PSBNb2NrVHJhYy5yZWNvcmRlZENvbW1pdEluZGljZXNCeVJldmlzaW9uTnVtYmVyOwogICAgICAg ICB0aGlzLnF1ZXVlID0gbmV3IE1vY2tCdWlsZGJvdFF1ZXVlKCk7CiAgICAgICAgIHRoaXMucXVl dWUuYnJhbmNoZXMgPSBbewogICAgICAgICAgICAgbmFtZTogInRydW5rIiwK