170189 2017-03-28 11:41:52 -0700 Web Inspector: Unable to Format JSON Request Data 2017-03-28 12:21:07 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue inspector-bugzilla-changes joepeck mattbaker oldest_to_newest 1291985 0 joepeck 2017-03-28 11:41:52 -0700 Summary: Unable to Format JSON Request Data Exception: null is not an object (evaluating 'this._delegate.textEditorScriptSourceType')​ (at TextEditor.js:​842:​40)​ _startWorkerPrettyPrint @ TextEditor.js:​842:​40 ?​ @ TextEditor.js:​825:​45 initializePromise @ [native code]​ Promise @ [native code]​ prettyPrint @ TextEditor.js:​816:​27 _format @ TextEditor.js:​796:​51 updateFormattedState @ TextEditor.js:​180:​28 _togglePrettyPrint @ TextContentView.js:​160:​46 dispatch @ Object.js:​170:​30 dispatchEventToListeners @ Object.js:​177:​17 _mouseClicked @ ButtonNavigationItem.js:​131:​38 _mouseClicked @ [native code]​ Notes: - Seems we are just trying to determine if this is a Script or a Module. We can assume a script if we don't have a delegate. 1291988 1 305617 joepeck 2017-03-28 11:45:50 -0700 Created attachment 305617 [PATCH] Proposed Fix 1291989 2 305617 mattbaker 2017-03-28 11:48:51 -0700 Comment on attachment 305617 [PATCH] Proposed Fix r=me 1292001 3 305617 commit-queue 2017-03-28 12:21:03 -0700 Comment on attachment 305617 [PATCH] Proposed Fix Clearing flags on attachment: 305617 Committed r214487: <http://trac.webkit.org/changeset/214487> 1292002 4 commit-queue 2017-03-28 12:21:07 -0700 All reviewed patches have been landed. Closing bug. 305617 2017-03-28 11:45:50 -0700 2017-03-28 12:21:03 -0700 [PATCH] Proposed Fix format-request-1.patch text/plain 1979 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDQwNDcxOTgxZjliLi45Y2E0M2U2NDkyNyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAKIDIwMTctMDMtMjggIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9y OiBVbmFibGUgdG8gRm9ybWF0IEpTT04gUmVxdWVzdCBEYXRhCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzAxODkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvVGV4dEVk aXRvci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UZXh0RWRpdG9yLnByb3RvdHlwZS5fc3Rh cnRXb3JrZXJQcmV0dHlQcmludCk6CisgICAgICAgIFdoZW4gd2UgYXJlIHZpZXdpbmcgcmVxdWVz dCBkYXRhIHdlIGFyZSBsb29raW5nIGF0IGEgVGV4dFJlc291cmNlQ29udGVudFZpZXcKKyAgICAg ICAgd2hpY2ggaGFzIGEgVGV4dEVkaXRvciB3aXRob3V0IGEgZGVsZWdhdGUuIEluIHRoZXNlIGNh c2VzIHdlIGNhbiBqdXN0IGFzc3VtZQorICAgICAgICBhIEphdmFTY3JpcHQgUHJvZ3JhbS4gSW4g dGhlIG1ham9yaXR5IG9mIGNhc2VzIHRoaXMgd2lsbCB0eXBpY2FsbHkgYmUgSlNPTgorICAgICAg ICBkYXRhLCBhbmQgZWl0aGVyIFByb2dyYW0gb3IgTW9kdWxlIHdpbGwgaGlnaGxpZ2h0IGFuZCBm b3JtYXQgYXMgZXhwZWN0ZWQuCisKKzIwMTctMDMtMjggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29y YXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbnNwZWN0aW5nIGEgTWFp biBSZXNvdXJjZSB0aGF0IGlzIEpTL0pTT04gZG9lcyBub3QgZm9ybWF0IC8gc3ludGF4IGhpZ2hs aWdodCBpdCBwcm9wZXJseQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTY2ODYyCiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yOTgzNTk3Nz4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRFZGl0 b3IuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UZXh0RWRp dG9yLmpzCmluZGV4IDc3NTRmMzJlZmMyLi40YTRmN2E0ZGZlMCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGV4dEVkaXRvci5qcworKysgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UZXh0RWRpdG9yLmpzCkBA IC04MzksNyArODM5LDcgQEAgV2ViSW5zcGVjdG9yLlRleHRFZGl0b3IgPSBjbGFzcyBUZXh0RWRp dG9yIGV4dGVuZHMgV2ViSW5zcGVjdG9yLlZpZXcKICAgICAgICAgbGV0IGluZGVudFN0cmluZyA9 IFdlYkluc3BlY3Rvci5pbmRlbnRTdHJpbmcoKTsKICAgICAgICAgY29uc3QgaW5jbHVkZVNvdXJj ZU1hcERhdGEgPSB0cnVlOwogCi0gICAgICAgIGxldCBzb3VyY2VUeXBlID0gdGhpcy5fZGVsZWdh dGUudGV4dEVkaXRvclNjcmlwdFNvdXJjZVR5cGUodGhpcyk7CisgICAgICAgIGxldCBzb3VyY2VU eXBlID0gdGhpcy5fZGVsZWdhdGUgPyB0aGlzLl9kZWxlZ2F0ZS50ZXh0RWRpdG9yU2NyaXB0U291 cmNlVHlwZSh0aGlzKSA6IFdlYkluc3BlY3Rvci5TY3JpcHQuU291cmNlVHlwZS5Qcm9ncmFtOwog ICAgICAgICBjb25zdCBpc01vZHVsZSA9IHNvdXJjZVR5cGUgPT09IFdlYkluc3BlY3Rvci5TY3Jp cHQuU291cmNlVHlwZS5Nb2R1bGU7CiAKICAgICAgICAgbGV0IHdvcmtlclByb3h5ID0gV2ViSW5z cGVjdG9yLkZvcm1hdHRlcldvcmtlclByb3h5LnNpbmdsZXRvbigpOwo=