170188 2017-03-28 11:08:46 -0700 [mac-wk1 debug] LayoutTest media/track/track-cue-rendering-with-padding.html is a flaky timeout 2017-03-30 23:54:25 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryanhaddad pvollan ap bfulgham commit-queue eric.carlson jer.noble pvollan oldest_to_newest 1291956 0 ryanhaddad 2017-03-28 11:08:46 -0700 LayoutTest media/track/track-cue-rendering-with-padding.html is a flaky timeout https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK1%20(Tests)/builds/198 https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Ftrack%2Ftrack-cue-rendering-with-padding.html 1292434 1 ap 2017-03-29 09:47:02 -0700 No timeouts from 2017-3-5 till 2017-3-16; one on 2017-3-16; frequent timeouts starting 2017-3-27. 1292716 2 305841 pvollan 2017-03-29 23:51:32 -0700 Created attachment 305841 Patch 1292790 3 305841 eric.carlson 2017-03-30 08:52:04 -0700 Comment on attachment 305841 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305841&action=review > LayoutTests/media/track/track-cue-rendering-with-padding.html:20 > + var maxRetries = 256; This means the test won't fail for 25 seconds. What made you choose such a long time, it seems *extremely* unlikely that it could take that long for the cue display element to be created. 1292809 4 pvollan 2017-03-30 09:35:10 -0700 (In reply to Eric Carlson from comment #3) > Comment on attachment 305841 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=305841&action=review > > > LayoutTests/media/track/track-cue-rendering-with-padding.html:20 > > + var maxRetries = 256; > > This means the test won't fail for 25 seconds. What made you choose such a > long time, it seems *extremely* unlikely that it could take that long for > the cue display element to be created. I chose a long time in order to make sure that if the test fails again, it was definitely not because we picked a too short time. But 25 seconds is probably a little too long, though :) 1292810 5 305841 pvollan 2017-03-30 09:35:49 -0700 Comment on attachment 305841 Patch Thanks for reviewing! 1292820 6 ap 2017-03-30 09:53:26 -0700 FWIW, 20 to 25 seconds is what I'd have picked too. The delays can be huge sometimes (think of 18 media tests running with GuardMalloc in parallel, and a couple of them crashing). 1292901 7 305841 commit-queue 2017-03-30 13:38:19 -0700 Comment on attachment 305841 Patch Rejecting attachment 305841 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 305841, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: Parsed 2 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/media/track/track-cue-rendering-with-padding.html Hunk #1 FAILED at 16. Hunk #2 FAILED at 26. 2 out of 2 hunks FAILED -- saving rejects to file LayoutTests/media/track/track-cue-rendering-with-padding.html.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Eric Carlson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/3442599 1293109 8 pvollan 2017-03-30 23:54:25 -0700 Committed <https://trac.webkit.org/changeset/214612/webkit>. 305841 2017-03-29 23:51:32 -0700 2017-03-30 13:38:19 -0700 Patch bug-170188-20170330085130.patch text/plain 2543 pvollan SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDIxNDYwMCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTAzLTI5ICBQZXIgQXJuZSBWb2xsYW4g IDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbbWFjLXdrMSBkZWJ1Z10gTGF5b3V0VGVz dCBtZWRpYS90cmFjay90cmFjay1jdWUtcmVuZGVyaW5nLXdpdGgtcGFkZGluZy5odG1sIGlzIGEg Zmxha3kgdGltZW91dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTcwMTg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGhlIHRleHRUcmFja0Rpc3BsYXlFbGVtZW50IGNhbGwgd2lsbCBmYWlsIGFuZCB0aHJv dyBhbiBleGNlcHRpb24gaWYgdGhlIHRleHQgdHJhY2sgZGlzcGxheSBlbGVtZW50CisgICAgICAg IGhhcyBub3QgeWV0IGJlZW4gYWRkZWQgdG8gdGhlIHRleHQgdHJhY2sgY29udGFpbmVyIGVsZW1l bnQuIFdlIHdhaXQgdW50aWwgaXQgaGFzIGJlZW4gYWRkZWQuCisKKyAgICAgICAgKiBtZWRpYS90 cmFjay90cmFjay1jdWUtcmVuZGVyaW5nLXdpdGgtcGFkZGluZy5odG1sOgorCiAyMDE3LTAzLTMw ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNT SU9OKH5yMjEyMzIyKTogTGF5b3V0VGVzdCBtZWRpYS90cmFjay90cmFjay1jdWUtY29udGFpbmVy LXJlbmRlcmluZy1wb3NpdGlvbi5odG1sIGlzIGEgZmxha3kgdGltZW91dApJbmRleDogTGF5b3V0 VGVzdHMvbWVkaWEvdHJhY2svdHJhY2stY3VlLXJlbmRlcmluZy13aXRoLXBhZGRpbmcuaHRtbAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1jdWUtcmVuZGVyaW5n LXdpdGgtcGFkZGluZy5odG1sCShyZXZpc2lvbiAyMTQ1OTkpCisrKyBMYXlvdXRUZXN0cy9tZWRp YS90cmFjay90cmFjay1jdWUtcmVuZGVyaW5nLXdpdGgtcGFkZGluZy5odG1sCSh3b3JraW5nIGNv cHkpCkBAIC0xNiw2ICsxNiw4IEBACiAgICAgICAgIDxzY3JpcHQ+CiAgICAgICAgIHZhciBjdWVD b250YWluZXJCb3R0b21Qb2ludDsKICAgICAgICAgdmFyIGN1ZURpc3BsYXlCb3R0b21Qb2ludDsK KyAgICAgICAgdmFyIHJldHJpZXMgPSAwOworICAgICAgICB2YXIgbWF4UmV0cmllcyA9IDI1NjsK IAogICAgICAgICBmdW5jdGlvbiBzdGFydFRlc3QoKQogICAgICAgICB7CkBAIC0yNCw4ICsyNiwy MiBAQAogICAgICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgICAgIH0KIAorICAgICAgICAg ICAgLy8gVGhlIHRleHRUcmFja0Rpc3BsYXlFbGVtZW50IGNhbGwgd2lsbCBmYWlsIGFuZCB0aHJv dyBhbiBleGNlcHRpb24gaWYgdGhlIHRleHQgdHJhY2sgZGlzcGxheSBlbGVtZW50CisgICAgICAg ICAgICAvLyBoYXMgbm90IHlldCBiZWVuIGFkZGVkIHRvIHRoZSB0ZXh0IHRyYWNrIGNvbnRhaW5l ciBlbGVtZW50LiBXZSB3YWl0IHVudGlsIGl0IGhhcyBiZWVuIGFkZGVkLgorICAgICAgICAgICAg dHJ5IHsKKyAgICAgICAgICAgICAgICB2YXIgY3VlRGlzcGxheUVsZW1lbnQgPSB0ZXh0VHJhY2tE aXNwbGF5RWxlbWVudCh2aWRlbywgJ2Rpc3BsYXknLCAwKTsKKyAgICAgICAgICAgIH0gY2F0Y2gg KGV4Y2VwdGlvbikgeworICAgICAgICAgICAgICAgIHJldHJpZXMrKzsKKyAgICAgICAgICAgICAg ICBpZiAocmV0cmllcyA+IG1heFJldHJpZXMpIHsKKyAgICAgICAgICAgICAgICAgICAgY29uc29s ZVdyaXRlKCJUaGUgdGVzdCBmYWlsZWQgYmVjYXVzZSB0aGUgdGV4dCB0cmFjayBkaXNwbGF5IGVs ZW1lbnQgd2FzIG5vdCBmb3VuZC4iKTsKKyAgICAgICAgICAgICAgICAgICAgZW5kVGVzdCgpOwor ICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAgICBlbHNlCisgICAgICAgICAgICAgICAg ICAgIHNldFRpbWVvdXQoc3RhcnRUZXN0LCAxMDApOworICAgICAgICAgICAgICAgIHJldHVybjsK KyAgICAgICAgICAgIH0KKwogICAgICAgICAgICAgdmFyIGN1ZUNvbnRhaW5lckVsZW1lbnQgPSB0 ZXh0VHJhY2tEaXNwbGF5RWxlbWVudCh2aWRlbyk7Ci0gICAgICAgICAgICB2YXIgY3VlRGlzcGxh eUVsZW1lbnQgPSB0ZXh0VHJhY2tEaXNwbGF5RWxlbWVudCh2aWRlbywgJ2Rpc3BsYXknLCAwKTsK IAogICAgICAgICAgICAgY3VlRGlzcGxheUJvdHRvbVBvaW50ID0gY3VlRGlzcGxheUVsZW1lbnQu b2Zmc2V0VG9wICsgY3VlRGlzcGxheUVsZW1lbnQub2Zmc2V0SGVpZ2h0OwogICAgICAgICAgICAg Y3VlQ29udGFpbmVyQm90dG9tUG9pbnQgPSBjdWVDb250YWluZXJFbGVtZW50Lm9mZnNldFRvcCAr IGN1ZUNvbnRhaW5lckVsZW1lbnQub2Zmc2V0SGVpZ2h0Owo=