17018 2008-01-26 03:38:42 -0800 Incorrect code generated from Function.toString for get/setters in object literals 2008-02-11 17:04:44 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Mac OS X 10.4 RESOLVED FIXED HasReduction P2 Normal --- 13638 1 oliver oliver darin jruderman oliver oldest_to_newest 68285 0 oliver 2008-01-26 03:38:42 -0800 If you have a function: function f() { ({ set g(x){} }); } Then f.toString will produce incorrect (non-compilable) output as it quotes the identifier string: function f() { ({ set "g"(x){} }); } Found by jsfunfuzz -- maybe i had recopmilation set to not test these cases when i was running these? 68287 1 oliver 2008-01-26 03:58:17 -0800 Fix appears to be diff --git a/JavaScriptCore/kjs/nodes2string.cpp b/JavaScriptCore/kjs/nodes2string.cpp index 0432b7f..79a0675 100644 --- a/JavaScriptCore/kjs/nodes2string.cpp +++ b/JavaScriptCore/kjs/nodes2string.cpp @@ -370,11 +370,11 @@ void PropertyNode::streamTo(SourceStream& s) const case Setter: { const FuncExprNode* func = static_cast<const FuncExprNode*>(assign.get()); if (type == Getter) - s << "get \""; + s << "get "; else - s << "set \""; + s << "set "; s << escapeStringForPrettyPrinting(name().ustring()) - << "\"(" << func->param << ')' << func->body; + << "(" << func->param << ')' << func->body; break; } } But I can't see why they were ever escaped strings -- is there a case i am missing where 'set "foo"(x)' would be valid? 68288 2 18706 oliver 2008-01-26 04:41:26 -0800 Created attachment 18706 Patch! 68294 3 18706 darin 2008-01-26 08:13:46 -0800 Comment on attachment 18706 Patch! r=me What about getters and setters with unusual names? 69013 4 oliver 2008-02-01 00:00:44 -0800 Fixed in r29812 70342 5 jruderman 2008-02-11 17:04:44 -0800 *** Bug 13621 has been marked as a duplicate of this bug. *** 18706 2008-01-26 04:41:26 -0800 2008-01-26 08:13:46 -0800 Patch! getterfix.patch text/plain 3928 oliver ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBmNTc5NjM4Li40MTZmYmI3IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMDgtMDEtMjYgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggQnVnIDE3MDE4OiBJ bmNvcnJlY3QgY29kZSBnZW5lcmF0ZWQgZnJvbSBGdW5jdGlvbi50b1N0cmluZyBmb3IgZ2V0L3Nl dHRlcnMgaW4gb2JqZWN0IGxpdGVyYWxzCisKKyAgICAgICAgRG9uJ3QgcXVvdGUgZ2V0dGVyIGFu ZCBzZXR0ZXIgbmFtZXMgZHVyaW5nIG91dHB1dCwgYXMgdGhhdCBpcyBzaW1wbHkgd3JvbmcuCisK KyAgICAgICAgKiBranMvbm9kZXMyc3RyaW5nLmNwcDoKKyAgICAgICAgKEtKUzo6UHJvcGVydHlO b2RlOjpzdHJlYW1Ubyk6CisKIDIwMDgtMDEtMjYgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL0phdmFT Y3JpcHRDb3JlL2tqcy9ub2RlczJzdHJpbmcuY3BwIGIvSmF2YVNjcmlwdENvcmUva2pzL25vZGVz MnN0cmluZy5jcHAKaW5kZXggMDQzMmI3Zi4uNzlhMDY3NSAxMDA2NDQKLS0tIGEvSmF2YVNjcmlw dENvcmUva2pzL25vZGVzMnN0cmluZy5jcHAKKysrIGIvSmF2YVNjcmlwdENvcmUva2pzL25vZGVz MnN0cmluZy5jcHAKQEAgLTM3MCwxMSArMzcwLDExIEBAIHZvaWQgUHJvcGVydHlOb2RlOjpzdHJl YW1UbyhTb3VyY2VTdHJlYW0mIHMpIGNvbnN0CiAgICAgICAgIGNhc2UgU2V0dGVyOiB7CiAgICAg ICAgICAgICBjb25zdCBGdW5jRXhwck5vZGUqIGZ1bmMgPSBzdGF0aWNfY2FzdDxjb25zdCBGdW5j RXhwck5vZGUqPihhc3NpZ24uZ2V0KCkpOwogICAgICAgICAgICAgaWYgKHR5cGUgPT0gR2V0dGVy KQotICAgICAgICAgICAgICAgIHMgPDwgImdldCBcIiI7IAorICAgICAgICAgICAgICAgIHMgPDwg ImdldCAiOyAKICAgICAgICAgICAgIGVsc2UKLSAgICAgICAgICAgICAgICBzIDw8ICJzZXQgXCIi OworICAgICAgICAgICAgICAgIHMgPDwgInNldCAiOwogICAgICAgICAgICAgcyA8PCBlc2NhcGVT dHJpbmdGb3JQcmV0dHlQcmludGluZyhuYW1lKCkudXN0cmluZygpKQotICAgICAgICAgICAgICAg IDw8ICJcIigiIDw8IGZ1bmMtPnBhcmFtIDw8ICcpJyA8PCBmdW5jLT5ib2R5OworICAgICAgICAg ICAgICAgIDw8ICIoIiA8PCBmdW5jLT5wYXJhbSA8PCAnKScgPDwgZnVuYy0+Ym9keTsKICAgICAg ICAgICAgIGJyZWFrOwogICAgICAgICB9CiAgICAgfQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGYwM2FmMmIuLjM2NzgwMTgg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAwOC0wMS0yNiAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJA YXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEFkZCB0ZXN0IGZvciBnZXR0ZXJzIGFuZCBzZXR0ZXJzIGFzIHBhcnQgb2YgZml4IGZvciBi dWcgIzE3MDE4CisKKyAgICAgICAgKiBmYXN0L2pzL2Z1bmN0aW9uLXRvU3RyaW5nLW9iamVjdC1s aXRlcmFscy1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9qcy9yZXNvdXJjZXMvZnVuY3Rp b24tdG9TdHJpbmctb2JqZWN0LWxpdGVyYWxzLmpzOgorCiAyMDA4LTAxLTI2ICBEYXJpbiBBZGxl ciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBPbGl2ZXIuCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2pzL2Z1bmN0aW9uLXRvU3RyaW5nLW9iamVjdC1saXRl cmFscy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2pzL2Z1bmN0aW9uLXRvU3RyaW5n LW9iamVjdC1saXRlcmFscy1leHBlY3RlZC50eHQKaW5kZXggZjBmZDE0NS4uZjk5YzQ3NiAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9qcy9mdW5jdGlvbi10b1N0cmluZy1vYmplY3QtbGl0 ZXJhbHMtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvanMvZnVuY3Rpb24tdG9T dHJpbmctb2JqZWN0LWxpdGVyYWxzLWV4cGVjdGVkLnR4dApAQCAtMTcsNiArMTcsOCBAQCBQQVNT IGNvbXBpbGVBbmRTZXJpYWxpemUoJ2EgPSB7ICIxIjogbnVsbCB9JykgaXMgJ2EgPSB7IDE6IG51 bGwgfScKIFBBU1MgY29tcGlsZUFuZFNlcmlhbGl6ZSgnYSA9IHsgIjFoaSI6IG51bGwgfScpIGlz ICdhID0geyAiMWhpIjogbnVsbCB9JwogUEFTUyBjb21waWxlQW5kU2VyaWFsaXplKCdhID0geyAi XCciOiBudWxsIH0nKSBpcyAnYSA9IHsgIlwnIjogbnVsbCB9JwogUEFTUyBjb21waWxlQW5kU2Vy aWFsaXplKCdhID0geyAiXFwiIjogbnVsbCB9JykgaXMgJ2EgPSB7ICJcXCIiOiBudWxsIH0nCitQ QVNTIGNvbXBpbGVBbmRTZXJpYWxpemUoJ2EgPSB7IGdldCB4KCkgeyB9IH0nKSBpcyAnYSA9IHsg Z2V0IHgoKSB7IH0gfScKK1BBU1MgY29tcGlsZUFuZFNlcmlhbGl6ZSgnYSA9IHsgc2V0IHgoeSkg eyB9IH0nKSBpcyAnYSA9IHsgc2V0IHgoeSkgeyB9IH0nCiBQQVNTIGNvbXBpbGVBbmRTZXJpYWxp emUoJ2EgPSB7IC0tMTogbnVsbCB9JykgdGhyZXcgZXhjZXB0aW9uIFN5bnRheEVycm9yOiBQYXJz ZSBlcnJvci4KIFBBU1MgY29tcGlsZUFuZFNlcmlhbGl6ZSgnYSA9IHsgLU5hTjogbnVsbCB9Jykg dGhyZXcgZXhjZXB0aW9uIFN5bnRheEVycm9yOiBQYXJzZSBlcnJvci4KIFBBU1MgY29tcGlsZUFu ZFNlcmlhbGl6ZSgnYSA9IHsgLTA6IG51bGwgfScpIHRocmV3IGV4Y2VwdGlvbiBTeW50YXhFcnJv cjogUGFyc2UgZXJyb3IuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2pzL3Jlc291cmNl cy9mdW5jdGlvbi10b1N0cmluZy1vYmplY3QtbGl0ZXJhbHMuanMgYi9MYXlvdXRUZXN0cy9mYXN0 L2pzL3Jlc291cmNlcy9mdW5jdGlvbi10b1N0cmluZy1vYmplY3QtbGl0ZXJhbHMuanMKaW5kZXgg ODc3ZmVjNy4uMWQ2YWQ5NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9qcy9yZXNvdXJj ZXMvZnVuY3Rpb24tdG9TdHJpbmctb2JqZWN0LWxpdGVyYWxzLmpzCisrKyBiL0xheW91dFRlc3Rz L2Zhc3QvanMvcmVzb3VyY2VzL2Z1bmN0aW9uLXRvU3RyaW5nLW9iamVjdC1saXRlcmFscy5qcwpA QCAtMzAsNiArMzAsOSBAQCBzaG91bGRCZSgiY29tcGlsZUFuZFNlcmlhbGl6ZSgnYSA9IHsgXCIx aGlcIjogbnVsbCB9JykiLCAiJ2EgPSB7IFwiMWhpXCI6IG51bGwgfQogc2hvdWxkQmUoImNvbXBp bGVBbmRTZXJpYWxpemUoJ2EgPSB7IFwiXFxcJ1wiOiBudWxsIH0nKSIsICInYSA9IHsgXCJcXFwn XCI6IG51bGwgfSciKTsKIHNob3VsZEJlKCJjb21waWxlQW5kU2VyaWFsaXplKCdhID0geyBcIlxc XFxcIlwiOiBudWxsIH0nKSIsICInYSA9IHsgXCJcXFxcXCJcIjogbnVsbCB9JyIpOwogCitzaG91 bGRCZSgiY29tcGlsZUFuZFNlcmlhbGl6ZSgnYSA9IHsgZ2V0IHgoKSB7IH0gfScpIiwgIidhID0g eyBnZXQgeCgpIHsgfSB9JyIpOworc2hvdWxkQmUoImNvbXBpbGVBbmRTZXJpYWxpemUoJ2EgPSB7 IHNldCB4KHkpIHsgfSB9JykiLCAiJ2EgPSB7IHNldCB4KHkpIHsgfSB9JyIpOworCiBzaG91bGRU aHJvdygiY29tcGlsZUFuZFNlcmlhbGl6ZSgnYSA9IHsgLS0xOiBudWxsIH0nKSIpOwogc2hvdWxk VGhyb3coImNvbXBpbGVBbmRTZXJpYWxpemUoJ2EgPSB7IC1OYU46IG51bGwgfScpIik7CiBzaG91 bGRUaHJvdygiY29tcGlsZUFuZFNlcmlhbGl6ZSgnYSA9IHsgLTA6IG51bGwgfScpIik7Cg==