170177 2017-03-28 08:59:00 -0700 LayoutTest fast/images/reset-image-animation.html is a flaky failure 2023-04-27 17:42:19 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad fujii fujii graouts jonlee sabouhallawa simon.fraser webkit-bug-importer oldest_to_newest 1291905 0 ryanhaddad 2017-03-28 08:59:00 -0700 LayoutTest fast/images/reset-image-animation.html is a flaky failure https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK2%20(Tests)/r214472%20(169)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fimages%2Freset-image-animation.html --- /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/fast/images/reset-image-animation-expected.txt +++ /Volumes/Data/slave/sierra-debug-tests-wk2/build/layout-test-results/fast/images/reset-image-animation-actual.txt @@ -4,7 +4,7 @@ PASS internals.imageFrameIndex(image) is 0 -PASS internals.imageFrameIndex(image) is 1 +FAIL internals.imageFrameIndex(image) should be 1. Was 0. The animation of the image was reset. PASS internals.imageFrameIndex(image) is 0 PASS internals.imageFrameIndex(image) is 1 1292437 1 ap 2017-03-29 09:52:27 -0700 No clear regression point, but this has become much more frequent about a week ago. 1292539 2 ap 2017-03-29 13:20:28 -0700 Easily reproducible under CPU pressure: run-webkit-tests -1 -v --no-build fast/images/reset-image-animation.html --repeat-each 1000 -f --child-processes=20 1292654 3 ap 2017-03-29 17:35:26 -0700 r214450 had a fix to make the test not flaky, but it is still flaky. 1294313 4 ryanhaddad 2017-04-04 18:00:27 -0700 Marked test as flaky in https://trac.webkit.org/r214921 1951478 5 fujii 2023-04-26 17:46:50 -0700 WinCairo Debug is the most flaky bot. https://results.webkit.org/?suite=layout-tests&test=fast%2Fimages%2Freset-image-animation.html The decoding frame seems to be delayed under heavy CPU load. The following patch makes the test stable. diff --git a/LayoutTests/fast/images/reset-image-animation.html b/LayoutTests/fast/images/reset-image-animation.html index 62cb9bf09894..634a79b7be04 100644 --- a/LayoutTests/fast/images/reset-image-animation.html +++ b/LayoutTests/fast/images/reset-image-animation.html @@ -16,7 +16,7 @@ shouldBe("internals.imageFrameIndex(image)", expectedFrame.toString()); setTimeout(() => { resolve(expectedFrame + 1); - }, 30); + }, 300); }); } 1951481 6 fujii 2023-04-26 18:01:45 -0700 I tried another approach of retrying drawFrame until expected frame without extending the timer duration. However, I'm observing timeout failure for this approach. Decoding frame doesn't proceed. I have to extend the timer duration in this approach too. diff --git a/LayoutTests/fast/images/reset-image-animation.html b/LayoutTests/fast/images/reset-image-animation.html index 62cb9bf09894..8c6fdc75ac14 100644 --- a/LayoutTests/fast/images/reset-image-animation.html +++ b/LayoutTests/fast/images/reset-image-animation.html @@ -13,6 +13,8 @@ let canvas = document.getElementById("canvas"); let context = canvas.getContext("2d"); context.drawImage(image, 0, 0, canvas.width, canvas.height); + if (internals.imageFrameIndex(image) != expectedFrame) + return drawFrame(expectedFrame).then(resolve); shouldBe("internals.imageFrameIndex(image)", expectedFrame.toString()); setTimeout(() => { resolve(expectedFrame + 1); 1951482 7 fujii 2023-04-26 18:13:44 -0700 Pull request: https://github.com/WebKit/WebKit/pull/13219 1951699 8 ews-feeder 2023-04-27 17:41:33 -0700 Committed 263478@main (b1cc64631025): <https://commits.webkit.org/263478@main> Reviewed commits have been landed. Closing PR #13219 and removing active labels. 1951700 9 webkit-bug-importer 2023-04-27 17:42:19 -0700 <rdar://problem/108636160>