170174 2017-03-28 03:37:21 -0700 ES2015 modules - Export default function hoisting 2017-06-02 18:35:05 -0700 1 1 1 Unclassified WebKit JavaScriptCore Safari Technology Preview Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 guybedford ysuzuki commit-queue fpizlo saam ysuzuki oldest_to_newest 1291869 0 guybedford 2017-03-28 03:37:21 -0700 The following circular reference case should work as export default can be used with function declarations that are hoisted, according to the rules of the HoistableDeclaration lookahead (https://tc39.github.io/ecma262/#prod-HoistableDeclaration). Instead, Safari gives the following error: SyntaxError: Importing binding name 'a' is not found. a.js: ``` import b from './b.js'; b(); export default function a () { console.log('a'); } ``` b.js: ``` import a from './a.js'; export default function b () { a(); } ``` Where a `<script type="module" src="a.js"></script>` is included in the page. This can be verified to work in the named exports hoisting case by converting the example to use `export function a ()`, `import {a}`, etc. 1291870 1 guybedford 2017-03-28 03:39:40 -0700 Updated link to the "export default HoistableDeclaration" rule - https://tc39.github.io/ecma262/#prod-ExportDeclaration. 1315007 2 ysuzuki 2017-06-02 03:03:40 -0700 Yeah, this bug is now fixed by fixing hoisting rules in JSC. I'll add this specific test into JSC's module tests :D 1315009 3 311812 ysuzuki 2017-06-02 03:09:44 -0700 Created attachment 311812 Patch 1315033 4 guybedford 2017-06-02 06:37:56 -0700 Great to heat that! The tests could be mixed together to form Mocha tests though :P 1315328 5 311812 ysuzuki 2017-06-02 18:16:49 -0700 Comment on attachment 311812 Patch Thanks ;) 1315331 6 ysuzuki 2017-06-02 18:18:57 -0700 (In reply to Guy Bedford from comment #4) > Great to heat that! The tests could be mixed together to form Mocha tests > though :P Mocha is also one of my favorite drink ;) 1315332 7 311812 commit-queue 2017-06-02 18:35:03 -0700 Comment on attachment 311812 Patch Clearing flags on attachment: 311812 Committed r217747: <http://trac.webkit.org/changeset/217747> 1315333 8 commit-queue 2017-06-02 18:35:05 -0700 All reviewed patches have been landed. Closing bug. 311812 2017-06-02 03:09:44 -0700 2017-06-02 18:35:03 -0700 Patch bug-170174-20170602190943.patch text/plain 2534 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3NzA2CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDhiZWRhZTE5OTY2YWRhNWZkNzM4ZjBjZTM3YTYx ZDU4OWI4YWY1MmYuLjgwMDgyYTVmODk1OTExZmE3Y2NlNTZiZDc5ZWY0ZDY4NTEyZGExMTYgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMjAgQEAKKzIwMTctMDYtMDIgIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRlYUBnbWFp bC5jb20+CisKKyAgICAgICAgRVMyMDE1IG1vZHVsZXMgLSBFeHBvcnQgZGVmYXVsdCBmdW5jdGlv biBob2lzdGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTcwMTc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGhpcyBpc3N1ZSBpdHNlbGYgaXMgc29sdmVkIGJ5IGZpeGluZyBmdW5jdGlvbiBkZWNsYXJh dGlvbiBob2lzdGluZyBydWxlcy4KKyAgICAgICAgVGhpcyBwYXRjaCBqdXN0IGFkZHMgdGhlIHNw ZWNpZmljIHRlc3QgdG8gbW9kdWxlcyB0ZXN0cyB0byBlbnN1cmUgdGhlIGJ1ZworICAgICAgICBp cyBmaXhlZC4KKworICAgICAgICAqIG1vZHVsZXMvZXhwb3J0LWRlZmF1bHQtZnVuY3Rpb24taG9p c3RpbmcuanM6IEFkZGVkLgorICAgICAgICAqIG1vZHVsZXMvZXhwb3J0LWRlZmF1bHQtZnVuY3Rp b24taG9pc3RpbmcvY2FwcHVjY2luby5qczogQWRkZWQuCisgICAgICAgIChpbXBvcnQuZHJpbmtD b2NvYS5mcm9tLnN0cmluZ19hcHBlYXJlZF9oZXJlLmV4cG9ydC5kZWZhdWx0LmRyaW5rQ2FwcHVj Y2lubyk6CisgICAgICAgICogbW9kdWxlcy9leHBvcnQtZGVmYXVsdC1mdW5jdGlvbi1ob2lzdGlu Zy9jb2NvYS5qczogQWRkZWQuCisgICAgICAgIChleHBvcnQuZGVmYXVsdC5kcmlua0NvY29hKToK KwogMjAxNy0wNi0wMSAgT2xla3NhbmRyIFNrYWNoa292ICA8Z3NrYWNoa292QGdtYWlsLmNvbT4K IAogICAgICAgICBDbGFzcyBQcm94eSBjYW4ndCBiZSBleHRlbmRlZApkaWZmIC0tZ2l0IGEvSlNU ZXN0cy9tb2R1bGVzL2V4cG9ydC1kZWZhdWx0LWZ1bmN0aW9uLWhvaXN0aW5nLmpzIGIvSlNUZXN0 cy9tb2R1bGVzL2V4cG9ydC1kZWZhdWx0LWZ1bmN0aW9uLWhvaXN0aW5nLmpzCm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu LmY3MWU3ZjM3Yjg5MTlmZmRhZWEzZTg1NDk4NDVlNjMzNzU0MDU0NTkKLS0tIC9kZXYvbnVsbAor KysgYi9KU1Rlc3RzL21vZHVsZXMvZXhwb3J0LWRlZmF1bHQtZnVuY3Rpb24taG9pc3RpbmcuanMK QEAgLTAsMCArMSw1IEBACitpbXBvcnQgeyBzaG91bGRCZSB9IGZyb20gIi4vcmVzb3VyY2VzL2Fz c2VydC5qcyI7CitpbXBvcnQgZHJpbmtDb2NvYSBmcm9tICcuL2V4cG9ydC1kZWZhdWx0LWZ1bmN0 aW9uLWhvaXN0aW5nL2NvY29hLmpzJworCitzaG91bGRCZShkcmlua0NvY29hKCksIDQyKTsKKwpk aWZmIC0tZ2l0IGEvSlNUZXN0cy9tb2R1bGVzL2V4cG9ydC1kZWZhdWx0LWZ1bmN0aW9uLWhvaXN0 aW5nL2NhcHB1Y2Npbm8uanMgYi9KU1Rlc3RzL21vZHVsZXMvZXhwb3J0LWRlZmF1bHQtZnVuY3Rp b24taG9pc3RpbmcvY2FwcHVjY2luby5qcwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4zYmY0YTM5NzRiNjZmOThhZjU0 ZTU3OTdhMzg4MzMyYTA1Njk5Y2ExCi0tLSAvZGV2L251bGwKKysrIGIvSlNUZXN0cy9tb2R1bGVz L2V4cG9ydC1kZWZhdWx0LWZ1bmN0aW9uLWhvaXN0aW5nL2NhcHB1Y2Npbm8uanMKQEAgLTAsMCAr MSw2IEBACitpbXBvcnQgZHJpbmtDb2NvYSBmcm9tICcuL2NvY29hLmpzJworCitleHBvcnQgZGVm YXVsdCBmdW5jdGlvbiBkcmlua0NhcHB1Y2Npbm8oKQoreworICAgIHJldHVybiBkcmlua0NvY29h KCk7Cit9CmRpZmYgLS1naXQgYS9KU1Rlc3RzL21vZHVsZXMvZXhwb3J0LWRlZmF1bHQtZnVuY3Rp b24taG9pc3RpbmcvY29jb2EuanMgYi9KU1Rlc3RzL21vZHVsZXMvZXhwb3J0LWRlZmF1bHQtZnVu Y3Rpb24taG9pc3RpbmcvY29jb2EuanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZDE5ZjlmYzEyNjMwMDRjMmUwNzQ5 YWU5ZmJjMzA2M2U3ZGJhOGZlMQotLS0gL2Rldi9udWxsCisrKyBiL0pTVGVzdHMvbW9kdWxlcy9l eHBvcnQtZGVmYXVsdC1mdW5jdGlvbi1ob2lzdGluZy9jb2NvYS5qcwpAQCAtMCwwICsxLDkgQEAK K2ltcG9ydCBkcmlua0NhcHB1Y2Npbm8gZnJvbSAnLi9jYXBwdWNjaW5vLmpzJworaW1wb3J0IHsg c2hvdWxkQmUgfSBmcm9tICIuLi9yZXNvdXJjZXMvYXNzZXJ0LmpzIjsKKworc2hvdWxkQmUoZHJp bmtDYXBwdWNjaW5vKCksIDQyKTsKKworZXhwb3J0IGRlZmF1bHQgZnVuY3Rpb24gZHJpbmtDb2Nv YSgpCit7CisgICAgcmV0dXJuIDQyOworfQo=