170173 2017-03-28 03:07:45 -0700 [OWR] Fix class structure for the OWR mock classes after last modifications 2017-04-03 05:24:27 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 alex alex clopez commit-queue eric.carlson youennf oldest_to_newest 1291865 0 alex 2017-03-28 03:07:45 -0700 In case of OWR MockRealtimeMediaSource.h inherits from RealtimeMediaSourceOwr, so we have to change some of the definitions. 1291866 1 305581 alex 2017-03-28 03:12:06 -0700 Created attachment 305581 Patch 1291899 2 305581 youennf 2017-03-28 07:56:47 -0700 Comment on attachment 305581 Patch To make things cleaner, the mock owr source could just implement RealtimeMediaSource and forwards calls to a member field inheriting from RealtimeMediaSourceOwr. Future refactoring? View in context: https://bugs.webkit.org/attachment.cgi?id=305581&action=review > Source/WebCore/platform/mock/MockRealtimeMediaSource.h:64 > +#if !USE(OPENWEBRTC) Or you could add a noop implementation here or in mock owr subclasses 1292768 3 alex 2017-03-30 05:06:22 -0700 Thanks for the review! (In reply to youenn fablet from comment #2) > Comment on attachment 305581 [details] > Patch > > To make things cleaner, the mock owr source could just implement > RealtimeMediaSource and forwards calls to a member field inheriting from > RealtimeMediaSourceOwr. Future refactoring? > Yeah, we want to review the whole mock class for webrtc at some point. > View in context: > https://bugs.webkit.org/attachment.cgi?id=305581&action=review > > > Source/WebCore/platform/mock/MockRealtimeMediaSource.h:64 > > +#if !USE(OPENWEBRTC) > > Or you could add a noop implementation here or in mock owr subclasses Actually the OWR is a super class of Mock, it is a noop already there, I would need to override in that case and don't do it for other platforms. 1293622 4 305581 commit-queue 2017-04-03 05:24:26 -0700 Comment on attachment 305581 Patch Clearing flags on attachment: 305581 Committed r214772: <http://trac.webkit.org/changeset/214772> 1293623 5 commit-queue 2017-04-03 05:24:27 -0700 All reviewed patches have been landed. Closing bug. 305581 2017-03-28 03:12:06 -0700 2017-04-03 05:24:26 -0700 Patch bug-170173-20170328121204.patch text/plain 1889 alex U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0NDY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2U4YjAwNTJhOTQ0MDA1 NDRjNGRhMTgyMTA0YmM3MDc3ZGM3ZDhiZi4uMDRjNThmNjViM2I0OTNhN2U1N2E1N2MyMThkYzA1 ZWY5ZmIyMmI4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTAzLTI4ICBBbGVq YW5kcm8gRy4gQ2FzdHJvICA8YWxleEBpZ2FsaWEuY29tPgorCisgICAgICAgIFtPV1JdIEZpeCBj bGFzcyBzdHJ1Y3R1cmUgZm9yIHRoZSBPV1IgbW9jayBjbGFzc2VzIGFmdGVyIGxhc3QgbW9kaWZp Y2F0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTcwMTczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SW4gY2FzZSBvZiBPV1IgTW9ja1JlYWx0aW1lTWVkaWFTb3VyY2UgaW5oZXJpdHMgZnJvbQorICAg ICAgICBSZWFsdGltZU1lZGlhU291cmNlT3dyLCBzbyB3ZSBoYXZlIHRvIGNoYW5nZSBzb21lIG9m IHRoZSBmdW5jdGlvbgorICAgICAgICBpbnRlcmZhY2VzLgorCisgICAgICAgICogcGxhdGZvcm0v bW9jay9Nb2NrUmVhbHRpbWVNZWRpYVNvdXJjZS5oOgorCiAyMDE3LTAzLTI4ICBBYXJvbiBDaHUg IDxhYXJvbl9jaHVAYXBwbGUuY29tPgogCiAgICAgICAgIEFYOiBNZWRpYSBjb250cm9scyBzaG91 bGQgYmUgYWJsZSB0byBiZSByZS1hY3RpdmF0ZWQgYWZ0ZXIgZmFkZWQgYXdheQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbW9jay9Nb2NrUmVhbHRpbWVNZWRpYVNvdXJjZS5o IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbW9jay9Nb2NrUmVhbHRpbWVNZWRpYVNvdXJjZS5o CmluZGV4IDI0ZmJmZjNmNDk3NDkwNjcwZTdiYjM3M2U4ZTk2NWFkZjcyNDUxMmEuLmNkYzMzMWQ5 ODIwYWUwYmUxNTE5ODg1OWYxNjlkNmRmNDQ5ZjQ3YTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL21vY2svTW9ja1JlYWx0aW1lTWVkaWFTb3VyY2UuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9tb2NrL01vY2tSZWFsdGltZU1lZGlhU291cmNlLmgKQEAgLTYxLDcg KzYxLDkgQEAgcHJvdGVjdGVkOgogCiAgICAgdmlydHVhbCB2b2lkIHVwZGF0ZVNldHRpbmdzKFJl YWx0aW1lTWVkaWFTb3VyY2VTZXR0aW5ncyYpID0gMDsKICAgICB2aXJ0dWFsIHZvaWQgaW5pdGlh bGl6ZUNhcGFiaWxpdGllcyhSZWFsdGltZU1lZGlhU291cmNlQ2FwYWJpbGl0aWVzJikgPSAwOwor I2lmICFVU0UoT1BFTldFQlJUQykKICAgICB2aXJ0dWFsIHZvaWQgaW5pdGlhbGl6ZVN1cHBvcnRl ZENvbnN0cmFpbnRzKFJlYWx0aW1lTWVkaWFTb3VyY2VTdXBwb3J0ZWRDb25zdHJhaW50cyYpID0g MDsKKyNlbmRpZgogCiAgICAgdm9pZCBzdGFydFByb2R1Y2luZ0RhdGEoKSBvdmVycmlkZTsKICAg ICB2b2lkIHN0b3BQcm9kdWNpbmdEYXRhKCkgb3ZlcnJpZGU7CkBAIC03Niw3ICs3OCwxMiBAQCBw cm90ZWN0ZWQ6CiAKIHByaXZhdGU6CiAgICAgdm9pZCBpbml0aWFsaXplQ2FwYWJpbGl0aWVzKCk7 CisjaWYgVVNFKE9QRU5XRUJSVEMpCisgICAgdm9pZCBpbml0aWFsaXplU2V0dGluZ3MoKSBmaW5h bDsKKyNlbHNlCiAgICAgdm9pZCBpbml0aWFsaXplU2V0dGluZ3MoKTsKKyNlbmRpZgorCiAgICAg Ym9vbCBpc1Byb2R1Y2luZ0RhdGEoKSBjb25zdCBvdmVycmlkZSB7IHJldHVybiBtX2lzUHJvZHVj aW5nRGF0YTsgfQogCiAgICAgUmVhbHRpbWVNZWRpYVNvdXJjZVNldHRpbmdzIG1fY3VycmVudFNl dHRpbmdzOwo=