170172 2017-03-28 02:25:31 -0700 [Win] Pass close_fds = True in Python popen call. 2017-03-30 14:10:59 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED PlatformOnly P2 Normal --- 1 pvollan pvollan achristensen bfulgham buildbot commit-queue glenn lforschler oldest_to_newest 1291860 0 pvollan 2017-03-28 02:25:31 -0700 This was previously not supported on Windows, but in Python 2.7.10 it is. 1291862 1 305580 pvollan 2017-03-28 02:29:03 -0700 Created attachment 305580 Patch 1292807 2 305580 bfulgham 2017-03-30 09:30:38 -0700 Comment on attachment 305580 Patch r=me. 1292816 3 305580 pvollan 2017-03-30 09:39:42 -0700 Comment on attachment 305580 Patch Thanks for reviewing :) 1292934 4 305580 commit-queue 2017-03-30 14:10:57 -0700 Comment on attachment 305580 Patch Clearing flags on attachment: 305580 Committed r214622: <http://trac.webkit.org/changeset/214622> 1292935 5 commit-queue 2017-03-30 14:10:59 -0700 All reviewed patches have been landed. Closing bug. 305580 2017-03-28 02:29:03 -0700 2017-03-30 14:10:57 -0700 Patch bug-170172-20170328112900.patch text/plain 2478 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNDQ2OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDE3LTAzLTI4ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBbV2luXSBQYXNzIGNsb3NlX2ZkcyA9IFRydWUgaW4gUHl0aG9uIHBvcGVu IGNhbGwuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NzAxNzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGlzIHdhcyBwcmV2aW91c2x5IG5vdCBzdXBwb3J0ZWQgb24gV2luZG93cywgYnV0IGluIFB5dGhv biAyLjcuMTAgaXQgaXMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9zeXN0 ZW0vZXhlY3V0aXZlLnB5OgorICAgICAgICAoRXhlY3V0aXZlLl9zaG91bGRfY2xvc2VfZmRzKToK KyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvc2VydmVyX3Byb2Nlc3MucHk6CisgICAg ICAgIChTZXJ2ZXJQcm9jZXNzLl9zdGFydCk6CisKIDIwMTctMDMtMjcgIEx1Y2FzIEZvcnNjaGxl ciAgPGxmb3JzY2hsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEFub3RoZXIgdGVzdCB2OC4KSW5k ZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL3N5c3RlbS9leGVjdXRpdmUucHkKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vc3lzdGVtL2V4ZWN1dGl2 ZS5weQkocmV2aXNpb24gMjEyMDAwKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24v c3lzdGVtL2V4ZWN1dGl2ZS5weQkod29ya2luZyBjb3B5KQpAQCAtOTEsOSArOTEsOCBAQCBjbGFz cyBFeGVjdXRpdmUob2JqZWN0KToKICAgICAgICAgIyBXZSBuZWVkIHRvIHBhc3MgY2xvc2VfZmRz PVRydWUgdG8gd29yayBhcm91bmQgUHl0aG9uIGJ1ZyAjMjMyMAogICAgICAgICAjIChvdGhlcndp c2Ugd2UgY2FuIGhhbmcgd2hlbiB3ZSBraWxsIER1bXBSZW5kZXJUcmVlIHdoZW4gd2UgYXJlIHJ1 bm5pbmcKICAgICAgICAgIyBtdWx0aXBsZSB0aHJlYWRzKS4gU2VlIGh0dHA6Ly9idWdzLnB5dGhv bi5vcmcvaXNzdWUyMzIwIC4KLSAgICAgICAgIyBOb3RlIHRoYXQgY2xvc2VfZmRzIGlzbid0IHN1 cHBvcnRlZCBvbiBXaW5kb3dzLCBidXQgdGhpcyBidWcgb25seQotICAgICAgICAjIHNob3dzIHVw IG9uIE1hYyBhbmQgTGludXguCi0gICAgICAgIHJldHVybiBub3QgKHN5cy5wbGF0Zm9ybSA9PSAn Y3lnd2luJyBvciBzeXMucGxhdGZvcm0uc3RhcnRzd2l0aCgnd2luJykpCisgICAgICAgICMgSW4g UHl0aG9uIDIuNy4xMCwgY2xvc2VfZmRzIGlzIGFsc28gc3VwcG9ydGVkIG9uIFdpbmRvd3MuCisg ICAgICAgIHJldHVybiBUcnVlCiAKICAgICBkZWYgX3J1bl9jb21tYW5kX3dpdGhfdGVlZF9vdXRw dXQoc2VsZiwgYXJncywgdGVlZF9vdXRwdXQsICoqa3dhcmdzKToKICAgICAgICAgY2hpbGRfcHJv Y2VzcyA9IHNlbGYucG9wZW4oYXJncywKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9y dC9zZXJ2ZXJfcHJvY2Vzcy5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5 L3BvcnQvc2VydmVyX3Byb2Nlc3MucHkJKHJldmlzaW9uIDIxMjAwMCkKKysrIFRvb2xzL1Njcmlw dHMvd2Via2l0cHkvcG9ydC9zZXJ2ZXJfcHJvY2Vzcy5weQkod29ya2luZyBjb3B5KQpAQCAtMTE0 LDcgKzExNCw4IEBAIGNsYXNzIFNlcnZlclByb2Nlc3Mob2JqZWN0KToKICAgICAgICAgICAgIHJh aXNlIFZhbHVlRXJyb3IoIiVzIGFscmVhZHkgcnVubmluZyIgJSBzZWxmLl9uYW1lKQogICAgICAg ICBzZWxmLl9yZXNldCgpCiAgICAgICAgICMgY2xvc2VfZmRzIGlzIGEgd29ya2Fyb3VuZCBmb3Ig aHR0cDovL2J1Z3MucHl0aG9uLm9yZy9pc3N1ZTIzMjAKLSAgICAgICAgY2xvc2VfZmRzID0gbm90 IHNlbGYuX2hvc3QucGxhdGZvcm0uaXNfd2luKCkKKyAgICAgICAgIyBJbiBQeXRob24gMi43LjEw LCBjbG9zZV9mZHMgaXMgYWxzbyBzdXBwb3J0ZWQgb24gV2luZG93cy4KKyAgICAgICAgY2xvc2Vf ZmRzID0gVHJ1ZQogICAgICAgICBzZWxmLl9wcm9jID0gc2VsZi5faG9zdC5leGVjdXRpdmUucG9w ZW4oc2VsZi5fY21kLCBzdGRpbj1zZWxmLl9ob3N0LmV4ZWN1dGl2ZS5QSVBFLAogICAgICAgICAg ICAgc3Rkb3V0PXNlbGYuX2hvc3QuZXhlY3V0aXZlLlBJUEUsCiAgICAgICAgICAgICBzdGRlcnI9 c2VsZi5faG9zdC5leGVjdXRpdmUuUElQRSwK