170167 2017-03-27 22:42:55 -0700 Dashboard test fails with error: latestIterationGetter is not a function 2017-03-28 02:33:27 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=170158 P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap commit-queue jmarcell lforschler oldest_to_newest 1291803 0 aakash_jain 2017-03-27 22:42:55 -0700 . 1291805 1 305564 aakash_jain 2017-03-27 22:48:02 -0700 Created attachment 305564 Proposed patch 1291810 2 305565 aakash_jain 2017-03-27 23:09:25 -0700 Created attachment 305565 Updated patch 1291863 3 305565 commit-queue 2017-03-28 02:33:24 -0700 Comment on attachment 305565 Updated patch Clearing flags on attachment: 305565 Committed r214470: <http://trac.webkit.org/changeset/214470> 1291864 4 commit-queue 2017-03-28 02:33:27 -0700 All reviewed patches have been landed. Closing bug. 305564 2017-03-27 22:48:02 -0700 2017-03-27 23:09:25 -0700 Proposed patch patch_dashboard_latestIterationGetter_v4 text/plain 2530 aakash_jain SW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1 YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL3Rlc3RzL3Jlc291cmNlcy90ZXN0cy5qcwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZp Zy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy90ZXN0cy9yZXNvdXJjZXMvdGVzdHMuanMJ KHJldmlzaW9uIDIxNDIzNykKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtp dC5vcmctY29uZmlnL3B1YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL3Rlc3RzL3Jlc291cmNl cy90ZXN0cy5qcwkod29ya2luZyBjb3B5KQpAQCAtMTY3LDEzICsxNjcsMjAgQEAgbW9kdWxlKCJC dWlsZEJvdFF1ZXVlVmlldyIsIHsKICAgICAgICAgfTsKICAgICAgICAgdGhpcy5xdWV1ZS5icmFu Y2hlcyA9IFt0aGlzLnRydW5rQnJhbmNoXTsKICAgICAgICAgdGhpcy52aWV3ID0gbmV3IE1vY2tC dWlsZGJvdFF1ZXVlVmlldyhbdGhpcy5xdWV1ZV0pOworICAgICAgICB0aGlzLnZpZXcuX2xhdGVz dFByb2R1Y3RpdmVJdGVyYXRpb24gPSBmdW5jdGlvbihxdWV1ZSkKKyAgICAgICAgeworICAgICAg ICAgICAgdmFyIGl0ZXJhdGlvbiA9IHsKKyAgICAgICAgICAgICAgICByZXZpc2lvbjogeyAib3Bl blNvdXJjZSI6ICIzMzAyMSIgfSwKKyAgICAgICAgICAgIH07CisgICAgICAgICAgICByZXR1cm4g aXRlcmF0aW9uOworICAgICAgICB9CiAgICAgfQogfSk7CiAKIHZhciBzZXR0aW5ncyA9IG5ldyBT ZXR0aW5nczsKIHRlc3QoIl9hcHBlbmRQZW5kaW5nUmV2aXNpb25Db3VudCIsIGZ1bmN0aW9uKCkK IHsKLSAgICB0aGlzLnZpZXcuX2FwcGVuZFBlbmRpbmdSZXZpc2lvbkNvdW50KHRoaXMucXVldWUp OworICAgIHRoaXMudmlldy5fYXBwZW5kUGVuZGluZ1JldmlzaW9uQ291bnQodGhpcy5xdWV1ZSwg dGhpcy52aWV3Ll9sYXRlc3RQcm9kdWN0aXZlSXRlcmF0aW9uKTsKICAgICB2YXIgcmV2aXNpb25z QmVoaW5kID0gdGhpcy52aWV3LmVsZW1lbnQuZ2V0RWxlbWVudHNCeUNsYXNzTmFtZSgibWVzc2Fn ZSIpWzBdLmlubmVySFRNTC5tYXRjaCgvLiooXGQrKSByZXZpc2lvbih8cykgYmVoaW5kLylbMV07 CiAgICAgc3RyaWN0RXF1YWwocmV2aXNpb25zQmVoaW5kLCAiMSIsICJhc3NlcnQgcmV2aXNpb25z IGJlaGluZCIpOwogfSk7CkBAIC0xODgsNyArMTk1LDcgQEAgdGVzdCgiX3ByZXNlbnRQb3BvdmVy Rm9yUGVuZGluZ0NvbW1pdHMiLAogewogICAgIHZhciBlbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRl RWxlbWVudCgiZGl2Iik7CiAgICAgdmFyIHBvcG92ZXIgPSBuZXcgRGFzaGJvYXJkLlBvcG92ZXIo KTsKLSAgICB0aGlzLnZpZXcuX3ByZXNlbnRQb3BvdmVyRm9yUGVuZGluZ0NvbW1pdHMoZWxlbWVu dCwgcG9wb3ZlciwgdGhpcy5xdWV1ZSk7CisgICAgdGhpcy52aWV3Ll9wcmVzZW50UG9wb3ZlckZv clBlbmRpbmdDb21taXRzKHRoaXMudmlldy5fbGF0ZXN0UHJvZHVjdGl2ZUl0ZXJhdGlvbiwgZWxl bWVudCwgcG9wb3ZlciwgdGhpcy5xdWV1ZSk7CiAgICAgdmFyIG5vZGVMaXN0ID0gcG9wb3Zlci5f ZWxlbWVudC5nZXRFbGVtZW50c0J5Q2xhc3NOYW1lKCJwZW5kaW5nLWNvbW1pdCIpOwogICAgIHN0 cmljdEVxdWFsKG5vZGVMaXN0Lmxlbmd0aCwgMSwgImhhcyAxIHBlbmRpbmcgY29tbWl0Iik7CiB9 KTsKQEAgLTIwNCwxNiArMjExLDkgQEAgdGVzdCgiX3ByZXNlbnRQb3BvdmVyRm9yUGVuZGluZ0Nv bW1pdHMgbgogICAgICAgICB9CiAgICAgfTsKICAgICB0aGlzLnF1ZXVlLmJyYW5jaGVzID0gW3Ro aXMuc29tZU90aGVyQnJhbmNoXTsKLSAgICB0aGlzLnZpZXcuX2xhdGVzdFByb2R1Y3RpdmVJdGVy YXRpb24gPSBmdW5jdGlvbihxdWV1ZSkKLSAgICB7Ci0gICAgICAgIHZhciBpdGVyYXRpb24gPSB7 Ci0gICAgICAgICAgICByZXZpc2lvbjogeyAib3BlblNvdXJjZSI6ICIzMzAyMSIgfSwKLSAgICAg ICAgfTsKLSAgICAgICAgcmV0dXJuIGl0ZXJhdGlvbjsKLSAgICB9OwogICAgIHZhciBlbGVtZW50 ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CiAgICAgdmFyIHBvcG92ZXIgPSBuZXcg RGFzaGJvYXJkLlBvcG92ZXIoKTsKLSAgICB0aGlzLnZpZXcuX3ByZXNlbnRQb3BvdmVyRm9yUGVu ZGluZ0NvbW1pdHMoZWxlbWVudCwgcG9wb3ZlciwgdGhpcy5xdWV1ZSk7CisgICAgdGhpcy52aWV3 Ll9wcmVzZW50UG9wb3ZlckZvclBlbmRpbmdDb21taXRzKHRoaXMudmlldy5fbGF0ZXN0UHJvZHVj dGl2ZUl0ZXJhdGlvbiwgZWxlbWVudCwgcG9wb3ZlciwgdGhpcy5xdWV1ZSk7CiAgICAgdmFyIG5v ZGVMaXN0ID0gcG9wb3Zlci5fZWxlbWVudC5nZXRFbGVtZW50c0J5Q2xhc3NOYW1lKCJwZW5kaW5n LWNvbW1pdCIpOwogICAgIHN0cmljdEVxdWFsKG5vZGVMaXN0Lmxlbmd0aCwgMCwgImhhcyAwIHBl bmRpbmcgY29tbWl0cyIpOwogfSk7Cg== 305565 2017-03-27 23:09:25 -0700 2017-03-28 02:33:24 -0700 Updated patch patch_dashboard_latestIterationGetter_v5 text/plain 3230 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNDQ2MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE3LTAzLTI3ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBEYXNoYm9hcmQgdGVzdCBmYWlscyB3aXRoIGVycm9yOiBsYXRlc3RJdGVy YXRpb25HZXR0ZXIgaXMgbm90IGEgZnVuY3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDE2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9y Zy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvdGVzdHMvcmVzb3VyY2VzL3Rl c3RzLmpzOgorICAgICAgICAodGhpcy52aWV3Ll9sYXRlc3RQcm9kdWN0aXZlSXRlcmF0aW9uKTog Q29uZmlndXJlIF9sYXRlc3RQcm9kdWN0aXZlSXRlcmF0aW9uIGluIHNldHVwLgorCiAyMDE3LTAz LTI3ICBMdWNhcyBGb3JzY2hsZXIgIDxsZm9yc2NobGVyQGFwcGxlLmNvbT4KIAogICAgICAgICBB bm90aGVyIHRlc3QgdjguCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJr aXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy90ZXN0cy9yZXNvdXJj ZXMvdGVzdHMuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQu d2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvdGVzdHMvcmVz b3VyY2VzL3Rlc3RzLmpzCShyZXZpc2lvbiAyMTQyMzcpCisrKyBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0 cy90ZXN0cy9yZXNvdXJjZXMvdGVzdHMuanMJKHdvcmtpbmcgY29weSkKQEAgLTE2NywxMyArMTY3 LDIwIEBAIG1vZHVsZSgiQnVpbGRCb3RRdWV1ZVZpZXciLCB7CiAgICAgICAgIH07CiAgICAgICAg IHRoaXMucXVldWUuYnJhbmNoZXMgPSBbdGhpcy50cnVua0JyYW5jaF07CiAgICAgICAgIHRoaXMu dmlldyA9IG5ldyBNb2NrQnVpbGRib3RRdWV1ZVZpZXcoW3RoaXMucXVldWVdKTsKKyAgICAgICAg dGhpcy52aWV3Ll9sYXRlc3RQcm9kdWN0aXZlSXRlcmF0aW9uID0gZnVuY3Rpb24ocXVldWUpCisg ICAgICAgIHsKKyAgICAgICAgICAgIHZhciBpdGVyYXRpb24gPSB7CisgICAgICAgICAgICAgICAg cmV2aXNpb246IHsgIm9wZW5Tb3VyY2UiOiAiMzMwMjEiIH0sCisgICAgICAgICAgICB9OworICAg ICAgICAgICAgcmV0dXJuIGl0ZXJhdGlvbjsKKyAgICAgICAgfQogICAgIH0KIH0pOwogCiB2YXIg c2V0dGluZ3MgPSBuZXcgU2V0dGluZ3M7CiB0ZXN0KCJfYXBwZW5kUGVuZGluZ1JldmlzaW9uQ291 bnQiLCBmdW5jdGlvbigpCiB7Ci0gICAgdGhpcy52aWV3Ll9hcHBlbmRQZW5kaW5nUmV2aXNpb25D b3VudCh0aGlzLnF1ZXVlKTsKKyAgICB0aGlzLnZpZXcuX2FwcGVuZFBlbmRpbmdSZXZpc2lvbkNv dW50KHRoaXMucXVldWUsIHRoaXMudmlldy5fbGF0ZXN0UHJvZHVjdGl2ZUl0ZXJhdGlvbik7CiAg ICAgdmFyIHJldmlzaW9uc0JlaGluZCA9IHRoaXMudmlldy5lbGVtZW50LmdldEVsZW1lbnRzQnlD bGFzc05hbWUoIm1lc3NhZ2UiKVswXS5pbm5lckhUTUwubWF0Y2goLy4qKFxkKykgcmV2aXNpb24o fHMpIGJlaGluZC8pWzFdOwogICAgIHN0cmljdEVxdWFsKHJldmlzaW9uc0JlaGluZCwgIjEiLCAi YXNzZXJ0IHJldmlzaW9ucyBiZWhpbmQiKTsKIH0pOwpAQCAtMTg4LDcgKzE5NSw3IEBAIHRlc3Qo Il9wcmVzZW50UG9wb3ZlckZvclBlbmRpbmdDb21taXRzIiwKIHsKICAgICB2YXIgZWxlbWVudCA9 IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwogICAgIHZhciBwb3BvdmVyID0gbmV3IERh c2hib2FyZC5Qb3BvdmVyKCk7Ci0gICAgdGhpcy52aWV3Ll9wcmVzZW50UG9wb3ZlckZvclBlbmRp bmdDb21taXRzKGVsZW1lbnQsIHBvcG92ZXIsIHRoaXMucXVldWUpOworICAgIHRoaXMudmlldy5f cHJlc2VudFBvcG92ZXJGb3JQZW5kaW5nQ29tbWl0cyh0aGlzLnZpZXcuX2xhdGVzdFByb2R1Y3Rp dmVJdGVyYXRpb24sIGVsZW1lbnQsIHBvcG92ZXIsIHRoaXMucXVldWUpOwogICAgIHZhciBub2Rl TGlzdCA9IHBvcG92ZXIuX2VsZW1lbnQuZ2V0RWxlbWVudHNCeUNsYXNzTmFtZSgicGVuZGluZy1j b21taXQiKTsKICAgICBzdHJpY3RFcXVhbChub2RlTGlzdC5sZW5ndGgsIDEsICJoYXMgMSBwZW5k aW5nIGNvbW1pdCIpOwogfSk7CkBAIC0yMDQsMTYgKzIxMSw5IEBAIHRlc3QoIl9wcmVzZW50UG9w b3ZlckZvclBlbmRpbmdDb21taXRzIG4KICAgICAgICAgfQogICAgIH07CiAgICAgdGhpcy5xdWV1 ZS5icmFuY2hlcyA9IFt0aGlzLnNvbWVPdGhlckJyYW5jaF07Ci0gICAgdGhpcy52aWV3Ll9sYXRl c3RQcm9kdWN0aXZlSXRlcmF0aW9uID0gZnVuY3Rpb24ocXVldWUpCi0gICAgewotICAgICAgICB2 YXIgaXRlcmF0aW9uID0gewotICAgICAgICAgICAgcmV2aXNpb246IHsgIm9wZW5Tb3VyY2UiOiAi MzMwMjEiIH0sCi0gICAgICAgIH07Ci0gICAgICAgIHJldHVybiBpdGVyYXRpb247Ci0gICAgfTsK ICAgICB2YXIgZWxlbWVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwogICAgIHZh ciBwb3BvdmVyID0gbmV3IERhc2hib2FyZC5Qb3BvdmVyKCk7Ci0gICAgdGhpcy52aWV3Ll9wcmVz ZW50UG9wb3ZlckZvclBlbmRpbmdDb21taXRzKGVsZW1lbnQsIHBvcG92ZXIsIHRoaXMucXVldWUp OworICAgIHRoaXMudmlldy5fcHJlc2VudFBvcG92ZXJGb3JQZW5kaW5nQ29tbWl0cyh0aGlzLnZp ZXcuX2xhdGVzdFByb2R1Y3RpdmVJdGVyYXRpb24sIGVsZW1lbnQsIHBvcG92ZXIsIHRoaXMucXVl dWUpOwogICAgIHZhciBub2RlTGlzdCA9IHBvcG92ZXIuX2VsZW1lbnQuZ2V0RWxlbWVudHNCeUNs YXNzTmFtZSgicGVuZGluZy1jb21taXQiKTsKICAgICBzdHJpY3RFcXVhbChub2RlTGlzdC5sZW5n dGgsIDAsICJoYXMgMCBwZW5kaW5nIGNvbW1pdHMiKTsKIH0pOwo=