170143 2017-03-27 15:05:01 -0700 Web Inspector: Probe values not showing in sidebar 2017-04-05 13:58:55 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 joepeck mattbaker commit-queue hi inspector-bugzilla-changes joepeck mattbaker oldest_to_newest 1291640 0 joepeck 2017-03-27 15:05:01 -0700 Summary: Probe values not showing in sidebar Steps to Reproduce: 1. Inspect http://bogojoker.com/shell/ 2. Resources > Select easySlider.min.js 3. Add a breakpoint on line 56 4. Right click > Edit Breakpoint 5. Add Action 6. Add a Probe Expression: "autoplay" 7. Automatically continue after evaluating 8. Dismiss popover => Should now have a Probes sidebar 9. Click the down arrow on the page => Should log a value in the Probe Datagrid, but nothing shows 1291662 1 hi 2017-03-27 16:11:42 -0700 I think this is being caused by the way WebInspector.ProbeSetDataGrid is being used by WebInspector.ProbeSetDetailsSection. Since WebInspector.DetailsSection is not yet a subclass of WebInspector.View, the check for `_isAttachedToRoot` fails as it's not a subview of the root, instead being added manually by calling `appendChild` on the actual element. 1294599 2 306304 mattbaker 2017-04-05 13:00:05 -0700 Created attachment 306304 Patch 1294620 3 306304 joepeck 2017-04-05 13:46:51 -0700 Comment on attachment 306304 Patch r=me 1294630 4 306304 commit-queue 2017-04-05 13:58:54 -0700 Comment on attachment 306304 Patch Clearing flags on attachment: 306304 Committed r214967: <http://trac.webkit.org/changeset/214967> 1294631 5 commit-queue 2017-04-05 13:58:55 -0700 All reviewed patches have been landed. Closing bug. 306304 2017-04-05 13:00:05 -0700 2017-04-05 13:58:54 -0700 Patch bug-170143-20170405130004.patch text/plain 2527 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0OTQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA1 ZmRmNmQwZjRhYTU2MmUxYzgyM2MzMTNlZmU3OWEzOGM5MTAwODQ3Li45ZjVhN2IxZDNjMjM5ODli M2E0ODRkZjFjMmEwN2MxMDRiNDNhMWM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxNy0wNC0wNSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUHJvYmUgdmFsdWVzIG5vdCBzaG93aW5nIGluIHNp ZGViYXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 MDE0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZv cmNlIHRoZSBEYXRhR3JpZCB0byByZWZyZXNoIGl0cyBsYXlvdXQgYWZ0ZXIgYWRkaW5nIGEgcHJv YmUgc2FtcGxlLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Qcm9iZVNldERhdGFH cmlkLmNzczoKKyAgICAgICAgKC5kZXRhaWxzLXNlY3Rpb24ucHJvYmUtc2V0IC5kYXRhLWdyaWQg dHIuZGF0YS11cGRhdGVkKToKKyAgICAgICAgKC5kZXRhaWxzLXNlY3Rpb24ucHJvYmUtc2V0IC5k YXRhLWdyaWQgPiB0ci5kYXRhLXVwZGF0ZWQpOiBEZWxldGVkLgorICAgICAgICBEcml2ZS1ieSBm aXg6IHNlbGVjdG9yIGRpZG4ndCBtYXRjaCBhbnkgcm93cy4KKworICAgICAgICAqIFVzZXJJbnRl cmZhY2UvVmlld3MvUHJvYmVTZXREYXRhR3JpZC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Q cm9iZVNldERhdGFHcmlkLnByb3RvdHlwZS5fdXBkYXRlTm9kZUZvckZyYW1lKToKKwogMjAxNy0w NC0wNCAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVj dG9yOiBSVEw6IGxheW91dCBpc3N1ZXMgaW4gVHlwZSBQcm9maWxlciBwb3BvdmVycwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUHJvYmVTZXRE YXRhR3JpZC5jc3MgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Q cm9iZVNldERhdGFHcmlkLmNzcwppbmRleCA0ODU2NDNkZmUxNmRjZTdkZTY0OWViNmU5MzMwNTY5 MTljMTg2YjY3Li4wZTVmZjJlM2EwNjIzNjZhYzdhZGY5YzU3MzM2YzkzN2FkNDIzNmYxIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Qcm9iZVNl dERhdGFHcmlkLmNzcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9W aWV3cy9Qcm9iZVNldERhdGFHcmlkLmNzcwpAQCAtNTksNyArNTksNyBAQAogICAgIGJvcmRlci1i b3R0b206IDJweCBzb2xpZCBoc2woMCwgMCUsIDQwJSk7CiB9CiAKLS5kZXRhaWxzLXNlY3Rpb24u cHJvYmUtc2V0IC5kYXRhLWdyaWQgPiB0ci5kYXRhLXVwZGF0ZWQgeworLmRldGFpbHMtc2VjdGlv bi5wcm9iZS1zZXQgLmRhdGEtZ3JpZCB0ci5kYXRhLXVwZGF0ZWQgewogICAgIGFuaW1hdGlvbi1k dXJhdGlvbjogMC4zczsKICAgICBhbmltYXRpb24tbmFtZTogYmxpbmstcHJvYmUtZnJhbWU7CiB9 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Q cm9iZVNldERhdGFHcmlkLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvUHJvYmVTZXREYXRhR3JpZC5qcwppbmRleCA0NmUxM2YxMDIxNTc0MjNkNzdhNjZmMzhh MzY4MDEwYmQwODA5ZTQ5Li42ZjIyNTJmYzRkMmVkMTc1NTc3ZWIzZTZiZWRjNThjYjAzNGRmNzkx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Q cm9iZVNldERhdGFHcmlkLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1Byb2JlU2V0RGF0YUdyaWQuanMKQEAgLTEzNSw2ICsxMzUsOSBAQCBXZWJJbnNw ZWN0b3IuUHJvYmVTZXREYXRhR3JpZCA9IGNsYXNzIFByb2JlU2V0RGF0YUdyaWQgZXh0ZW5kcyBX ZWJJbnNwZWN0b3IuRGF0YQogICAgICAgICB9CiAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KG5vZGUp OwogCisgICAgICAgIC8vIEZJWE1FOiA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTUyMjY5PiBXZWIg SW5zcGVjdG9yOiBDb252ZXJ0IERldGFpbHNTZWN0aW9uIGNsYXNzZXMgdG8gdXNlIFZpZXcKKyAg ICAgICAgdGhpcy51cGRhdGVMYXlvdXRJZk5lZWRlZCgpOworCiAgICAgICAgIG5vZGUuZWxlbWVu dC5jbGFzc0xpc3QuYWRkKCJkYXRhLXVwZGF0ZWQiKTsKICAgICAgICAgd2luZG93LnNldFRpbWVv dXQoZnVuY3Rpb24oKSB7CiAgICAgICAgICAgICBub2RlLmVsZW1lbnQuY2xhc3NMaXN0LnJlbW92 ZSgiZGF0YS11cGRhdGVkIik7Cg==