170140 2017-03-27 14:14:23 -0700 Move and update WebLoaderStrategy logging statement 2017-04-17 14:51:32 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 krollin krollin achristensen beidson commit-queue oldest_to_newest 1291612 0 krollin 2017-03-27 14:14:23 -0700 WebLoaderStrategy::scheduleLoad has a logging statement that says, in part: "Resource has been queued for scheduling with the NetworkProcess". This statement is emitted after the ScheduleResourceLoad message has been successfully sent to the NetworkProcess. The logging statement was added at this location to indicate that the resource-load had been successfully handed off; it pairs a similar logging statement that is emitted if the sending of the ScheduleResourceLoad message fails. I think it would be better to move this logging statement before the ScheduleResourceLoad message is sent to the NetworkProcess (and change its wording to "Resource is being scheduled with the NetworkProcess"). The reason for this change is to help make sure that the sequence of logging statements is more deterministic. In the current form, the message "Resource has been queued for scheduling with the NetworkProcess" normally appears before any NetworkProcess logging statements that indicate that the resource-loading is continuing there, but in rare occasions the logging statements can be reversed. This change in the ordering of the statements has caused a problem in a script I've written that examines the resource-loading process and looks for errors. By ensuring that the WebLoaderStrategy statement always appears before the NetworkResourceLoader statement, the flow makes better sense and the script can be more robust. In making this change, we are probably not giving up any assurance that the ScheduleResourceLoad message has been sent to the NetworkResourceLoader. If the message is successfully sent, we'll see logging in the NetworkProcess. If the message has not been sent, we'll see WebLoaderStrategy logging an error. 1291623 1 305509 krollin 2017-03-27 14:21:03 -0700 Created attachment 305509 Patch 1298036 2 305509 commit-queue 2017-04-17 14:51:31 -0700 Comment on attachment 305509 Patch Clearing flags on attachment: 305509 Committed r215433: <http://trac.webkit.org/changeset/215433> 1298037 3 commit-queue 2017-04-17 14:51:32 -0700 All reviewed patches have been landed. Closing bug. 305509 2017-03-27 14:21:03 -0700 2017-04-17 14:51:31 -0700 Patch bug-170140-20170327142102.patch text/plain 5229 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0NDIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDY3YzBhYmZiNDEyNWQx OTBkOWQwOGUyNWU4MzI3MzM4ZTQ3ZDRhOS4uODg2ZDA4YjMyOGE0NWFmYTBmMTI3M2QzMTliNTZl Y2E0OTBmODA4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQzIEBACisyMDE3LTAzLTI3ICBLZWl0 aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAgICAgICBNb3ZlIGFuZCB1cGRhdGUg V2ViTG9hZGVyU3RyYXRlZ3kgbG9nZ2luZyBzdGF0ZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDE0MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYkxvYWRlclN0cmF0ZWd5OjpzY2hlZHVsZUxv YWQgaGFzIGEgbG9nZ2luZyBzdGF0ZW1lbnQgdGhhdCBzYXlzLCBpbgorICAgICAgICBwYXJ0OiAi UmVzb3VyY2UgaGFzIGJlZW4gcXVldWVkIGZvciBzY2hlZHVsaW5nIHdpdGggdGhlCisgICAgICAg IE5ldHdvcmtQcm9jZXNzIi4gVGhpcyBzdGF0ZW1lbnQgaXMgZW1pdHRlZCBhZnRlciB0aGUKKyAg ICAgICAgU2NoZWR1bGVSZXNvdXJjZUxvYWQgbWVzc2FnZSBoYXMgYmVlbiBzdWNjZXNzZnVsbHkg c2VudCB0byB0aGUKKyAgICAgICAgTmV0d29ya1Byb2Nlc3MuIFRoZSBsb2dnaW5nIHN0YXRlbWVu dCB3YXMgYWRkZWQgYXQgdGhpcyBsb2NhdGlvbiB0bworICAgICAgICBpbmRpY2F0ZSB0aGF0IHRo ZSByZXNvdXJjZS1sb2FkIGhhZCBiZWVuIHN1Y2Nlc3NmdWxseSBoYW5kZWQgb2ZmOyBpdAorICAg ICAgICBwYWlycyBhIHNpbWlsYXIgbG9nZ2luZyBzdGF0ZW1lbnQgdGhhdCBpcyBlbWl0dGVkIGlm IHRoZSBzZW5kaW5nIG9mCisgICAgICAgIHRoZSBTY2hlZHVsZVJlc291cmNlTG9hZCBtZXNzYWdl IGZhaWxzLgorCisgICAgICAgIEkgdGhpbmsgaXQgd291bGQgYmUgYmV0dGVyIHRvIG1vdmUgdGhp cyBsb2dnaW5nIHN0YXRlbWVudCBiZWZvcmUgdGhlCisgICAgICAgIFNjaGVkdWxlUmVzb3VyY2VM b2FkIG1lc3NhZ2UgaXMgc2VudCB0byB0aGUgTmV0d29ya1Byb2Nlc3MgKGFuZCBjaGFuZ2UKKyAg ICAgICAgaXRzIHdvcmRpbmcgdG8gIlJlc291cmNlIGlzIGJlaW5nIHNjaGVkdWxlZCB3aXRoIHRo ZSBOZXR3b3JrUHJvY2VzcyIpLgorICAgICAgICBUaGUgcmVhc29uIGZvciB0aGlzIGNoYW5nZSBp cyB0byBoZWxwIG1ha2Ugc3VyZSB0aGF0IHRoZSBzZXF1ZW5jZSBvZgorICAgICAgICBsb2dnaW5n IHN0YXRlbWVudHMgaXMgbW9yZSBkZXRlcm1pbmlzdGljLiBJbiB0aGUgY3VycmVudCBmb3JtLCB0 aGUKKyAgICAgICAgbWVzc2FnZSAiUmVzb3VyY2UgaGFzIGJlZW4gcXVldWVkIGZvciBzY2hlZHVs aW5nIHdpdGggdGhlCisgICAgICAgIE5ldHdvcmtQcm9jZXNzIiBub3JtYWxseSBhcHBlYXJzIGJl Zm9yZSBhbnkgTmV0d29ya1Byb2Nlc3MgbG9nZ2luZworICAgICAgICBzdGF0ZW1lbnRzIHRoYXQg aW5kaWNhdGUgdGhhdCB0aGUgcmVzb3VyY2UtbG9hZGluZyBpcyBjb250aW51aW5nCisgICAgICAg IHRoZXJlLCBidXQgaW4gcmFyZSBvY2Nhc2lvbnMgdGhlIGxvZ2dpbmcgc3RhdGVtZW50cyBjYW4g YmUgcmV2ZXJzZWQuCisgICAgICAgIFRoaXMgY2hhbmdlIGluIHRoZSBvcmRlcmluZyBvZiB0aGUg c3RhdGVtZW50cyBoYXMgY2F1c2VkIGEgcHJvYmxlbSBpbgorICAgICAgICBhIHNjcmlwdCBJJ3Zl IHdyaXR0ZW4gdGhhdCBleGFtaW5lcyB0aGUgcmVzb3VyY2UtbG9hZGluZyBwcm9jZXNzIGFuZAor ICAgICAgICBsb29rcyBmb3IgZXJyb3JzLiBCeSBlbnN1cmluZyB0aGF0IHRoZSBXZWJMb2FkZXJT dHJhdGVneSBzdGF0ZW1lbnQKKyAgICAgICAgYWx3YXlzIGFwcGVhcnMgYmVmb3JlIHRoZSBOZXR3 b3JrUmVzb3VyY2VMb2FkZXIgc3RhdGVtZW50LCB0aGUgZmxvdworICAgICAgICBtYWtlcyBiZXR0 ZXIgc2Vuc2UgYW5kIHRoZSBzY3JpcHQgY2FuIGJlIG1vcmUgcm9idXN0LgorCisgICAgICAgIElu IG1ha2luZyB0aGlzIGNoYW5nZSwgd2UgYXJlIHByb2JhYmx5IG5vdCBnaXZpbmcgdXAgYW55IGFz c3VyYW5jZQorICAgICAgICB0aGF0IHRoZSBTY2hlZHVsZVJlc291cmNlTG9hZCBtZXNzYWdlIGhh cyBiZWVuIHNlbnQgdG8gdGhlCisgICAgICAgIE5ldHdvcmtSZXNvdXJjZUxvYWRlci4gSWYgdGhl IG1lc3NhZ2UgaXMgc3VjY2Vzc2Z1bGx5IHNlbnQsIHdlJ2xsIHNlZQorICAgICAgICBsb2dnaW5n IGluIHRoZSBOZXR3b3JrUHJvY2Vzcy4gSWYgdGhlIG1lc3NhZ2UgaGFzIG5vdCBiZWVuIHNlbnQs IHdlJ2xsCisgICAgICAgIHNlZSBXZWJMb2FkZXJTdHJhdGVneSBsb2dnaW5nIGFuIGVycm9yLgor CisgICAgICAgICogV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYkxvYWRlclN0cmF0ZWd5LmNwcDoKKyAg ICAgICAgKFdlYktpdDo6V2ViTG9hZGVyU3RyYXRlZ3k6OnNjaGVkdWxlTG9hZCk6CisKIDIwMTct MDMtMjcgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAg ICAgICBNYWtlIFdlYlNvY2tldHMgd29yayBpbiBuZXR3b3JrIHByb2Nlc3MKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvTmV0d29yay9XZWJMb2FkZXJTdHJhdGVneS5jcHAg Yi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05ldHdvcmsvV2ViTG9hZGVyU3RyYXRlZ3kuY3Bw CmluZGV4IDE4MjgyNzQzZjAzMmEzMmFlMmI1NWI4MTk0NDdkNDJmNmZhYjBmZmEuLjhmNDQ1YTU2 NTYxNzUyZDFlMWNhM2E3OTBhNTNlMWY4NDg2MDAwYjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvTmV0d29yay9XZWJMb2FkZXJTdHJhdGVneS5jcHAKKysrIGIvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYkxvYWRlclN0cmF0ZWd5LmNwcApAQCAtMjMw LDYgKzIzMCw3IEBAIHZvaWQgV2ViTG9hZGVyU3RyYXRlZ3k6OnNjaGVkdWxlTG9hZChSZXNvdXJj ZUxvYWRlciYgcmVzb3VyY2VMb2FkZXIsIENhY2hlZFJlc291CiAKICAgICBBU1NFUlQoKGxvYWRQ YXJhbWV0ZXJzLndlYlBhZ2VJRCAmJiBsb2FkUGFyYW1ldGVycy53ZWJGcmFtZUlEKSB8fCBsb2Fk UGFyYW1ldGVycy5jbGllbnRDcmVkZW50aWFsUG9saWN5ID09IENsaWVudENyZWRlbnRpYWxQb2xp Y3k6OkNhbm5vdEFza0NsaWVudEZvckNyZWRlbnRpYWxzKTsKIAorICAgIFJFTEVBU0VfTE9HX0lG X0FMTE9XRUQocmVzb3VyY2VMb2FkZXIsICJzY2hlZHVsZUxvYWQ6IFJlc291cmNlIGlzIGJlaW5n IHNjaGVkdWxlZCB3aXRoIHRoZSBOZXR3b3JrUHJvY2VzcyAoZnJhbWUgPSAlcCwgcHJpb3JpdHkg PSAlZCwgcGFnZUlEID0gJSIgUFJJdTY0ICIsIGZyYW1lSUQgPSAlIiBQUkl1NjQgIiwgcmVzb3Vy Y2VJRCA9ICUiIFBSSXU2NCAiKSIsIHJlc291cmNlTG9hZGVyLmZyYW1lKCksIHN0YXRpY19jYXN0 PGludD4ocmVzb3VyY2VMb2FkZXIucmVxdWVzdCgpLnByaW9yaXR5KCkpLCBsb2FkUGFyYW1ldGVy cy53ZWJQYWdlSUQsIGxvYWRQYXJhbWV0ZXJzLndlYkZyYW1lSUQsIGxvYWRQYXJhbWV0ZXJzLmlk ZW50aWZpZXIpOwogICAgIGlmICghV2ViUHJvY2Vzczo6c2luZ2xldG9uKCkubmV0d29ya0Nvbm5l Y3Rpb24oKS5jb25uZWN0aW9uKCkuc2VuZChNZXNzYWdlczo6TmV0d29ya0Nvbm5lY3Rpb25Ub1dl YlByb2Nlc3M6OlNjaGVkdWxlUmVzb3VyY2VMb2FkKGxvYWRQYXJhbWV0ZXJzKSwgMCkpIHsKICAg ICAgICAgUkVMRUFTRV9MT0dfRVJST1JfSUZfQUxMT1dFRChyZXNvdXJjZUxvYWRlciwgInNjaGVk dWxlTG9hZDogVW5hYmxlIHRvIHNjaGVkdWxlIHJlc291cmNlIHdpdGggdGhlIE5ldHdvcmtQcm9j ZXNzIChmcmFtZSA9ICVwLCBwcmlvcml0eSA9ICVkLCBwYWdlSUQgPSAlIiBQUkl1NjQgIiwgZnJh bWVJRCA9ICUiIFBSSXU2NCAiLCByZXNvdXJjZUlEID0gJSIgUFJJdTY0ICIpIiwgcmVzb3VyY2VM b2FkZXIuZnJhbWUoKSwgc3RhdGljX2Nhc3Q8aW50PihyZXNvdXJjZUxvYWRlci5yZXF1ZXN0KCku cHJpb3JpdHkoKSksIGxvYWRQYXJhbWV0ZXJzLndlYlBhZ2VJRCwgbG9hZFBhcmFtZXRlcnMud2Vi RnJhbWVJRCwgbG9hZFBhcmFtZXRlcnMuaWRlbnRpZmllcik7CiAgICAgICAgIC8vIFdlIHByb2Jh Ymx5IGZhaWxlZCB0byBzY2hlZHVsZSB0aGlzIGxvYWQgd2l0aCB0aGUgTmV0d29ya1Byb2Nlc3Mg YmVjYXVzZSBpdCBoYWQgY3Jhc2hlZC4KQEAgLTIzOCw5ICsyMzksNyBAQCB2b2lkIFdlYkxvYWRl clN0cmF0ZWd5OjpzY2hlZHVsZUxvYWQoUmVzb3VyY2VMb2FkZXImIHJlc291cmNlTG9hZGVyLCBD YWNoZWRSZXNvdQogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgYXV0byB3ZWJSZXNvdXJj ZUxvYWRlciA9IFdlYlJlc291cmNlTG9hZGVyOjpjcmVhdGUocmVzb3VyY2VMb2FkZXIsIHRyYWNr aW5nUGFyYW1ldGVycyk7Ci0gICAgUkVMRUFTRV9MT0dfSUZfQUxMT1dFRChyZXNvdXJjZUxvYWRl ciwgInNjaGVkdWxlTG9hZDogUmVzb3VyY2UgaGFzIGJlZW4gcXVldWVkIGZvciBzY2hlZHVsaW5n IHdpdGggdGhlIE5ldHdvcmtQcm9jZXNzIChmcmFtZSA9ICVwLCBwcmlvcml0eSA9ICVkLCBwYWdl SUQgPSAlIiBQUkl1NjQgIiwgZnJhbWVJRCA9ICUiIFBSSXU2NCAiLCByZXNvdXJjZUlEID0gJSIg UFJJdTY0ICIsIFdlYlJlc291cmNlTG9hZGVyID0gJXApIiwgcmVzb3VyY2VMb2FkZXIuZnJhbWUo KSwgc3RhdGljX2Nhc3Q8aW50PihyZXNvdXJjZUxvYWRlci5yZXF1ZXN0KCkucHJpb3JpdHkoKSks IGxvYWRQYXJhbWV0ZXJzLndlYlBhZ2VJRCwgbG9hZFBhcmFtZXRlcnMud2ViRnJhbWVJRCwgbG9h ZFBhcmFtZXRlcnMuaWRlbnRpZmllciwgd2ViUmVzb3VyY2VMb2FkZXIucHRyKCkpOwotICAgIG1f d2ViUmVzb3VyY2VMb2FkZXJzLnNldChpZGVudGlmaWVyLCBXVEZNb3ZlKHdlYlJlc291cmNlTG9h ZGVyKSk7CisgICAgbV93ZWJSZXNvdXJjZUxvYWRlcnMuc2V0KGlkZW50aWZpZXIsIFdlYlJlc291 cmNlTG9hZGVyOjpjcmVhdGUocmVzb3VyY2VMb2FkZXIsIHRyYWNraW5nUGFyYW1ldGVycykpOwog fQogCiB2b2lkIFdlYkxvYWRlclN0cmF0ZWd5OjpzY2hlZHVsZUludGVybmFsbHlGYWlsZWRMb2Fk KFdlYkNvcmU6OlJlc291cmNlTG9hZGVyJiByZXNvdXJjZUxvYWRlcikK