170126 2017-03-27 12:23:36 -0700 Update NetworkResourceLoader logging statement 2017-03-27 17:16:15 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 krollin krollin achristensen beidson commit-queue oldest_to_newest 1291560 0 krollin 2017-03-27 12:23:36 -0700 NetworkResourceLoader contains a logging statement that prints, in part: "start: Retrieving resource from cache". This is misleading, since it's not necessarily the case that the resource will be loaded from the cache. What is actually happening at the point where that is logged is that the cache is being checked for the resource. It still remains to be seen if the resource will be found in it. To address this, change the logging to say "start: Checking cache for resource". 1291600 1 305505 krollin 2017-03-27 13:49:10 -0700 Created attachment 305505 Patch 1291696 2 305505 commit-queue 2017-03-27 17:16:12 -0700 Comment on attachment 305505 Patch Clearing flags on attachment: 305505 Committed r214444: <http://trac.webkit.org/changeset/214444> 1291697 3 commit-queue 2017-03-27 17:16:15 -0700 All reviewed patches have been landed. Closing bug. 305505 2017-03-27 13:49:10 -0700 2017-03-27 17:16:12 -0700 Patch bug-170126-20170327134909.patch text/plain 2362 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0NDIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMDY3YzBhYmZiNDEyNWQx OTBkOWQwOGUyNWU4MzI3MzM4ZTQ3ZDRhOS4uMjI3MGM2Njg3ZGQwMjk5OWEzYTQwOWRjNTQ4ZmEy NmU1YTViNDBkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTAzLTI3ICBLZWl0 aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAgICAgICBVcGRhdGUgTmV0d29ya1Jl c291cmNlTG9hZGVyIGxvZ2dpbmcgc3RhdGVtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzAxMjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBOZXR3b3JrUmVzb3VyY2VMb2FkZXIgY29udGFpbnMgYSBs b2dnaW5nIHN0YXRlbWVudCB0aGF0IHByaW50cywgaW4KKyAgICAgICAgcGFydDogInN0YXJ0OiBS ZXRyaWV2aW5nIHJlc291cmNlIGZyb20gY2FjaGUiLiBUaGlzIGlzIG1pc2xlYWRpbmcsCisgICAg ICAgIHNpbmNlIGl0J3Mgbm90IG5lY2Vzc2FyaWx5IHRoZSBjYXNlIHRoYXQgdGhlIHJlc291cmNl IHdpbGwgYmUgbG9hZGVkCisgICAgICAgIGZyb20gdGhlIGNhY2hlLiBXaGF0IGlzIGFjdHVhbGx5 IGhhcHBlbmluZyBhdCB0aGUgcG9pbnQgd2hlcmUgdGhhdCBpcworICAgICAgICBsb2dnZWQgaXMg dGhhdCB0aGUgY2FjaGUgaXMgYmVpbmcgY2hlY2tlZCBmb3IgdGhlIHJlc291cmNlLiBJdCBzdGls bAorICAgICAgICByZW1haW5zIHRvIGJlIHNlZW4gaWYgdGhlIHJlc291cmNlIHdpbGwgYmUgZm91 bmQgaW4gaXQuIFRvIGFkZHJlc3MKKyAgICAgICAgdGhpcywgY2hhbmdlIHRoZSBsb2dnaW5nIHRv IHNheSAic3RhcnQ6IENoZWNraW5nIGNhY2hlIGZvciByZXNvdXJjZSIuCisKKyAgICAgICAgKiBO ZXR3b3JrUHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkZXIuY3BwOgorICAgICAgICAoV2ViS2l0 OjpOZXR3b3JrUmVzb3VyY2VMb2FkZXI6OnN0YXJ0KToKKwogMjAxNy0wMy0yNyAgQWxleCBDaHJp c3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIE1ha2UgV2ViU29j a2V0cyB3b3JrIGluIG5ldHdvcmsgcHJvY2VzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv TmV0d29ya1Byb2Nlc3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQy L05ldHdvcmtQcm9jZXNzL05ldHdvcmtSZXNvdXJjZUxvYWRlci5jcHAKaW5kZXggMTZlOWZkMDJm ODZlNDY0ODRhYWNkYWUxYWIyNmJkNGZhYTEzOTdiMy4uZjY2ODQ5YTY3N2Y4NGViNTViNTEyOGNk ZmU1Y2E0ZDU0ZmE4NjY3OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nl c3MvTmV0d29ya1Jlc291cmNlTG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3Jr UHJvY2Vzcy9OZXR3b3JrUmVzb3VyY2VMb2FkZXIuY3BwCkBAIC0xNjMsNyArMTYzLDcgQEAgdm9p ZCBOZXR3b3JrUmVzb3VyY2VMb2FkZXI6OnN0YXJ0KCkKIAogI2lmIEVOQUJMRShORVRXT1JLX0NB Q0hFKQogICAgIGlmIChjYW5Vc2VDYWNoZShvcmlnaW5hbFJlcXVlc3QoKSkpIHsKLSAgICAgICAg UkVMRUFTRV9MT0dfSUZfQUxMT1dFRCgic3RhcnQ6IFJldHJpZXZpbmcgcmVzb3VyY2UgZnJvbSBj YWNoZSAocGFnZUlEID0gJSIgUFJJdTY0ICIsIGZyYW1lSUQgPSAlIiBQUkl1NjQgIiwgcmVzb3Vy Y2VJRCA9ICUiIFBSSXU2NCAiLCBpc01haW5SZXNvdXJjZSA9ICVkLCBpc1N5bmNocm9ub3VzID0g JWQpIiwgbV9wYXJhbWV0ZXJzLndlYlBhZ2VJRCwgbV9wYXJhbWV0ZXJzLndlYkZyYW1lSUQsIG1f cGFyYW1ldGVycy5pZGVudGlmaWVyLCBpc01haW5SZXNvdXJjZSgpLCBpc1N5bmNocm9ub3VzKCkp OworICAgICAgICBSRUxFQVNFX0xPR19JRl9BTExPV0VEKCJzdGFydDogQ2hlY2tpbmcgY2FjaGUg Zm9yIHJlc291cmNlIChwYWdlSUQgPSAlIiBQUkl1NjQgIiwgZnJhbWVJRCA9ICUiIFBSSXU2NCAi LCByZXNvdXJjZUlEID0gJSIgUFJJdTY0ICIsIGlzTWFpblJlc291cmNlID0gJWQsIGlzU3luY2hy b25vdXMgPSAlZCkiLCBtX3BhcmFtZXRlcnMud2ViUGFnZUlELCBtX3BhcmFtZXRlcnMud2ViRnJh bWVJRCwgbV9wYXJhbWV0ZXJzLmlkZW50aWZpZXIsIGlzTWFpblJlc291cmNlKCksIGlzU3luY2hy b25vdXMoKSk7CiAgICAgICAgIHJldHJpZXZlQ2FjaGVFbnRyeShvcmlnaW5hbFJlcXVlc3QoKSk7 CiAgICAgICAgIHJldHVybjsKICAgICB9Cg==