170116 2017-03-27 04:24:58 -0700 Fixes for libwebrtc logging after r214288 2017-03-27 23:35:25 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 alex alex achristensen commit-queue ggaren youennf oldest_to_newest 1291447 0 alex 2017-03-27 04:24:58 -0700 The refactor of g_log_crit was not complete after that commit. 1291450 1 305462 alex 2017-03-27 05:25:09 -0700 Created attachment 305462 Patch 1291451 2 305463 alex 2017-03-27 05:33:01 -0700 Created attachment 305463 Patch 1291506 3 305463 youennf 2017-03-27 10:24:30 -0700 Comment on attachment 305463 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305463&action=review > Source/ThirdParty/libwebrtc/Source/webrtc/base/logging.cc:121 > + static webrtc::NeverDestroyed<LogMessage::StreamList> streams GUARDED_BY(g_log_crit()); Why do we need both changes in this method? 1291808 4 alex 2017-03-27 23:03:55 -0700 (In reply to youenn fablet from comment #3) > Comment on attachment 305463 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=305463&action=review > > > Source/ThirdParty/libwebrtc/Source/webrtc/base/logging.cc:121 > > + static webrtc::NeverDestroyed<LogMessage::StreamList> streams GUARDED_BY(g_log_crit()); > > Why do we need both changes in this method? First one to use the method g_log_crit() instead of the old variable g_log_crit when creating the static variable, and the second change to make sure everyone calling the method does it inside a critical section because it is returning the guarded variable, clang is complaining to us if we don't do it. 1291818 5 305463 commit-queue 2017-03-27 23:35:21 -0700 Comment on attachment 305463 Patch Clearing flags on attachment: 305463 Committed r214466: <http://trac.webkit.org/changeset/214466> 1291819 6 commit-queue 2017-03-27 23:35:25 -0700 All reviewed patches have been landed. Closing bug. 305462 2017-03-27 05:25:09 -0700 2017-03-27 05:32:55 -0700 Patch bug-170116-20170327142507.patch text/plain 2377 alex U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0NDExCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCBmOTRlYmI1MmNkZDdjZDJkM2NjNDE0ZWI1NWJhNWU4MGQ1ZTk5OTZhLi41NjBi OGE0ZGUxOGJiMDFiYjhlNWNiNWQ2NTY2OTJmZmQ2NGQxNTAyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxNy0wMy0yNyAgQWxlamFuZHJv IEcuIENhc3RybyAgPGFsZXhAaWdhbGlhLmNvbT4KKworICAgICAgICBGaXhlcyBmb3IgbGlid2Vi cnRjIGxvZ2dpbmcgYWZ0ZXIgcjIxNDI4OAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTcwMTE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBTb3VyY2Uvd2VicnRjL2Jhc2UvbG9nZ2luZy5jYzoKKworMjAx Ny0wMy0yNyAgQWxlamFuZHJvIEcuIENhc3RybyAgPGFsZXhAaWdhbGlhLmNvbT4KKworICAgICAg ICBGaXhlcyBmb3IgbGlid2VicnRjIGxvZ2dpbmcgYWZ0ZXIgcjIxNDI4OAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwMTE2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTb3VyY2Uvd2VicnRjL2Jhc2Uv bG9nZ2luZy5jYzogQWRkZWQgdGhlIGNyaXRpY2FsIHNlY3Rpb24KKyAgICAgICAgcmVxdWlyZW1l bnQgYW5kIHRoZSBjYWxsIHRvIHRoZSBuZXcgZ2V0dGVyIGZvciBnX2xvZ19jcml0LgorCiAyMDE3 LTAzLTIyICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgRml4IHdhcm5pbmdzIGluIGxpYndlYnJ0YwpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJk UGFydHkvbGlid2VicnRjL1NvdXJjZS93ZWJydGMvYmFzZS9sb2dnaW5nLmNjIGIvU291cmNlL1Ro aXJkUGFydHkvbGlid2VicnRjL1NvdXJjZS93ZWJydGMvYmFzZS9sb2dnaW5nLmNjCmluZGV4IGYy MDdkZjYyMzJmOWEyOWQyM2NlYmE3ODQ0NzA5NGYwZDYzNDhiNDIuLjFjMTk1YTIzZDliMjNmNWE1 ZjNiMjMwZmQ0NzM4NTg0MGY4YTQyNWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9Tb3VyY2Uvd2VicnRjL2Jhc2UvbG9nZ2luZy5jYworKysgYi9Tb3VyY2UvVGhpcmRQ YXJ0eS9saWJ3ZWJydGMvU291cmNlL3dlYnJ0Yy9iYXNlL2xvZ2dpbmcuY2MKQEAgLTExNiw5ICsx MTYsOSBAQCBjb25zdCBDcml0aWNhbFNlY3Rpb24mIGdfbG9nX2NyaXQoKQogLy8gTm90ZTogd2Ug ZXhwbGljaXRseSBkbyBub3QgY2xlYW4gdGhpcyB1cCwgYmVjYXVzZSBvZiB0aGUgdW5jZXJ0YWlu IG9yZGVyaW5nCiAvLyBvZiBkZXN0cnVjdG9ycyBhdCBwcm9ncmFtIGV4aXQuICBMZXQgdGhlIHBl cnNvbiB3aG8gc2V0cyB0aGUgc3RyZWFtIHRyaWdnZXIKIC8vIGNsZWFudXAgYnkgc2V0dGluZyB0 byBudWxsLCBvciBsZXQgaXQgbGVhayAoc2FmZSBhdCBwcm9ncmFtIGV4aXQpLgotTG9nTWVzc2Fn ZTo6U3RyZWFtTGlzdCYgTG9nTWVzc2FnZTo6c3RyZWFtcygpCitMb2dNZXNzYWdlOjpTdHJlYW1M aXN0JiBMb2dNZXNzYWdlOjpzdHJlYW1zKCkgRVhDTFVTSVZFX0xPQ0tTX1JFUVVJUkVEKGdfbG9n X2NyaXQoKSkKIHsKLSAgICBzdGF0aWMgd2VicnRjOjpOZXZlckRlc3Ryb3llZDxMb2dNZXNzYWdl OjpTdHJlYW1MaXN0PiBzdHJlYW1zIEdVQVJERURfQlkoZ19sb2dfY3JpdCk7CisgICAgc3RhdGlj IHdlYnJ0Yzo6TmV2ZXJEZXN0cm95ZWQ8TG9nTWVzc2FnZTo6U3RyZWFtTGlzdD4gc3RyZWFtcyBH VUFSREVEX0JZKGdfbG9nX2NyaXQoKSk7CiAgICAgcmV0dXJuIHN0cmVhbXM7CiB9CiAKQEAgLTM0 Miw3ICszNDIsNyBAQCB2b2lkIExvZ01lc3NhZ2U6OkNvbmZpZ3VyZUxvZ2dpbmcoY29uc3QgY2hh ciogcGFyYW1zKSB7CiAgIExvZ1RvRGVidWcoZGVidWdfbGV2ZWwpOwogfQogCi12b2lkIExvZ01l c3NhZ2U6OlVwZGF0ZU1pbkxvZ1NldmVyaXR5KCkgRVhDTFVTSVZFX0xPQ0tTX1JFUVVJUkVEKGdf bG9nX2NyaXQpIHsKK3ZvaWQgTG9nTWVzc2FnZTo6VXBkYXRlTWluTG9nU2V2ZXJpdHkoKSBFWENM VVNJVkVfTE9DS1NfUkVRVUlSRUQoZ19sb2dfY3JpdCgpKSB7CiAgIExvZ2dpbmdTZXZlcml0eSBt aW5fc2V2ID0gZGJnX3Nldl87CiAgIGZvciAoYXV0byYga3YgOiBzdHJlYW1zKCkpIHsKICAgICBt aW5fc2V2ID0gc3RkOjptaW4oZGJnX3Nldl8sIGt2LnNlY29uZCk7Cg== 305463 2017-03-27 05:33:01 -0700 2017-03-27 23:35:21 -0700 Patch bug-170116-20170327143259.patch text/plain 2131 alex U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0NDExCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCBmOTRlYmI1MmNkZDdjZDJkM2NjNDE0ZWI1NWJhNWU4MGQ1ZTk5OTZhLi5hNzA1 ZTMyODdkODFmODY1MjgwNTY1YzBiZWVmNjkwOGFmNmRlNTI1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxNy0wMy0yNyAgQWxlamFuZHJv IEcuIENhc3RybyAgPGFsZXhAaWdhbGlhLmNvbT4KKworICAgICAgICBGaXhlcyBmb3IgbGlid2Vi cnRjIGxvZ2dpbmcgYWZ0ZXIgcjIxNDI4OAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTcwMTE2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBTb3VyY2Uvd2VicnRjL2Jhc2UvbG9nZ2luZy5jYzogQWRkZWQg dGhlIGNyaXRpY2FsIHNlY3Rpb24KKyAgICAgICAgcmVxdWlyZW1lbnQgYW5kIHRoZSBjYWxsIHRv IHRoZSBuZXcgZ2V0dGVyIGZvciBnX2xvZ19jcml0LgorCiAyMDE3LTAzLTIyICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgRml4IHdhcm5pbmdz IGluIGxpYndlYnJ0YwpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL1Nv dXJjZS93ZWJydGMvYmFzZS9sb2dnaW5nLmNjIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRj L1NvdXJjZS93ZWJydGMvYmFzZS9sb2dnaW5nLmNjCmluZGV4IGYyMDdkZjYyMzJmOWEyOWQyM2Nl YmE3ODQ0NzA5NGYwZDYzNDhiNDIuLjFjMTk1YTIzZDliMjNmNWE1ZjNiMjMwZmQ0NzM4NTg0MGY4 YTQyNWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Tb3VyY2Uvd2Vi cnRjL2Jhc2UvbG9nZ2luZy5jYworKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvU291 cmNlL3dlYnJ0Yy9iYXNlL2xvZ2dpbmcuY2MKQEAgLTExNiw5ICsxMTYsOSBAQCBjb25zdCBDcml0 aWNhbFNlY3Rpb24mIGdfbG9nX2NyaXQoKQogLy8gTm90ZTogd2UgZXhwbGljaXRseSBkbyBub3Qg Y2xlYW4gdGhpcyB1cCwgYmVjYXVzZSBvZiB0aGUgdW5jZXJ0YWluIG9yZGVyaW5nCiAvLyBvZiBk ZXN0cnVjdG9ycyBhdCBwcm9ncmFtIGV4aXQuICBMZXQgdGhlIHBlcnNvbiB3aG8gc2V0cyB0aGUg c3RyZWFtIHRyaWdnZXIKIC8vIGNsZWFudXAgYnkgc2V0dGluZyB0byBudWxsLCBvciBsZXQgaXQg bGVhayAoc2FmZSBhdCBwcm9ncmFtIGV4aXQpLgotTG9nTWVzc2FnZTo6U3RyZWFtTGlzdCYgTG9n TWVzc2FnZTo6c3RyZWFtcygpCitMb2dNZXNzYWdlOjpTdHJlYW1MaXN0JiBMb2dNZXNzYWdlOjpz dHJlYW1zKCkgRVhDTFVTSVZFX0xPQ0tTX1JFUVVJUkVEKGdfbG9nX2NyaXQoKSkKIHsKLSAgICBz dGF0aWMgd2VicnRjOjpOZXZlckRlc3Ryb3llZDxMb2dNZXNzYWdlOjpTdHJlYW1MaXN0PiBzdHJl YW1zIEdVQVJERURfQlkoZ19sb2dfY3JpdCk7CisgICAgc3RhdGljIHdlYnJ0Yzo6TmV2ZXJEZXN0 cm95ZWQ8TG9nTWVzc2FnZTo6U3RyZWFtTGlzdD4gc3RyZWFtcyBHVUFSREVEX0JZKGdfbG9nX2Ny aXQoKSk7CiAgICAgcmV0dXJuIHN0cmVhbXM7CiB9CiAKQEAgLTM0Miw3ICszNDIsNyBAQCB2b2lk IExvZ01lc3NhZ2U6OkNvbmZpZ3VyZUxvZ2dpbmcoY29uc3QgY2hhciogcGFyYW1zKSB7CiAgIExv Z1RvRGVidWcoZGVidWdfbGV2ZWwpOwogfQogCi12b2lkIExvZ01lc3NhZ2U6OlVwZGF0ZU1pbkxv Z1NldmVyaXR5KCkgRVhDTFVTSVZFX0xPQ0tTX1JFUVVJUkVEKGdfbG9nX2NyaXQpIHsKK3ZvaWQg TG9nTWVzc2FnZTo6VXBkYXRlTWluTG9nU2V2ZXJpdHkoKSBFWENMVVNJVkVfTE9DS1NfUkVRVUlS RUQoZ19sb2dfY3JpdCgpKSB7CiAgIExvZ2dpbmdTZXZlcml0eSBtaW5fc2V2ID0gZGJnX3Nldl87 CiAgIGZvciAoYXV0byYga3YgOiBzdHJlYW1zKCkpIHsKICAgICBtaW5fc2V2ID0gc3RkOjptaW4o ZGJnX3Nldl8sIGt2LnNlY29uZCk7Cg==