170091 2017-03-24 17:44:45 -0700 [iOS WK2] Move from a pre-commit handler to dispatch_async for visible content rect updates 2017-03-24 18:06:02 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser simon.fraser oldest_to_newest 1291097 0 simon.fraser 2017-03-24 17:44:45 -0700 [iOS WK2] Move from a pre-commit handler to dispatch_async for visible content rect updates 1291098 1 305343 simon.fraser 2017-03-24 17:46:43 -0700 Created attachment 305343 Patch 1291106 2 305348 simon.fraser 2017-03-24 18:00:11 -0700 Created attachment 305348 Patch 1291107 3 305348 thorton 2017-03-24 18:02:25 -0700 Comment on attachment 305348 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305348&action=review > Source/WebKit2/ChangeLog:12 > + So dispatch_async() to postpone the call to [CATransaction addCommitHandler:forPhase: to a known- missing closing suqare bracket :P 1291108 4 simon.fraser 2017-03-24 18:06:02 -0700 https://trac.webkit.org/r214391 305343 2017-03-24 17:46:43 -0700 2017-03-24 18:00:08 -0700 Patch bug-170091-20170324174643.patch text/plain 2798 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0MjQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTA5YjVmYWFmMDQ2N2Iw NTEwZmJiYmEyNzU1MThjNDgwY2IxNTM1Yi4uZTljZWZmMjZmODE2ZWNhMjEyMzhjMTkyZjBjYzc0 ZjdhODIyZmUxYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE3LTAzLTI0ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1MgV0syXSBN b3ZlIGZyb20gYSBwcmUtY29tbWl0IGhhbmRsZXIgdG8gZGlzcGF0Y2hfYXN5bmMgZm9yIHZpc2li bGUgY29udGVudCByZWN0IHVwZGF0ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE3MDA5MQorICAgICAgICByZGFyOi8vcHJvYmxlbS8zMDY4MjU4NAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAg W0NBVHJhbnNhY3Rpb24gYWRkQ29tbWl0SGFuZGxlcjpmb3JQaGFzZTpdIGlzIHNvbWV0aW1lcyBu b3QgY2FsbGVkIHdoZW4gcnVubmluZyBpbnNpZGUgYW5vdGhlcgorICAgICAgICBjb21taXQgY2Fs bGJhY2sgKHJkYXI6Ly9wcm9ibGVtLzMxMjUzOTUyKSwgYW5kIHdlIGRvbid0IHlldCBoYXZlIGEg cmVsaWFibGUgd2F5IHRvIGRldGVjdCB0aGlzLgorCisgICAgICAgIFNvIGluc3RlYWQgdXNlIGRp c3BhdGNoX2FzeW5jKCkgdG8gY29hbGVzZSB0aGUgY2FsbHMgdG8gX3VwZGF0ZVZpc2libGVDb250 ZW50UmVjdHMsIHJlbmFtaW5nIHRoZQorICAgICAgICBzdGF0ZSB2YXJpYWJsZSBhY2NvcmRpbmds eS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tOgorICAgICAg ICAoLVtXS1dlYlZpZXcgX3NjaGVkdWxlVmlzaWJsZUNvbnRlbnRSZWN0VXBkYXRlQWZ0ZXJTY3Jv bGxJblZpZXc6XSk6CisKIDIwMTctMDMtMTkgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBh cHBsZS5jb20+CiAKICAgICAgICAgVGVhY2ggVGV4dEluZGljYXRvciB0byBlc3RpbWF0ZSB0aGUg YmFja2dyb3VuZCBjb2xvciBvZiB0aGUgZ2l2ZW4gUmFuZ2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tXZWJWaWV3Lm1tIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW0KaW5kZXggOTA3M2ZjNzcxYmQzNWFlYjkz ODAwZjhmNmIyN2M1ODM3YmFjZWNmOS4uYTAxMGFiZmUxMGZhZGI2NjcxNWI4MTc0MjlhNGFkNmEy ZGFjNTJkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9X S1dlYlZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dl YlZpZXcubW0KQEAgLTI4OCw3ICsyODgsNyBAQCBAaW1wbGVtZW50YXRpb24gV0tXZWJWaWV3IHsK IAogICAgIFJldGFpblB0cjxXS1Bhc3N3b3JkVmlldz4gX3Bhc3N3b3JkVmlldzsKIAotICAgIEJP T0wgX2hhc0luc3RhbGxlZFByZUNvbW1pdEhhbmRsZXJGb3JWaXNpYmxlUmVjdFVwZGF0ZTsKKyAg ICBCT09MIF9oYXNTY2hlZHVsZWRWaXNpYmxlUmVjdFVwZGF0ZTsKICAgICBCT09MIF92aXNpYmxl Q29udGVudFJlY3RVcGRhdGVTY2hlZHVsZWRGcm9tU2Nyb2xsVmlld0luU3RhYmxlU3RhdGU7CiAg ICAgVmVjdG9yPEJsb2NrUHRyPHZvaWQgKCk+PiBfdmlzaWJsZUNvbnRlbnRSZWN0VXBkYXRlQ2Fs bGJhY2tzOwogI2VuZGlmCkBAIC0yMzAxLDE2ICsyMzAxLDE2IEBAIC0gKHZvaWQpX3NjaGVkdWxl VmlzaWJsZUNvbnRlbnRSZWN0VXBkYXRlQWZ0ZXJTY3JvbGxJblZpZXc6KFVJU2Nyb2xsVmlldyAq KXNjcm9sCiB7CiAgICAgX3Zpc2libGVDb250ZW50UmVjdFVwZGF0ZVNjaGVkdWxlZEZyb21TY3Jv bGxWaWV3SW5TdGFibGVTdGF0ZSA9IFtzZWxmIF9zY3JvbGxWaWV3SXNJblN0YWJsZVN0YXRlOnNj cm9sbFZpZXddOwogCi0gICAgaWYgKF9oYXNJbnN0YWxsZWRQcmVDb21taXRIYW5kbGVyRm9yVmlz aWJsZVJlY3RVcGRhdGUpCisgICAgaWYgKF9oYXNTY2hlZHVsZWRWaXNpYmxlUmVjdFVwZGF0ZSkK ICAgICAgICAgcmV0dXJuOwogCi0gICAgX2hhc0luc3RhbGxlZFByZUNvbW1pdEhhbmRsZXJGb3JW aXNpYmxlUmVjdFVwZGF0ZSA9IFlFUzsKLQotICAgIFtDQVRyYW5zYWN0aW9uIGFkZENvbW1pdEhh bmRsZXI6W3JldGFpbmVkU2VsZiA9IHJldGFpblB0cihzZWxmKV0geworICAgIF9oYXNTY2hlZHVs ZWRWaXNpYmxlUmVjdFVwZGF0ZSA9IFlFUzsKKyAgICAKKyAgICBkaXNwYXRjaF9hc3luYyhkaXNw YXRjaF9nZXRfbWFpbl9xdWV1ZSgpLCBbcmV0YWluZWRTZWxmID0gcmV0YWluUHRyKHNlbGYpXSB7 CiAgICAgICAgIFdLV2ViVmlldyAqd2ViVmlldyA9IHJldGFpbmVkU2VsZi5nZXQoKTsKICAgICAg ICAgW3dlYlZpZXcgX3VwZGF0ZVZpc2libGVDb250ZW50UmVjdHNdOwotICAgICAgICB3ZWJWaWV3 LT5faGFzSW5zdGFsbGVkUHJlQ29tbWl0SGFuZGxlckZvclZpc2libGVSZWN0VXBkYXRlID0gTk87 Ci0gICAgfSBmb3JQaGFzZTprQ0FUcmFuc2FjdGlvblBoYXNlUHJlQ29tbWl0XTsKKyAgICAgICAg d2ViVmlldy0+X2hhc1NjaGVkdWxlZFZpc2libGVSZWN0VXBkYXRlID0gTk87CisgICAgfSk7CiB9 CiAKIHN0YXRpYyBib29sIHNjcm9sbFZpZXdDYW5TY3JvbGwoVUlTY3JvbGxWaWV3ICpzY3JvbGxW aWV3KQo= 305348 2017-03-24 18:00:11 -0700 2017-03-24 18:02:10 -0700 Patch bug-170091-20170324180010.patch text/plain 3091 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0MjQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNTA5YjVmYWFmMDQ2N2Iw NTEwZmJiYmEyNzU1MThjNDgwY2IxNTM1Yi4uODYzN2JjYjI5ZDMzYzhlY2E5M2FiYjNkZWRjM2Vi ODJhN2JlZmI2ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE3LTAzLTI0ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFtpT1MgV0syXSBN b3ZlIGZyb20gYSBwcmUtY29tbWl0IGhhbmRsZXIgdG8gZGlzcGF0Y2hfYXN5bmMgZm9yIHZpc2li bGUgY29udGVudCByZWN0IHVwZGF0ZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE3MDA5MQorICAgICAgICByZGFyOi8vcHJvYmxlbS8zMDY4MjU4NAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAg W0NBVHJhbnNhY3Rpb24gYWRkQ29tbWl0SGFuZGxlcjpmb3JQaGFzZTpdIGlzIHNvbWV0aW1lcyBu b3QgY2FsbGVkIHdoZW4gcnVubmluZyBpbnNpZGUgYW5vdGhlcgorICAgICAgICBjb21taXQgY2Fs bGJhY2sgKHJkYXI6Ly9wcm9ibGVtLzMxMjUzOTUyKSwgYW5kIHdlIGRvbid0IHlldCBoYXZlIGEg cmVsaWFibGUgd2F5IHRvIGRldGVjdCB0aGlzLgorCisgICAgICAgIFNvIGRpc3BhdGNoX2FzeW5j KCkgdG8gcG9zdHBvbmUgdGhlIGNhbGwgdG8gW0NBVHJhbnNhY3Rpb24gYWRkQ29tbWl0SGFuZGxl cjpmb3JQaGFzZTogdG8gYSBrbm93bi0KKyAgICAgICAgZ29vZCB0aW1lLgorCisgICAgICAgICog VUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXcubW06CisgICAgICAgICgtW1dLV2ViVmlldyBf c2NoZWR1bGVWaXNpYmxlQ29udGVudFJlY3RVcGRhdGVBZnRlclNjcm9sbEluVmlldzpdKToKKwog MjAxNy0wMy0xOSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAg ICAgICBUZWFjaCBUZXh0SW5kaWNhdG9yIHRvIGVzdGltYXRlIHRoZSBiYWNrZ3JvdW5kIGNvbG9y IG9mIHRoZSBnaXZlbiBSYW5nZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9Db2NvYS9XS1dlYlZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0Nv Y29hL1dLV2ViVmlldy5tbQppbmRleCA5MDczZmM3NzFiZDM1YWViOTM4MDBmOGY2YjI3YzU4Mzdi YWNlY2Y5Li4zNGU4ZTE1NTU3YWQyYjViN2UwNDA0N2FmYWU2NTlhMjU4NTNlMWM0IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlldy5tbQpAQCAtMjg4 LDcgKzI4OCw3IEBAIEBpbXBsZW1lbnRhdGlvbiBXS1dlYlZpZXcgewogCiAgICAgUmV0YWluUHRy PFdLUGFzc3dvcmRWaWV3PiBfcGFzc3dvcmRWaWV3OwogCi0gICAgQk9PTCBfaGFzSW5zdGFsbGVk UHJlQ29tbWl0SGFuZGxlckZvclZpc2libGVSZWN0VXBkYXRlOworICAgIEJPT0wgX2hhc1NjaGVk dWxlZFZpc2libGVSZWN0VXBkYXRlOwogICAgIEJPT0wgX3Zpc2libGVDb250ZW50UmVjdFVwZGF0 ZVNjaGVkdWxlZEZyb21TY3JvbGxWaWV3SW5TdGFibGVTdGF0ZTsKICAgICBWZWN0b3I8QmxvY2tQ dHI8dm9pZCAoKT4+IF92aXNpYmxlQ29udGVudFJlY3RVcGRhdGVDYWxsYmFja3M7CiAjZW5kaWYK QEAgLTIzMDEsMTYgKzIzMDEsMTkgQEAgLSAodm9pZClfc2NoZWR1bGVWaXNpYmxlQ29udGVudFJl Y3RVcGRhdGVBZnRlclNjcm9sbEluVmlldzooVUlTY3JvbGxWaWV3ICopc2Nyb2wKIHsKICAgICBf dmlzaWJsZUNvbnRlbnRSZWN0VXBkYXRlU2NoZWR1bGVkRnJvbVNjcm9sbFZpZXdJblN0YWJsZVN0 YXRlID0gW3NlbGYgX3Njcm9sbFZpZXdJc0luU3RhYmxlU3RhdGU6c2Nyb2xsVmlld107CiAKLSAg ICBpZiAoX2hhc0luc3RhbGxlZFByZUNvbW1pdEhhbmRsZXJGb3JWaXNpYmxlUmVjdFVwZGF0ZSkK KyAgICBpZiAoX2hhc1NjaGVkdWxlZFZpc2libGVSZWN0VXBkYXRlKQogICAgICAgICByZXR1cm47 CiAKLSAgICBfaGFzSW5zdGFsbGVkUHJlQ29tbWl0SGFuZGxlckZvclZpc2libGVSZWN0VXBkYXRl ID0gWUVTOwotCi0gICAgW0NBVHJhbnNhY3Rpb24gYWRkQ29tbWl0SGFuZGxlcjpbcmV0YWluZWRT ZWxmID0gcmV0YWluUHRyKHNlbGYpXSB7Ci0gICAgICAgIFdLV2ViVmlldyAqd2ViVmlldyA9IHJl dGFpbmVkU2VsZi5nZXQoKTsKLSAgICAgICAgW3dlYlZpZXcgX3VwZGF0ZVZpc2libGVDb250ZW50 UmVjdHNdOwotICAgICAgICB3ZWJWaWV3LT5faGFzSW5zdGFsbGVkUHJlQ29tbWl0SGFuZGxlckZv clZpc2libGVSZWN0VXBkYXRlID0gTk87Ci0gICAgfSBmb3JQaGFzZTprQ0FUcmFuc2FjdGlvblBo YXNlUHJlQ29tbWl0XTsKKyAgICBfaGFzU2NoZWR1bGVkVmlzaWJsZVJlY3RVcGRhdGUgPSBZRVM7 CisgICAgCisgICAgLy8gRklYTUU6IHJlbW92ZSB0aGUgZGlzcGF0Y2hfYXN5bmMoKSB3aGVuIHdl IGhhdmUgYSBmaXggZm9yIHJkYXI6Ly9wcm9ibGVtLzMxMjUzOTUyLgorICAgIGRpc3BhdGNoX2Fz eW5jKGRpc3BhdGNoX2dldF9tYWluX3F1ZXVlKCksIFtyZXRhaW5lZFNlbGYgPSByZXRhaW5QdHIo c2VsZildIHsKKyAgICAgICAgW0NBVHJhbnNhY3Rpb24gYWRkQ29tbWl0SGFuZGxlcjpbcmV0YWlu ZWRTZWxmXSB7CisgICAgICAgICAgICBXS1dlYlZpZXcgKndlYlZpZXcgPSByZXRhaW5lZFNlbGYu Z2V0KCk7CisgICAgICAgICAgICBbd2ViVmlldyBfdXBkYXRlVmlzaWJsZUNvbnRlbnRSZWN0c107 CisgICAgICAgICAgICB3ZWJWaWV3LT5faGFzU2NoZWR1bGVkVmlzaWJsZVJlY3RVcGRhdGUgPSBO TzsKKyAgICAgICAgfSBmb3JQaGFzZTprQ0FUcmFuc2FjdGlvblBoYXNlUHJlQ29tbWl0XTsKKyAg ICB9KTsKIH0KIAogc3RhdGljIGJvb2wgc2Nyb2xsVmlld0NhblNjcm9sbChVSVNjcm9sbFZpZXcg KnNjcm9sbFZpZXcpCg==