17009 2008-01-25 12:42:46 -0800 [GTK] Webkit strips accents from some dead-key combinations 2008-02-08 02:42:33 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 14120 1 jasa.david webkit-unassigned alp christian oldest_to_newest 68228 0 jasa.david 2008-01-25 12:42:46 -0800 Some accented character in cs layout can be written only by combining "dead" key followed by base letter. If I try to write e.g. "ï", webkit shows only "d". I can reproduce this for any czech accented letter, including latin1-compatible "á". Webkit version: SVN 29753 Midori version: 0.0.17 68229 1 jasa.david 2008-01-25 12:46:50 -0800 Pasting such letter to input/textarea works fine. 68235 2 christian 2008-01-25 13:29:28 -0800 Confirmed. Dead keys are not applied to typed characters whereas typing characters present in the keyboard layout works fine. For instance I cannot use the ^ or ` keys on a German keyboard to input accented characters but umlauts, present as keys, are fine. 68238 3 sven 2008-01-25 14:33:03 -0800 Christian, are you sure you changed your keyboard layout? The default one for German is "eliminate dead keys", so you should make sure you choose a default US keyboard to test this. 68249 4 christian 2008-01-25 20:06:17 -0800 (In reply to comment #3) > Christian, are you sure you changed your keyboard layout? The default one for > German is "eliminate dead keys", so you should make sure you choose a default > US keyboard to test this. Yes, I am. I have a German layout with dead keys. Besides, I can type accented letters with '´' or '^' and a vowel virtually everywhere else, such as Gtk, Qt, Gecko widgets, etc. :) 68381 5 alp 2008-01-27 14:08:22 -0800 My suspicions fall on WebCore/platform/gtk/KeyEventGtk.cpp Might be worth examining singleCharacterString() and other bits. (KeyEventGtk.cpp is one of the ugliest files in the GTK+ port right now. Probably several bugs lurking in there.) (I'm assuming this bug isn't related to input method support.) 69709 6 18990 pierre-luc.beaudoin 2008-02-07 14:43:49 -0800 Created attachment 18990 Fix This fix the issue. I tried it with my French Canadian keyboard layout and dead keys (for à,ç,ê,ï,ù...) worked perfectly. This was totally related to input method. Each key event has to be filtered by gtk_im_context_filter_keypress which will do the magic. At first, my characters were in screwed up: a utf8/utf16 conversion was missing. While at it, I implemented the isKeypad check and made disambiguateKeyDownEvent behave more like other ports. 69757 7 18990 alp 2008-02-08 02:34:56 -0800 Comment on attachment 18990 Fix The copy-and-pasted string conversion code looks bogus -- just use String::fromUTF8()? Added a TODO about refcounting the GdkEvent. We need something like OwnPtr for gdk to do this elegantly. Looks fine otherwise, though I had to improve the ChangeLog entries. 69762 8 alp 2008-02-08 02:42:33 -0800 Landed in r30090. Please take a look over the commit when you have a moment. 18990 2008-02-07 14:43:49 -0800 2008-02-08 02:34:56 -0800 Fix fix-17009.patch text/plain 5785 pierre-luc.beaudoin SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3RrL0tleUV2ZW50R3RrLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL3BsYXRmb3JtL2d0ay9LZXlFdmVudEd0ay5jcHAJKHLDqXZpc2lvbiAzMDA2NCkK KysrIFdlYkNvcmUvcGxhdGZvcm0vZ3RrL0tleUV2ZW50R3RrLmNwcAkoY29waWUgZGUgdHJhdmFp bCkKQEAgLTIsNiArMiw3IEBACiAgKiBDb3B5cmlnaHQgKEMpIDIwMDYsIDIwMDcgQXBwbGUgSW5j LiAgQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqIENvcHlyaWdodCAoQykgMjAwNiBNaWNoYWVsIEVt bWVsIG1pa2UuZW1tZWxAZ21haWwuY29tCiAgKiBDb3B5cmlnaHQgKEMpIDIwMDcgSG9sZ2VyIEhh bnMgUGV0ZXIgRnJleXRoZXIKKyAqIENvcHlyaWdodCAoQykgMjAwOCBDb2xsYWJvcmEsIEx0ZC4g IEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAgKiBBbGwgcmlnaHRzIHJlc2VydmVkLgogICoKICAqIFJl ZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Ig d2l0aG91dApAQCAtNDkxLDIwICs0OTIsMjQgQEAKICAgICAsIG1fa2V5SWRlbnRpZmllcihrZXlJ ZGVudGlmaWVyRm9yR2RrS2V5Q29kZShldmVudC0+a2V5dmFsKSkKICAgICAsIG1fYXV0b1JlcGVh dChmYWxzZSkKICAgICAsIG1fd2luZG93c1ZpcnR1YWxLZXlDb2RlKHdpbmRvd3NLZXlDb2RlRm9y S2V5RXZlbnQoZXZlbnQtPmtleXZhbCkpCi0gICAgLCBtX2lzS2V5cGFkKGZhbHNlKQorICAgICwg bV9pc0tleXBhZChldmVudC0+a2V5dmFsID49IEdES19LUF9TcGFjZSAmJiBldmVudC0+a2V5dmFs IDw9IEdES19LUF85KQogICAgICwgbV9zaGlmdEtleSgoZXZlbnQtPnN0YXRlICYgR0RLX1NISUZU X01BU0spIHx8IChldmVudC0+a2V5dmFsID09IEdES18zMjcwX0JhY2tUYWIpKQogICAgICwgbV9j dHJsS2V5KGV2ZW50LT5zdGF0ZSAmIEdES19DT05UUk9MX01BU0spCiAgICAgLCBtX2FsdEtleShl dmVudC0+c3RhdGUgJiBHREtfTU9EMV9NQVNLKQogICAgICwgbV9tZXRhS2V5KGV2ZW50LT5zdGF0 ZSAmIEdES19NT0QyX01BU0spCisgICAgLCBtX2dka0V2ZW50S2V5KGV2ZW50KQogewogfQogCi12 b2lkIFBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6ZGlzYW1iaWd1YXRlS2V5RG93bkV2ZW50KFR5cGUg dHlwZSwgYm9vbCkKK3ZvaWQgUGxhdGZvcm1LZXlib2FyZEV2ZW50OjpkaXNhbWJpZ3VhdGVLZXlE b3duRXZlbnQoVHlwZSB0eXBlLCBib29sIGJhY2t3YXJkQ29tcGF0aWJpbGl0eU1vZGUpCiB7CiAg ICAgLy8gQ2FuIG9ubHkgY2hhbmdlIHR5cGUgZnJvbSBLZXlEb3duIHRvIFJhd0tleURvd24gb3Ig Q2hhciwgYXMgd2UgbGFjayBpbmZvcm1hdGlvbiBmb3Igb3RoZXIgY29udmVyc2lvbnMuCiAgICAg QVNTRVJUKG1fdHlwZSA9PSBLZXlEb3duKTsKICAgICBtX3R5cGUgPSB0eXBlOwogCisgICAgaWYg KGJhY2t3YXJkQ29tcGF0aWJpbGl0eU1vZGUpCisgICAgICAgIHJldHVybjsKKwogICAgIGlmICh0 eXBlID09IFJhd0tleURvd24pIHsKICAgICAgICAgbV90ZXh0ID0gU3RyaW5nKCk7CiAgICAgICAg IG1fdW5tb2RpZmllZFRleHQgPSBTdHJpbmcoKTsKQEAgLTUyMCw0ICs1MjUsOSBAQAogICAgIHJl dHVybiBmYWxzZTsKIH0KIAorR2RrRXZlbnRLZXkqIFBsYXRmb3JtS2V5Ym9hcmRFdmVudDo6Z2Rr RXZlbnRLZXkoKSBjb25zdAoreworICAgIHJldHVybiBtX2dka0V2ZW50S2V5OwogfQorCit9Cklu ZGV4OiBXZWJDb3JlL3BsYXRmb3JtL1BsYXRmb3JtS2V5Ym9hcmRFdmVudC5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvcGxhdGZvcm0vUGxhdGZvcm1LZXlib2FyZEV2ZW50LmgJKHLDqXZpc2lvbiAz MDA2NCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vUGxhdGZvcm1LZXlib2FyZEV2ZW50LmgJKGNvcGll IGRlIHRyYXZhaWwpCkBAIC0xLDUgKzEsNiBAQAogLyoKICAqIENvcHlyaWdodCAoQykgMjAwNCwg MjAwNSwgMjAwNiBBcHBsZSBDb21wdXRlciwgSW5jLiAgQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAq IENvcHlyaWdodCAoQykgMjAwOCBDb2xsYWJvcmEsIEx0ZC4gIEFsbCByaWdodHMgcmVzZXJ2ZWQu CiAgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jt cywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlk ZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKQEAgLTExOCw2ICsxMTksNyBAQAogCiAj aWYgUExBVEZPUk0oR1RLKQogICAgICAgICBQbGF0Zm9ybUtleWJvYXJkRXZlbnQoR2RrRXZlbnRL ZXkqKTsKKyAgICAgICAgR2RrRXZlbnRLZXkqIGdka0V2ZW50S2V5KCkgY29uc3Q7CiAjZW5kaWYK IAogI2lmIFBMQVRGT1JNKFFUKQpAQCAtMTQ3LDYgKzE0OSw5IEBACiAjaWYgUExBVEZPUk0oV0lO KQogICAgICAgICBib29sIG1faXNTeXN0ZW1LZXk7CiAjZW5kaWYKKyNpZiBQTEFURk9STShHVEsp CisgICAgICAgIEdka0V2ZW50S2V5KiBtX2dka0V2ZW50S2V5OworI2VuZGlmCiAgICAgfTsKIAog fSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpJbmRleDogV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9F ZGl0b3JDbGllbnRHdGsuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9ndGsvV2ViQ29yZVN1cHBv cnQvRWRpdG9yQ2xpZW50R3RrLmNwcAkocsOpdmlzaW9uIDMwMDY0KQorKysgV2ViS2l0L2d0ay9X ZWJDb3JlU3VwcG9ydC9FZGl0b3JDbGllbnRHdGsuY3BwCShjb3BpZSBkZSB0cmF2YWlsKQpAQCAt MSw1ICsxLDYgQEAKIC8qCiAgKiAgQ29weXJpZ2h0IChDKSAyMDA3IEFscCBUb2tlciA8YWxwQGF0 b2tlci5jb20+CisgKiAgQ29weXJpZ2h0IChDKSAyMDA4IENvbGxhYm9yYSwgTHRkLiAgQWxsIHJp Z2h0cyByZXNlcnZlZC4KICAqCiAgKiAgVGhpcyBsaWJyYXJ5IGlzIGZyZWUgc29mdHdhcmU7IHlv dSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vcgogICogIG1vZGlmeSBpdCB1bmRlciB0aGUgdGVy bXMgb2YgdGhlIEdOVSBMZXNzZXIgR2VuZXJhbCBQdWJsaWMKQEAgLTM3LDcgKzM4LDE0IEBACiBz dGF0aWMgdm9pZCBpbUNvbnRleHRDb21taXR0ZWQoR3RrSU1Db250ZXh0KiBjb250ZXh0LCBjb25z dCBjaGFyKiBzdHIsIEVkaXRvckNsaWVudCogY2xpZW50KQogewogICAgIEZyYW1lKiBmcmFtZSA9 IGNvcmUoY2xpZW50LT5tX3dlYlZpZXcpLT5mb2N1c0NvbnRyb2xsZXIoKS0+Zm9jdXNlZE9yTWFp bkZyYW1lKCk7Ci0gICAgZnJhbWUtPmVkaXRvcigpLT5pbnNlcnRUZXh0V2l0aG91dFNlbmRpbmdU ZXh0RXZlbnQoc3RyLCBmYWxzZSk7CisgICAgCisgICAgZ2xvbmcgbndjOworICAgIGd1bmljaGFy IHUgPSBnX3V0ZjhfZ2V0X2NoYXIoc3RyKTsKKyAgICBndW5pY2hhcjIqIHVjaGFyMTYgPSBnX3Vj czRfdG9fdXRmMTYoJnUsIDEsIDAsICZud2MsIDApOworCisgICAgZnJhbWUtPmVkaXRvcigpLT5p bnNlcnRUZXh0V2l0aG91dFNlbmRpbmdUZXh0RXZlbnQoU3RyaW5nKChVQ2hhciopdWNoYXIxNiwg bndjKSwgZmFsc2UpOworCisgICAgZ19mcmVlKHVjaGFyMTYpOwogfQogCiBib29sIEVkaXRvckNs aWVudDo6c2hvdWxkRGVsZXRlUmFuZ2UoUmFuZ2UqKQpAQCAtMzgyLDEwICszOTAsMTAgQEAKICAg ICBub3RJbXBsZW1lbnRlZCgpOwogfQogCi1ib29sIEVkaXRvckNsaWVudDo6ZG9UZXh0RmllbGRD b21tYW5kRnJvbUV2ZW50KEVsZW1lbnQqLCBLZXlib2FyZEV2ZW50KikKK2Jvb2wgRWRpdG9yQ2xp ZW50Ojpkb1RleHRGaWVsZENvbW1hbmRGcm9tRXZlbnQoRWxlbWVudCogZWxlbWVudCwgS2V5Ym9h cmRFdmVudCogZXZlbnQpCiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKLSAgICByZXR1cm4gZmFs c2U7CisgICAgV2ViS2l0V2ViVmlld1ByaXZhdGUqIHByaXYgPSBtX3dlYlZpZXctPnByaXY7Cisg ICAgcmV0dXJuIGd0a19pbV9jb250ZXh0X2ZpbHRlcl9rZXlwcmVzcyhwcml2LT5pbUNvbnRleHQs IGV2ZW50LT5rZXlFdmVudCgpLT5nZGtFdmVudEtleSgpKTsKIH0KIAogdm9pZCBFZGl0b3JDbGll bnQ6OnRleHRXaWxsQmVEZWxldGVkSW5UZXh0RmllbGQoRWxlbWVudCopCkluZGV4OiBXZWJDb3Jl L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL0NoYW5nZUxvZwkocsOpdmlzaW9uIDMw MDczKQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKGNvcGllIGRlIHRyYXZhaWwpCkBAIC0xLDMgKzEs MTYgQEAKKzIwMDgtMDItMDcgIFBpZXJyZS1MdWMgQmVhdWRvaW4gIDxwaWVycmUtbHVjLmJlYXVk b2luQGNvbGxhYm9yYS5jby51az4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBGaXggYnVnICMxNzAwOSAoW0d0a10gV2Via2l0IHN0cmlwcyBhY2NlbnRz IGZyb20gc29tZSBkZWFkLWtleSBjb21iaW5hdGlvbnMpCisgICAgICAgIEtleUV2ZW50cyBoYXZl IHRvIGdvIHRocm91Z2ggdGhlIGd0ayBpbnB1dCBtZXRob2QuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9QbGF0Zm9ybUtleWJvYXJkRXZlbnQuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvS2V5RXZl bnRHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGxhdGZvcm1LZXlib2FyZEV2ZW50OjpQbGF0 Zm9ybUtleWJvYXJkRXZlbnQpOgorICAgICAgICAoV2ViQ29yZTo6UGxhdGZvcm1LZXlib2FyZEV2 ZW50OjpkaXNhbWJpZ3VhdGVLZXlEb3duRXZlbnQpOgorICAgICAgICAoV2ViQ29yZTo6UGxhdGZv cm1LZXlib2FyZEV2ZW50OjpnZGtFdmVudEtleSk6CisKIDIwMDgtMDItMDcgIERhdmlkIEh5YXR0 ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBmb3IgYnVnIDYyNDgsIGltcGxlbWVu dCB0aGUgbnRoLSogQ1NTMyBzZWxlY3RvcnMuICBQYXRjaCBiYXNlZCBvbiBvcmlnaW5hbCBLSFRN TCB3b3JrIGZyb20gQWxsYW4gSmVuc2VuCkluZGV4OiBXZWJLaXQvZ3RrL0NoYW5nZUxvZwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJLaXQvZ3RrL0NoYW5nZUxvZwkocsOpdmlzaW9uIDMwMDczKQorKysgV2Vi S2l0L2d0ay9DaGFuZ2VMb2cJKGNvcGllIGRlIHRyYXZhaWwpCkBAIC0xLDMgKzEsMTQgQEAKKzIw MDgtMDItMDcgIFBpZXJyZS1MdWMgQmVhdWRvaW4gIDxwaWVycmUtbHVjLmJlYXVkb2luQGNvbGxh Ym9yYS5jby51az4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBGaXggYnVnICMxNzAwOSAoW0d0a10gV2Via2l0IHN0cmlwcyBhY2NlbnRzIGZyb20gc29t ZSBkZWFkLWtleSBjb21iaW5hdGlvbnMpCisgICAgICAgIEtleUV2ZW50cyBoYXZlIHRvIGdvIHRo cm91Z2ggdGhlIGd0ayBpbnB1dCBtZXRob2QuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9F ZGl0b3JDbGllbnRHdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjppbUNvbnRleHRDb21taXR0ZWQp OgorICAgICAgICAoV2ViS2l0OjpFZGl0b3JDbGllbnQ6OmRvVGV4dEZpZWxkQ29tbWFuZEZyb21F dmVudCk6CisKIDIwMDgtMDItMDUgIE1hcmsgUm93ZSAgPG1yb3dlQGFwcGxlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBBbHAgVG9rZXIuCg==