170085 2017-03-24 16:36:27 -0700 Web Inspector: Saving files should not suggest the top level directory 2017-03-27 16:37:46 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1291066 0 joepeck 2017-03-24 16:36:27 -0700 Summary: Saving files should not suggest the top level directory Steps to Reproduce: 1. Inspect this page 2. Click the Download button in the toolbar => Save Dialog suggests the top level directory (/) which is unhelpful Notes: • Normal behavior when we have no good suggestion is to provide the last directory used by a save dialog in the application. - This can be done by not setting the Save Panel's panel.directoryURL 1291067 1 joepeck 2017-03-24 16:36:45 -0700 <rdar://problem/30197794> 1291068 2 305339 joepeck 2017-03-24 16:38:13 -0700 Created attachment 305339 [PATCH] Proposed Fix 1291660 3 305339 mattbaker 2017-03-27 16:07:34 -0700 Comment on attachment 305339 [PATCH] Proposed Fix r=me 1291677 4 305339 commit-queue 2017-03-27 16:37:43 -0700 Comment on attachment 305339 [PATCH] Proposed Fix Clearing flags on attachment: 305339 Committed r214442: <http://trac.webkit.org/changeset/214442> 1291678 5 commit-queue 2017-03-27 16:37:46 -0700 All reviewed patches have been landed. Closing bug. 305339 2017-03-24 16:38:13 -0700 2017-03-27 16:37:43 -0700 [PATCH] Proposed Fix file-save-1.patch text/plain 4562 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwppbmRleCBjZDY2NWQ3YzM0YS4uZGFkNjUyZjg3YjMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNy0wMy0yNCAgSm9zZXBoIFBlY29yYXJvICA8cGVj b3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFNhdmluZyBmaWxlcyBz aG91bGQgbm90IHN1Z2dlc3QgdGhlIHRvcCBsZXZlbCBkaXJlY3RvcnkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDA4NQorICAgICAgICA8cmRhcjov L3Byb2JsZW0vMzAxOTc3OTQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JDbGllbnQubW06CisgICAg ICAgIChXZWJJbnNwZWN0b3JGcm9udGVuZENsaWVudDo6c2F2ZSk6CisgICAgICAgIERvbid0IHNl dCBwYW5lbC5kaXJlY3RvcnlVUkwgdW5sZXNzIHdlIGhhdmUgYSBnb29kIHN1Z2dlc3Rpb24uCisK IDIwMTctMDMtMjEgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAg ICAgICAgQWRkIHN1cHBvcnQgZm9yIHNob3dpbmcgdGhlIHBsYXRmb3JtIGRhdGEgaW50ZXJhY3Rp b24gY2FyZXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dl Ykluc3BlY3RvckNsaWVudC5tbSBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dl Ykluc3BlY3RvckNsaWVudC5tbQppbmRleCA2Yzg4NDRkNzYyNy4uNTRkYzI3ZmNlYWEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkluc3BlY3RvckNsaWVu dC5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JD bGllbnQubW0KQEAgLTMyOSw3ICszMjksMTIgQEAgdm9pZCBXZWJJbnNwZWN0b3JGcm9udGVuZENs aWVudDo6c2F2ZShjb25zdCBTdHJpbmcmIHN1Z2dlc3RlZFVSTCwgY29uc3QgU3RyaW5nJgogCiAg ICAgTlNTYXZlUGFuZWwgKnBhbmVsID0gW05TU2F2ZVBhbmVsIHNhdmVQYW5lbF07CiAgICAgcGFu ZWwubmFtZUZpZWxkU3RyaW5nVmFsdWUgPSBwbGF0Zm9ybVVSTC5sYXN0UGF0aENvbXBvbmVudDsK LSAgICBwYW5lbC5kaXJlY3RvcnlVUkwgPSBbcGxhdGZvcm1VUkwgVVJMQnlEZWxldGluZ0xhc3RQ YXRoQ29tcG9uZW50XTsKKworICAgIC8vIElmIHdlIGhhdmUgYSBmaWxlIFVSTCB3ZSd2ZSBhbHJl YWR5IHNhdmVkIHRoaXMgZmlsZSB0byBhIHBhdGggYW5kCisgICAgLy8gY2FuIHByb3ZpZGUgYSBn b29kIGRpcmVjdG9yeSB0byBzaG93LiBPdGhlcndpc2UsIHVzZSB0aGUgc3lzdGVtJ3MKKyAgICAv LyBkZWZhdWx0IGJlaGF2aW9yIGZvciB0aGUgaW5pdGlhbCBkaXJlY3RvcnkgdG8gc2hvdyBpbiB0 aGUgZGlhbG9nLgorICAgIGlmIChwbGF0Zm9ybVVSTC5pc0ZpbGVVUkwpCisgICAgICAgIHBhbmVs LmRpcmVjdG9yeVVSTCA9IFtwbGF0Zm9ybVVSTCBVUkxCeURlbGV0aW5nTGFzdFBhdGhDb21wb25l bnRdOwogCiAgICAgYXV0byBjb21wbGV0aW9uSGFuZGxlciA9IF4oTlNJbnRlZ2VyIHJlc3VsdCkg ewogICAgICAgICBpZiAocmVzdWx0ID09IE5TTW9kYWxSZXNwb25zZUNhbmNlbCkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpp bmRleCA1M2NjYzkzMGE2ZC4uZTEwYmMzNTc4ZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEgKzEsMTUgQEAK KzIwMTctMDMtMjQgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAg ICAgICBXZWIgSW5zcGVjdG9yOiBTYXZpbmcgZmlsZXMgc2hvdWxkIG5vdCBzdWdnZXN0IHRoZSB0 b3AgbGV2ZWwgZGlyZWN0b3J5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNzAwODUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMwMTk3Nzk0PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNz L21hYy9SZW1vdGVXZWJJbnNwZWN0b3JQcm94eU1hYy5tbToKKyAgICAgICAgKFdlYktpdDo6UmVt b3RlV2ViSW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtU2F2ZSk6CisgICAgICAgICogVUlQcm9jZXNz L21hYy9XZWJJbnNwZWN0b3JQcm94eU1hYy5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViSW5zcGVj dG9yUHJveHk6OnBsYXRmb3JtU2F2ZSk6CisgICAgICAgIERvbid0IHNldCBwYW5lbC5kaXJlY3Rv cnlVUkwgdW5sZXNzIHdlIGhhdmUgYSBnb29kIHN1Z2dlc3Rpb24uCisKID09IFJvbGxlZCBvdmVy IHRvIENoYW5nZUxvZy0yMDE3LTAzLTIzID09CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvbWFjL1JlbW90ZVdlYkluc3BlY3RvclByb3h5TWFjLm1tIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL21hYy9SZW1vdGVXZWJJbnNwZWN0b3JQcm94eU1hYy5tbQppbmRleCA2YmVm NGI4OWZmYy4uMjYzYWY4Zjc3OTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9tYWMvUmVtb3RlV2ViSW5zcGVjdG9yUHJveHlNYWMubW0KKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL21hYy9SZW1vdGVXZWJJbnNwZWN0b3JQcm94eU1hYy5tbQpAQCAtMTc5LDcgKzE3 OSwxMiBAQCB2b2lkIFJlbW90ZVdlYkluc3BlY3RvclByb3h5OjpwbGF0Zm9ybVNhdmUoY29uc3Qg U3RyaW5nJiBzdWdnZXN0ZWRVUkwsIGNvbnN0IFN0cgogCiAgICAgTlNTYXZlUGFuZWwgKnBhbmVs ID0gW05TU2F2ZVBhbmVsIHNhdmVQYW5lbF07CiAgICAgcGFuZWwubmFtZUZpZWxkU3RyaW5nVmFs dWUgPSBwbGF0Zm9ybVVSTC5sYXN0UGF0aENvbXBvbmVudDsKLSAgICBwYW5lbC5kaXJlY3RvcnlV UkwgPSBbcGxhdGZvcm1VUkwgVVJMQnlEZWxldGluZ0xhc3RQYXRoQ29tcG9uZW50XTsKKworICAg IC8vIElmIHdlIGhhdmUgYSBmaWxlIFVSTCB3ZSd2ZSBhbHJlYWR5IHNhdmVkIHRoaXMgZmlsZSB0 byBhIHBhdGggYW5kCisgICAgLy8gY2FuIHByb3ZpZGUgYSBnb29kIGRpcmVjdG9yeSB0byBzaG93 LiBPdGhlcndpc2UsIHVzZSB0aGUgc3lzdGVtJ3MKKyAgICAvLyBkZWZhdWx0IGJlaGF2aW9yIGZv ciB0aGUgaW5pdGlhbCBkaXJlY3RvcnkgdG8gc2hvdyBpbiB0aGUgZGlhbG9nLgorICAgIGlmIChw bGF0Zm9ybVVSTC5pc0ZpbGVVUkwpCisgICAgICAgIHBhbmVsLmRpcmVjdG9yeVVSTCA9IFtwbGF0 Zm9ybVVSTCBVUkxCeURlbGV0aW5nTGFzdFBhdGhDb21wb25lbnRdOwogCiAgICAgYXV0byBjb21w bGV0aW9uSGFuZGxlciA9IF4oTlNJbnRlZ2VyIHJlc3VsdCkgewogICAgICAgICBpZiAocmVzdWx0 ID09IE5TTW9kYWxSZXNwb25zZUNhbmNlbCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvbWFjL1dlYkluc3BlY3RvclByb3h5TWFjLm1tCmluZGV4IDg0YmY0ZTk5ZGUxLi5kYmQ0 MDQyZDM3ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XZWJJbnNw ZWN0b3JQcm94eU1hYy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYklu c3BlY3RvclByb3h5TWFjLm1tCkBAIC00NjAsNyArNDYwLDEyIEBAIHZvaWQgV2ViSW5zcGVjdG9y UHJveHk6OnBsYXRmb3JtU2F2ZShjb25zdCBTdHJpbmcmIHN1Z2dlc3RlZFVSTCwgY29uc3QgU3Ry aW5nJiBjCiAKICAgICBOU1NhdmVQYW5lbCAqcGFuZWwgPSBbTlNTYXZlUGFuZWwgc2F2ZVBhbmVs XTsKICAgICBwYW5lbC5uYW1lRmllbGRTdHJpbmdWYWx1ZSA9IHBsYXRmb3JtVVJMLmxhc3RQYXRo Q29tcG9uZW50OwotICAgIHBhbmVsLmRpcmVjdG9yeVVSTCA9IFtwbGF0Zm9ybVVSTCBVUkxCeURl bGV0aW5nTGFzdFBhdGhDb21wb25lbnRdOworCisgICAgLy8gSWYgd2UgaGF2ZSBhIGZpbGUgVVJM IHdlJ3ZlIGFscmVhZHkgc2F2ZWQgdGhpcyBmaWxlIHRvIGEgcGF0aCBhbmQKKyAgICAvLyBjYW4g cHJvdmlkZSBhIGdvb2QgZGlyZWN0b3J5IHRvIHNob3cuIE90aGVyd2lzZSwgdXNlIHRoZSBzeXN0 ZW0ncworICAgIC8vIGRlZmF1bHQgYmVoYXZpb3IgZm9yIHRoZSBpbml0aWFsIGRpcmVjdG9yeSB0 byBzaG93IGluIHRoZSBkaWFsb2cuCisgICAgaWYgKHBsYXRmb3JtVVJMLmlzRmlsZVVSTCkKKyAg ICAgICAgcGFuZWwuZGlyZWN0b3J5VVJMID0gW3BsYXRmb3JtVVJMIFVSTEJ5RGVsZXRpbmdMYXN0 UGF0aENvbXBvbmVudF07CiAKICAgICBhdXRvIGNvbXBsZXRpb25IYW5kbGVyID0gXihOU0ludGVn ZXIgcmVzdWx0KSB7CiAgICAgICAgIGlmIChyZXN1bHQgPT0gTlNNb2RhbFJlc3BvbnNlQ2FuY2Vs KQo=