170080 2017-03-24 15:56:43 -0700 REGRESSION(r214195): zillow.com header video doesn't resume when switching to another tab and back 2017-03-25 20:52:48 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar, Regression P2 Normal --- 1 kling cdumez commit-queue eric.carlson jer.noble kling koivisto webkit-bug-importer oldest_to_newest 1291026 0 kling 2017-03-24 15:56:43 -0700 Repro steps: 1. open "zillow.com" in one tab 2. switch to another tab 3. switch back to the zillow tab Notice how the huge video up top doesn't animate anymore. This regressed with https://trac.webkit.org/changeset/214195/webkit 1291032 1 webkit-bug-importer 2017-03-24 16:02:56 -0700 <rdar://problem/31252522> 1291213 2 cdumez 2017-03-25 10:21:12 -0700 We do call play() on the player when the view becomes visible again. Then I see the play / playing / timeupdate events getting fired. I also see rateDidChange() being called with a rate of 1. I do believe the video is actually playing now. However, for some reason, the view stays static and does not display the frames. If anyone has an idea of what could be going on, please let me know. 1291273 3 cdumez 2017-03-25 16:03:38 -0700 (In reply to Chris Dumez from comment #2) > We do call play() on the player when the view becomes visible again. Then I > see the play / playing / timeupdate events getting fired. I also see > rateDidChange() being called with a rate of 1. I do believe the video is > actually playing now. > > However, for some reason, the view stays static and does not display the > frames. > > If anyone has an idea of what could be going on, please let me know. It looks like we are displaying the poster even though the video is playing again. If I update HTMLVideoElement::shouldDisplayPosterImage() to always return false, then the bug goes away. 1291281 4 305408 cdumez 2017-03-25 16:57:52 -0700 Created attachment 305408 Patch 1291298 5 305408 commit-queue 2017-03-25 20:52:44 -0700 Comment on attachment 305408 Patch Clearing flags on attachment: 305408 Committed r214407: <http://trac.webkit.org/changeset/214407> 1291299 6 commit-queue 2017-03-25 20:52:48 -0700 All reviewed patches have been landed. Closing bug. 305408 2017-03-25 16:57:52 -0700 2017-03-25 20:52:44 -0700 Patch bug-170080-20170325165752.patch text/plain 2571 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0MzY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGMzZDk4NzVlNDBmZTgy M2FiNmQzZWZmMjc0MDY1MjNjNDhmYmE0Yi4uYmYxNDVhMmFmYjYwMGNlMGQ5ZWJhYTdmOTg0Mzc2 Mjc2MmJjYzFlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE3LTAzLTI1ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjE0MTk1 KTogemlsbG93LmNvbSBoZWFkZXIgdmlkZW8gZG9lc24ndCByZXN1bWUgd2hlbiBzd2l0Y2hpbmcg dG8gYW5vdGhlciB0YWIgYW5kIGJhY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE3MDA4MAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzEyNTI1MjI+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHZp ZGVvIGhlYWRlciBvbiB6aWxsb3cuY29tIHdvdWxkIHBhdXNlIHdoZW4gc3dpdGNoaW5nIHRvIGFu b3RoZXIgdGFiIGFmdGVyIHIyMTQxOTUuIE9uCisgICAgICAgIHN3aXRjaGluZyBiYWNrIHRvIHRo ZSB6aWxsb3cuY29tIHRhYiwgd2Ugd291bGQgcmVzdW1lIHRoZSB2aWRlbyBidXQgZmFpbCB0byB0 YWtlIHRoZSBwb3N0ZXIKKyAgICAgICAgYXdheSwgbWFraW5nIGl0IGxvb2sgbGlrZSB0aGUgdmlk ZW8gaXMgc3RpbGwgcGF1c2VkLgorCisgICAgICAgIFdlIG5vcm1hbGx5IHRha2UgdGhlIHBvc3Rl ciBhd2F5IHdoZW4gSFRNTE1lZGlhRWxlbWVudDo6bWVkaWFQbGF5ZXJGaXJzdFZpZGVvRnJhbWVB dmFpbGFibGUoKQorICAgICAgICBpcyBjYWxsZWQuIEhvd2V2ZXIsIG1lZGlhUGxheWVyRmlyc3RW aWRlb0ZyYW1lQXZhaWxhYmxlKCkgd2FzIG9ubHkgZXZlciBjYWxsZWQgb25jZSBiZWNhdXNlIG9m CisgICAgICAgIHRoZSBtX2hhdmVSZXBvcnRlZEZpcnN0VmlkZW9GcmFtZSBmbGFnIGluIE1lZGlh UGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbjo6dXBkYXRlU3RhdGVzKCkuCisgICAgICAgIFdlIG5v dyByZXNldCBtX2hhdmVSZXBvcnRlZEZpcnN0VmlkZW9GcmFtZSB0byBmYWxzZSBpbiB1cGRhdGVT dGF0ZXMoKSBpZiBoYXNBdmFpbGFibGVWaWRlb0ZyYW1lKCkKKyAgICAgICAgcmV0dXJuIGZhbHNl LCBzbyB0aGF0IHdlIGNhbGwgbWVkaWFQbGF5ZXJGaXJzdFZpZGVvRnJhbWVBdmFpbGFibGUoKSBh Z2FpbiB3aGVuIHRoZSByZXR1cm4KKyAgICAgICAgdmFsdWUgb2YgYXNBdmFpbGFibGVWaWRlb0Zy YW1lKCkgYmVjb21lcyB0cnVlIGFnYWluIChlLmcuIGFmdGVyIHRoZSBtZWRpYSBzZXNzaW9uIGlu dGVycnVwdGlvbgorICAgICAgICBoYXMgZW5kZWQpLgorCisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3MvYXZmb3VuZGF0aW9uL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbi5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVBVkZvdW5kYXRpb246OnVwZGF0ZVN0 YXRlcyk6CisKIDIwMTctMDMtMjQgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgog CiAgICAgICAgIEFkZCBzdXBwb3J0IGZvciBxcFN1bSBpbiBXZWJSVEMgc3RhdHMKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9NZWRpYVBs YXllclByaXZhdGVBVkZvdW5kYXRpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvYXZmb3VuZGF0aW9uL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbi5jcHAKaW5k ZXggZmVmOTVkZmE5ZWRmNjI0Mjg5NzQ5NWU2NjFlOWQzOWNmMjcwNzYwZi4uYjBjMjZhZjUzM2Y0 MjM3YzQ3NjQ5NjE1YjRlZDY0MWI0MmMwZGU4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRh dGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0 aW9uL01lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbi5jcHAKQEAgLTU2MSw3ICs1NjEsOCBA QCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUFWRm91bmRhdGlvbjo6dXBkYXRlU3RhdGVzKCkKICAg ICAgICAgICAgIG5ld1JlYWR5U3RhdGUgPSBNZWRpYVBsYXllcjo6SGF2ZUN1cnJlbnREYXRhOwog ICAgICAgICBtX2hhdmVSZXBvcnRlZEZpcnN0VmlkZW9GcmFtZSA9IHRydWU7CiAgICAgICAgIG1f cGxheWVyLT5maXJzdFZpZGVvRnJhbWVBdmFpbGFibGUoKTsKLSAgICB9CisgICAgfSBlbHNlIGlm ICghaGFzQXZhaWxhYmxlVmlkZW9GcmFtZSgpKQorICAgICAgICBtX2hhdmVSZXBvcnRlZEZpcnN0 VmlkZW9GcmFtZSA9IGZhbHNlOwogCiAjaWYgIUxPR19ESVNBQkxFRAogICAgIGlmIChtX25ldHdv cmtTdGF0ZSAhPSBuZXdOZXR3b3JrU3RhdGUgfHwgbV9yZWFkeVN0YXRlICE9IG5ld1JlYWR5U3Rh dGUpIHsK