170076 2017-03-24 14:38:53 -0700 Add delegate method to let an WebKit client provide a custom image preview controller. 2017-03-27 16:33:02 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 yongjun_zhang yongjun_zhang andersca bdakin commit-queue enrica mitz sam thorton yongjun_zhang oldest_to_newest 1291000 0 yongjun_zhang 2017-03-24 14:38:53 -0700 Sometimes a WebKit client might want to provide a custom image preview controller than the stock WKImagePreviewViewController. It would be nice if we have a delegate method in WKUIDelegate(Private) to enable that. 1291002 1 yongjun_zhang 2017-03-24 14:42:14 -0700 rdar://problem/31153051 1291015 2 305325 yongjun_zhang 2017-03-24 15:26:45 -0700 Created attachment 305325 Patch. 1291673 3 305325 commit-queue 2017-03-27 16:32:59 -0700 Comment on attachment 305325 Patch. Clearing flags on attachment: 305325 Committed r214440: <http://trac.webkit.org/changeset/214440> 1291674 4 commit-queue 2017-03-27 16:33:02 -0700 All reviewed patches have been landed. Closing bug. 305325 2017-03-24 15:26:45 -0700 2017-03-27 16:32:59 -0700 Patch. custom_delegate.patch text/plain 5321 yongjun_zhang Y29tbWl0IGIyNTViYTlkNGNhNDk5NjJjMmJkZTUxMWJlMGU5ZDA0NDZhN2JlYmIKQXV0aG9yOiBZ b25nanVuIFpoYW5nIDx5b25nanVuX3poYW5nQGFwcGxlLmNvbT4KRGF0ZTogICBGcmkgTWFyIDI0 IDE0OjQyOjQ3IDIwMTcgLTA3MDAKCiAgICBBZGQgZGVsZWdhdGUgbWV0aG9kIHRvIGxldCBhbiBX ZWJLaXQgY2xpZW50IHByb3ZpZGUgYSBjdXN0b20gaW1hZ2UgcHJldmlldyBjb250cm9sbGVyLgog ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDA3NgogICAgcmRh cjovL3Byb2JsZW0vMzExNTMwNTEKICAgIAogICAgQWRkIGEgbmV3IGRlbGVnYXRlIG1ldGhvZCAo X3dlYlZpZXc6cHJldmlld1ZpZXdDb250cm9sbGVyRm9ySW1hZ2U6YWx0ZXJuYXRlVVJMOmRlZmF1 bHRBY3Rpb25zOmVsZW1lbnRJbmZvOikgdG8KICAgIFdLVUlEZWxlZ2F0ZVByaXZhdGUsIGFuIGNs aWVudCBjYW4gdXNlIHRoaXMgbWV0aG9kIHRvIHByb3ZpZGUgYSBjdXN0b20gaW1hZ2UgcHJldmll dyB2aWV3IGNvbnRyb2xsZXIgaWYgdGhlIGltYWdlCiAgICBoYXMgYWx0ZXJuYXRlZCBVUkwgb3Ig Y3VzdG9tIGltYWdlIGluZm8uCiAgICAKICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgog ICAgCiAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tVSURlbGVnYXRlUHJpdmF0ZS5oOiBBZGQg ZGVsZWdhdGUgbWV0aG9kIF93ZWJWaWV3OnByZXZpZXdWaWV3Q29udHJvbGxlckZvckltYWdlOmFs dGVybmF0ZVVSTDpkZWZhdWx0QWN0aW9uczplbGVtZW50SW5mbzouCiAgICAqIFVJUHJvY2Vzcy9p b3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgogICAgKC1bV0tDb250ZW50VmlldyBfcHJl c2VudGVkVmlld0NvbnRyb2xsZXJGb3JQcmV2aWV3SXRlbUNvbnRyb2xsZXI6XSk6IElmIHRoZSBp bWFnZSBoYXMgYWx0ZXJuYXRlZCBVUkwgb3IgY3VzdG9tIGluZm8sIHRyeSB0byB1c2UgdGhlIGNs aWVudC1wcm92aWRlZAogICAgICAgIHByZXZpZXcgdmlldyBjb250cm9sbGVyLiBPdGhlcndpc2Us IHVzZSB0aGUgZGVmYXVsdCBXS0ltYWdlUHJldmlld1ZpZXdDb250cm9sbGVyLgoKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpp bmRleCAyOTE2ODcyZTc1Ny4uNDQ4YjFhMmIyYTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBA QAorMjAxNy0wMy0yNCAgWW9uZ2p1biBaaGFuZyAgPHlvbmdqdW5femhhbmdAYXBwbGUuY29tPgor CisgICAgICAgIEFkZCBkZWxlZ2F0ZSBtZXRob2QgdG8gbGV0IGFuIFdlYktpdCBjbGllbnQgcHJv dmlkZSBhIGN1c3RvbSBpbWFnZSBwcmV2aWV3IGNvbnRyb2xsZXIuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzAwNzYKKyAgICAgICAgcmRhcjovL3By b2JsZW0vMzExNTMwNTEKKworICAgICAgICBBZGQgYSBuZXcgZGVsZWdhdGUgbWV0aG9kIChfd2Vi VmlldzpwcmV2aWV3Vmlld0NvbnRyb2xsZXJGb3JJbWFnZTphbHRlcm5hdGVVUkw6ZGVmYXVsdEFj dGlvbnM6ZWxlbWVudEluZm86KSB0bworICAgICAgICBXS1VJRGVsZWdhdGVQcml2YXRlLCBhbiBj bGllbnQgY2FuIHVzZSB0aGlzIG1ldGhvZCB0byBwcm92aWRlIGEgY3VzdG9tIGltYWdlIHByZXZp ZXcgdmlldyBjb250cm9sbGVyIGlmIHRoZSBpbWFnZQorICAgICAgICBoYXMgYWx0ZXJuYXRlZCBV Ukwgb3IgY3VzdG9tIGltYWdlIGluZm8uCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLVUlEZWxlZ2F0ZVByaXZh dGUuaDogQWRkIGRlbGVnYXRlIG1ldGhvZCBfd2ViVmlldzpwcmV2aWV3Vmlld0NvbnRyb2xsZXJG b3JJbWFnZTphbHRlcm5hdGVVUkw6ZGVmYXVsdEFjdGlvbnM6ZWxlbWVudEluZm86LgorICAgICAg ICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAo LVtXS0NvbnRlbnRWaWV3IF9wcmVzZW50ZWRWaWV3Q29udHJvbGxlckZvclByZXZpZXdJdGVtQ29u dHJvbGxlcjpdKTogSWYgdGhlIGltYWdlIGhhcyBhbHRlcm5hdGVkIFVSTCBvciBjdXN0b20gaW5m bywgdHJ5IHRvIHVzZSB0aGUgY2xpZW50LXByb3ZpZGVkCisgICAgICAgICAgICBwcmV2aWV3IHZp ZXcgY29udHJvbGxlci4gT3RoZXJ3aXNlLCB1c2UgdGhlIGRlZmF1bHQgV0tJbWFnZVByZXZpZXdW aWV3Q29udHJvbGxlci4KKwogMjAxNy0wMy0yMCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FA YXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBhIHBhc3RlLW8gaW4gV2ViUGF5bWVudENvb3JkaW5h dG9yUHJveHk6OnBsYXRmb3JtQ29tcGxldGVQYXltZW50U2Vzc2lvbgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1VJRGVsZWdhdGVQcml2YXRlLmggYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL0NvY29hL1dLVUlEZWxlZ2F0ZVByaXZhdGUuaApp bmRleCBjOTZkMjAxMWY3MS4uZjlhNDgyYWNhNjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tVSURlbGVnYXRlUHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tVSURlbGVnYXRlUHJpdmF0ZS5oCkBAIC04Nyw2 ICs4Nyw3IEBAIHN0cnVjdCBVSUVkZ2VJbnNldHM7CiAtIChVSVZpZXdDb250cm9sbGVyICopX3By ZXNlbnRpbmdWaWV3Q29udHJvbGxlckZvcldlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcgV0tf QVBJX0FWQUlMQUJMRShpb3MoMTAuMCkpOwogLSAodm9pZClfd2ViVmlldzooV0tXZWJWaWV3ICop d2ViVmlldyBnZXRBbHRlcm5hdGVVUkxGcm9tSW1hZ2U6KFVJSW1hZ2UgKilpbWFnZSBjb21wbGV0 aW9uSGFuZGxlcjoodm9pZCAoXikoTlNVUkwgKmFsdGVybmF0ZVVSTCwgTlNEaWN0aW9uYXJ5ICp1 c2VySW5mbykpY29tcGxldGlvbkhhbmRsZXIgV0tfQVBJX0FWQUlMQUJMRShpb3MoV0tfSU9TX1RC QSkpOwogLSAoTlNVUkwgKilfd2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldyBhbHRlcm5hdGVV UkxGcm9tSW1hZ2U6KFVJSW1hZ2UgKilpbWFnZSB1c2VySW5mbzooTlNEaWN0aW9uYXJ5ICoqKXVz ZXJJbmZvIFdLX0FQSV9BVkFJTEFCTEUoaW9zKFdLX0lPU19UQkEpKTsKKy0gKFVJVmlld0NvbnRy b2xsZXIgKilfd2ViVmlldzooV0tXZWJWaWV3ICopd2ViVmlldyBwcmV2aWV3Vmlld0NvbnRyb2xs ZXJGb3JJbWFnZTooVUlJbWFnZSAqKWltYWdlIGFsdGVybmF0ZVVSTDooTlNVUkwgKil1cmwgZGVm YXVsdEFjdGlvbnM6KE5TQXJyYXk8X1dLRWxlbWVudEFjdGlvbiAqPiAqKWFjdGlvbnMgZWxlbWVu dEluZm86KF9XS0FjdGl2YXRlZEVsZW1lbnRJbmZvICopZWxlbWVudEluZm8gV0tfQVBJX0FWQUlM QUJMRShpb3MoV0tfSU9TX1RCQSkpOwogLSAoTlNBcnJheTxVSUl0ZW1Qcm92aWRlciAqPiAqKV93 ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3IGFkanVzdGVkRGF0YUludGVyYWN0aW9uSXRlbVBy b3ZpZGVyczooTlNBcnJheTxVSUl0ZW1Qcm92aWRlciAqPiAqKW9yaWdpbmFsSXRlbVByb3ZpZGVy cyBXS19BUElfQVZBSUxBQkxFKGlvcyhXS19JT1NfVEJBKSk7CiAtIChCT09MKV93ZWJWaWV3OihX S1dlYlZpZXcgKil3ZWJWaWV3IHBlcmZvcm1EYXRhSW50ZXJhY3Rpb25PcGVyYXRpb25XaXRoSXRl bVByb3ZpZGVyczooTlNBcnJheTxVSUl0ZW1Qcm92aWRlciAqPiAqKWl0ZW1Qcm92aWRlcnMgV0tf QVBJX0FWQUlMQUJMRShpb3MoV0tfSU9TX1RCQSkpOwogI2Vsc2UKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KaW5k ZXggYmIxNzNjMTAwYmMuLjE4OTg5Yjg0ZDU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtNDMzNiw4 ICs0MzM2LDExIEBAIC0gKFVJVmlld0NvbnRyb2xsZXIgKilfcHJlc2VudGVkVmlld0NvbnRyb2xs ZXJGb3JQcmV2aWV3SXRlbUNvbnRyb2xsZXI6KFVJUHJldmllCiAgICAgICAgICAgICBbdWlEZWxl Z2F0ZSBfd2ViVmlldzpfd2ViVmlldyB3aWxsUHJldmlld0ltYWdlV2l0aFVSTDp0YXJnZXRVUkxd OwogCiAgICAgICAgIGF1dG8gZGVmYXVsdEFjdGlvbnMgPSBbX2FjdGlvblNoZWV0QXNzaXN0YW50 IGRlZmF1bHRBY3Rpb25zRm9ySW1hZ2VTaGVldDplbGVtZW50SW5mby5nZXQoKV07Ci0gICAgICAg IGlmIChpbWFnZUluZm8gJiYgW3VpRGVsZWdhdGUgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3Rv cihfd2ViVmlldzphY3Rpb25zRm9yRWxlbWVudDpkZWZhdWx0QWN0aW9uczopXSkKLSAgICAgICAg ICAgIGRlZmF1bHRBY3Rpb25zID0gW3VpRGVsZWdhdGUgX3dlYlZpZXc6X3dlYlZpZXcgYWN0aW9u c0ZvckVsZW1lbnQ6ZWxlbWVudEluZm8uZ2V0KCkgZGVmYXVsdEFjdGlvbnM6ZGVmYXVsdEFjdGlv bnMuZ2V0KCldOworICAgICAgICBpZiAoaW1hZ2VJbmZvICYmIFt1aURlbGVnYXRlIHJlc3BvbmRz VG9TZWxlY3RvcjpAc2VsZWN0b3IoX3dlYlZpZXc6cHJldmlld1ZpZXdDb250cm9sbGVyRm9ySW1h Z2U6YWx0ZXJuYXRlVVJMOmRlZmF1bHRBY3Rpb25zOmVsZW1lbnRJbmZvOildKSB7CisgICAgICAg ICAgICBVSVZpZXdDb250cm9sbGVyICpwcmV2aWV3Vmlld0NvbnRyb2xsZXIgPSBbdWlEZWxlZ2F0 ZSBfd2ViVmlldzpfd2ViVmlldyBwcmV2aWV3Vmlld0NvbnRyb2xsZXJGb3JJbWFnZTp1aUltYWdl LmdldCgpIGFsdGVybmF0ZVVSTDphbHRlcm5hdGVVUkwuZ2V0KCkgZGVmYXVsdEFjdGlvbnM6ZGVm YXVsdEFjdGlvbnMuZ2V0KCkgZWxlbWVudEluZm86ZWxlbWVudEluZm8uZ2V0KCldOworICAgICAg ICAgICAgaWYgKHByZXZpZXdWaWV3Q29udHJvbGxlcikKKyAgICAgICAgICAgICAgICByZXR1cm4g cHJldmlld1ZpZXdDb250cm9sbGVyOworICAgICAgICB9CiAKICAgICAgICAgcmV0dXJuIFtbW1dL SW1hZ2VQcmV2aWV3Vmlld0NvbnRyb2xsZXIgYWxsb2NdIGluaXRXaXRoQ0dJbWFnZTpjZ0ltYWdl IGRlZmF1bHRBY3Rpb25zOmRlZmF1bHRBY3Rpb25zIGVsZW1lbnRJbmZvOmVsZW1lbnRJbmZvXSBh dXRvcmVsZWFzZV07CiAgICAgfQo=