170065 2017-03-24 11:28:38 -0700 Web Inspector: Resource Details Sidebar displays previous image metrics when viewing resource where content load failed 2017-03-27 16:19:28 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bfulgham commit-queue inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1290887 0 joepeck 2017-03-24 11:28:38 -0700 Summary: Resource Details Sidebar displays previous image metrics when viewing resource where content load failed Steps to Reproduce: 1. Inspect https://web.whatsapp.com 2. Reload so we get all Image resources 3. Select a data:image/png image resource => Details Sidebar shows correct image size 4. Select a data:image/webp image resource => Details Sidebar shows previous image's size Notes: The frontend failed to load the content, so it should return a failure to the sidebar to update its display in some way (either dashes or remove the section). 1290888 1 joepeck 2017-03-24 11:28:52 -0700 <rdar://problem/27081591> 1290890 2 305306 joepeck 2017-03-24 11:30:08 -0700 Created attachment 305306 [PATCH] Proposed Fix 1290891 3 305306 joepeck 2017-03-24 11:30:48 -0700 Comment on attachment 305306 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=305306&action=review > Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js:458 > + } else > + hideImageSection.call(this); An alternative would be to show the section and have emdash values. But seeing as we hide the section above if the `resource.failed` I matched that here. 1291654 4 305306 mattbaker 2017-03-27 15:50:07 -0700 Comment on attachment 305306 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=305306&action=review >> Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSidebarPanel.js:458 >> + hideImageSection.call(this); > > An alternative would be to show the section and have emdash values. But seeing as we hide the section above if the `resource.failed` I matched that here. r=me. I like this approach, rather than showing emdash values. Cuts down on clutter. 1291664 5 305306 commit-queue 2017-03-27 16:19:25 -0700 Comment on attachment 305306 [PATCH] Proposed Fix Clearing flags on attachment: 305306 Committed r214436: <http://trac.webkit.org/changeset/214436> 1291665 6 commit-queue 2017-03-27 16:19:28 -0700 All reviewed patches have been landed. Closing bug. 305306 2017-03-24 11:30:08 -0700 2017-03-27 16:19:25 -0700 [PATCH] Proposed Fix imagesize-1.patch text/plain 5129 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDdlOTcyYjQ4NzRiLi44YzZmODFjYjYyZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTctMDMtMjQgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBSZXNvdXJjZSBEZXRhaWxzIFNpZGViYXIgZGlzcGxheXMgcHJldmlvdXMgaW1hZ2UgbWV0cmlj cyB3aGVuIHZpZXdpbmcgcmVzb3VyY2Ugd2hlcmUgY29udGVudCBsb2FkIGZhaWxlZAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwMDY1CisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS8yNzA4MTU5MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvTW9kZWxzL1Jlc291cmNlLmpzOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLlJlc291cmNlLnByb3RvdHlwZS5nZXRJbWFnZVNpemUuaW1h Z2VEaWRMb2FkKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5SZXNvdXJjZS5wcm90b3R5cGUuZ2V0 SW1hZ2VTaXplLnJlcXVlc3RDb250ZW50RmFpbHVyZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu UmVzb3VyY2UucHJvdG90eXBlLmdldEltYWdlU2l6ZSk6CisgICAgICAgIElmIHRoZSByZXF1ZXN0 Q29udGVudCBmYWlsZWQsIHJldHVybiBhIG51bGwgaW1hZ2Ugc2l6ZS4KKworICAgICAgICAqIFVz ZXJJbnRlcmZhY2UvVmlld3MvUmVzb3VyY2VEZXRhaWxzU2lkZWJhclBhbmVsLmpzOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLlJlc291cmNlRGV0YWlsc1NpZGViYXJQYW5lbC5wcm90b3R5cGUuX3Jl ZnJlc2hJbWFnZVNpemVTZWN0aW9uLmhpZGVJbWFnZVNlY3Rpb24pOgorICAgICAgICAoV2ViSW5z cGVjdG9yLlJlc291cmNlRGV0YWlsc1NpZGViYXJQYW5lbC5wcm90b3R5cGUuX3JlZnJlc2hJbWFn ZVNpemVTZWN0aW9uKToKKyAgICAgICAgSWYgdGhlIGNhbGxiYWNrIGlzIGNhbGxlZCB3aXRoIGEg bnVsbCBzaXplLCBoaWRlIHRoZSBpbWFnZSBzaXplIHNlY3Rpb24uCisKIDIwMTctMDMtMjMgIEpv c2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVj dG9yOiBDYWNoZSB0eXBlIGlzIG5vdCBzdHlsZWQgY29ycmVjdGx5IGluIFRpbWVsaW5lcyB0YWIK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9S ZXNvdXJjZS5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9S ZXNvdXJjZS5qcwppbmRleCAzZjQ3YjA0MmJiNC4uZWZhMzg0YjA3ZDkgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9SZXNvdXJjZS5qcworKysg Yi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMvUmVzb3VyY2UuanMK QEAgLTY5OSw3ICs2OTksNyBAQCBXZWJJbnNwZWN0b3IuUmVzb3VyY2UgPSBjbGFzcyBSZXNvdXJj ZSBleHRlbmRzIFdlYkluc3BlY3Rvci5Tb3VyY2VDb2RlCiAKICAgICAgICAgLy8gU2VlIGlmIHdl J3ZlIGFscmVhZHkgY29tcHV0ZWQgYW5kIGNhY2hlZCB0aGUgaW1hZ2Ugc2l6ZSwKICAgICAgICAg Ly8gaW4gd2hpY2ggY2FzZSB3ZSBjYW4gcHJvdmlkZSB0aGVtIGRpcmVjdGx5LgotICAgICAgICBp ZiAodGhpcy5faW1hZ2VTaXplKSB7CisgICAgICAgIGlmICh0aGlzLl9pbWFnZVNpemUgIT09IHVu ZGVmaW5lZCkgewogICAgICAgICAgICAgY2FsbGJhY2sodGhpcy5faW1hZ2VTaXplKTsKICAgICAg ICAgICAgIHJldHVybjsKICAgICAgICAgfQpAQCAtNzA3LDggKzcwNyw3IEBAIFdlYkluc3BlY3Rv ci5SZXNvdXJjZSA9IGNsYXNzIFJlc291cmNlIGV4dGVuZHMgV2ViSW5zcGVjdG9yLlNvdXJjZUNv ZGUKICAgICAgICAgdmFyIG9iamVjdFVSTCA9IG51bGw7CiAKICAgICAgICAgLy8gRXZlbnQgaGFu ZGxlciBmb3IgdGhlIGltYWdlICJsb2FkIiBldmVudC4KLSAgICAgICAgZnVuY3Rpb24gaW1hZ2VE aWRMb2FkKCkKLSAgICAgICAgeworICAgICAgICBmdW5jdGlvbiBpbWFnZURpZExvYWQoKSB7CiAg ICAgICAgICAgICBVUkwucmV2b2tlT2JqZWN0VVJMKG9iamVjdFVSTCk7CiAKICAgICAgICAgICAg IC8vIENhY2hlIHRoZSBpbWFnZSBtZXRyaWNzLgpAQCAtNzIwLDYgKzcxOSwxMSBAQCBXZWJJbnNw ZWN0b3IuUmVzb3VyY2UgPSBjbGFzcyBSZXNvdXJjZSBleHRlbmRzIFdlYkluc3BlY3Rvci5Tb3Vy Y2VDb2RlCiAgICAgICAgICAgICBjYWxsYmFjayh0aGlzLl9pbWFnZVNpemUpOwogICAgICAgICB9 CiAKKyAgICAgICAgZnVuY3Rpb24gcmVxdWVzdENvbnRlbnRGYWlsdXJlKCkgeworICAgICAgICAg ICAgdGhpcy5faW1hZ2VTaXplID0gbnVsbDsKKyAgICAgICAgICAgIGNhbGxiYWNrKHRoaXMuX2lt YWdlU2l6ZSk7CisgICAgICAgIH0KKwogICAgICAgICAvLyBDcmVhdGUgYW4gPGltZz4gZWxlbWVu dCB0aGF0IHdlJ2xsIHVzZSB0byBsb2FkIHRoZSBpbWFnZSByZXNvdXJjZQogICAgICAgICAvLyBz byB0aGF0IHdlIGNhbiBxdWVyeSBpdHMgaW50cmluc2ljIHNpemUuCiAgICAgICAgIHZhciBpbWFn ZSA9IG5ldyBJbWFnZTsKQEAgLTcyOCw3ICs3MzIsNyBAQCBXZWJJbnNwZWN0b3IuUmVzb3VyY2Ug PSBjbGFzcyBSZXNvdXJjZSBleHRlbmRzIFdlYkluc3BlY3Rvci5Tb3VyY2VDb2RlCiAgICAgICAg IC8vIFNldCB0aGUgaW1hZ2Ugc291cmNlIHVzaW5nIGFuIG9iamVjdCBVUkwgb25jZSB3ZSd2ZSBv YnRhaW5lZCBpdHMgZGF0YS4KICAgICAgICAgdGhpcy5yZXF1ZXN0Q29udGVudCgpLnRoZW4oZnVu Y3Rpb24oY29udGVudCkgewogICAgICAgICAgICAgb2JqZWN0VVJMID0gaW1hZ2Uuc3JjID0gY29u dGVudC5zb3VyY2VDb2RlLmNyZWF0ZU9iamVjdFVSTCgpOwotICAgICAgICB9KTsKKyAgICAgICAg fSwgcmVxdWVzdENvbnRlbnRGYWlsdXJlLmJpbmQodGhpcykpOwogICAgIH0KIAogICAgIHJlcXVl c3RDb250ZW50KCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL1Jlc291cmNlRGV0YWlsc1NpZGViYXJQYW5lbC5qcyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlRGV0YWlsc1NpZGViYXJQYW5lbC5q cwppbmRleCBlMmQ0YzY2MWFjMy4uOTUwNDc0ZDA1NDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlRGV0YWlsc1NpZGViYXJQYW5l bC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZXNv dXJjZURldGFpbHNTaWRlYmFyUGFuZWwuanMKQEAgLTQzNCwxMSArNDM0LDE1IEBAIFdlYkluc3Bl Y3Rvci5SZXNvdXJjZURldGFpbHNTaWRlYmFyUGFuZWwgPSBjbGFzcyBSZXNvdXJjZURldGFpbHNT aWRlYmFyUGFuZWwgZXh0CiAgICAgICAgIGlmICghcmVzb3VyY2UpCiAgICAgICAgICAgICByZXR1 cm47CiAKLSAgICAgICAgLy8gSGlkZSB0aGUgc2VjdGlvbiBpZiB3ZSdyZSBub3QgZGVhbGluZyB3 aXRoIGFuIGltYWdlIG9yIGlmIHRoZSBsb2FkIGZhaWxlZC4KLSAgICAgICAgaWYgKHJlc291cmNl LnR5cGUgIT09IFdlYkluc3BlY3Rvci5SZXNvdXJjZS5UeXBlLkltYWdlIHx8IHJlc291cmNlLmZh aWxlZCkgewotICAgICAgICAgICAgdmFyIGltYWdlU2VjdGlvbkVsZW1lbnQgPSB0aGlzLl9pbWFn ZVNpemVTZWN0aW9uLmVsZW1lbnQ7CisgICAgICAgIGZ1bmN0aW9uIGhpZGVJbWFnZVNlY3Rpb24o KSB7CisgICAgICAgICAgICBsZXQgaW1hZ2VTZWN0aW9uRWxlbWVudCA9IHRoaXMuX2ltYWdlU2l6 ZVNlY3Rpb24uZWxlbWVudDsKICAgICAgICAgICAgIGlmIChpbWFnZVNlY3Rpb25FbGVtZW50LnBh cmVudE5vZGUpCiAgICAgICAgICAgICAgICAgdGhpcy5jb250ZW50Vmlldy5lbGVtZW50LnJlbW92 ZUNoaWxkKGltYWdlU2VjdGlvbkVsZW1lbnQpOworICAgICAgICB9CisKKyAgICAgICAgLy8gSGlk ZSB0aGUgc2VjdGlvbiBpZiB3ZSdyZSBub3QgZGVhbGluZyB3aXRoIGFuIGltYWdlIG9yIGlmIHRo ZSBsb2FkIGZhaWxlZC4KKyAgICAgICAgaWYgKHJlc291cmNlLnR5cGUgIT09IFdlYkluc3BlY3Rv ci5SZXNvdXJjZS5UeXBlLkltYWdlIHx8IHJlc291cmNlLmZhaWxlZCkgeworICAgICAgICAgICAg aGlkZUltYWdlU2VjdGlvbi5jYWxsKHRoaXMpOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAg ICB9CiAKQEAgLTQ0Nyw4ICs0NTEsMTEgQEAgV2ViSW5zcGVjdG9yLlJlc291cmNlRGV0YWlsc1Np ZGViYXJQYW5lbCA9IGNsYXNzIFJlc291cmNlRGV0YWlsc1NpZGViYXJQYW5lbCBleHQKIAogICAg ICAgICAvLyBHZXQgdGhlIG1ldHJpY3MgZm9yIHRoaXMgcmVzb3VyY2UgYW5kIGZpbGwgaW4gdGhl IG1ldHJpY3Mgcm93cyB3aXRoIHRoYXQgaW5mb3JtYXRpb24uCiAgICAgICAgIHJlc291cmNlLmdl dEltYWdlU2l6ZSgoc2l6ZSkgPT4gewotICAgICAgICAgICAgdGhpcy5faW1hZ2VXaWR0aFJvdy52 YWx1ZSA9IFdlYkluc3BlY3Rvci5VSVN0cmluZygiJWRweCIpLmZvcm1hdChzaXplLndpZHRoKTsK LSAgICAgICAgICAgIHRoaXMuX2ltYWdlSGVpZ2h0Um93LnZhbHVlID0gV2ViSW5zcGVjdG9yLlVJ U3RyaW5nKCIlZHB4IikuZm9ybWF0KHNpemUuaGVpZ2h0KTsKKyAgICAgICAgICAgIGlmIChzaXpl KSB7CisgICAgICAgICAgICAgICAgdGhpcy5faW1hZ2VXaWR0aFJvdy52YWx1ZSA9IFdlYkluc3Bl Y3Rvci5VSVN0cmluZygiJWRweCIpLmZvcm1hdChzaXplLndpZHRoKTsKKyAgICAgICAgICAgICAg ICB0aGlzLl9pbWFnZUhlaWdodFJvdy52YWx1ZSA9IFdlYkluc3BlY3Rvci5VSVN0cmluZygiJWRw eCIpLmZvcm1hdChzaXplLmhlaWdodCk7CisgICAgICAgICAgICB9IGVsc2UKKyAgICAgICAgICAg ICAgICBoaWRlSW1hZ2VTZWN0aW9uLmNhbGwodGhpcyk7CiAgICAgICAgIH0pOwogICAgIH0KIAo=