<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>17006</bug_id>
          
          <creation_ts>2008-01-25 07:17:31 -0800</creation_ts>
          <short_desc>[GTK] Header path should be webkit/webkit.h</short_desc>
          <delta_ts>2008-01-31 16:31:29 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Gtk</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Alp Toker">alp</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>jmalonzo</cc>
    
    <cc>mrowe</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>68210</commentid>
    <comment_count>0</comment_count>
    <who name="Alp Toker">alp</who>
    <bug_when>2008-01-25 07:17:31 -0800</bug_when>
    <thetext>Right now, GTK+ API headers get installed into the top level include directory, eg. /usr/include/WebKitGtk/*.h

This means that developers do this in applications:

#include &lt;webkit.h&gt;

Our own webkit.h looks like this:

#ifndef __WEBKIT_H__
#define __WEBKIT_H__

#include &lt;webkitdefines.h&gt;
#include &lt;webkitnetworkrequest.h&gt;
#include &lt;webkitwebframe.h&gt;
#include &lt;webkitwebsettings.h&gt;
#include &lt;webkitwebview.h&gt;

#endif /* __WEBKIT_H__ */


I propose that we rename WebKit/gtk/WebView to WebKit/gtk/webkit to allow:

#include &lt;webkit/webkit.h&gt;

This matches GTK+ module conventions.

The alternative is to use ForwardingHeaders, which would help avoid the renaming in SVN, but the benefits of this aren&apos;t too clear for non-Apple APIs, and it would add maintenance overhead.

All in favour of renaming this directory and updating the necessary build systems and headers?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>68980</commentid>
    <comment_count>1</comment_count>
    <who name="Alp Toker">alp</who>
    <bug_when>2008-01-31 16:31:29 -0800</bug_when>
    <thetext>Fix landed in r29898.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>