170054 2017-03-24 09:12:12 -0700 Web Inspector: allow users to click links in inline/user-agent styles 2017-03-24 12:36:46 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 hi hi commit-queue inspector-bugzilla-changes oldest_to_newest 1290810 0 hi 2017-03-24 09:12:12 -0700 If the inline style of an element contains a url(), the user should be able to Option-Click to open the resource in Resources or New Tab. 1290815 1 305287 hi 2017-03-24 09:25:09 -0700 Created attachment 305287 Patch 1290908 2 305287 joepeck 2017-03-24 11:57:09 -0700 Comment on attachment 305287 Patch r=me 1290939 3 305287 commit-queue 2017-03-24 12:36:43 -0700 Comment on attachment 305287 Patch Clearing flags on attachment: 305287 Committed r214366: <http://trac.webkit.org/changeset/214366> 1290940 4 commit-queue 2017-03-24 12:36:46 -0700 All reviewed patches have been landed. Closing bug. 305287 2017-03-24 09:25:09 -0700 2017-03-24 12:36:43 -0700 Patch bug-170054-20170324092509.patch text/plain 6535 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGJmNTEzYTgxZmNhMzA0MmQ3ZGU0OGVmMzQyNzg0 MzQyNDk5ZDZjMzQuLjg4ZTZkODhmZWNmZmQ0YjIwYzcxZThjODA3N2ZjNTE4MTZkYzhlNjEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTAzLTI0ICBEZXZp biBSb3Vzc28gIDx3ZWJraXRAZGV2aW5yb3Vzc28uY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IGFsbG93IHVzZXJzIHRvIGNsaWNrIGxpbmtzIGluIGlubGluZS91c2VyLWFnZW50IHN0eWxl cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwMDU0 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2Vy SW50ZXJmYWNlL1ZpZXdzL0NTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yLmpzOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLkNTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yLnByb3RvdHlwZS5z ZXQgc3R5bGUpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNTU1N0eWxlRGVjbGFyYXRpb25UZXh0 RWRpdG9yLnByb3RvdHlwZS5fdXBkYXRlSnVtcFRvU3ltYm9sVHJhY2tpbmdNb2RlKToKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5DU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRvci5wcm90b3R5cGUu dG9rZW5UcmFja2luZ0NvbnRyb2xsZXJIaWdobGlnaHRlZFJhbmdlV2FzQ2xpY2tlZCk6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRFZGl0b3IucHJvdG90eXBl LnRva2VuVHJhY2tpbmdDb250cm9sbGVyTmV3SGlnaGxpZ2h0Q2FuZGlkYXRlKToKKyAgICAgICAg QWx3YXlzIGVuYWJsZSB0aGUgdG9rZW4gdHJhY2tpbmcgY29udHJvbGxlciwgYnV0IG9ubHkgYWN0 IG9uIGhvdmVyZWQvY2xpY2tlZCB0b2tlbiBpZiBpdCBpcworICAgICAgICBhIGxpbmsgb3IgdGhl IG93bmVyIHN0eWxlIGRlY2xhcmF0aW9uIGhhcyBhIHNvdXJjZSBjb2RlIGxvY2F0aW9uIChmb3Ig anVtcGluZyB0byB0aGUgUmVzb3VyY2UpLgorCiAyMDE3LTAzLTIzICBKb3NlcGggUGVjb3Jhcm8g IDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogQ2FjaGUgdHlw ZSBpcyBub3Qgc3R5bGVkIGNvcnJlY3RseSBpbiBUaW1lbGluZXMgdGFiCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DU1NTdHlsZURlY2xhcmF0 aW9uVGV4dEVkaXRvci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1Zp ZXdzL0NTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yLmpzCmluZGV4IDI0NWQ2NjI0YzI5MDY4 NGM3Y2UyYmEwYjUzMmU1ZTA4ODRhMzc2ODkuLmY2NmU1NmZlNjI5NmVmOTk2NTE1MTE0ZjlhNGMw NWY0MzZkNWU3MjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL0NTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yLmpzCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NTU1N0eWxlRGVjbGFyYXRpb25UZXh0 RWRpdG9yLmpzCkBAIC0xMDksMTYgKzEwOSwxNCBAQCBXZWJJbnNwZWN0b3IuQ1NTU3R5bGVEZWNs YXJhdGlvblRleHRFZGl0b3IgPSBjbGFzcyBDU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRvcgog CiAgICAgICAgIGlmICh0aGlzLl9zdHlsZSkgewogICAgICAgICAgICAgdGhpcy5fc3R5bGUucmVt b3ZlRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuQ1NTU3R5bGVEZWNsYXJhdGlvbi5FdmVudC5Q cm9wZXJ0aWVzQ2hhbmdlZCwgdGhpcy5fcHJvcGVydGllc0NoYW5nZWQsIHRoaXMpOwotICAgICAg ICAgICAgaWYgKHRoaXMuX3N0eWxlLm93bmVyUnVsZSAmJiB0aGlzLl9zdHlsZS5vd25lclJ1bGUu c291cmNlQ29kZUxvY2F0aW9uKQotICAgICAgICAgICAgICAgIFdlYkluc3BlY3Rvci5ub3RpZmlj YXRpb25zLnJlbW92ZUV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLk5vdGlmaWNhdGlvbi5HbG9i YWxNb2RpZmllcktleXNEaWRDaGFuZ2UsIHRoaXMuX3VwZGF0ZUp1bXBUb1N5bWJvbFRyYWNraW5n TW9kZSwgdGhpcyk7CisgICAgICAgICAgICBXZWJJbnNwZWN0b3Iubm90aWZpY2F0aW9ucy5yZW1v dmVFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5Ob3RpZmljYXRpb24uR2xvYmFsTW9kaWZpZXJL ZXlzRGlkQ2hhbmdlLCB0aGlzLl91cGRhdGVKdW1wVG9TeW1ib2xUcmFja2luZ01vZGUsIHRoaXMp OwogICAgICAgICB9CiAKICAgICAgICAgdGhpcy5fc3R5bGUgPSBzdHlsZSB8fCBudWxsOwogCiAg ICAgICAgIGlmICh0aGlzLl9zdHlsZSkgewogICAgICAgICAgICAgdGhpcy5fc3R5bGUuYWRkRXZl bnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuQ1NTU3R5bGVEZWNsYXJhdGlvbi5FdmVudC5Qcm9wZXJ0 aWVzQ2hhbmdlZCwgdGhpcy5fcHJvcGVydGllc0NoYW5nZWQsIHRoaXMpOwotICAgICAgICAgICAg aWYgKHRoaXMuX3N0eWxlLm93bmVyUnVsZSAmJiB0aGlzLl9zdHlsZS5vd25lclJ1bGUuc291cmNl Q29kZUxvY2F0aW9uKQotICAgICAgICAgICAgICAgIFdlYkluc3BlY3Rvci5ub3RpZmljYXRpb25z LmFkZEV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9yLk5vdGlmaWNhdGlvbi5HbG9iYWxNb2RpZmll cktleXNEaWRDaGFuZ2UsIHRoaXMuX3VwZGF0ZUp1bXBUb1N5bWJvbFRyYWNraW5nTW9kZSwgdGhp cyk7CisgICAgICAgICAgICBXZWJJbnNwZWN0b3Iubm90aWZpY2F0aW9ucy5hZGRFdmVudExpc3Rl bmVyKFdlYkluc3BlY3Rvci5Ob3RpZmljYXRpb24uR2xvYmFsTW9kaWZpZXJLZXlzRGlkQ2hhbmdl LCB0aGlzLl91cGRhdGVKdW1wVG9TeW1ib2xUcmFja2luZ01vZGUsIHRoaXMpOwogICAgICAgICB9 CiAKICAgICAgICAgdGhpcy5fdXBkYXRlSnVtcFRvU3ltYm9sVHJhY2tpbmdNb2RlKCk7CkBAIC0x Njk0LDcgKzE2OTIsNyBAQCBXZWJJbnNwZWN0b3IuQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRFZGl0 b3IgPSBjbGFzcyBDU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRvcgogICAgIHsKICAgICAgICAg dmFyIG9sZEp1bXBUb1N5bWJvbFRyYWNraW5nTW9kZUVuYWJsZWQgPSB0aGlzLl9qdW1wVG9TeW1i b2xUcmFja2luZ01vZGVFbmFibGVkOwogCi0gICAgICAgIGlmICghdGhpcy5fc3R5bGUgfHwgIXRo aXMuX3N0eWxlLm93bmVyUnVsZSB8fCAhdGhpcy5fc3R5bGUub3duZXJSdWxlLnNvdXJjZUNvZGVM b2NhdGlvbikKKyAgICAgICAgaWYgKCF0aGlzLl9zdHlsZSkKICAgICAgICAgICAgIHRoaXMuX2p1 bXBUb1N5bWJvbFRyYWNraW5nTW9kZUVuYWJsZWQgPSBmYWxzZTsKICAgICAgICAgZWxzZQogICAg ICAgICAgICAgdGhpcy5fanVtcFRvU3ltYm9sVHJhY2tpbmdNb2RlRW5hYmxlZCA9IFdlYkluc3Bl Y3Rvci5tb2RpZmllcktleXMuYWx0S2V5ICYmICFXZWJJbnNwZWN0b3IubW9kaWZpZXJLZXlzLm1l dGFLZXkgJiYgIVdlYkluc3BlY3Rvci5tb2RpZmllcktleXMuc2hpZnRLZXk7CkBAIC0xNzAyLDcg KzE3MDAsNyBAQCBXZWJJbnNwZWN0b3IuQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRFZGl0b3IgPSBj bGFzcyBDU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRvcgogICAgICAgICBpZiAob2xkSnVtcFRv U3ltYm9sVHJhY2tpbmdNb2RlRW5hYmxlZCAhPT0gdGhpcy5fanVtcFRvU3ltYm9sVHJhY2tpbmdN b2RlRW5hYmxlZCkgewogICAgICAgICAgICAgaWYgKHRoaXMuX2p1bXBUb1N5bWJvbFRyYWNraW5n TW9kZUVuYWJsZWQpIHsKICAgICAgICAgICAgICAgICB0aGlzLl90b2tlblRyYWNraW5nQ29udHJv bGxlci5oaWdobGlnaHRMYXN0SG92ZXJlZFJhbmdlKCk7Ci0gICAgICAgICAgICAgICAgdGhpcy5f dG9rZW5UcmFja2luZ0NvbnRyb2xsZXIuZW5hYmxlZCA9ICF0aGlzLl9jb2RlTWlycm9yLmdldE9w dGlvbigicmVhZE9ubHkiKTsKKyAgICAgICAgICAgICAgICB0aGlzLl90b2tlblRyYWNraW5nQ29u dHJvbGxlci5lbmFibGVkID0gdHJ1ZTsKICAgICAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAg ICAgICAgdGhpcy5fdG9rZW5UcmFja2luZ0NvbnRyb2xsZXIucmVtb3ZlSGlnaGxpZ2h0ZWRSYW5n ZSgpOwogICAgICAgICAgICAgICAgIHRoaXMuX3Rva2VuVHJhY2tpbmdDb250cm9sbGVyLmVuYWJs ZWQgPSBmYWxzZTsKQEAgLTE3MTIsMjYgKzE3MTAsMzMgQEAgV2ViSW5zcGVjdG9yLkNTU1N0eWxl RGVjbGFyYXRpb25UZXh0RWRpdG9yID0gY2xhc3MgQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRFZGl0 b3IKIAogICAgIHRva2VuVHJhY2tpbmdDb250cm9sbGVySGlnaGxpZ2h0ZWRSYW5nZVdhc0NsaWNr ZWQodG9rZW5UcmFja2luZ0NvbnRyb2xsZXIpCiAgICAgewotICAgICAgICBsZXQgc291cmNlQ29k ZUxvY2F0aW9uID0gdGhpcy5fc3R5bGUub3duZXJSdWxlLnNvdXJjZUNvZGVMb2NhdGlvbjsKLSAg ICAgICAgY29uc29sZS5hc3NlcnQoc291cmNlQ29kZUxvY2F0aW9uKTsKLSAgICAgICAgaWYgKCFz b3VyY2VDb2RlTG9jYXRpb24pCi0gICAgICAgICAgICByZXR1cm47Ci0KICAgICAgICAgbGV0IGNh bmRpZGF0ZSA9IHRva2VuVHJhY2tpbmdDb250cm9sbGVyLmNhbmRpZGF0ZTsKICAgICAgICAgY29u c29sZS5hc3NlcnQoY2FuZGlkYXRlKTsKICAgICAgICAgaWYgKCFjYW5kaWRhdGUpCiAgICAgICAg ICAgICByZXR1cm47CiAKKyAgICAgICAgbGV0IHNvdXJjZUNvZGVMb2NhdGlvbiA9IG51bGw7Cisg ICAgICAgIGlmICh0aGlzLl9zdHlsZS5vd25lclJ1bGUpCisgICAgICAgICAgICBzb3VyY2VDb2Rl TG9jYXRpb24gPSB0aGlzLl9zdHlsZS5vd25lclJ1bGUuc291cmNlQ29kZUxvY2F0aW9uOworCiAg ICAgICAgIGxldCB0b2tlbiA9IGNhbmRpZGF0ZS5ob3ZlcmVkVG9rZW47CiAKLSAgICAgICAgLy8g U3BlY2lhbCBjYXNlIGNvbW1hbmQgY2xpY2tpbmcgdXJsKC4uLikgbGlua3MuCisgICAgICAgIC8v IFNwZWNpYWwgY2FzZSBvcHRpb24tY2xpY2tpbmcgdXJsKC4uLikgbGlua3MuCiAgICAgICAgIGlm ICh0b2tlbiAmJiAvXGJsaW5rXGIvLnRlc3QodG9rZW4udHlwZSkpIHsKICAgICAgICAgICAgIGxl dCB1cmwgPSB0b2tlbi5zdHJpbmc7Ci0gICAgICAgICAgICBsZXQgYmFzZVVSTCA9IHNvdXJjZUNv ZGVMb2NhdGlvbi5zb3VyY2VDb2RlLnVybDsKKyAgICAgICAgICAgIGxldCBiYXNlVVJMID0gc291 cmNlQ29kZUxvY2F0aW9uID8gc291cmNlQ29kZUxvY2F0aW9uLnNvdXJjZUNvZGUudXJsIDogdGhp cy5fc3R5bGUubm9kZS5vd25lckRvY3VtZW50LmRvY3VtZW50VVJMOwogICAgICAgICAgICAgV2Vi SW5zcGVjdG9yLm9wZW5VUkwoYWJzb2x1dGVVUkwodXJsLCBiYXNlVVJMKSk7CiAgICAgICAgICAg ICByZXR1cm47CiAgICAgICAgIH0KIAorICAgICAgICAvLyBPbmx5IGFsbG93IG90aGVyIHRleHQg dG8gYmUgY2xpY2tlZCBpZiB0aGVyZSBpcyBhIHNvdXJjZSBjb2RlIGxvY2F0aW9uLgorICAgICAg ICBpZiAoIXRoaXMuX3N0eWxlLm93bmVyUnVsZSB8fCAhdGhpcy5fc3R5bGUub3duZXJSdWxlLnNv dXJjZUNvZGVMb2NhdGlvbikKKyAgICAgICAgICAgIHJldHVybjsKKworICAgICAgICBjb25zb2xl LmFzc2VydChzb3VyY2VDb2RlTG9jYXRpb24pOworICAgICAgICBpZiAoIXNvdXJjZUNvZGVMb2Nh dGlvbikKKyAgICAgICAgICAgIHJldHVybjsKKwogICAgICAgICBmdW5jdGlvbiBzaG93UmFuZ2VJ blNvdXJjZUNvZGUoc291cmNlQ29kZSwgcmFuZ2UpCiAgICAgICAgIHsKICAgICAgICAgICAgIGlm ICghc291cmNlQ29kZSB8fCAhcmFuZ2UpCkBAIC0xNzYwLDYgKzE3NjUsMTMgQEAgV2ViSW5zcGVj dG9yLkNTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yID0gY2xhc3MgQ1NTU3R5bGVEZWNsYXJh dGlvblRleHRFZGl0b3IKIAogICAgIHRva2VuVHJhY2tpbmdDb250cm9sbGVyTmV3SGlnaGxpZ2h0 Q2FuZGlkYXRlKHRva2VuVHJhY2tpbmdDb250cm9sbGVyLCBjYW5kaWRhdGUpCiAgICAgeworICAg ICAgICAvLyBEbyBub3QgaGlnaGxpZ2h0IGlmIHRoZSBzdHlsZSBoYXMgbm8gc291cmNlIGNvZGUg bG9jYXRpb24uCisgICAgICAgIGlmICghdGhpcy5fc3R5bGUub3duZXJSdWxlIHx8ICF0aGlzLl9z dHlsZS5vd25lclJ1bGUuc291cmNlQ29kZUxvY2F0aW9uKSB7CisgICAgICAgICAgICAvLyBTcGVj aWFsIGNhc2Ugb3B0aW9uLWNsaWNraW5nIHVybCguLi4pIGxpbmtzLgorICAgICAgICAgICAgaWYg KCFjYW5kaWRhdGUuaG92ZXJlZFRva2VuIHx8ICEvXGJsaW5rXGIvLnRlc3QoY2FuZGlkYXRlLmhv dmVyZWRUb2tlbi50eXBlKSkKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKwog ICAgICAgICB0aGlzLl90b2tlblRyYWNraW5nQ29udHJvbGxlci5oaWdobGlnaHRSYW5nZShjYW5k aWRhdGUuaG92ZXJlZFRva2VuUmFuZ2UpOwogICAgIH0KIH07Cg==