170049 2017-03-24 04:20:23 -0700 [GStreamer] MediaPlayerPrivateGStreamerOwr shouldn't be the default engine 2017-03-24 05:51:06 -0700 1 1 1 Unclassified WebKit Platform WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply zan oldest_to_newest 1290771 0 cgarcia 2017-03-24 04:20:23 -0700 This is causing several media tests to fail after r214338. When trying to load something like this: http://127.0.0.1:8000/media/resources/serve-video.php?name=../../../../media/content/silence.wav&type=audio/wav&content-length=no&icy-data=yes since r214338, the content type is known and inferred from the extension in this case, what ends up calling nextMediaEngine() in MediaPlayer::loadWithNextMediaEngine. That returns the first registered media engine, that is Owr that doesn't know how to load that and fails. 1290772 1 305274 cgarcia 2017-03-24 04:26:31 -0700 Created attachment 305274 Patch 1290776 2 305276 cgarcia 2017-03-24 05:00:07 -0700 Created attachment 305276 Patch ChangeLog updated with the tests fixed by this. 1290781 3 cgarcia 2017-03-24 05:51:06 -0700 Committed r214341: <http://trac.webkit.org/changeset/214341> 305274 2017-03-24 04:26:31 -0700 2017-03-24 05:00:07 -0700 Patch wcore-gst-owr.diff text/plain 2525 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzYWIxMDVjOGI4OC4uMTQzMjFlNzJjZjYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMyBAQAogMjAxNy0wMy0yNCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CiAKKyAgICAgICAgW0dTdHJlYW1lcl0gTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVh bWVyT3dyIHNob3VsZG4ndCBiZSB0aGUgZGVmYXVsdCBlbmdpbmUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDA0OQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgY2F1c2luZyBzZXZlcmFsIG1l ZGlhIHRlc3RzIHRvIGZhaWwgYWZ0ZXIgcjIxNDMzOC4gV2hlbiB0cnlpbmcgdG8gbG9hZCBzb21l dGhpbmcgbGlrZSB0aGlzOgorCisgICAgICAgIGh0dHA6Ly8xMjcuMC4wLjE6ODAwMC9tZWRpYS9y ZXNvdXJjZXMvc2VydmUtdmlkZW8ucGhwP25hbWU9Li4vLi4vLi4vLi4vbWVkaWEvY29udGVudC9z aWxlbmNlLndhdiZ0eXBlPWF1ZGlvL3dhdiZjb250ZW50LWxlbmd0aD1ubyZpY3ktZGF0YT15ZXMK KworICAgICAgICBzaW5jZSByMjE0MzM4LCB0aGUgY29udGVudCB0eXBlIGlzIGtub3duIGFuZCBp bmZlcnJlZCBmcm9tIHRoZSBleHRlbnNpb24gaW4gdGhpcyBjYXNlLCB3aGF0IGVuZHMgdXAgY2Fs bGluZworICAgICAgICBuZXh0TWVkaWFFbmdpbmUoKSBpbiBNZWRpYVBsYXllcjo6bG9hZFdpdGhO ZXh0TWVkaWFFbmdpbmUuIFRoYXQgcmV0dXJucyB0aGUgZmlyc3QgcmVnaXN0ZXJlZCBtZWRpYSBl bmdpbmUsIHRoYXQKKyAgICAgICAgaXMgT3dyIHRoYXQgZG9lc24ndCBrbm93IGhvdyB0byBsb2Fk IHRoYXQgYW5kIGZhaWxzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5 ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6YnVpbGRNZWRpYUVuZ2luZXNWZWN0b3IpOgorCisy MDE3LTAzLTI0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKwog ICAgICAgICBbR1RLXSBBZGQgTUlNRVR5cGVSZWdpc3RyeSBpbXBsZW1lbnRhdGlvbiB1c2luZyB4 ZGdtaW1lIGFuZCByZW1vdmUgdGhlIEdUSysgb25lCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzAwMDEKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvTWVkaWFQbGF5ZXIuY3BwCmluZGV4IGExY2M1MzhjZTVjLi5kMmFhMTY0 ZWI4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvTWVkaWFQ bGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxh eWVyLmNwcApAQCAtMjI5LDEyICsyMjksNiBAQCBzdGF0aWMgdm9pZCBidWlsZE1lZGlhRW5naW5l c1ZlY3RvcigpCiAgICAgICAgIE1lZGlhUGxheWVyUHJpdmF0ZVFUS2l0OjpyZWdpc3Rlck1lZGlh RW5naW5lKGFkZE1lZGlhRW5naW5lKTsKICNlbmRpZgogCi0KLSNpZiBFTkFCTEUoTUVESUFfU1RS RUFNKSAmJiBVU0UoR1NUUkVBTUVSKSAmJiBVU0UoT1BFTldFQlJUQykKLSAgICBpZiAoU2V0dGlu Z3M6OmlzR1N0cmVhbWVyRW5hYmxlZCgpKQotICAgICAgICBNZWRpYVBsYXllclByaXZhdGVHU3Ry ZWFtZXJPd3I6OnJlZ2lzdGVyTWVkaWFFbmdpbmUoYWRkTWVkaWFFbmdpbmUpOwotI2VuZGlmCi0K ICNpZiBkZWZpbmVkKFBsYXRmb3JtTWVkaWFFbmdpbmVDbGFzc05hbWUpCiAjaWYgVVNFKEdTVFJF QU1FUikKICAgICBpZiAoU2V0dGluZ3M6OmlzR1N0cmVhbWVyRW5hYmxlZCgpKQpAQCAtMjQyLDYg KzIzNiwxMSBAQCBzdGF0aWMgdm9pZCBidWlsZE1lZGlhRW5naW5lc1ZlY3RvcigpCiAgICAgICAg IFBsYXRmb3JtTWVkaWFFbmdpbmVDbGFzc05hbWU6OnJlZ2lzdGVyTWVkaWFFbmdpbmUoYWRkTWVk aWFFbmdpbmUpOwogI2VuZGlmCiAKKyNpZiBFTkFCTEUoTUVESUFfU1RSRUFNKSAmJiBVU0UoR1NU UkVBTUVSKSAmJiBVU0UoT1BFTldFQlJUQykKKyAgICBpZiAoU2V0dGluZ3M6OmlzR1N0cmVhbWVy RW5hYmxlZCgpKQorICAgICAgICBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJPd3I6OnJlZ2lz dGVyTWVkaWFFbmdpbmUoYWRkTWVkaWFFbmdpbmUpOworI2VuZGlmCisKICNpZiBFTkFCTEUoVklE RU8pICYmIFVTRShHU1RSRUFNRVIpICYmIEVOQUJMRShNRURJQV9TT1VSQ0UpICYmIEVOQUJMRShW SURFT19UUkFDSykKICAgICBpZiAoU2V0dGluZ3M6OmlzR1N0cmVhbWVyRW5hYmxlZCgpKQogICAg ICAgICBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJNU0U6OnJlZ2lzdGVyTWVkaWFFbmdpbmUo YWRkTWVkaWFFbmdpbmUpOwo= 305276 2017-03-24 05:00:07 -0700 2017-03-24 05:35:21 -0700 Patch wcore-gst-owr.diff text/plain 3303 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAzYWIxMDVjOGI4OC4uNTNhNmQ3YjZhMWEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwzNCBAQAogMjAxNy0wMy0yNCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CiAKKyAgICAgICAgW0dTdHJlYW1lcl0gTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVh bWVyT3dyIHNob3VsZG4ndCBiZSB0aGUgZGVmYXVsdCBlbmdpbmUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDA0OQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgY2F1c2luZyBzZXZlcmFsIG1l ZGlhIHRlc3RzIHRvIGZhaWwgYWZ0ZXIgcjIxNDMzOC4gV2hlbiB0cnlpbmcgdG8gbG9hZCBzb21l dGhpbmcgbGlrZSB0aGlzOgorCisgICAgICAgIGh0dHA6Ly8xMjcuMC4wLjE6ODAwMC9tZWRpYS9y ZXNvdXJjZXMvc2VydmUtdmlkZW8ucGhwP25hbWU9Li4vLi4vLi4vLi4vbWVkaWEvY29udGVudC9z aWxlbmNlLndhdiZ0eXBlPWF1ZGlvL3dhdiZjb250ZW50LWxlbmd0aD1ubyZpY3ktZGF0YT15ZXMK KworICAgICAgICBzaW5jZSByMjE0MzM4LCB0aGUgY29udGVudCB0eXBlIGlzIGtub3duIGFuZCBp bmZlcnJlZCBmcm9tIHRoZSBleHRlbnNpb24gaW4gdGhpcyBjYXNlLCB3aGF0IGVuZHMgdXAgY2Fs bGluZworICAgICAgICBuZXh0TWVkaWFFbmdpbmUoKSBpbiBNZWRpYVBsYXllcjo6bG9hZFdpdGhO ZXh0TWVkaWFFbmdpbmUuIFRoYXQgcmV0dXJucyB0aGUgZmlyc3QgcmVnaXN0ZXJlZCBtZWRpYSBl bmdpbmUsIHRoYXQKKyAgICAgICAgaXMgT3dyIHRoYXQgZG9lc24ndCBrbm93IGhvdyB0byBsb2Fk IHRoYXQgYW5kIGZhaWxzLgorCisgICAgICAgIEZpeGVzOiBodHRwL3Rlc3RzL21lZGlhL21lZGlh LXBsYXktc3RyZWFtLWNodW5rZWQtaWN5Lmh0bWwKKyAgICAgICAgICAgICAgIGh0dHAvdGVzdHMv bWVkaWEvbWVkaWEtc2Vla2luZy1uby1yYW5nZXMtc2VydmVyLmh0bWwKKyAgICAgICAgICAgICAg IGh0dHAvdGVzdHMvbWVkaWEvdmlkZW8tYXV0aC5odG1sCisgICAgICAgICAgICAgICBodHRwL3Rl c3RzL21lZGlhL3ZpZGVvLXBsYXktc3RhbGwtYmVmb3JlLW1ldGEtZGF0YS5odG1sCisgICAgICAg ICAgICAgICBodHRwL3Rlc3RzL3NlY3VyaXR5L2NvbnRlbnRTZWN1cml0eVBvbGljeS9hdWRpby1y ZWRpcmVjdC1hbGxvd2VkLmh0bWwKKyAgICAgICAgICAgICAgIGh0dHAvdGVzdHMvc2VjdXJpdHkv Y29udGVudFNlY3VyaXR5UG9saWN5L2F1ZGlvLXJlZGlyZWN0LWFsbG93ZWQyLmh0bWwKKyAgICAg ICAgICAgICAgIGh0dHAvdGVzdHMvc2VjdXJpdHkvY29udGVudFNlY3VyaXR5UG9saWN5L2F1ZGlv LXJlZGlyZWN0LWJsb2NrZWQuaHRtbAorICAgICAgICAgICAgICAgaHR0cC90ZXN0cy9zZWN1cml0 eS9jb250ZW50U2VjdXJpdHlQb2xpY3kvdmlkZW8tcmVkaXJlY3QtYWxsb3dlZC5odG1sCisgICAg ICAgICAgICAgICBodHRwL3Rlc3RzL3NlY3VyaXR5L2NvbnRlbnRTZWN1cml0eVBvbGljeS92aWRl by1yZWRpcmVjdC1hbGxvd2VkMi5odG1sCisgICAgICAgICAgICAgICBodHRwL3Rlc3RzL3NlY3Vy aXR5L2NvbnRlbnRTZWN1cml0eVBvbGljeS92aWRlby1yZWRpcmVjdC1ibG9ja2VkLmh0bWwKKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OmJ1aWxkTWVkaWFFbmdpbmVzVmVjdG9yKToKKworMjAxNy0wMy0yNCAgQ2FybG9zIEdh cmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKICAgICAgICAgW0dUS10gQWRkIE1J TUVUeXBlUmVnaXN0cnkgaW1wbGVtZW50YXRpb24gdXNpbmcgeGRnbWltZSBhbmQgcmVtb3ZlIHRo ZSBHVEsrIG9uZQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTcwMDAxCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L01lZGlhUGxheWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlh UGxheWVyLmNwcAppbmRleCBhMWNjNTM4Y2U1Yy4uZDJhYTE2NGViODYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxheWVyLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9NZWRpYVBsYXllci5jcHAKQEAgLTIyOSwxMiAr MjI5LDYgQEAgc3RhdGljIHZvaWQgYnVpbGRNZWRpYUVuZ2luZXNWZWN0b3IoKQogICAgICAgICBN ZWRpYVBsYXllclByaXZhdGVRVEtpdDo6cmVnaXN0ZXJNZWRpYUVuZ2luZShhZGRNZWRpYUVuZ2lu ZSk7CiAjZW5kaWYKIAotCi0jaWYgRU5BQkxFKE1FRElBX1NUUkVBTSkgJiYgVVNFKEdTVFJFQU1F UikgJiYgVVNFKE9QRU5XRUJSVEMpCi0gICAgaWYgKFNldHRpbmdzOjppc0dTdHJlYW1lckVuYWJs ZWQoKSkKLSAgICAgICAgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyT3dyOjpyZWdpc3Rlck1l ZGlhRW5naW5lKGFkZE1lZGlhRW5naW5lKTsKLSNlbmRpZgotCiAjaWYgZGVmaW5lZChQbGF0Zm9y bU1lZGlhRW5naW5lQ2xhc3NOYW1lKQogI2lmIFVTRShHU1RSRUFNRVIpCiAgICAgaWYgKFNldHRp bmdzOjppc0dTdHJlYW1lckVuYWJsZWQoKSkKQEAgLTI0Miw2ICsyMzYsMTEgQEAgc3RhdGljIHZv aWQgYnVpbGRNZWRpYUVuZ2luZXNWZWN0b3IoKQogICAgICAgICBQbGF0Zm9ybU1lZGlhRW5naW5l Q2xhc3NOYW1lOjpyZWdpc3Rlck1lZGlhRW5naW5lKGFkZE1lZGlhRW5naW5lKTsKICNlbmRpZgog CisjaWYgRU5BQkxFKE1FRElBX1NUUkVBTSkgJiYgVVNFKEdTVFJFQU1FUikgJiYgVVNFKE9QRU5X RUJSVEMpCisgICAgaWYgKFNldHRpbmdzOjppc0dTdHJlYW1lckVuYWJsZWQoKSkKKyAgICAgICAg TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyT3dyOjpyZWdpc3Rlck1lZGlhRW5naW5lKGFkZE1l ZGlhRW5naW5lKTsKKyNlbmRpZgorCiAjaWYgRU5BQkxFKFZJREVPKSAmJiBVU0UoR1NUUkVBTUVS KSAmJiBFTkFCTEUoTUVESUFfU09VUkNFKSAmJiBFTkFCTEUoVklERU9fVFJBQ0spCiAgICAgaWYg KFNldHRpbmdzOjppc0dTdHJlYW1lckVuYWJsZWQoKSkKICAgICAgICAgTWVkaWFQbGF5ZXJQcml2 YXRlR1N0cmVhbWVyTVNFOjpyZWdpc3Rlck1lZGlhRW5naW5lKGFkZE1lZGlhRW5naW5lKTsK