170027 2017-03-23 15:07:32 -0700 Consider changing MachineThreads::m_registeredThreads to be a linked list of WTFThreadData. 2018-04-01 12:27:16 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 170502 1 mark.lam ysuzuki fpizlo jfbastien keith_miller msaboff saam ysuzuki oldest_to_newest 1290611 0 mark.lam 2017-03-23 15:07:32 -0700 Currently, MachineThreads instantiates MachineThreads::Thread (which is just a linked list node) that points to MachineThreads::ThreadData (a thread specific record that basically copies the content of WTFThreadData i.e. the stack bounds, and adds a few other things). In order to instantiate the MachineThreads::ThreadData, the code needs to consult (and thereby create) the WTFThreadData instance anyway. If we can lower PlatformThread to the WTF layer (and unify it with whatever representation of a thread id we have there e.g. that which is returned by currentThread()), then we can add that to WTFThreadData. I think it is also fine to add the other platform specific MachineThreads::ThreadData fields to WTFThreadData as well. Note: a side detail, we used to copy the stack bounds base and end. Instead, we can change MachineStackMarker.cpp to use StackBounds::contains() instead to check the stack bounds. 1410971 1 ysuzuki 2018-04-01 12:27:16 -0700 MachineThreads are converted to WTF::ThreadGroup.