170014 2017-03-23 11:36:17 -0700 [GTK] Remove notifications guards from GTK API layer 2017-05-11 05:54:30 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 manday csaavedra berto bugs-noreply buildbot cgarcia commit-queue csaavedra gustavo mcatanzaro oldest_to_newest 1290513 0 305207 manday 2017-03-23 11:36:17 -0700 Created attachment 305207 Error as produced by cmake ; make Despite USE_LIBNOTIFY=OFF, the following error occurs during compilation of Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/API/gtk/WebKitWebContext.cpp: ‘WebKitWebContextPrivate {aka struct _WebKitWebContextPrivate}’ has no member named ‘notificationProvider’ IIRC, I could easily fix this last time by commenting out the according section. I don't know whether this is proper but assume so. I'll submit a patch a.s.a.p. 1290558 1 mcatanzaro 2017-03-23 13:03:15 -0700 No that's not right. We support USE_LIBNOTIFY=OFF, but we do *not* support ENABLE_NOTIFICATIONS=OFF. The ENABLE(NOTIFICATIONS) guards should be removed from the GTK API layer. The only use of libnotify is in WebKitWebView.cpp and that is properly guarded. I wonder how you wound up with ENABLE_NOTIFICATIONS=OFF? If something is setting that in our build system, it needs to be fixed. 1290559 2 mcatanzaro 2017-03-23 13:04:15 -0700 To be clear, WebKitNotificationProvider is required for notifications to work properly regardless of whether the default libnotify implementation is compiled in or not. 1290748 3 manday 2017-03-23 23:40:34 -0700 I do not understand your answer. What exactly is it that you're suggesting is missing? I configure WK using the following commandline cmake -DPORT=GTK -DCMAKE_BUILD_TYPE=Release -DENABLE_ACCESSIBILITY=OFF -DENABLE_GEOLOCATION=OFF -DENABLE_INTROSPECTION=OFF -DENABLE_MINIBROWSER=ON -DENABLE_NOTIFICATIONS=OFF -DUSE_LD_GOLD=OFF -DUSE_LIBHYPHEN=OFF -DUSE_LIBNOTIFY=OFF -DENABLE_SPELLCHECK=OFF -DCMAKE_INSTALL_PREFIX="$HOME/local" -DENABLE_PLUGIN_PROCESS_GTK2=OFF -DUSE_LIBSECRET=OFF -DUSE_SYSTEM_MALLOC=ON 1290782 4 mcatanzaro 2017-03-24 05:59:14 -0700 (In reply to ManDay from comment #3) > -DENABLE_NOTIFICATIONS=OFF This isn't supported, GTK+ port uses ENABLE_NOTIFICATIONS=ON. Remember back when we fixed a bunch of private options mistakenly not being marked as ADVANCED? This was one of them. There is still a bug though, because we have ENABLE_NOTIFICATIONS guards in our GTK API code. We should either remove them, or make it public and actually allow building with it disabled. 1290783 5 mcatanzaro 2017-03-24 06:00:40 -0700 What you can do is build with ENABLE_NOTIFICATIONS=ON USE_LIBNOTIFY=OFF, in which case applications still get callbacks when there is a web notification but have to implement the notifications themselves (or just ignore it). That's also an option for applications when using USE_LIBNOTIFY=ON. libnotify is just a default handler. 1307239 6 309707 csaavedra 2017-05-11 04:57:09 -0700 Created attachment 309707 Patch 1307240 7 buildbot 2017-05-11 04:59:10 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1307246 8 309707 commit-queue 2017-05-11 05:54:29 -0700 Comment on attachment 309707 Patch Clearing flags on attachment: 309707 Committed r216675: <http://trac.webkit.org/changeset/216675> 1307247 9 commit-queue 2017-05-11 05:54:30 -0700 All reviewed patches have been landed. Closing bug. 305207 2017-03-23 11:36:17 -0700 2017-03-23 11:36:17 -0700 Error as produced by cmake ; make err.txt text/plain 792 manday L3RtcC93ZWJraXRndGstMi4xNi4wL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dl YktpdFdlYkNvbnRleHQuY3BwOiBJbiBmdW5jdGlvbiDigJh2b2lkIHdlYmtpdF93ZWJfY29udGV4 dF9pbml0aWFsaXplX25vdGlmaWNhdGlvbl9wZXJtaXNzaW9ucyhXZWJLaXRXZWJDb250ZXh0Kiwg R0xpc3QqLCBHTGlzdCop4oCZOgovdG1wL3dlYmtpdGd0ay0yLjE2LjAvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViQ29udGV4dC5jcHA6MTM5MzoyMDogZXJyb3I6IOKA mFdlYktpdFdlYkNvbnRleHRQcml2YXRlIHtha2Egc3RydWN0IF9XZWJLaXRXZWJDb250ZXh0UHJp dmF0ZX3igJkgaGFzIG5vIG1lbWJlciBuYW1lZCDigJhub3RpZmljYXRpb25Qcm92aWRlcuKAmQog ICAgIGNvbnRleHQtPnByaXYtPm5vdGlmaWNhdGlvblByb3ZpZGVyLT5zZXROb3RpZmljYXRpb25Q ZXJtaXNzaW9ucyhXVEZNb3ZlKG1hcCkpOwogICAgICAgICAgICAgICAgICAgIF4KbWFrZVsyXTog KioqIFtTb3VyY2UvV2ViS2l0Mi9DTWFrZUZpbGVzL1dlYktpdDIuZGlyL2J1aWxkLm1ha2U6MTQ3 NDM6IFNvdXJjZS9XZWJLaXQyL0NNYWtlRmlsZXMvV2ViS2l0Mi5kaXIvVUlQcm9jZXNzL0FQSS9n dGsvV2ViS2l0V2ViQ29udGV4dC5jcHAub10gRXJyb3IgMQptYWtlWzFdOiAqKiogW0NNYWtlRmls ZXMvTWFrZWZpbGUyOjEwODk6IFNvdXJjZS9XZWJLaXQyL0NNYWtlRmlsZXMvV2ViS2l0Mi5kaXIv YWxsXSBFcnJvciAyCm1ha2U6ICoqKiBbTWFrZWZpbGU6MTUwOiBhbGxdIEVycm9yIDIK 309707 2017-05-11 04:57:09 -0700 2017-05-11 05:54:29 -0700 Patch bug-170014-20170511145708.patch text/plain 2201 csaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjE2NjcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggN2ExMjY0MTg1NTkzMzM3 MjlhMmU2OWY2ZjNkNzcyYzlmM2Y0ZTE1ZS4uMmY4NGRjZjQyYWE2ZmNiNmI3ZjNiMWRmNjM4NGMz YmQxMWVjMWEzNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE3LTA1LTExICBDbGF1 ZGlvIFNhYXZlZHJhICA8Y3NhYXZlZHJhQGlnYWxpYS5jb20+CiAKKyAgICAgICAgW0dUS10gUmVt b3ZlIG5vdGlmaWNhdGlvbnMgZ3VhcmRzIGZyb20gR1RLIEFQSSBsYXllcgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwMDE0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRU5BQkxFX05PVElGSUNBVElPTlMg aW4gdGhlIEdUSyBwb3J0IGlzIGEgcHJpdmF0ZSBvcHRpb24gYW5kCisgICAgICAgIGRpc2FibGlu ZyBpdCBpcyB1bnN1cHBvcnRlZCwgaGVuY2UgcmVtb3ZlIGl0cyBndWFyZHMgZnJvbSB0aGUgR1RL IEFQSQorICAgICAgICBsYXllci4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktp dFdlYkNvbnRleHQuY3BwOgorICAgICAgICAod2Via2l0V2ViQ29udGV4dENvbnN0cnVjdGVkKToK KworMjAxNy0wNS0xMSAgQ2xhdWRpbyBTYWF2ZWRyYSAgPGNzYWF2ZWRyYUBpZ2FsaWEuY29tPgor CiAgICAgICAgIFtHVEtdIEphdmFTY3JpcHQgcHJvbXB0IHVzZXMgdGl0bGUgb2YgcGFnZSB0byBi ZSBsb2FkZWQgcmF0aGVyIHRoYW4gdGl0bGUgb2YgY3VycmVudCBwYWdlCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNTI2OTAKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViQ29udGV4dC5jcHAgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJDb250ZXh0LmNwcAppbmRl eCBiYzNiODk2ZTA3YzJkOGY0MDI0NjY2NDcwYmU3MTVkMGM1M2U3N2E2Li45NjI5MzE0ZDE1MTU2 MzljZjliZWRlMGM3NGQ2YTBiM2Y0YWM2MGJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJDb250ZXh0LmNwcApAQCAtMTY4LDkgKzE2OCw3 IEBAIHN0cnVjdCBfV2ViS2l0V2ViQ29udGV4dFByaXZhdGUgewogI2lmIEVOQUJMRShHRU9MT0NB VElPTikKICAgICBSZWZQdHI8V2ViS2l0R2VvbG9jYXRpb25Qcm92aWRlcj4gZ2VvbG9jYXRpb25Q cm92aWRlcjsKICNlbmRpZgotI2lmIEVOQUJMRShOT1RJRklDQVRJT05TKQogICAgIFJlZlB0cjxX ZWJLaXROb3RpZmljYXRpb25Qcm92aWRlcj4gbm90aWZpY2F0aW9uUHJvdmlkZXI7Ci0jZW5kaWYK ICAgICBHUmVmUHRyPFdlYktpdFdlYnNpdGVEYXRhTWFuYWdlcj4gd2Vic2l0ZURhdGFNYW5hZ2Vy OwogCiAgICAgQ1N0cmluZyBmYXZpY29uRGF0YWJhc2VEaXJlY3Rvcnk7CkBAIC0zMjcsOSArMzI1 LDcgQEAgc3RhdGljIHZvaWQgd2Via2l0V2ViQ29udGV4dENvbnN0cnVjdGVkKEdPYmplY3QqIG9i amVjdCkKICNpZiBFTkFCTEUoR0VPTE9DQVRJT04pCiAgICAgcHJpdi0+Z2VvbG9jYXRpb25Qcm92 aWRlciA9IFdlYktpdEdlb2xvY2F0aW9uUHJvdmlkZXI6OmNyZWF0ZShwcml2LT5wcm9jZXNzUG9v bC0+c3VwcGxlbWVudDxXZWJHZW9sb2NhdGlvbk1hbmFnZXJQcm94eT4oKSk7CiAjZW5kaWYKLSNp ZiBFTkFCTEUoTk9USUZJQ0FUSU9OUykKICAgICBwcml2LT5ub3RpZmljYXRpb25Qcm92aWRlciA9 IFdlYktpdE5vdGlmaWNhdGlvblByb3ZpZGVyOjpjcmVhdGUocHJpdi0+cHJvY2Vzc1Bvb2wtPnN1 cHBsZW1lbnQ8V2ViTm90aWZpY2F0aW9uTWFuYWdlclByb3h5PigpLCB3ZWJDb250ZXh0KTsKLSNl bmRpZgogI2lmIEVOQUJMRShSRU1PVEVfSU5TUEVDVE9SKQogICAgIHByaXYtPnJlbW90ZUluc3Bl Y3RvclByb3RvY29sSGFuZGxlciA9IHN0ZDo6bWFrZV91bmlxdWU8UmVtb3RlSW5zcGVjdG9yUHJv dG9jb2xIYW5kbGVyPih3ZWJDb250ZXh0KTsKICNlbmRpZgo=