170006 2017-03-23 07:36:01 -0700 Text stroke is sometimes clipped on video captions. 2017-03-24 05:01:52 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue eric.carlson jonlee webkit-bug-importer oldest_to_newest 1290438 0 pvollan 2017-03-23 07:36:01 -0700 Text stroke is sometimes clipped on video captions, when using a thick(er) stroke. 1290441 1 305194 pvollan 2017-03-23 07:49:36 -0700 Created attachment 305194 Patch 1290768 2 pvollan 2017-03-24 02:04:05 -0700 rdar://problem/31238410 1290769 3 pvollan 2017-03-24 02:04:45 -0700 Thanks for reviewing! 1290777 4 305194 commit-queue 2017-03-24 05:01:48 -0700 Comment on attachment 305194 Patch Clearing flags on attachment: 305194 Committed r214340: <http://trac.webkit.org/changeset/214340> 1290778 5 commit-queue 2017-03-24 05:01:52 -0700 All reviewed patches have been landed. Closing bug. 305194 2017-03-23 07:49:36 -0700 2017-03-24 05:01:48 -0700 Patch bug-170006-20170323154934.patch text/plain 4587 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNDMwMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE3LTAzLTIzICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBUZXh0IHN0cm9rZSBpcyBz b21ldGltZXMgY2xpcHBlZCBvbiB2aWRlbyBjYXB0aW9ucy4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDAwNgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNldCAnb3ZlcmZsb3cnIHByb3BlcnR5IHRvICd2 aXNpYmxlJyBvbiBjdWUgZWxlbWVudCB0byBhdm9pZCBjbGlwcGluZyBvZiB0ZXh0IHN0cm9rZS4K KworICAgICAgICBVcGRhdGVkIHRlc3QgbWVkaWEvdHJhY2svdHJhY2stY3NzLXN0cm9rZS1jdWVz Lmh0bWwuCisKKyAgICAgICAgKiBodG1sL3RyYWNrL1RleHRUcmFja0N1ZUdlbmVyaWMuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6VGV4dFRyYWNrQ3VlR2VuZXJpY0JveEVsZW1lbnQ6OmFwcGx5Q1NT UHJvcGVydGllcyk6CisgICAgICAgICogaHRtbC90cmFjay9WVFRDdWUuY3BwOgorICAgICAgICAo V2ViQ29yZTo6VlRUQ3VlQm94OjphcHBseUNTU1Byb3BlcnRpZXMpOgorCiAyMDE3LTAzLTIyICBB bmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBMZXQgTWVtb3J5UHJl c3N1cmVIYW5kbGVyIHRyYWNrIHdoZXRoZXIgdGhlIHByb2Nlc3MgaXMgYWN0aXZlIG9yIGluYWN0 aXZlLgpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC90cmFjay9UZXh0VHJhY2tDdWVHZW5lcmlj LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL1RleHRUcmFja0N1 ZUdlbmVyaWMuY3BwCShyZXZpc2lvbiAyMTQyNDEpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL3Ry YWNrL1RleHRUcmFja0N1ZUdlbmVyaWMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNDEsNiArMTQx LDEwIEBAIHZvaWQgVGV4dFRyYWNrQ3VlR2VuZXJpY0JveEVsZW1lbnQ6OmFwcGwKICAgICAgICAg c2V0SW5saW5lU3R5bGVQcm9wZXJ0eShDU1NQcm9wZXJ0eUJhY2tncm91bmRDb2xvciwgY3VlLT5i YWNrZ3JvdW5kQ29sb3IoKS5zZXJpYWxpemVkKCkpOwogICAgIHNldElubGluZVN0eWxlUHJvcGVy dHkoQ1NTUHJvcGVydHlXcml0aW5nTW9kZSwgY3VlLT5nZXRDU1NXcml0aW5nTW9kZSgpLCBmYWxz ZSk7CiAgICAgc2V0SW5saW5lU3R5bGVQcm9wZXJ0eShDU1NQcm9wZXJ0eVdoaXRlU3BhY2UsIENT U1ZhbHVlUHJlV3JhcCk7CisKKyAgICAvLyBNYWtlIHN1cmUgc2hhZG93IG9yIHN0cm9rZSBpcyBu b3QgY2xpcHBlZC4KKyAgICBzZXRJbmxpbmVTdHlsZVByb3BlcnR5KENTU1Byb3BlcnR5T3ZlcmZs b3csIENTU1ZhbHVlVmlzaWJsZSk7CisgICAgY3VlRWxlbWVudC0+c2V0SW5saW5lU3R5bGVQcm9w ZXJ0eShDU1NQcm9wZXJ0eU92ZXJmbG93LCBDU1NWYWx1ZVZpc2libGUpOwogfQogCiBUZXh0VHJh Y2tDdWVHZW5lcmljOjpUZXh0VHJhY2tDdWVHZW5lcmljKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQm IGNvbnRleHQsIGNvbnN0IE1lZGlhVGltZSYgc3RhcnQsIGNvbnN0IE1lZGlhVGltZSYgZW5kLCBj b25zdCBTdHJpbmcmIGNvbnRlbnQpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL1ZU VEN1ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRtbC90cmFjay9WVFRDdWUu Y3BwCShyZXZpc2lvbiAyMTQyNDEpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL3RyYWNrL1ZUVEN1 ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIyMyw2ICsyMjMsMTAgQEAgdm9pZCBWVFRDdWVCb3g6 OmFwcGx5Q1NTUHJvcGVydGllcyhjb25zdAogCiAgICAgICAgIHNldElubGluZVN0eWxlUHJvcGVy dHkoQ1NTUHJvcGVydHlXaGl0ZVNwYWNlLCBDU1NWYWx1ZVByZSk7CiAgICAgfQorCisgICAgLy8g TWFrZSBzdXJlIHNoYWRvdyBvciBzdHJva2UgaXMgbm90IGNsaXBwZWQuCisgICAgc2V0SW5saW5l U3R5bGVQcm9wZXJ0eShDU1NQcm9wZXJ0eU92ZXJmbG93LCBDU1NWYWx1ZVZpc2libGUpOworICAg IG1fY3VlLmVsZW1lbnQoKS5zZXRJbmxpbmVTdHlsZVByb3BlcnR5KENTU1Byb3BlcnR5T3ZlcmZs b3csIENTU1ZhbHVlVmlzaWJsZSk7CiB9CiAKIGNvbnN0IEF0b21pY1N0cmluZyYgVlRUQ3VlQm94 Ojp2dHRDdWVCb3hTaGFkb3dQc2V1ZG9JZCgpCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMTQyNDEpCisr KyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAor MjAxNy0wMy0yMyAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+CisKKyAgICAg ICAgVGV4dCBzdHJva2UgaXMgc29tZXRpbWVzIGNsaXBwZWQgb24gdmlkZW8gY2FwdGlvbnMuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzAwMDYKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIG1lZGlhL3Ry YWNrL3RyYWNrLWNzcy1zdHJva2UtY3Vlcy1leHBlY3RlZC50eHQ6CisgICAgICAgICogbWVkaWEv dHJhY2svdHJhY2stY3NzLXN0cm9rZS1jdWVzLmh0bWw6CisKIDIwMTctMDMtMjEgIEJyYWR5IEVp ZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgogCiAgICAgICAgIERpc2FibGUgYWxsIHZpcnR1YWwg dGFibGVzLgpJbmRleDogTGF5b3V0VGVzdHMvbWVkaWEvdHJhY2svdHJhY2stY3NzLXN0cm9rZS1j dWVzLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9tZWRpYS90cmFjay90 cmFjay1jc3Mtc3Ryb2tlLWN1ZXMtZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAyMTQyNDEpCisrKyBM YXlvdXRUZXN0cy9tZWRpYS90cmFjay90cmFjay1jc3Mtc3Ryb2tlLWN1ZXMtZXhwZWN0ZWQudHh0 CSh3b3JraW5nIGNvcHkpCkBAIC03LDUgKzcsNiBAQCBFWFBFQ1RFRCAoZ2V0Q29tcHV0ZWRTdHls ZSh0ZXh0VHJhY2tEaXNwCiBFWFBFQ1RFRCAoZ2V0Q29tcHV0ZWRTdHlsZSh0ZXh0VHJhY2tEaXNw bGF5RWxlbWVudCh2aWRlbywgJ2N1ZScpKS5wYWludE9yZGVyID09ICdzdHJva2UnKSBPSwogRVhQ RUNURUQgKGdldENvbXB1dGVkU3R5bGUodGV4dFRyYWNrRGlzcGxheUVsZW1lbnQodmlkZW8sICdj dWUnKSkuc3Ryb2tlTGluZWpvaW4gPT0gJ3JvdW5kJykgT0sKIEVYUEVDVEVEIChnZXRDb21wdXRl ZFN0eWxlKHRleHRUcmFja0Rpc3BsYXlFbGVtZW50KHZpZGVvLCAnY3VlJykpLnN0cm9rZUxpbmVj YXAgPT0gJ3JvdW5kJykgT0sKK0VYUEVDVEVEIChnZXRDb21wdXRlZFN0eWxlKHRleHRUcmFja0Rp c3BsYXlFbGVtZW50KHZpZGVvLCAnY3VlJykpLm92ZXJmbG93ID09ICd2aXNpYmxlJykgT0sKIEVO RCBPRiBURVNUCiAKSW5kZXg6IExheW91dFRlc3RzL21lZGlhL3RyYWNrL3RyYWNrLWNzcy1zdHJv a2UtY3Vlcy5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL21lZGlhL3RyYWNrL3RyYWNr LWNzcy1zdHJva2UtY3Vlcy5odG1sCShyZXZpc2lvbiAyMTQyNDEpCisrKyBMYXlvdXRUZXN0cy9t ZWRpYS90cmFjay90cmFjay1jc3Mtc3Ryb2tlLWN1ZXMuaHRtbAkod29ya2luZyBjb3B5KQpAQCAt MjIsNiArMjIsNyBAQAogICAgICAgICAgICAgdGVzdEV4cGVjdGVkKCJnZXRDb21wdXRlZFN0eWxl KHRleHRUcmFja0Rpc3BsYXlFbGVtZW50KHZpZGVvLCAnY3VlJykpLnBhaW50T3JkZXIiLCAic3Ry b2tlIik7CiAgICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoImdldENvbXB1dGVkU3R5bGUodGV4dFRy YWNrRGlzcGxheUVsZW1lbnQodmlkZW8sICdjdWUnKSkuc3Ryb2tlTGluZWpvaW4iLCAicm91bmQi KTsKICAgICAgICAgICAgIHRlc3RFeHBlY3RlZCgiZ2V0Q29tcHV0ZWRTdHlsZSh0ZXh0VHJhY2tE aXNwbGF5RWxlbWVudCh2aWRlbywgJ2N1ZScpKS5zdHJva2VMaW5lY2FwIiwgInJvdW5kIik7Cisg ICAgICAgICAgICB0ZXN0RXhwZWN0ZWQoImdldENvbXB1dGVkU3R5bGUodGV4dFRyYWNrRGlzcGxh eUVsZW1lbnQodmlkZW8sICdjdWUnKSkub3ZlcmZsb3ciLCAidmlzaWJsZSIpOwogICAgICAgICAg ICAgZW5kVGVzdCgpOwogICAgICAgICB9CiAK