170002 2017-03-23 05:13:24 -0700 [JSC] Use jsNontrivialString agressively for ToString(Int52) 2017-03-24 07:30:31 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ysuzuki ysuzuki buildbot keith_miller mark.lam msaboff saam oldest_to_newest 1290417 0 ysuzuki 2017-03-23 05:13:24 -0700 [JSC] Use jsNontrivialString agressively for ToString(Int52) 1290418 1 305183 ysuzuki 2017-03-23 05:14:24 -0700 Created attachment 305183 Patch 1290802 2 ysuzuki 2017-03-24 07:30:31 -0700 Committed r214345: <http://trac.webkit.org/changeset/214345> 305183 2017-03-23 05:14:24 -0700 2017-03-24 05:29:48 -0700 Patch bug-170002-20170323211422.patch text/plain 5057 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0MzAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA5 ODM5YzdjMjcxOTViOTBhYmVhZjE1ZDA3YjM0ZGNjOWY0MDJjYjRjLi5jYTNhMDE0MWQ3OTgyMDEy NzI4NzUwNTkyZjNlMjU3MGI3ZWUxNGMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNy0wMy0yMyAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbSlNDXSBVc2UganNOb250cml2aWFsU3RyaW5nIGFncmVzc2l2ZWx5 IGZvciBUb1N0cmluZyhJbnQ1MikKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE3MDAwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFdlIHVzZSB0aGUgc2FtZSBsb2dpYyB1c2VkIGZvciBJbnQzMiB0byB1c2Ug anNOb250dmlyaWFsU3RyaW5nLgorICAgICAgICBBZnRlciBzaW5nbGUgY2hhcmFjdGVyIGNoZWNr LCBwcm9kdWNlZCBzdHJpbmcgaXMgYWx3YXlzIGxvbmdlciB0aGFuIDEuCisgICAgICAgIFRodXMs IHdlIGNhbiB1c2UganNOb250cml2aWFsU3RyaW5nLgorCisgICAgICAgICogcnVudGltZS9OdW1i ZXJQcm90b3R5cGUuY3BwOgorICAgICAgICAoSlNDOjppbnQ1MlRvU3RyaW5nKToKKwogMjAxNy0w My0yMyAgR3VpbGxhdW1lIEVtb250ICA8Z3VpamVtb250QGlnYWxpYS5jb20+CiAKICAgICAgICAg W2pzY10gQWRkIE1hY3JvQXNzZW1ibGVyTUlQUzo6c3RvcmVGZW5jZSgpCmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9OdW1iZXJQcm90b3R5cGUuY3BwIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTnVtYmVyUHJvdG90eXBlLmNwcAppbmRleCA2ZDFlYzBm YmFmYTczMDcxZDEyNDRlNDI1ZDAzNzlmOGE3NjNjMjg1Li45YjM4NjgyNTVjOWZmYzA0NTVkNGYz NTZlNjlhNmU3Mjc2OTYxMDdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9OdW1iZXJQcm90b3R5cGUuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL051bWJlclByb3RvdHlwZS5jcHAKQEAgLTU0Miw4ICs1NDIsMTUgQEAgSlNTdHJpbmcqIGlu dDMyVG9TdHJpbmcoVk0mIHZtLCBpbnQzMl90IHZhbHVlLCBpbnQzMl90IHJhZGl4KQogSlNTdHJp bmcqIGludDUyVG9TdHJpbmcoVk0mIHZtLCBpbnQ2NF90IHZhbHVlLCBpbnQzMl90IHJhZGl4KQog ewogICAgIEFTU0VSVCghKHJhZGl4IDwgMiB8fCByYWRpeCA+IDM2KSk7CisgICAgLy8gQSBuZWdh dGl2ZSB2YWx1ZSBjYXN0ZWQgdG8gdW5zaWduZWQgd291bGQgYmUgYmlnZ2VyIHRoYW4gMzYgKHRo ZSBtYXggcmFkaXgpLgorICAgIGlmIChzdGF0aWNfY2FzdDx1aW50NjRfdD4odmFsdWUpIDwgc3Rh dGljX2Nhc3Q8dWludDY0X3Q+KHJhZGl4KSkgeworICAgICAgICBBU1NFUlQodmFsdWUgPD0gMzYp OworICAgICAgICBBU1NFUlQodmFsdWUgPj0gMCk7CisgICAgICAgIHJldHVybiB2bS5zbWFsbFN0 cmluZ3Muc2luZ2xlQ2hhcmFjdGVyU3RyaW5nKHJhZGl4RGlnaXRzW3ZhbHVlXSk7CisgICAgfQor CiAgICAgaWYgKHJhZGl4ID09IDEwKQotICAgICAgICByZXR1cm4ganNTdHJpbmcoJnZtLCB2bS5u dW1lcmljU3RyaW5ncy5hZGQoc3RhdGljX2Nhc3Q8ZG91YmxlPih2YWx1ZSkpKTsKKyAgICAgICAg cmV0dXJuIGpzTm9udHJpdmlhbFN0cmluZygmdm0sIHZtLm51bWVyaWNTdHJpbmdzLmFkZChzdGF0 aWNfY2FzdDxkb3VibGU+KHZhbHVlKSkpOwogCiAgICAgLy8gUG9zaXRpb24gdGhlIGRlY2ltYWwg cG9pbnQgYXQgdGhlIGNlbnRlciBvZiB0aGUgc3RyaW5nLCBzZXQKICAgICAvLyB0aGUgc3RhcnRP ZlJlc3VsdFN0cmluZyBwb2ludGVyIHRvIHBvaW50IGF0IHRoZSBkZWNpbWFsIHBvaW50LgpAQCAt NTUyLDcgKzU1OSw3IEBAIEpTU3RyaW5nKiBpbnQ1MlRvU3RyaW5nKFZNJiB2bSwgaW50NjRfdCB2 YWx1ZSwgaW50MzJfdCByYWRpeCkKICAgICBjaGFyKiBzdGFydE9mUmVzdWx0U3RyaW5nID0gZGVj aW1hbFBvaW50OwogICAgICpkZWNpbWFsUG9pbnQgPSAnXDAnOwogCi0gICAgcmV0dXJuIGpzU3Ry aW5nKCZ2bSwgaW50NTJUb1N0cmluZ1dpdGhSYWRpeChzdGFydE9mUmVzdWx0U3RyaW5nLCB2YWx1 ZSwgcmFkaXgpKTsKKyAgICByZXR1cm4ganNOb250cml2aWFsU3RyaW5nKCZ2bSwgaW50NTJUb1N0 cmluZ1dpdGhSYWRpeChzdGFydE9mUmVzdWx0U3RyaW5nLCB2YWx1ZSwgcmFkaXgpKTsKIH0KIAog SlNTdHJpbmcqIG51bWJlclRvU3RyaW5nKFZNJiB2bSwgZG91YmxlIGRvdWJsZVZhbHVlLCBpbnQz Ml90IHJhZGl4KQpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9DaGFuZ2VMb2cgYi9KU1Rlc3RzL0NoYW5n ZUxvZwppbmRleCBkNzNhY2RjZTAxMDRiZTcxNjM4MTQ0ZmVjNmUxOTE3NWE1OWE4ZjExLi43Nzdi MmQyMzMxNWI4Y2IyZWVlYjI3MTU0YTFlMzFiZDA3NjExODM0IDEwMDY0NAotLS0gYS9KU1Rlc3Rz L0NoYW5nZUxvZworKysgYi9KU1Rlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3 LTAzLTIzICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgorCisgICAgICAg IFtKU0NdIFVzZSBqc05vbnRyaXZpYWxTdHJpbmcgYWdyZXNzaXZlbHkgZm9yIFRvU3RyaW5nKElu dDUyKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcw MDAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBz dHJlc3MvdG8tc3RyaW5nLWludDUyLmpzOiBBZGRlZC4KKyAgICAgICAgKHNob3VsZEJlKToKKyAg ICAgICAgKHRvU3RyaW5nMTApOgorICAgICAgICAoZXhwZWN0ZWQpOgorCiAyMDE3LTAzLTIyICBZ dXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29tPgogCiAgICAgICAgIFtKU0NdW0RG R10gUHJvcGFnYXRlIEFueUludEFzRG91YmxlIGluZm9ybWF0aW9uIGNhcmVmdWxseSB0byB1dGls aXplIGl0IGluIGZpeHVwCmRpZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVzcy90by1zdHJpbmctaW50 NTIuanMgYi9KU1Rlc3RzL3N0cmVzcy90by1zdHJpbmctaW50NTIuanMKbmV3IGZpbGUgbW9kZSAx MDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZTFm MzIzZjc2NTRhMWM5ZWQ1OTc5ZTk0NGQwYzI4NmYzMjcxYjhlNAotLS0gL2Rldi9udWxsCisrKyBi L0pTVGVzdHMvc3RyZXNzL3RvLXN0cmluZy1pbnQ1Mi5qcwpAQCAtMCwwICsxLDU5IEBACitmdW5j dGlvbiBzaG91bGRCZShhY3R1YWwsIGV4cGVjdGVkKQoreworICAgIGlmIChhY3R1YWwgIT09IGV4 cGVjdGVkKQorICAgICAgICB0aHJvdyBuZXcgRXJyb3IoYGJhZCB2YWx1ZTogZXhwZWN0ZWQ6KCR7 ZXhwZWN0ZWR9KSxhY3R1YWw6KCR7YWN0dWFsfSlgKTsKK30KKworZnVuY3Rpb24gdG9TdHJpbmco dmFsdWUsIHJhZGl4KQoreworICAgIHJldHVybiBmaWF0SW50NTIodmFsdWUpLnRvU3RyaW5nKHJh ZGl4KTsKK30KK25vSW5saW5lKHRvU3RyaW5nKTsKKworZnVuY3Rpb24gdG9TdHJpbmcxMCh2YWx1 ZSkKK3sKKyAgICByZXR1cm4gYCR7ZmlhdEludDUyKHZhbHVlKX1gOworfQorbm9JbmxpbmUodG9T dHJpbmcxMCk7CisKK2Z1bmN0aW9uIGV4cGVjdGVkKG51bSwgcmFkaXgpCit7CisgICAgbGV0IGNo YXJhY3RlcnMgPSAiMDEyMzQ1Njc4OWFiY2RlZmdoaWprbG1ub3BxcnN0dXZ3eHl6IjsKKyAgICBs ZXQgcmVzdWx0ID0gIiI7CisgICAgbGV0IG5lZ2F0aXZlID0gZmFsc2U7CisgICAgaWYgKG51bSA8 IDApIHsKKyAgICAgICAgbmVnYXRpdmUgPSB0cnVlOworICAgICAgICBudW0gPSAtbnVtOworICAg IH0KKworICAgIGRvIHsKKyAgICAgICAgY29uc3QgaW5kZXggPSBudW0gJSByYWRpeDsKKyAgICAg ICAgcmVzdWx0ID0gY2hhcmFjdGVyc1tpbmRleF0gKyByZXN1bHQ7CisgICAgICAgIG51bSA9IChu dW0gLSBpbmRleCkgLyByYWRpeDsKKyAgICB9IHdoaWxlIChudW0pOworCisgICAgaWYgKG5lZ2F0 aXZlKQorICAgICAgICByZXR1cm4gJy0nICsgcmVzdWx0OworICAgIHJldHVybiByZXN1bHQ7Cit9 CisKK2ZvciAodmFyIGkgPSAwOyBpIDwgMWU0OyArK2kpIHsKKyAgICB0b1N0cmluZyhpLCAxMCk7 CisgICAgdG9TdHJpbmcoaSwgMzYpOworICAgIHRvU3RyaW5nMTAoaSk7Cit9CisKK2ZvciAodmFy IHJhZGl4ID0gMjsgcmFkaXggPCAzNzsgKytyYWRpeCkgeworICAgIGZvciAodmFyIGxlc3NUaGFu UmFkaXggPSAtMjAwMDsgbGVzc1RoYW5SYWRpeCA8IHJhZGl4OyArK2xlc3NUaGFuUmFkaXgpCisg ICAgICAgIHNob3VsZEJlKHRvU3RyaW5nKGxlc3NUaGFuUmFkaXgsIHJhZGl4KSwgZXhwZWN0ZWQo bGVzc1RoYW5SYWRpeCwgcmFkaXgpKTsKKyAgICBmb3IgKHZhciBncmVhdGVyVGhhblJhZGl4ID0g cmFkaXg7IGdyZWF0ZXJUaGFuUmFkaXggPCAyMDAwOyArK2dyZWF0ZXJUaGFuUmFkaXgpCisgICAg ICAgIHNob3VsZEJlKHRvU3RyaW5nKGdyZWF0ZXJUaGFuUmFkaXgsIHJhZGl4KSwgZXhwZWN0ZWQo Z3JlYXRlclRoYW5SYWRpeCwgcmFkaXgpKTsKK30KKworeworICAgIHZhciByYWRpeCA9IDEwOwor ICAgIGZvciAodmFyIGxlc3NUaGFuUmFkaXggPSAtMjAwMDsgbGVzc1RoYW5SYWRpeCA8IHJhZGl4 OyArK2xlc3NUaGFuUmFkaXgpCisgICAgICAgIHNob3VsZEJlKHRvU3RyaW5nMTAobGVzc1RoYW5S YWRpeCksIGV4cGVjdGVkKGxlc3NUaGFuUmFkaXgsIHJhZGl4KSk7CisgICAgZm9yICh2YXIgZ3Jl YXRlclRoYW5SYWRpeCA9IHJhZGl4OyBncmVhdGVyVGhhblJhZGl4IDwgMjAwMDsgKytncmVhdGVy VGhhblJhZGl4KQorICAgICAgICBzaG91bGRCZSh0b1N0cmluZzEwKGdyZWF0ZXJUaGFuUmFkaXgp LCBleHBlY3RlZChncmVhdGVyVGhhblJhZGl4LCByYWRpeCkpOworfQo=