169969 2017-03-22 13:44:54 -0700 Only run volume-related autoplay policy tests on Mac 2017-03-23 09:41:11 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mrajca webkit-unassigned webkit-bug-importer oldest_to_newest 1290192 0 mrajca 2017-03-22 13:44:54 -0700 iOS does not support volume changes to media elements so these tests are timing out. 1290202 1 305125 mrajca 2017-03-22 13:55:31 -0700 Created attachment 305125 Patch 1290218 2 305125 achristensen 2017-03-22 15:13:31 -0700 Comment on attachment 305125 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305125&action=review > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:218 > +#if PLATFORM(MAC) I would put a comment here explaining why this is disabled on iOS. 1290220 3 mrajca 2017-03-22 15:22:31 -0700 (In reply to Alex Christensen from comment #2) > Comment on attachment 305125 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=305125&action=review > > > Tools/TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:218 > > +#if PLATFORM(MAC) > > I would put a comment here explaining why this is disabled on iOS. Done. 1290221 4 mrajca 2017-03-22 15:23:38 -0700 https://trac.webkit.org/changeset/214278/webkit 1290465 5 webkit-bug-importer 2017-03-23 09:36:32 -0700 <rdar://problem/31221127> 305125 2017-03-22 13:55:31 -0700 2017-03-22 15:13:31 -0700 Patch patch.diff text/plain 2863 mrajca ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmOTU3 MjRjZjc2OS4uMmM3OTc3OGZmMzMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNy0wMy0yMiAgTWF0dCBSYWpjYSAg PG1yYWpjYUBhcHBsZS5jb20+CisKKyAgICAgICAgT25seSBydW4gdm9sdW1lLXJlbGF0ZWQgYXV0 b3BsYXkgcG9saWN5IHRlc3RzIG9uIE1hYy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE2OTk2OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIGlPUyBkb2VzIG5vdCBzdXBwb3J0IHZvbHVtZSBjaGFuZ2VzIHRv IG1lZGlhIGVsZW1lbnRzIHNvIHRoZXNlIHRlc3RzIGFyZSB0aW1pbmcgb3V0LgorCisgICAgICAg ICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyQ29jb2EvV2Vic2l0ZVBvbGljaWVzLm1tOgor ICAgICAgICAoVEVTVCk6CisKIDIwMTctMDMtMjAgIE1hdHQgUmFqY2EgIDxtcmFqY2FAYXBwbGUu Y29tPgogCiAgICAgICAgIExvb3NlbiBhdWRpbyBwbGF5YmFjayByZXN0cmljdGlvbnMgd2hlbiB0 aGUgdm9sdW1lIGlzIDAuCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dl YktpdDJDb2NvYS9XZWJzaXRlUG9saWNpZXMubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3Rz L1dlYktpdDJDb2NvYS9XZWJzaXRlUG9saWNpZXMubW0KaW5kZXggMWRlOTNhMTIzMzkuLjg2ODc3 NWQ3MDY0IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJDb2Nv YS9XZWJzaXRlUG9saWNpZXMubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL aXQyQ29jb2EvV2Vic2l0ZVBvbGljaWVzLm1tCkBAIC0yMTQsOCArMjE0LDExIEBAIFRFU1QoV2Vi S2l0MiwgV2Vic2l0ZVBvbGljaWVzQXV0b3BsYXlFbmFibGVkKQogCiAgICAgTlNVUkxSZXF1ZXN0 ICpyZXF1ZXN0V2l0aEF1ZGlvID0gW05TVVJMUmVxdWVzdCByZXF1ZXN0V2l0aFVSTDpbW05TQnVu ZGxlIG1haW5CdW5kbGVdIFVSTEZvclJlc291cmNlOkAiYXV0b3BsYXktY2hlY2siIHdpdGhFeHRl bnNpb246QCJodG1sIiBzdWJkaXJlY3Rvcnk6QCJUZXN0V2ViS2l0QVBJLnJlc291cmNlcyJdXTsK ICAgICBOU1VSTFJlcXVlc3QgKnJlcXVlc3RXaXRob3V0QXVkaW8gPSBbTlNVUkxSZXF1ZXN0IHJl cXVlc3RXaXRoVVJMOltbTlNCdW5kbGUgbWFpbkJ1bmRsZV0gVVJMRm9yUmVzb3VyY2U6QCJhdXRv cGxheS1uby1hdWRpby1jaGVjayIgd2l0aEV4dGVuc2lvbjpAImh0bWwiIHN1YmRpcmVjdG9yeTpA IlRlc3RXZWJLaXRBUEkucmVzb3VyY2VzIl1dOworCisjaWYgUExBVEZPUk0oTUFDKQogICAgIE5T VVJMUmVxdWVzdCAqcmVxdWVzdFdpdGhvdXRWb2x1bWUgPSBbTlNVUkxSZXF1ZXN0IHJlcXVlc3RX aXRoVVJMOltbTlNCdW5kbGUgbWFpbkJ1bmRsZV0gVVJMRm9yUmVzb3VyY2U6QCJhdXRvcGxheS16 ZXJvLXZvbHVtZS1jaGVjayIgd2l0aEV4dGVuc2lvbjpAImh0bWwiIHN1YmRpcmVjdG9yeTpAIlRl c3RXZWJLaXRBUEkucmVzb3VyY2VzIl1dOwotICAgIAorI2VuZGlmCisKICAgICBbZGVsZWdhdGUg c2V0QXV0b3BsYXlQb2xpY3lGb3JVUkw6XihOU1VSTCAqKSB7CiAgICAgICAgIHJldHVybiBfV0tX ZWJzaXRlQXV0b3BsYXlQb2xpY3lBbGxvd1dpdGhvdXRTb3VuZDsKICAgICB9XTsKQEAgLTIyNSwx NCArMjI4LDE5IEBAIFRFU1QoV2ViS2l0MiwgV2Vic2l0ZVBvbGljaWVzQXV0b3BsYXlFbmFibGVk KQogICAgIFt3ZWJWaWV3IGxvYWRSZXF1ZXN0OnJlcXVlc3RXaXRob3V0QXVkaW9dOwogICAgIFt3 ZWJWaWV3IHdhaXRGb3JNZXNzYWdlOkAiYXV0b3BsYXllZCJdOwogCisjaWYgUExBVEZPUk0oTUFD KQogICAgIFt3ZWJWaWV3IGxvYWRSZXF1ZXN0OnJlcXVlc3RXaXRob3V0Vm9sdW1lXTsKICAgICBb d2ViVmlldyB3YWl0Rm9yTWVzc2FnZTpAImF1dG9wbGF5ZWQiXTsKKyNlbmRpZgogCiAgICAgW2Rl bGVnYXRlIHNldEF1dG9wbGF5UG9saWN5Rm9yVVJMOl4oTlNVUkwgKikgewogICAgICAgICByZXR1 cm4gX1dLV2Vic2l0ZUF1dG9wbGF5UG9saWN5RGVueTsKICAgICB9XTsKKworI2lmIFBMQVRGT1JN KE1BQykKICAgICBbd2ViVmlldyBsb2FkUmVxdWVzdDpyZXF1ZXN0V2l0aG91dFZvbHVtZV07CiAg ICAgW3dlYlZpZXcgd2FpdEZvck1lc3NhZ2U6QCJkaWQtbm90LXBsYXkiXTsKKyNlbmRpZgogCiAg ICAgW3dlYlZpZXcgbG9hZFJlcXVlc3Q6cmVxdWVzdFdpdGhBdWRpb107CiAgICAgW3dlYlZpZXcg d2FpdEZvck1lc3NhZ2U6QCJkaWQtbm90LXBsYXkiXTsKQEAgLTI1Niw4ICsyNjQsMTAgQEAgVEVT VChXZWJLaXQyLCBXZWJzaXRlUG9saWNpZXNBdXRvcGxheUVuYWJsZWQpCiAgICAgW3dlYlZpZXcg bG9hZFJlcXVlc3Q6cmVxdWVzdFdpdGhvdXRBdWRpb107CiAgICAgW3dlYlZpZXcgd2FpdEZvck1l c3NhZ2U6QCJhdXRvcGxheWVkIl07CiAKKyNpZiBQTEFURk9STShNQUMpCiAgICAgW3dlYlZpZXcg bG9hZFJlcXVlc3Q6cmVxdWVzdFdpdGhvdXRWb2x1bWVdOwogICAgIFt3ZWJWaWV3IHdhaXRGb3JN ZXNzYWdlOkAiYXV0b3BsYXllZCJdOworI2VuZGlmCiAKICAgICBOU1VSTFJlcXVlc3QgKnJlcXVl c3RXaXRoQXVkaW9JbklGcmFtZSA9IFtOU1VSTFJlcXVlc3QgcmVxdWVzdFdpdGhVUkw6W1tOU0J1 bmRsZSBtYWluQnVuZGxlXSBVUkxGb3JSZXNvdXJjZTpAImF1dG9wbGF5LWNoZWNrLWluLWlmcmFt ZSIgd2l0aEV4dGVuc2lvbjpAImh0bWwiIHN1YmRpcmVjdG9yeTpAIlRlc3RXZWJLaXRBUEkucmVz b3VyY2VzIl1dOwogCg==