169965 2017-03-22 12:28:20 -0700 [JSC] Use jsNontrivialString for Number toString operations 2017-03-22 13:07:28 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ysuzuki ysuzuki buildbot keith_miller mark.lam msaboff saam oldest_to_newest 1290159 0 ysuzuki 2017-03-22 12:28:20 -0700 ... 1290167 1 305117 ysuzuki 2017-03-22 12:52:40 -0700 Created attachment 305117 Patch 1290170 2 305117 mark.lam 2017-03-22 12:57:55 -0700 Comment on attachment 305117 Patch r=me 1290172 3 ysuzuki 2017-03-22 13:07:28 -0700 Committed r214272: <http://trac.webkit.org/changeset/214272> 305117 2017-03-22 12:52:40 -0700 2017-03-22 12:57:55 -0700 Patch bug-169965-20170323045238.patch text/plain 4646 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0MjI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA4 M2I2MmIxZDQ4OTY1OTg0MGFhNWIxYjZiZWNhNTYxZTU0MDU1Mjc4Li42YmVjNmNhZjIzMmU1NTE0 YjE2ZDhmZjlhNDFiMmFhYTg5ZTNmOTAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxNy0wMy0yMiAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbSlNDXSBVc2UganNOb250cml2aWFsU3RyaW5nIGZvciBOdW1iZXIg dG9TdHJpbmcgb3BlcmF0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTY5OTY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWZ0ZXIgc2luZ2xlIGNoYXJhY3RlciBjaGVjaywgcHJvZHVjZWQgc3RyaW5n IGlzIGFsd2F5cyBsb25nZXIgdGhhbiAxLgorICAgICAgICBUaHVzLCB3ZSBjYW4gdXNlIGpzTm9u dHJpdmlhbFN0cmluZy4KKworICAgICAgICAqIHJ1bnRpbWUvTnVtYmVyUHJvdG90eXBlLmNwcDoK KyAgICAgICAgKEpTQzo6aW50MzJUb1N0cmluZ0ludGVybmFsKToKKwogMjAxNy0wMy0yMSAgQ3Nh YmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFtBUk1dIEFkZCBt aXNzaW5nIE1hY3JvQXNzZW1ibGVyIGZ1bmN0aW9ucyBhZnRlciByMjE0MTg3CmRpZmYgLS1naXQg YS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9OdW1iZXJQcm90b3R5cGUuY3BwIGIvU291 cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvTnVtYmVyUHJvdG90eXBlLmNwcAppbmRleCA5NGU1 MWMwOTFjNjkxYmIzMTc0YTk4YTY0OThhZWZkODhkMTRiNjIzLi42ZDFlYzBmYmFmYTczMDcxZDEy NDRlNDI1ZDAzNzlmOGE3NjNjMjg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv cnVudGltZS9OdW1iZXJQcm90b3R5cGUuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL051bWJlclByb3RvdHlwZS5jcHAKQEAgLTQ5OSw3ICs0OTksNyBAQCBzdGF0aWMgaW5s aW5lIGludDMyX3QgZXh0cmFjdFJhZGl4RnJvbUFyZ3MoRXhlY1N0YXRlKiBleGVjKQogICAgIHJl dHVybiByYWRpeDsKIH0KIAotc3RhdGljIGlubGluZSBKU1N0cmluZyogaW50MzJUb1N0cmluZ0lu dGVybmFsKFZNJiB2bSwgaW50MzJfdCB2YWx1ZSwgaW50MzJfdCByYWRpeCkKK3N0YXRpYyBBTFdB WVNfSU5MSU5FIEpTU3RyaW5nKiBpbnQzMlRvU3RyaW5nSW50ZXJuYWwoVk0mIHZtLCBpbnQzMl90 IHZhbHVlLCBpbnQzMl90IHJhZGl4KQogewogICAgIEFTU0VSVCghKHJhZGl4IDwgMiB8fCByYWRp eCA+IDM2KSk7CiAgICAgLy8gQSBuZWdhdGl2ZSB2YWx1ZSBjYXN0ZWQgdG8gdW5zaWduZWQgd291 bGQgYmUgYmlnZ2VyIHRoYW4gMzYgKHRoZSBtYXggcmFkaXgpLgpAQCAtNTA5LDExICs1MDksMTAg QEAgc3RhdGljIGlubGluZSBKU1N0cmluZyogaW50MzJUb1N0cmluZ0ludGVybmFsKFZNJiB2bSwg aW50MzJfdCB2YWx1ZSwgaW50MzJfdCByYWQKICAgICAgICAgcmV0dXJuIHZtLnNtYWxsU3RyaW5n cy5zaW5nbGVDaGFyYWN0ZXJTdHJpbmcocmFkaXhEaWdpdHNbdmFsdWVdKTsKICAgICB9CiAKLSAg ICBpZiAocmFkaXggPT0gMTApIHsKLSAgICAgICAgcmV0dXJuIGpzU3RyaW5nKCZ2bSwgdm0ubnVt ZXJpY1N0cmluZ3MuYWRkKHZhbHVlKSk7Ci0gICAgfQorICAgIGlmIChyYWRpeCA9PSAxMCkKKyAg ICAgICAgcmV0dXJuIGpzTm9udHJpdmlhbFN0cmluZygmdm0sIHZtLm51bWVyaWNTdHJpbmdzLmFk ZCh2YWx1ZSkpOwogCi0gICAgcmV0dXJuIGpzU3RyaW5nKCZ2bSwgdG9TdHJpbmdXaXRoUmFkaXgo dmFsdWUsIHJhZGl4KSk7CisgICAgcmV0dXJuIGpzTm9udHJpdmlhbFN0cmluZygmdm0sIHRvU3Ry aW5nV2l0aFJhZGl4KHZhbHVlLCByYWRpeCkpOwogCiB9CiAKZGlmZiAtLWdpdCBhL0pTVGVzdHMv Q2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYWFjY2ZmYmY0OWIwZGM1NDM4MGIy ODU5MDdjZWRhYjQ0MzliMjhhZi4uYjc5MTk1NjE1NjhjNGU3NTVjMzVkMjE0MmU5MTZmZjRiYTM5 YTNlMCAxMDA2NDQKLS0tIGEvSlNUZXN0cy9DaGFuZ2VMb2cKKysrIGIvSlNUZXN0cy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNSBAQAorMjAxNy0wMy0yMiAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUu dGVhQGdtYWlsLmNvbT4KKworICAgICAgICBbSlNDXSBVc2UganNOb250cml2aWFsU3RyaW5nIGZv ciBOdW1iZXIgdG9TdHJpbmcgb3BlcmF0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY5OTY1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvdG8tc3RyaW5nLWludDMyLmpzOiBBZGRlZC4K KyAgICAgICAgKHNob3VsZEJlKToKKyAgICAgICAgKHRvU3RyaW5nMTApOgorICAgICAgICAoZXhw ZWN0ZWQpOgorCiAyMDE3LTAzLTIxICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwu Y29tPgogCiAgICAgICAgIFtKU0NdIE9wdGltaXplIE51bWJlci5wcm90b3R5cGUudG9TdHJpbmcg b24gSW50MzIgLyBJbnQ1MiAvIERvdWJsZQpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3MvdG8t c3RyaW5nLWludDMyLmpzIGIvSlNUZXN0cy9zdHJlc3MvdG8tc3RyaW5nLWludDMyLmpzCm5ldyBm aWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAuLjUyNzlmZTVjNmQzNTZmNDRmYmUwZDRjZDU2MDkwOWI2ZWYyMjIwZTMKLS0tIC9kZXYv bnVsbAorKysgYi9KU1Rlc3RzL3N0cmVzcy90by1zdHJpbmctaW50MzIuanMKQEAgLTAsMCArMSw1 OSBAQAorZnVuY3Rpb24gc2hvdWxkQmUoYWN0dWFsLCBleHBlY3RlZCkKK3sKKyAgICBpZiAoYWN0 dWFsICE9PSBleHBlY3RlZCkKKyAgICAgICAgdGhyb3cgbmV3IEVycm9yKGBiYWQgdmFsdWU6IGV4 cGVjdGVkOigke2V4cGVjdGVkfSksYWN0dWFsOigke2FjdHVhbH0pYCk7Cit9CisKK2Z1bmN0aW9u IHRvU3RyaW5nKHZhbHVlLCByYWRpeCkKK3sKKyAgICByZXR1cm4gdmFsdWUudG9TdHJpbmcocmFk aXgpOworfQorbm9JbmxpbmUodG9TdHJpbmcpOworCitmdW5jdGlvbiB0b1N0cmluZzEwKHZhbHVl KQoreworICAgIHJldHVybiBgJHt2YWx1ZX1gOworfQorbm9JbmxpbmUodG9TdHJpbmcxMCk7CisK K2Z1bmN0aW9uIGV4cGVjdGVkKG51bSwgcmFkaXgpCit7CisgICAgbGV0IGNoYXJhY3RlcnMgPSAi MDEyMzQ1Njc4OWFiY2RlZmdoaWprbG1ub3BxcnN0dXZ3eHl6IjsKKyAgICBsZXQgcmVzdWx0ID0g IiI7CisgICAgbGV0IG5lZ2F0aXZlID0gZmFsc2U7CisgICAgaWYgKG51bSA8IDApIHsKKyAgICAg ICAgbmVnYXRpdmUgPSB0cnVlOworICAgICAgICBudW0gPSAtbnVtOworICAgIH0KKworICAgIGRv IHsKKyAgICAgICAgY29uc3QgaW5kZXggPSBudW0gJSByYWRpeDsKKyAgICAgICAgcmVzdWx0ID0g Y2hhcmFjdGVyc1tpbmRleF0gKyByZXN1bHQ7CisgICAgICAgIG51bSA9IChudW0gLSBpbmRleCkg LyByYWRpeDsKKyAgICB9IHdoaWxlIChudW0pOworCisgICAgaWYgKG5lZ2F0aXZlKQorICAgICAg ICByZXR1cm4gJy0nICsgcmVzdWx0OworICAgIHJldHVybiByZXN1bHQ7Cit9CisKK2ZvciAodmFy IGkgPSAwOyBpIDwgMWU0OyArK2kpIHsKKyAgICB0b1N0cmluZyhpLCAxMCk7CisgICAgdG9TdHJp bmcoaSwgMzYpOworICAgIHRvU3RyaW5nMTAoaSk7Cit9CisKK2ZvciAodmFyIHJhZGl4ID0gMjsg cmFkaXggPCAzNzsgKytyYWRpeCkgeworICAgIGZvciAodmFyIGxlc3NUaGFuUmFkaXggPSAtMjAw MDsgbGVzc1RoYW5SYWRpeCA8IHJhZGl4OyArK2xlc3NUaGFuUmFkaXgpCisgICAgICAgIHNob3Vs ZEJlKHRvU3RyaW5nKGxlc3NUaGFuUmFkaXgsIHJhZGl4KSwgZXhwZWN0ZWQobGVzc1RoYW5SYWRp eCwgcmFkaXgpKTsKKyAgICBmb3IgKHZhciBncmVhdGVyVGhhblJhZGl4ID0gcmFkaXg7IGdyZWF0 ZXJUaGFuUmFkaXggPCAyMDAwOyArK2dyZWF0ZXJUaGFuUmFkaXgpCisgICAgICAgIHNob3VsZEJl KHRvU3RyaW5nKGdyZWF0ZXJUaGFuUmFkaXgsIHJhZGl4KSwgZXhwZWN0ZWQoZ3JlYXRlclRoYW5S YWRpeCwgcmFkaXgpKTsKK30KKworeworICAgIHZhciByYWRpeCA9IDEwOworICAgIGZvciAodmFy IGxlc3NUaGFuUmFkaXggPSAtMjAwMDsgbGVzc1RoYW5SYWRpeCA8IHJhZGl4OyArK2xlc3NUaGFu UmFkaXgpCisgICAgICAgIHNob3VsZEJlKHRvU3RyaW5nMTAobGVzc1RoYW5SYWRpeCksIGV4cGVj dGVkKGxlc3NUaGFuUmFkaXgsIHJhZGl4KSk7CisgICAgZm9yICh2YXIgZ3JlYXRlclRoYW5SYWRp eCA9IHJhZGl4OyBncmVhdGVyVGhhblJhZGl4IDwgMjAwMDsgKytncmVhdGVyVGhhblJhZGl4KQor ICAgICAgICBzaG91bGRCZSh0b1N0cmluZzEwKGdyZWF0ZXJUaGFuUmFkaXgpLCBleHBlY3RlZChn cmVhdGVyVGhhblJhZGl4LCByYWRpeCkpOworfQo=