169938 2017-03-21 17:36:56 -0700 RTCPeerConnection is crashing if no backend is created 2017-03-22 11:00:30 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf achristensen commit-queue eric.carlson ggaren oldest_to_newest 1289911 0 youennf 2017-03-21 17:36:56 -0700 RTCPeerConnection is crashing if no backend is created. 1289915 1 305053 youennf 2017-03-21 17:42:59 -0700 Created attachment 305053 Patch 1289916 2 youennf 2017-03-21 17:43:37 -0700 Might be related to rdar://30796880 1289933 3 305053 ggaren 2017-03-21 18:48:32 -0700 Comment on attachment 305053 Patch I see a lot of methods that use m_backend and don't check for RTCSignalingState::Closed. How do we know they're OK? 1289954 4 youennf 2017-03-21 20:38:18 -0700 (In reply to Geoffrey Garen from comment #3) > Comment on attachment 305053 [details] > Patch > > I see a lot of methods that use m_backend and don't check for > RTCSignalingState::Closed. How do we know they're OK? Since RTCPeerConnection is a Once created, 1289955 5 youennf 2017-03-21 20:42:33 -0700 (In reply to youenn fablet from comment #4) > (In reply to Geoffrey Garen from comment #3) > > Comment on attachment 305053 [details] > > Patch > > > > I see a lot of methods that use m_backend and don't check for > > RTCSignalingState::Closed. How do we know they're OK? > > Since RTCPeerConnection is a > Once created, Since RTCPeerConnection is a JS built-in, once the C++ wrapper is created, initializeWith will be called and will return an exception. But the C++ object remains an active DOM object that remains to be stopped. Setting the state to closed allows RTCPeerConnection::close to be a no-op. But really, we should solve the real issue, which is that RTCPeerConnection is exposed while isLibWebRTCAvailable returns false. Once done, m_backend should be made a uniqueref. 1290119 6 305053 commit-queue 2017-03-22 11:00:25 -0700 Comment on attachment 305053 Patch Clearing flags on attachment: 305053 Committed r214262: <http://trac.webkit.org/changeset/214262> 1290120 7 commit-queue 2017-03-22 11:00:30 -0700 All reviewed patches have been landed. Closing bug. 305053 2017-03-21 17:42:59 -0700 2017-03-22 11:00:25 -0700 Patch bug-169938-20170321174258.patch text/plain 2235 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0MjIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTQwYjNiMDM0ZjI5NGQ3 NDEzYzBhZDM5NDM4ZGExODU0MmIzNmQwZS4uYzY4ZmYzNzViMWQ5NzQ3Y2I1M2JiZjdjYmJjOTNl NzFlYzc4MDliZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE3LTAzLTIxICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAorICAgICAgICBSVENQZWVyQ29ubmVjdGlv biBpcyBjcmFzaGluZyBpZiBubyBiYWNrZW5kIGlzIGNyZWF0ZWQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2OTkzOAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJUQ1BlZXJDb25uZWN0aW9uIHNob3VsZCBu b3QgYmUgdmlzaWJsZSBpZiBpdCBpcyBub3QgYWJsZSB0byBjcmVhdGUgYSBiYWNrZW5kLgorICAg ICAgICBJbiBjYXNlIHdoZW4gdGhpcyBoYXBwZW5zIGFueXdheSwgaXQgc2hvdWxkIGJlIGFibGUg dG8gYmUgc3RvcHBlZCBhbmQgZGVzdHJveWVkIHdpdGhvdXQgY3Jhc2hpbmcuCisgICAgICAgIFRv IGRvIHNvLCB3ZSBuZWVkIHRvIHNldCBpdHMgc3RhdGUgdG8gY2xvc2VkLgorCisgICAgICAgICog TW9kdWxlcy9tZWRpYXN0cmVhbS9SVENQZWVyQ29ubmVjdGlvbi5jcHA6CisgICAgICAgIChXZWJD b3JlOjpSVENQZWVyQ29ubmVjdGlvbjo6UlRDUGVlckNvbm5lY3Rpb24pOgorICAgICAgICAoV2Vi Q29yZTo6UlRDUGVlckNvbm5lY3Rpb246OmNsb3NlKTogQ29zbWV0aWMgY2hhbmdlLCBqdXN0IGlu IGNhc2Ugc3RvcCBiZWNvbWVzIHJlZW50cmFudCBhdCBzb21lIHBvaW50LgorCisyMDE3LTAzLTIx ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKwogICAgICAgICBbRmV0Y2ggQVBJ XSBpbXBsZW1lbnQgQWNjZXNzLUNvbnRyb2wtRXhwb3NlLUhlYWRlcnM6ICoKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2OTE5NAogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL1JUQ1BlZXJDb25uZWN0aW9uLmNw cCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24u Y3BwCmluZGV4IDc0MDkxYWRmYzJkNTBjYzE2YWZlYmI4MWQyNTg2MmExMDQwZDE2ZTEuLmU5ZmM4 MWQ3NjMwNTkwMTI3NjU4ZjZjZmYzZDExNDA5MmU2MGVmYmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24uY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzdHJlYW0vUlRDUGVlckNvbm5lY3Rpb24uY3BwCkBA IC03Niw2ICs3NiwxMCBAQCBSVENQZWVyQ29ubmVjdGlvbjo6UlRDUGVlckNvbm5lY3Rpb24oU2Ny aXB0RXhlY3V0aW9uQ29udGV4dCYgY29udGV4dCkKICAgICA6IEFjdGl2ZURPTU9iamVjdCgmY29u dGV4dCkKICAgICAsIG1fYmFja2VuZChQZWVyQ29ubmVjdGlvbkJhY2tlbmQ6OmNyZWF0ZSgqdGhp cykpCiB7CisgICAgaWYgKCFtX2JhY2tlbmQpIHsKKyAgICAgICAgbV9zaWduYWxpbmdTdGF0ZSA9 IFJUQ1NpZ25hbGluZ1N0YXRlOjpDbG9zZWQ7CisgICAgICAgIG1faWNlQ29ubmVjdGlvblN0YXRl ID0gUlRDSWNlQ29ubmVjdGlvblN0YXRlOjpDbG9zZWQ7CisgICAgfQogfQogCiBSVENQZWVyQ29u bmVjdGlvbjo6flJUQ1BlZXJDb25uZWN0aW9uKCkKQEAgLTM1NCwxMSArMzU4LDExIEBAIHZvaWQg UlRDUGVlckNvbm5lY3Rpb246OmNsb3NlKCkKICAgICBpZiAobV9zaWduYWxpbmdTdGF0ZSA9PSBS VENTaWduYWxpbmdTdGF0ZTo6Q2xvc2VkKQogICAgICAgICByZXR1cm47CiAKLSAgICBtX2JhY2tl bmQtPnN0b3AoKTsKLQogICAgIG1faWNlQ29ubmVjdGlvblN0YXRlID0gUlRDSWNlQ29ubmVjdGlv blN0YXRlOjpDbG9zZWQ7CiAgICAgbV9zaWduYWxpbmdTdGF0ZSA9IFJUQ1NpZ25hbGluZ1N0YXRl OjpDbG9zZWQ7CiAKKyAgICBtX2JhY2tlbmQtPnN0b3AoKTsKKwogICAgIGZvciAoUlRDUnRwU2Vu ZGVyJiBzZW5kZXIgOiBtX3RyYW5zY2VpdmVyU2V0LT5zZW5kZXJzKCkpCiAgICAgICAgIHNlbmRl ci5zdG9wKCk7CiAK