169937 2017-03-21 17:26:12 -0700 EWS fails to parse_bug_id_from_attachment_page after bugzilla upgrade 2017-03-21 17:46:21 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap ddkilzer lforschler oldest_to_newest 1289908 0 aakash_jain 2017-03-21 17:26:12 -0700 After bugzilla upgrade, ews fails in parse_bug_id_from_attachment_page() method. See <rdar://problem/31181859>. 1289909 1 305052 aakash_jain 2017-03-21 17:32:07 -0700 Created attachment 305052 Proposed patch This might not solve all the EWS problem, and we might uncover more problems. But this fix atleast the mentioned problem. 1289910 2 305052 ap 2017-03-21 17:35:44 -0700 Comment on attachment 305052 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=305052&action=review > Tools/Scripts/webkitpy/common/net/bugzilla/bugzilla.py:494 > + match = re.search("show_bug.cgi\?id=(?P<bug_id>\d+)", str(title)) > return int(match.group('bug_id')) Can something be printed to the log if this fails? 1289917 3 aakash_jain 2017-03-21 17:46:14 -0700 Committed http://trac.webkit.org/r214238 Printed a log statement when no match is found. 305052 2017-03-21 17:32:07 -0700 2017-03-21 17:35:44 -0700 Proposed patch patch_ews_fix_parse_bug_id text/plain 2657 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNDIzNykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE3LTAzLTIxICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBFV1MgZmFpbHMgdG8gcGFyc2VfYnVnX2lkX2Zyb21fYXR0YWNobWVudF9w YWdlIGFmdGVyIGJ1Z3ppbGxhIHVwZ3JhZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE2OTkzNworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzExODE4 NTk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVnemlsbGEvYnVnemlsbGEucHk6CisgICAgICAg IChCdWd6aWxsYS5fcGFyc2VfYnVnX2lkX2Zyb21fYXR0YWNobWVudF9wYWdlKTogU2luY2UgcmVs IHRhZyBpcyBubyBsb25nZXIgcHJlc2VudCwgcGFyc2luZyB0aGUgYnVnIGlkIGZyb20gYnVnX3Rp dGxlLiAKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVnemlsbGEvYnVn emlsbGFfdW5pdHRlc3QucHk6IEZpeGVkIHVuaXQgdGVzdC4KKwogMjAxNy0wMy0yMSAgQWFrYXNo IEphaW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgZXdzIHNob3VsZCBpbmRp Y2F0ZSBpbiBsb2dzIHdoZW4gaXQgZmFpbHMgdG8gcGFyc2VfYnVnX2lkX2Zyb21fYXR0YWNobWVu dF9wYWdlCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVnemlsbGEv YnVnemlsbGEucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24v bmV0L2J1Z3ppbGxhL2J1Z3ppbGxhLnB5CShyZXZpc2lvbiAyMTQyMzMpCisrKyBUb29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVnemlsbGEvYnVnemlsbGEucHkJKHdvcmtpbmcgY29w eSkKQEAgLTQ4NiwxMSArNDg2LDExIEBAIGNsYXNzIEJ1Z3ppbGxhKG9iamVjdCk6CiAKICAgICBk ZWYgX3BhcnNlX2J1Z19pZF9mcm9tX2F0dGFjaG1lbnRfcGFnZShzZWxmLCBwYWdlKToKICAgICAg ICAgIyBUaGUgIlVwIiByZWxhdGlvbiBoYXBwZW5zIHRvIHBvaW50IHRvIHRoZSBidWcuCi0gICAg ICAgIHVwX2xpbmsgPSBCZWF1dGlmdWxTb3VwKHBhZ2UpLmZpbmQoJ2xpbmsnLCByZWw9J1VwJykK LSAgICAgICAgaWYgbm90IHVwX2xpbms6CisgICAgICAgIHRpdGxlID0gQmVhdXRpZnVsU291cChw YWdlKS5maW5kKCdkaXYnLCBhdHRycz17J2lkJzonYnVnX3RpdGxlJ30pCisgICAgICAgIGlmIG5v dCB0aXRsZSA6CiAgICAgICAgICAgICBfbG9nLndhcm5pbmcoIlRoaXMgYXR0YWNobWVudCBkb2Vz IG5vdCBleGlzdCAob3IgeW91IGRvbid0IGhhdmUgcGVybWlzc2lvbnMgdG8gdmlldyBpdCkuIikK ICAgICAgICAgICAgIHJldHVybiBOb25lCi0gICAgICAgIG1hdGNoID0gcmUuc2VhcmNoKCJzaG93 X2J1Zy5jZ2lcP2lkPSg/UDxidWdfaWQ+XGQrKSIsIHVwX2xpbmtbJ2hyZWYnXSkKKyAgICAgICAg bWF0Y2ggPSByZS5zZWFyY2goInNob3dfYnVnLmNnaVw/aWQ9KD9QPGJ1Z19pZD5cZCspIiwgc3Ry KHRpdGxlKSkKICAgICAgICAgcmV0dXJuIGludChtYXRjaC5ncm91cCgnYnVnX2lkJykpCiAKICAg ICBkZWYgYnVnX2lkX2Zvcl9hdHRhY2htZW50X2lkKHNlbGYsIGF0dGFjaG1lbnRfaWQpOgpJbmRl eDogVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1Z3ppbGxhL2J1Z3ppbGxhX3Vu aXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25l dC9idWd6aWxsYS9idWd6aWxsYV91bml0dGVzdC5weQkocmV2aXNpb24gMjE0MjMzKQorKysgVG9v bHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1Z3ppbGxhL2J1Z3ppbGxhX3VuaXR0ZXN0 LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yMzgsOCArMjM4LDkgQEAgSWdub3JlIHRoaXMgYnVnLiAg SnVzdCBmb3IgdGVzdGluZyBmYWlsdQogICA8aGVhZD4KICAgICA8dGl0bGU+CiAgIEF0dGFjaG1l bnQgNDEwNzMgRGV0YWlscyBmb3IgQnVnIDI3MzE0PC90aXRsZT4KLTxsaW5rIHJlbD0iVG9wIiBo cmVmPSJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy8iPgotICAgIDxsaW5rIHJlbD0iVXAiIGhyZWY9 InNob3dfYnVnLmNnaT9pZD0yNzMxNCI+Cis8ZGl2IGlkPSJidWdfdGl0bGUiPgorICBBdHRhY2ht ZW50IDQxMDczIERldGFpbHMgZm9yCisgIDxhIGNsYXNzPSJiel9idWdfbGluayBiel9zdGF0dXNf QVNTSUdORUQgIiB0aXRsZT0iU2FtcGxlIGJ1ZyIgaHJlZj0ic2hvd19idWcuY2dpP2lkPTI3MzE0 Ij5CdWcgMjczMTQ8L2E+OiBTYW1wbGUgYnVnPC9kaXY+CiAiIiIKIAogICAgIGRlZiB0ZXN0X2F0 dGFjaG1lbnRfZGV0YWlsX2J1Z19wYXJzaW5nKHNlbGYpOgo=