169915 2017-03-21 06:26:29 -0700 [GTK] Several WPT tests are failing since they were added in the last update in r213882 2017-03-22 01:44:34 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugzilla.gnome.org/show_bug.cgi?id=780352 Gtk, LayoutTestFailure, Soup P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply danw oldest_to_newest 1289763 0 cgarcia 2017-03-21 06:26:29 -0700 imported/w3c/web-platform-tests/XMLHttpRequest/getallresponseheaders-cl.htm imported/w3c/web-platform-tests/XMLHttpRequest/getallresponseheaders.htm imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type.htm All of them fail because libsoup fails to load the requests because the response doesn't include the empty line after the headers. Other browsers allow that, so I've written a patch for libsoup in https://bugzilla.gnome.org/show_bug.cgi?id=780352. While the patch is reviewed and we have a new libsoup version to depend on, we can probably add the patch to our jhbuild to make sure those test pass and don't regress. 1289765 1 cgarcia 2017-03-21 06:41:09 -0700 Actually, with libsoup patched imported/w3c/web-platform-tests/XMLHttpRequest/getallresponseheaders-cl.htm passes, imported/w3c/web-platform-tests/XMLHttpRequest/getallresponseheaders.htm still fails, but it no longer timeouts and resultds are pretty much the same, and imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type.htm still fails with the same errors. 1289766 2 cgarcia 2017-03-21 07:10:10 -0700 imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type.htm no longer works with the current version of wptserve, so I'm going to remove our expectations, since the test is skipped globally. 1289770 3 cgarcia 2017-03-21 07:41:25 -0700 Our result for imported/w3c/web-platform-tests/XMLHttpRequest/getallresponseheaders.htm is valid with libsoup patched, it's just different to what CF does, but still valid. 1289772 4 305002 cgarcia 2017-03-21 07:51:48 -0700 Created attachment 305002 Patch 1289922 5 305002 mcatanzaro 2017-03-21 18:09:43 -0700 Comment on attachment 305002 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305002&action=review > LayoutTests/platform/gtk/imported/w3c/web-platform-tests/XMLHttpRequest/getallresponseheaders-expected.txt:3 > +FAIL XMLHttpRequest: getAllResponseHeaders() 1 assert_equals: expected "also-here: Mr. PB\r\newok: lego\r\nfoo-test: 1, 2\r\n" but got "ALSO-here: Mr. PB\r\nfoo-test: 1, 2\r\newok: lego\r\n" IMO the test should be updated to print PASS for either result, so we don't have the text FAIL in our expected results unnecessarily. 1290002 6 cgarcia 2017-03-22 00:41:14 -0700 (In reply to Michael Catanzaro from comment #5) > Comment on attachment 305002 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=305002&action=review > > > LayoutTests/platform/gtk/imported/w3c/web-platform-tests/XMLHttpRequest/getallresponseheaders-expected.txt:3 > > +FAIL XMLHttpRequest: getAllResponseHeaders() 1 assert_equals: expected "also-here: Mr. PB\r\newok: lego\r\nfoo-test: 1, 2\r\n" but got "ALSO-here: Mr. PB\r\nfoo-test: 1, 2\r\newok: lego\r\n" > > IMO the test should be updated to print PASS for either result, so we don't > have the text FAIL in our expected results unnecessarily. Tests are not passing, but now the expected failure is the same than in all other browsers. 1290014 7 cgarcia 2017-03-22 01:44:34 -0700 It seems webkit-patch doesn't know how to comment and close bugs with the new version of bugzilla. Committed r214243: <http://trac.webkit.org/changeset/214243> 305002 2017-03-21 07:51:48 -0700 2017-03-21 18:09:43 -0700 Patch wk-soup-response.diff text/plain 6458 cgarcia ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2ZGM4YzFlODgyOS4uNzkyOGNlMGNmYTggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMCBAQAog MjAxNy0wMy0yMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAK KyAgICAgICAgW0dUS10gU2V2ZXJhbCBXUFQgdGVzdHMgYXJlIGZhaWxpbmcgc2luY2UgdGhleSB3 ZXJlIGFkZGVkIGluIHRoZSBsYXN0IHVwZGF0ZSBpbiByMjEzODgyCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjk5MTUKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGV5IGZhaWwgYmVjYXVzZSBsaWJzb3Vw IGZhaWxzIHRvIGxvYWQgdGhlIHJlcXVlc3RzIGJlY2F1c2UgdGhlIHJlc3BvbnNlIGRvZXNuJ3Qg aW5jbHVkZSB0aGUgZW1wdHkgbGluZSBhZnRlciB0aGUKKyAgICAgICAgaGVhZGVycyB3aGlsZSBv dGhlciBicm93c2VycyBhbGxvdyB0aGF0LiBFdmVuIHdpdGggbGlic291cCBwYXRjaGVkIHdlIHN0 aWxsIG5lZWQgcGxhdGZvcm0gc3BlY2lmaWMgZXhwZWN0YXRpb25zCisgICAgICAgIGZvciBpbXBv cnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL1hNTEh0dHBSZXF1ZXN0L2dldGFsbHJlc3BvbnNl aGVhZGVycy5odG0sIGJlY2F1c2UgbGlic291cCBjYWNoZXMgYWxsIGhlYWRlcgorICAgICAgICBu YW1lcywgc28gdGhlIGZpcnN0IHRpbWUgZm9vLXRlc3QgaGVhZGVyIGlzIGNhY2hlZCBhbmQgdGhl biBhbHdheXMgdXNlZCBubyBtYXR0ZXIgd2hhdCBjYXNlIGlzIHVzZWQuIFRoZSByZXN1bHRzCisg ICAgICAgIGFyZSBzdGlsbCB2YWxpZCBpbiBhbnkgY2FzZS4KKworICAgICAgICAqIHBsYXRmb3Jt L2d0ay9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL1hNTEh0dHBSZXF1ZXN0L2dldGFs bHJlc3BvbnNlaGVhZGVycy1leHBlY3RlZC50eHQ6IEFkZGVkLgorCisyMDE3LTAzLTIxICBDYXJs b3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKwogICAgICAgICBVbnJldmll d2VkIEdUSysgZ2FyZGVuaW5nLiBSZW1vdmUgZXhwZWN0YXRpb25zIGZvciBpbXBvcnRlZC93M2Mv d2ViLXBsYXRmb3JtLXRlc3RzL1hNTEh0dHBSZXF1ZXN0L3NldHJlcXVlc3RoZWFkZXItY29udGVu dC10eXBlLmh0bS4KIAogICAgICAgICBJdCBubyBsb25nZXIgd29ya3Mgd2l0aCBjdXJyZW50IHZl cnNpb24gb2Ygd3B0c2VydmUgYW5kIGl0J3MgYWxyZWFkeSBza2lwcGVkIGdsb2JhbGx5LgpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2ltcG9ydGVkL3czYy93ZWItcGxhdGZv cm0tdGVzdHMvWE1MSHR0cFJlcXVlc3QvZ2V0YWxscmVzcG9uc2VoZWFkZXJzLWV4cGVjdGVkLnR4 dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL1hNTEh0dHBSZXF1ZXN0L2dldGFsbHJlc3BvbnNlaGVhZGVycy1leHBlY3RlZC50eHQKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAuLjgzMGQ0YjcyNmNhCi0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2ltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvWE1MSHR0cFJlcXVlc3QvZ2V0YWxscmVzcG9uc2VoZWFkZXJzLWV4cGVjdGVk LnR4dApAQCAtMCwwICsxLDQgQEAKKworUEFTUyBYTUxIdHRwUmVxdWVzdDogZ2V0QWxsUmVzcG9u c2VIZWFkZXJzKCkgCitGQUlMIFhNTEh0dHBSZXF1ZXN0OiBnZXRBbGxSZXNwb25zZUhlYWRlcnMo KSAxIGFzc2VydF9lcXVhbHM6IGV4cGVjdGVkICJhbHNvLWhlcmU6IE1yLiBQQlxyXG5ld29rOiBs ZWdvXHJcbmZvby10ZXN0OiAxLCAyXHJcbiIgYnV0IGdvdCAiQUxTTy1oZXJlOiBNci4gUEJcclxu Zm9vLXRlc3Q6IDEsIDJcclxuZXdvazogbGVnb1xyXG4iCisKZGlmZiAtLWdpdCBhL1Rvb2xzL0No YW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAwNjc3MDgyNWZlMi4uYTk4MjlhYmRhYzIg MTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNy0wMy0yMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gU2V2ZXJhbCBXUFQgdGVzdHMgYXJlIGZhaWxpbmcg c2luY2UgdGhleSB3ZXJlIGFkZGVkIGluIHRoZSBsYXN0IHVwZGF0ZSBpbiByMjEzODgyCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjk5MTUKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbGlic291cCBw YXRjaCB0byBub3QgZmFpbCBsb2FkcyB3aGVuIHRoZXJlJ3Mgbm8gZW1wdHkgbGluZSBhZnRlciB0 aGUgaGVhZGVycyBpbiByZXNwb25zZXMgd2l0aCBubyBib2R5LgorCisgICAgICAgICogZ3RrL2po YnVpbGQubW9kdWxlczoKKyAgICAgICAgKiBndGsvcGF0Y2hlcy9saWJzb3VwLXNvdXAtbWVzc2Fn ZS1pby1Eby1ub3QtZmFpbC13aGVuLXRoZXJlLXMtbm8tZW1wdHktbGkucGF0Y2g6IEFkZGVkLgor CiAyMDE3LTAzLTIwICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIEFkZCBhIHN5c3RlbSB0cmFjZSBwb2ludCBmb3IgbWVtb3J5IHdhcm5pbmcgaGFuZGxp bmcKZGlmZiAtLWdpdCBhL1Rvb2xzL2d0ay9qaGJ1aWxkLm1vZHVsZXMgYi9Ub29scy9ndGsvamhi dWlsZC5tb2R1bGVzCmluZGV4IGU3NzYyZmFjODU4Li45OWFhZWFkNjQ5MyAxMDA2NDQKLS0tIGEv VG9vbHMvZ3RrL2poYnVpbGQubW9kdWxlcworKysgYi9Ub29scy9ndGsvamhidWlsZC5tb2R1bGVz CkBAIC0yNDUsNiArMjQ1LDcgQEAKICAgICAgICAgICAgIGhhc2g9InNoYTI1NjpjYTFjYTAzN2U4 OWU4YmM3Yjc4MjU1OWYzZWM1ZDg5YzlkMGI4MzZmNTA1YjJmOTVlMDA4ZWQ1MTdmZDY2NThmIj4K ICAgICAgIDxwYXRjaCBmaWxlPSJsaWJzb3VwLWF1dGgtRml4LWFzeW5jLWF1dGhlbnRpY2F0aW9u LXdoZW4tZmxhZy1TT1VQX01FU1NBR0UucGF0Y2giIHN0cmlwPSIxIi8+CiAgICAgICA8cGF0Y2gg ZmlsZT0ibGlic291cC1hdXRoLWRvLW5vdC11c2UtY2FjaGVkLWNyZWRlbnRpYWxzLWluLWxvb2t1 cC1tZXRob2QtLnBhdGNoIiBzdHJpcD0iMSIvPgorICAgICAgPHBhdGNoIGZpbGU9ImxpYnNvdXAt c291cC1tZXNzYWdlLWlvLURvLW5vdC1mYWlsLXdoZW4tdGhlcmUtcy1uby1lbXB0eS1saS5wYXRj aCIgc3RyaXA9IjEiLz4KICAgICA8L2JyYW5jaD4KICAgPC9hdXRvdG9vbHM+CiAKZGlmZiAtLWdp dCBhL1Rvb2xzL2d0ay9wYXRjaGVzL2xpYnNvdXAtc291cC1tZXNzYWdlLWlvLURvLW5vdC1mYWls LXdoZW4tdGhlcmUtcy1uby1lbXB0eS1saS5wYXRjaCBiL1Rvb2xzL2d0ay9wYXRjaGVzL2xpYnNv dXAtc291cC1tZXNzYWdlLWlvLURvLW5vdC1mYWlsLXdoZW4tdGhlcmUtcy1uby1lbXB0eS1saS5w YXRjaApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMC4uYzVlNDcxYTUzMGEK LS0tIC9kZXYvbnVsbAorKysgYi9Ub29scy9ndGsvcGF0Y2hlcy9saWJzb3VwLXNvdXAtbWVzc2Fn ZS1pby1Eby1ub3QtZmFpbC13aGVuLXRoZXJlLXMtbm8tZW1wdHktbGkucGF0Y2gKQEAgLTAsMCAr MSw3NCBAQAorRnJvbSBiYjIzY2FmN2RiNGU5MTEyMDg5ZTE1MDJhYThjMTA2MTc4MDk1ZTdlIE1v biBTZXAgMTcgMDA6MDA6MDAgMjAwMQorRnJvbTogQ2FybG9zIEdhcmNpYSBDYW1wb3MgPGNnYXJj aWFAaWdhbGlhLmNvbT4KK0RhdGU6IFR1ZSwgMjEgTWFyIDIwMTcgMTQ6MTk6NDYgKzAxMDAKK1N1 YmplY3Q6IFtQQVRDSF0gc291cC1tZXNzYWdlLWlvOiBEbyBub3QgZmFpbCB3aGVuIHRoZXJlJ3Mg bm8gZW1wdHkgbGluZSBhZnRlcgorIGhlYWRlcnMKKworVGhlIHNwZWMgc2F5cyB0aGVyZSBzaG91 bGQgYmUgYW4gZW1wdHkgbGluZSAoXHJcbikgYmV0d2VlbiB0aGUgcmVzcG9uc2UKK2hlYWRlcnMg YW5kIHRoZSBib2R5LiBIb3dldmVyLCBzb21lIHNlcnZlcnMgZG9uJ3QgaW5jbHVkZSB0aGUgZW1w dHkgbGluZQord2hlbiB0aGUgcmVzcG9uc2UgZG9lc24ndCBoYXZlIGEgYm9keS4gVGhpcyBpcyBj YXVzaW5nIHNldmVyYWwgV2ViS2l0Cit0ZXN0cyB0byBmYWlsLCBiZWNhdXNlIHNvbWUgb2YgdGhl IGltcG9ydGVkIHczYyB0ZXN0cyBkbyBub3QgaW5jbHVkZQordGhhdCBlbXB0eSBsaW5lLiBUaG9z ZSB0ZXN0cyBwYXNzIGluIGZpcmVmb3gsIGNocm9taXVtIGFuZCBzYWZhcmksIHNvIGF0CitsZWFz dCB0aG9zZSBvdGhlciBicm93c2VycyBhbGxvdyB0aGF0LgorCitodHRwczovL2J1Z3ppbGxhLmdu b21lLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NzgwMzUyCistLS0KKyBsaWJzb3VwL3NvdXAtbWVzc2Fn ZS1pby5jIHwgMzQgKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLQorIDEgZmlsZSBj aGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCAxNCBkZWxldGlvbnMoLSkKKworZGlmZiAtLWdpdCBh L2xpYnNvdXAvc291cC1tZXNzYWdlLWlvLmMgYi9saWJzb3VwL3NvdXAtbWVzc2FnZS1pby5jCitp bmRleCBlODkzZWMyYS4uZWEwMmIxZTMgMTAwNjQ0CistLS0gYS9saWJzb3VwL3NvdXAtbWVzc2Fn ZS1pby5jCisrKysgYi9saWJzb3VwL3NvdXAtbWVzc2FnZS1pby5jCitAQCAtMjI5LDEyICsyMjks MTYgQEAgcmVhZF9oZWFkZXJzIChTb3VwTWVzc2FnZSAqbXNnLCBnYm9vbGVhbiBibG9ja2luZywK KyAJCQkJCQkJICAgIGNhbmNlbGxhYmxlLCBlcnJvcik7CisgCQlpby0+cmVhZF9oZWFkZXJfYnVm LT5sZW4gPSBvbGRfbGVuICsgTUFYIChucmVhZCwgMCk7CisgCQlpZiAobnJlYWQgPT0gMCkgewor LQkJCXNvdXBfbWVzc2FnZV9zZXRfc3RhdHVzIChtc2csIFNPVVBfU1RBVFVTX01BTEZPUk1FRCk7 CistCQkJZ19zZXRfZXJyb3JfbGl0ZXJhbCAoZXJyb3IsIEdfSU9fRVJST1IsCistCQkJCQkgICAg IEdfSU9fRVJST1JfUEFSVElBTF9JTlBVVCwKKy0JCQkJCSAgICAgXygiQ29ubmVjdGlvbiB0ZXJt aW5hdGVkIHVuZXhwZWN0ZWRseSIpKTsKKysJCQlpZiAoaW8tPnJlYWRfaGVhZGVyX2J1Zi0+bGVu ID09IDApIHsKKysJCQkJc291cF9tZXNzYWdlX3NldF9zdGF0dXMgKG1zZywgU09VUF9TVEFUVVNf TUFMRk9STUVEKTsKKysJCQkJZ19zZXRfZXJyb3JfbGl0ZXJhbCAoZXJyb3IsIEdfSU9fRVJST1Is CisrCQkJCQkJICAgICBHX0lPX0VSUk9SX1BBUlRJQUxfSU5QVVQsCisrCQkJCQkJICAgICBfKCJD b25uZWN0aW9uIHRlcm1pbmF0ZWQgdW5leHBlY3RlZGx5IikpOworKwkJCQlyZXR1cm4gRkFMU0U7 CisrCQkJfQorKwkJCWJyZWFrOworIAkJfQorLQkJaWYgKG5yZWFkIDw9IDApCisrCQlpZiAobnJl YWQgPCAwKQorIAkJCXJldHVybiBGQUxTRTsKKyAKKyAJCWlmIChnb3RfbGYpIHsKK0BAIC0yNTEs MTUgKzI1NSwxNyBAQCByZWFkX2hlYWRlcnMgKFNvdXBNZXNzYWdlICptc2csIGdib29sZWFuIGJs b2NraW5nLAorIAkJfQorIAl9CisgCistCS8qIFdlIG5lZWQgdG8gInJld2luZCIgaW8tPnJlYWRf aGVhZGVyX2J1ZiBiYWNrIG9uZSBsaW5lLgorLQkgKiBUaGF0IFNIT1VMRCBiZSB0d28gY2hhcmFj dGVycyAoQ1IgTEYpLCBidXQgaWYgdGhlCistCSAqIHdlYiBzZXJ2ZXIgd2FzIHN0dXBpZCwgaXQg bWlnaHQgb25seSBiZSBvbmUuCistCSAqLworLQlpZiAoaW8tPnJlYWRfaGVhZGVyX2J1Zi0+bGVu IDwgMyB8fAorLQkgICAgaW8tPnJlYWRfaGVhZGVyX2J1Zi0+ZGF0YVtpby0+cmVhZF9oZWFkZXJf YnVmLT5sZW4gLSAyXSA9PSAnXG4nKQorLQkJaW8tPnJlYWRfaGVhZGVyX2J1Zi0+bGVuLS07Cist CWVsc2UKKy0JCWlvLT5yZWFkX2hlYWRlcl9idWYtPmxlbiAtPSAyOworKwlpZiAoZ290X2xmKSB7 CisrCQkvKiBXZSBuZWVkIHRvICJyZXdpbmQiIGlvLT5yZWFkX2hlYWRlcl9idWYgYmFjayBvbmUg bGluZS4KKysJCSAqIFRoYXQgU0hPVUxEIGJlIHR3byBjaGFyYWN0ZXJzIChDUiBMRiksIGJ1dCBp ZiB0aGUKKysJCSAqIHdlYiBzZXJ2ZXIgd2FzIHN0dXBpZCwgaXQgbWlnaHQgb25seSBiZSBvbmUu CisrCQkgKi8KKysJCWlmIChpby0+cmVhZF9oZWFkZXJfYnVmLT5sZW4gPCAzIHx8CisrCQkgICAg aW8tPnJlYWRfaGVhZGVyX2J1Zi0+ZGF0YVtpby0+cmVhZF9oZWFkZXJfYnVmLT5sZW4gLSAyXSA9 PSAnXG4nKQorKwkJCWlvLT5yZWFkX2hlYWRlcl9idWYtPmxlbi0tOworKwkJZWxzZQorKwkJCWlv LT5yZWFkX2hlYWRlcl9idWYtPmxlbiAtPSAyOworKwl9CisgCWlvLT5yZWFkX2hlYWRlcl9idWYt PmRhdGFbaW8tPnJlYWRfaGVhZGVyX2J1Zi0+bGVuXSA9ICdcMCc7CisgCisgCXJldHVybiBUUlVF OworLS0gCisyLjExLjAKKwo=