169912 2017-03-21 03:54:57 -0700 [ARM] Add missing MacroAssembler functions after r214187 2017-03-21 04:42:44 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Linux RESOLVED FIXED P1 Blocker --- 108645 169820 1 ossy ossy commit-queue fpizlo keith_miller mark.lam msaboff saam zherczeg oldest_to_newest 1289749 0 ossy 2017-03-21 03:54:57 -0700 https://trac.webkit.org/changeset/214187 broke the ARM build because of unimplemented functions: - storeFloat(FPRegisterID src, BaseIndex address) - loadFloat(BaseIndex address, FPRegisterID dest) It's super easy to fix the build, we already have these functions for double type, it's a simple copy/paste patch. 1289750 1 304998 ossy 2017-03-21 03:58:40 -0700 Created attachment 304998 Patch 1289754 2 304998 ysuzuki 2017-03-21 04:13:15 -0700 Comment on attachment 304998 Patch r=me 1289757 3 304998 commit-queue 2017-03-21 04:42:39 -0700 Comment on attachment 304998 Patch Clearing flags on attachment: 304998 Committed r214220: <http://trac.webkit.org/changeset/214220> 1289758 4 commit-queue 2017-03-21 04:42:44 -0700 All reviewed patches have been landed. Closing bug. 304998 2017-03-21 03:58:40 -0700 2017-03-21 04:42:39 -0700 Patch bug-169912-20170321115838.patch text/plain 2167 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0MjE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm ODEwMGRjOGE3NmRjNmE5YTJjY2ZkOTlmNjAyMjM5NjY4OTg2MmI0Li5lYzI5ODg5ZmQxMTQ3NDdl MzBiM2ZiZGJkY2RhYzM0ZmM1YzkxNDE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNCBAQAorMjAxNy0wMy0yMSAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQu b3JnPgorCisgICAgICAgIFtBUk1dIEFkZCBtaXNzaW5nIE1hY3JvQXNzZW1ibGVyIGZ1bmN0aW9u cyBhZnRlciByMjE0MTg3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNjk5MTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIGFzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFSTS5oOgorICAgICAgICAoSlNDOjpN YWNyb0Fzc2VtYmxlckFSTTo6bG9hZEZsb2F0KToKKyAgICAgICAgKEpTQzo6TWFjcm9Bc3NlbWJs ZXJBUk06OnN0b3JlRmxvYXQpOgorCiAyMDE3LTAzLTIxICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJz ZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBbanNjXSBNYWNyb0Fzc2VtYmxlck1JUFM6IGltcGxl bWVudCB0aGUgYnJhbmNoUHRyKFJlbGF0aW9uYWxDb25kaXRpb24sIEJhc2VJbmRleCwgUmVnaXN0 ZXJJRCkgb3ZlcmxvYWQuCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1i bGVyL01hY3JvQXNzZW1ibGVyQVJNLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVy L01hY3JvQXNzZW1ibGVyQVJNLmgKaW5kZXggNDMyY2UwNDBhNDE2OTAzOTI3OWU4Zjk1YWJmOWQy Y2M0NTM5MDdkZS4uMGI0MGFmMmJmNjA5ZDBmM2M5MzY3NjM4NGI0ZTA2ZTk2YmU3MzQzYiAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlckFS TS5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJB Uk0uaApAQCAtMTE4NSw2ICsxMTg1LDEyIEBAIHB1YmxpYzoKICAgICBzdGF0aWMgYm9vbCBzdXBw b3J0c0Zsb2F0aW5nUG9pbnRBYnMoKSB7IHJldHVybiBmYWxzZTsgfQogICAgIHN0YXRpYyBib29s IHN1cHBvcnRzRmxvYXRpbmdQb2ludFJvdW5kaW5nKCkgeyByZXR1cm4gZmFsc2U7IH0KIAorCisg ICAgdm9pZCBsb2FkRmxvYXQoSW1wbGljaXRBZGRyZXNzIGFkZHJlc3MsIEZQUmVnaXN0ZXJJRCBk ZXN0KQorICAgIHsKKyAgICAgICAgbV9hc3NlbWJsZXIuZGF0YVRyYW5zZmVyRmxvYXQoQVJNQXNz ZW1ibGVyOjpMb2FkRmxvYXQsIGRlc3QsIGFkZHJlc3MuYmFzZSwgYWRkcmVzcy5vZmZzZXQpOwor ICAgIH0KKwogICAgIHZvaWQgbG9hZEZsb2F0KEJhc2VJbmRleCBhZGRyZXNzLCBGUFJlZ2lzdGVy SUQgZGVzdCkKICAgICB7CiAgICAgICAgIG1fYXNzZW1ibGVyLmJhc2VJbmRleFRyYW5zZmVyRmxv YXQoQVJNQXNzZW1ibGVyOjpMb2FkRmxvYXQsIGRlc3QsIGFkZHJlc3MuYmFzZSwgYWRkcmVzcy5p bmRleCwgc3RhdGljX2Nhc3Q8aW50PihhZGRyZXNzLnNjYWxlKSwgYWRkcmVzcy5vZmZzZXQpOwpA QCAtMTIyNCw2ICsxMjMwLDExIEBAIHB1YmxpYzoKICAgICAgICAgQ1JBU0goKTsKICAgICB9CiAK KyAgICB2b2lkIHN0b3JlRmxvYXQoRlBSZWdpc3RlcklEIHNyYywgSW1wbGljaXRBZGRyZXNzIGFk ZHJlc3MpCisgICAgeworICAgICAgICBtX2Fzc2VtYmxlci5kYXRhVHJhbnNmZXJGbG9hdChBUk1B c3NlbWJsZXI6OlN0b3JlRmxvYXQsIHNyYywgYWRkcmVzcy5iYXNlLCBhZGRyZXNzLm9mZnNldCk7 CisgICAgfQorCiAgICAgdm9pZCBzdG9yZUZsb2F0KEZQUmVnaXN0ZXJJRCBzcmMsIEJhc2VJbmRl eCBhZGRyZXNzKQogICAgIHsKICAgICAgICAgbV9hc3NlbWJsZXIuYmFzZUluZGV4VHJhbnNmZXJG bG9hdChBUk1Bc3NlbWJsZXI6OlN0b3JlRmxvYXQsIHNyYywgYWRkcmVzcy5iYXNlLCBhZGRyZXNz LmluZGV4LCBzdGF0aWNfY2FzdDxpbnQ+KGFkZHJlc3Muc2NhbGUpLCBhZGRyZXNzLm9mZnNldCk7 Cg==