169903 2017-03-20 19:03:43 -0700 Modernize BuildRequestQueuePage 2017-03-20 19:13:08 -0700 1 1 1 Unclassified WebKit Perf Dashboard Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa cdumez rniwa oldest_to_newest 1289673 0 rniwa 2017-03-20 19:03:43 -0700 Modernize the code for /v3/#/analysis/queue. 1289676 1 304980 rniwa 2017-03-20 19:08:18 -0700 Created attachment 304980 Modernize the code 1289678 2 rniwa 2017-03-20 19:13:08 -0700 Committed r214205: <http://trac.webkit.org/changeset/214205> 304980 2017-03-20 19:08:18 -0700 2017-03-20 19:11:59 -0700 Modernize the code bug-169903-20170320190817.patch text/plain 7289 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0MjAyCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCAxMzc5ZjI1MTFlYWU4NDI0ZGE5OTc5MjAyY2E0NzI5OTc4MTRiZTQ1Li4yOGIzMzQwYzNi YTk0YTkxYTVhMzgyZWNhYjI3NWZhNGI0OGZmZGYyIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJm LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxNy0wMy0yMCAgUnlvc3VrZSBOaXdhICA8cm5pd2FA d2Via2l0Lm9yZz4KKworICAgICAgICBNb2Rlcm5pemUgQnVpbGRSZXF1ZXN0UXVldWVQYWdlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjk5MDMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNb2Rlcm5pemVk IHRoZSBjb2RlIGZvciAvdjMvIy9hbmFseXNpcy9xdWV1ZS4KKworICAgICAgICAqIHB1YmxpYy92 My9tb2RlbHMvYnVpbGQtcmVxdWVzdC5qczoKKyAgICAgICAgKEJ1aWxkUmVxdWVzdC5mZXRjaFRy aWdnZXJhYmxlcyk6IERlbGV0ZWQgc2luY2UgdGhlIG1hbmlmZXN0IEpTT04gbm93IGNvbnRhaW5z IGFsbCB0aGUgdHJpZ2dlcmFibGVzLgorCisgICAgICAgICogcHVibGljL3YzL3BhZ2VzL2J1aWxk LXJlcXVlc3QtcXVldWUtcGFnZS5qczoKKyAgICAgICAgKEJ1aWxkUmVxdWVzdFF1ZXVlUGFnZSk6 IERlbGV0ZWQgdGhpcy5fdHJpZ2dlcmFibGVzLiBBZGRlZCB0aGlzLl9idWlsZFJlcXVlc3RzQnlU cmlnZ2VyYWJsZS4KKyAgICAgICAgKEJ1aWxkUmVxdWVzdFF1ZXVlUGFnZS5wcm90b3R5cGUub3Bl bik6IE1vZGVybml6ZWQgdGhlIGNvZGUuCisgICAgICAgIChCdWlsZFJlcXVlc3RRdWV1ZVBhZ2Uu cHJvdG90eXBlLnJlbmRlcik6IERpdHRvLgorICAgICAgICAoQnVpbGRSZXF1ZXN0UXVldWVQYWdl LnByb3RvdHlwZS5fY29uc3RydWN0QnVpbGRSZXF1ZXN0VGFibGUpOiBEaXR0by4KKwogMjAxNy0w My0xOSAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBDaGFydHMg cGFnZSBzaG93IGFuIGluY29uc2lzdGVudCBsaXN0IG9mIHJldmlzaW9ucyBmb3IgR2l0IGFuZCBT dWJ2ZXJzaW9uCmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3Yz L21vZGVscy9idWlsZC1yZXF1ZXN0LmpzIGIvV2Vic2l0ZXMvcGVyZi53ZWJraXQub3JnL3B1Ymxp Yy92My9tb2RlbHMvYnVpbGQtcmVxdWVzdC5qcwppbmRleCBiNTRlNTJmYTUzNmIyNzIxNDhhYWYx ZDlmNGI5NTY2ZmJiYjFkNjk4Li4yMWQ0NzI1ZWExYzcyNWQ0Yzk0ZTg5MDA1ZTYzOTk1YWIwYTU5 ZGQ5IDEwMDY0NAotLS0gYS9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YzL21vZGVs cy9idWlsZC1yZXF1ZXN0LmpzCisrKyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJsaWMv djMvbW9kZWxzL2J1aWxkLXJlcXVlc3QuanMKQEAgLTExNSwxMyArMTE1LDYgQEAgY2xhc3MgQnVp bGRSZXF1ZXN0IGV4dGVuZHMgRGF0YU1vZGVsT2JqZWN0IHsKICAgICAgICAgdGhpcy5fdGVzdEdy b3VwLmRpZFNldFJlc3VsdCh0aGlzKTsKICAgICB9CiAKLSAgICBzdGF0aWMgZmV0Y2hUcmlnZ2Vy YWJsZXMoKQotICAgIHsKLSAgICAgICAgcmV0dXJuIHRoaXMuY2FjaGVkRmV0Y2goJy9hcGkvdHJp Z2dlcmFibGVzLycpLnRoZW4oZnVuY3Rpb24gKHJlc3BvbnNlKSB7Ci0gICAgICAgICAgICByZXR1 cm4gcmVzcG9uc2UudHJpZ2dlcmFibGVzLm1hcChmdW5jdGlvbiAoZW50cnkpIHsgcmV0dXJuIHtp ZDogZW50cnkuaWQsIG5hbWU6IGVudHJ5Lm5hbWV9OyB9KTsKLSAgICAgICAgfSk7Ci0gICAgfQot CiAgICAgLy8gRklYTUU6IENyZWF0ZSBhIHJlYWwgbW9kZWwgb2JqZWN0IGZvciB0cmlnZ2VyYWJs ZXMuCiAgICAgc3RhdGljIGNhY2hlZFJlcXVlc3RzRm9yVHJpZ2dlcmFibGVJRChpZCkKICAgICB7 CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9wZXJmLndlYmtpdC5vcmcvcHVibGljL3YzL3BhZ2VzL2J1 aWxkLXJlcXVlc3QtcXVldWUtcGFnZS5qcyBiL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJs aWMvdjMvcGFnZXMvYnVpbGQtcmVxdWVzdC1xdWV1ZS1wYWdlLmpzCmluZGV4IGJkYjA5MmI2NDE3 NWU1Y2E4OWI4YTBjYWIzZTgxMTliMTBjZWRkNmIuLjkzMTdkOTg2OWEwZjg2YmU0ZDhkMWZmMzgx MTY3OTZlMjBmOTZlOGUgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL3BlcmYud2Via2l0Lm9yZy9wdWJs aWMvdjMvcGFnZXMvYnVpbGQtcmVxdWVzdC1xdWV1ZS1wYWdlLmpzCisrKyBiL1dlYnNpdGVzL3Bl cmYud2Via2l0Lm9yZy9wdWJsaWMvdjMvcGFnZXMvYnVpbGQtcmVxdWVzdC1xdWV1ZS1wYWdlLmpz CkBAIC0zLDcgKzMsNyBAQCBjbGFzcyBCdWlsZFJlcXVlc3RRdWV1ZVBhZ2UgZXh0ZW5kcyBQYWdl V2l0aEhlYWRpbmcgewogICAgIGNvbnN0cnVjdG9yKCkKICAgICB7CiAgICAgICAgIHN1cGVyKCdi dWlsZC1yZXF1ZXN0LXF1ZXVlLXBhZ2UnKTsKLSAgICAgICAgdGhpcy5fdHJpZ2dlcmFibGVzID0g W107CisgICAgICAgIHRoaXMuX2J1aWxkUmVxdWVzdHNCeVRyaWdnZXJhYmxlID0gbmV3IE1hcDsK ICAgICB9CiAKICAgICByb3V0ZU5hbWUoKSB7IHJldHVybiAnYW5hbHlzaXMvcXVldWUnOyB9CkBA IC0xMSwyNCArMTEsMTQgQEAgY2xhc3MgQnVpbGRSZXF1ZXN0UXVldWVQYWdlIGV4dGVuZHMgUGFn ZVdpdGhIZWFkaW5nIHsKIAogICAgIG9wZW4oc3RhdGUpCiAgICAgewotICAgICAgICB2YXIgc2Vs ZiA9IHRoaXM7Ci0gICAgICAgIEJ1aWxkUmVxdWVzdC5mZXRjaFRyaWdnZXJhYmxlcygpLnRoZW4o ZnVuY3Rpb24gKGxpc3QpIHsKLSAgICAgICAgICAgIHNlbGYuX3RyaWdnZXJhYmxlcyA9IGxpc3Qu bWFwKGZ1bmN0aW9uIChlbnRyeSkgewotICAgICAgICAgICAgICAgIHZhciB0cmlnZ2VyYWJsZSA9 IHtuYW1lOiBlbnRyeS5uYW1lLCBidWlsZFJlcXVlc3RzOiBCdWlsZFJlcXVlc3QuY2FjaGVkUmVx dWVzdHNGb3JUcmlnZ2VyYWJsZUlEKGVudHJ5LmlkKX07Ci0KLSAgICAgICAgICAgICAgICBCdWls ZFJlcXVlc3QuZmV0Y2hGb3JUcmlnZ2VyYWJsZShlbnRyeS5uYW1lKS50aGVuKGZ1bmN0aW9uIChy ZXF1ZXN0cykgewotICAgICAgICAgICAgICAgICAgICB0cmlnZ2VyYWJsZS5idWlsZFJlcXVlc3Rz ID0gcmVxdWVzdHM7Ci0gICAgICAgICAgICAgICAgICAgIHNlbGYuZW5xdWV1ZVRvUmVuZGVyKCk7 Ci0gICAgICAgICAgICAgICAgfSk7Ci0KLSAgICAgICAgICAgICAgICByZXR1cm4gdHJpZ2dlcmFi bGU7CisgICAgICAgIGZvciAobGV0IHRyaWdnZXJhYmxlIG9mIFRyaWdnZXJhYmxlLmFsbCgpKSB7 CisgICAgICAgICAgICBCdWlsZFJlcXVlc3QuZmV0Y2hGb3JUcmlnZ2VyYWJsZSh0cmlnZ2VyYWJs ZS5uYW1lKCkpLnRoZW4oKHJlcXVlc3RzKSA9PiB7CisgICAgICAgICAgICAgICAgdGhpcy5fYnVp bGRSZXF1ZXN0c0J5VHJpZ2dlcmFibGUuc2V0KHRyaWdnZXJhYmxlLCByZXF1ZXN0cyk7CisgICAg ICAgICAgICAgICAgdGhpcy5lbnF1ZXVlVG9SZW5kZXIoKTsKICAgICAgICAgICAgIH0pOwotICAg ICAgICAgICAgc2VsZi5lbnF1ZXVlVG9SZW5kZXIoKTsKLSAgICAgICAgfSk7CisgICAgICAgIH0K IAotICAgICAgICBBbmFseXNpc1Rhc2suZmV0Y2hBbGwoKS50aGVuKGZ1bmN0aW9uICgpIHsKLSAg ICAgICAgICAgIHNlbGYuZW5xdWV1ZVRvUmVuZGVyKCk7Ci0gICAgICAgIH0pOworICAgICAgICBB bmFseXNpc1Rhc2suZmV0Y2hBbGwoKS50aGVuKCgpID0+IHRoaXMuZW5xdWV1ZVRvUmVuZGVyKCkp OwogCiAgICAgICAgIHN1cGVyLm9wZW4oc3RhdGUpOwogICAgIH0KQEAgLTM3LDIyICsyNywyNSBA QCBjbGFzcyBCdWlsZFJlcXVlc3RRdWV1ZVBhZ2UgZXh0ZW5kcyBQYWdlV2l0aEhlYWRpbmcgewog ICAgIHsKICAgICAgICAgc3VwZXIucmVuZGVyKCk7CiAKLSAgICAgICAgdmFyIHJlZmVyZW5jZVRp bWUgPSBEYXRlLm5vdygpOworICAgICAgICBjb25zdCByZWZlcmVuY2VUaW1lID0gRGF0ZS5ub3co KTsKICAgICAgICAgdGhpcy5yZW5kZXJSZXBsYWNlKHRoaXMuY29udGVudCgpLnF1ZXJ5U2VsZWN0 b3IoJy50cmlnZ2VyYWJsZS1saXN0JyksCi0gICAgICAgICAgICB0aGlzLl90cmlnZ2VyYWJsZXMu bWFwKHRoaXMuX2NvbnN0cnVjdEJ1aWxkUmVxdWVzdFRhYmxlLmJpbmQodGhpcywgcmVmZXJlbmNl VGltZSkpKTsKKyAgICAgICAgICAgIFRyaWdnZXJhYmxlLnNvcnRCeU5hbWUoVHJpZ2dlcmFibGUu YWxsKCkpLm1hcCgodHJpZ2dlcmFibGUpID0+IHsKKyAgICAgICAgICAgICAgICBjb25zdCBidWls ZFJlcXVlc3RzID0gdGhpcy5fYnVpbGRSZXF1ZXN0c0J5VHJpZ2dlcmFibGUuZ2V0KHRyaWdnZXJh YmxlKSB8fCBbXTsKKyAgICAgICAgICAgICAgICByZXR1cm4gdGhpcy5fY29uc3RydWN0QnVpbGRS ZXF1ZXN0VGFibGUocmVmZXJlbmNlVGltZSwgdHJpZ2dlcmFibGUsIGJ1aWxkUmVxdWVzdHMpOwor ICAgICAgICAgICAgfSkpOwogICAgIH0KIAotICAgIF9jb25zdHJ1Y3RCdWlsZFJlcXVlc3RUYWJs ZShyZWZlcmVuY2VUaW1lLCB0cmlnZ2VyYWJsZSkKKyAgICBfY29uc3RydWN0QnVpbGRSZXF1ZXN0 VGFibGUocmVmZXJlbmNlVGltZSwgdHJpZ2dlcmFibGUsIGJ1aWxkUmVxdWVzdHMpCiAgICAgewot ICAgICAgICBpZiAoIXRyaWdnZXJhYmxlLmJ1aWxkUmVxdWVzdHMubGVuZ3RoKQorICAgICAgICBp ZiAoIWJ1aWxkUmVxdWVzdHMubGVuZ3RoKQogICAgICAgICAgICAgcmV0dXJuIFtdOwogCi0gICAg ICAgIHZhciByb3dMaXN0ID0gW107Ci0gICAgICAgIHZhciBwcmV2aW91c1JvdyA9IG51bGw7Ci0g ICAgICAgIHZhciByZXF1ZXN0Q291bnQgPSAwOwotICAgICAgICB2YXIgcmVxdWVzdENvdW50Rm9y R3JvdXAgPSB7fTsKLSAgICAgICAgZm9yICh2YXIgcmVxdWVzdCBvZiB0cmlnZ2VyYWJsZS5idWls ZFJlcXVlc3RzKSB7Ci0gICAgICAgICAgICB2YXIgZ3JvdXBJZCA9IHJlcXVlc3QudGVzdEdyb3Vw SWQoKTsKKyAgICAgICAgY29uc3Qgcm93TGlzdCA9IFtdOworICAgICAgICBjb25zdCByZXF1ZXN0 Q291bnRGb3JHcm91cCA9IHt9OworICAgICAgICBsZXQgcHJldmlvdXNSb3cgPSBudWxsOworICAg ICAgICBsZXQgcmVxdWVzdENvdW50ID0gMDsKKyAgICAgICAgZm9yIChsZXQgcmVxdWVzdCBvZiBi dWlsZFJlcXVlc3RzKSB7CisgICAgICAgICAgICBjb25zdCBncm91cElkID0gcmVxdWVzdC50ZXN0 R3JvdXBJZCgpOwogICAgICAgICAgICAgaWYgKGdyb3VwSWQgaW4gcmVxdWVzdENvdW50Rm9yR3Jv dXApCiAgICAgICAgICAgICAgICAgcmVxdWVzdENvdW50Rm9yR3JvdXBbZ3JvdXBJZF0rKzsKICAg ICAgICAgICAgIGVsc2UKQEAgLTcyLDExICs2NSwxMSBAQCBjbGFzcyBCdWlsZFJlcXVlc3RRdWV1 ZVBhZ2UgZXh0ZW5kcyBQYWdlV2l0aEhlYWRpbmcgewogICAgICAgICAgICAgcHJldmlvdXNSb3cg PSByb3dMaXN0W3Jvd0xpc3QubGVuZ3RoIC0gMV07CiAgICAgICAgIH0KIAotICAgICAgICB2YXIg ZWxlbWVudCA9IENvbXBvbmVudEJhc2UuY3JlYXRlRWxlbWVudDsKLSAgICAgICAgdmFyIGxpbmsg PSBDb21wb25lbnRCYXNlLmNyZWF0ZUxpbms7Ci0gICAgICAgIHZhciByb3V0ZXIgPSB0aGlzLnJv dXRlcigpOworICAgICAgICBjb25zdCBlbGVtZW50ID0gQ29tcG9uZW50QmFzZS5jcmVhdGVFbGVt ZW50OworICAgICAgICBjb25zdCBsaW5rID0gQ29tcG9uZW50QmFzZS5jcmVhdGVMaW5rOworICAg ICAgICBjb25zdCByb3V0ZXIgPSB0aGlzLnJvdXRlcigpOwogICAgICAgICByZXR1cm4gZWxlbWVu dCgndGFibGUnLCB7Y2xhc3M6ICdidWlsZC1yZXF1ZXN0LXRhYmxlJ30sIFsKLSAgICAgICAgICAg IGVsZW1lbnQoJ2NhcHRpb24nLCBgJHt0cmlnZ2VyYWJsZS5uYW1lfTogJHtyZXF1ZXN0Q291bnR9 IHBlbmRpbmcgcmVxdWVzdHNgKSwKKyAgICAgICAgICAgIGVsZW1lbnQoJ2NhcHRpb24nLCBgJHt0 cmlnZ2VyYWJsZS5uYW1lKCl9OiAke3JlcXVlc3RDb3VudH0gcGVuZGluZyByZXF1ZXN0c2ApLAog ICAgICAgICAgICAgZWxlbWVudCgndGhlYWQnLCBbCiAgICAgICAgICAgICAgICAgZWxlbWVudCgn dGQnLCAnUmVxdWVzdCBJRCcpLAogICAgICAgICAgICAgICAgIGVsZW1lbnQoJ3RkJywgJ1BsYXRm b3JtJyksCkBAIC04NywxNiArODAsMTYgQEAgY2xhc3MgQnVpbGRSZXF1ZXN0UXVldWVQYWdlIGV4 dGVuZHMgUGFnZVdpdGhIZWFkaW5nIHsKICAgICAgICAgICAgICAgICBlbGVtZW50KCd0ZCcsICdT dGF0dXMnKSwKICAgICAgICAgICAgICAgICBlbGVtZW50KCd0ZCcsICdXYWl0aW5nIFRpbWUnKSwK ICAgICAgICAgICAgIF0pLAotICAgICAgICAgICAgZWxlbWVudCgndGJvZHknLCByb3dMaXN0Lm1h cChmdW5jdGlvbiAoZW50cnkpIHsKKyAgICAgICAgICAgIGVsZW1lbnQoJ3Rib2R5Jywgcm93TGlz dC5tYXAoKGVudHJ5KSA9PiB7CiAgICAgICAgICAgICAgICAgaWYgKGVudHJ5LmNvbnRyYWN0aW9u KSB7CiAgICAgICAgICAgICAgICAgICAgIHJldHVybiBlbGVtZW50KCd0cicsIHtjbGFzczogJ2Nv bnRyYWN0aW9uJ30sIFsKICAgICAgICAgICAgICAgICAgICAgICAgIGVsZW1lbnQoJ3RkJywge2Nv bHNwYW46IDh9LCBgJHtlbnRyeS5jb3VudH0gYWRkaXRpb25hbCByZXF1ZXN0c2ApCiAgICAgICAg ICAgICAgICAgICAgIF0pOwogICAgICAgICAgICAgICAgIH0KIAotICAgICAgICAgICAgICAgIHZh ciByZXF1ZXN0ID0gZW50cnkucmVxdWVzdDsKLSAgICAgICAgICAgICAgICB2YXIgdGFza0lkID0g cmVxdWVzdC5hbmFseXNpc1Rhc2tJZCgpOwotICAgICAgICAgICAgICAgIHZhciB0YXNrID0gQW5h bHlzaXNUYXNrLmZpbmRCeUlkKHRhc2tJZCk7CisgICAgICAgICAgICAgICAgY29uc3QgcmVxdWVz dCA9IGVudHJ5LnJlcXVlc3Q7CisgICAgICAgICAgICAgICAgY29uc3QgdGFza0lkID0gcmVxdWVz dC5hbmFseXNpc1Rhc2tJZCgpOworICAgICAgICAgICAgICAgIGNvbnN0IHRhc2sgPSBBbmFseXNp c1Rhc2suZmluZEJ5SWQodGFza0lkKTsKICAgICAgICAgICAgICAgICByZXR1cm4gZWxlbWVudCgn dHInLCBbCiAgICAgICAgICAgICAgICAgICAgIGVsZW1lbnQoJ3RkJywge2NsYXNzOiAncmVxdWVz dC1pZCd9LCByZXF1ZXN0LmlkKCkpLAogICAgICAgICAgICAgICAgICAgICBlbGVtZW50KCd0ZCcs IHtjbGFzczogJ3BsYXRmb3JtJ30sIHJlcXVlc3QucGxhdGZvcm0oKS5uYW1lKCkpLAo=