169899 2017-03-20 17:06:57 -0700 REGRESSION (r187873): Web Inspector: When resizing, prevent DataGrid columns from collapsing entirely 2017-03-20 17:46:20 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev commit-queue inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1289636 0 nvasilyev 2017-03-20 17:06:57 -0700 This was implemented a long time ago but broke when we transitioned to ES6 classes: Bug 147439 - Web Inspector: Convert DataGrid and DataGridNode classes to ES6 classes. Unfortunately, JavaScript doesn't show any warnings for `aNumber - undefined`. 1289637 1 webkit-bug-importer 2017-03-20 17:07:34 -0700 <rdar://problem/31160842> 1289639 2 304969 nvasilyev 2017-03-20 17:08:39 -0700 Created attachment 304969 Patch 1289647 3 304969 joepeck 2017-03-20 17:16:44 -0700 Comment on attachment 304969 Patch rs=me 1289662 4 304969 commit-queue 2017-03-20 17:46:14 -0700 Comment on attachment 304969 Patch Clearing flags on attachment: 304969 Committed r214198: <http://trac.webkit.org/changeset/214198> 1289663 5 commit-queue 2017-03-20 17:46:20 -0700 All reviewed patches have been landed. Closing bug. 304969 2017-03-20 17:08:39 -0700 2017-03-20 17:46:14 -0700 Patch patch.txt text/plain 1869 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGY3ZDgxZTIuLjBlMWE2M2YgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTAzLTIwICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxODc4NzMp OiBXZWIgSW5zcGVjdG9yOiBXaGVuIHJlc2l6aW5nLCBwcmV2ZW50IERhdGFHcmlkIGNvbHVtbnMg ZnJvbSBjb2xsYXBzaW5nIGVudGlyZWx5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjk4OTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanM6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuRGF0YUdyaWQucHJvdG90eXBlLnJlc2l6ZXJEcmFnZ2luZyk6Cisg ICAgICAgIGxlZnRNaW5pbXVtIGFuZCByaWdodE1heGltdW0gdmFyaWFibGVzIHdlcmUgYWx3YXlz IE5hTiBiZWNhdXNlIHRoaXMuQ29sdW1uUmVzaXplUGFkZGluZyBpcyB1bmRlZmluZWQuCisKIDIw MTctMDMtMTkgIE1hdHQgQmFrZXIgIDxtYXR0YmFrZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IFJFR1JFU1NJT04gKHIyMTI5MTApOiBBY3RpdmUgY2FsbCBmcmFtZSBzdGF0 dXMgaWNvbiBoYXMgaW5jb3JyZWN0IGxlZnQgbWFyZ2luCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EYXRhR3JpZC5qcyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkLmpzCmluZGV4IDRlODAzYjQu LjNiNDhlNDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL0RhdGFHcmlkLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL0RhdGFHcmlkLmpzCkBAIC0xODI3LDggKzE4MjcsOCBAQCBXZWJJbnNwZWN0b3Iu RGF0YUdyaWQgPSBjbGFzcyBEYXRhR3JpZCBleHRlbmRzIFdlYkluc3BlY3Rvci5WaWV3CiAgICAg ICAgIGxldCB0cmFpbGluZ0VkZ2VPZk5leHRDb2x1bW4gPSBsZWFkaW5nRWRnZU9mUHJldmlvdXND b2x1bW4gKyBmaXJzdFJvd0NlbGxzW2xlZnRDb2x1bW5JbmRleF0ub2Zmc2V0V2lkdGggKyBmaXJz dFJvd0NlbGxzW3JpZ2h0Q29sdW1uSW5kZXhdLm9mZnNldFdpZHRoOwogCiAgICAgICAgIC8vIEdp dmUgZWFjaCBjb2x1bW4gc29tZSBwYWRkaW5nIHNvIHRoYXQgdGhleSBkb24ndCBkaXNhcHBlYXIu Ci0gICAgICAgIGxldCBsZWZ0TWluaW11bSA9IGxlYWRpbmdFZGdlT2ZQcmV2aW91c0NvbHVtbiAr IHRoaXMuQ29sdW1uUmVzaXplUGFkZGluZzsKLSAgICAgICAgbGV0IHJpZ2h0TWF4aW11bSA9IHRy YWlsaW5nRWRnZU9mTmV4dENvbHVtbiAtIHRoaXMuQ29sdW1uUmVzaXplUGFkZGluZzsKKyAgICAg ICAgbGV0IGxlZnRNaW5pbXVtID0gbGVhZGluZ0VkZ2VPZlByZXZpb3VzQ29sdW1uICsgV2ViSW5z cGVjdG9yLkRhdGFHcmlkLkNvbHVtblJlc2l6ZVBhZGRpbmc7CisgICAgICAgIGxldCByaWdodE1h eGltdW0gPSB0cmFpbGluZ0VkZ2VPZk5leHRDb2x1bW4gLSBXZWJJbnNwZWN0b3IuRGF0YUdyaWQu Q29sdW1uUmVzaXplUGFkZGluZzsKIAogICAgICAgICBkcmFnUG9pbnQgPSBOdW1iZXIuY29uc3Ry YWluKGRyYWdQb2ludCwgbGVmdE1pbmltdW0sIHJpZ2h0TWF4aW11bSk7CiAK