169867 2017-03-19 16:14:58 -0700 B3::LowerToAir incorrectly selects BitXor(AtomicStrongCAS(...), $1) 2017-04-04 15:38:14 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo buildbot keith_miller mark.lam msaboff saam oldest_to_newest 1289413 0 fpizlo 2017-03-19 16:14:58 -0700 It thinks that this is just like NotEqual(AtomicStrongCAS(@exp, ...), @exp). It's not. We need to teach it to only look for AtomicWeakCAS in that pattern, not any AtomicCAS. 1294198 1 306210 fpizlo 2017-04-04 15:06:37 -0700 Created attachment 306210 the patch 1294226 2 fpizlo 2017-04-04 15:38:14 -0700 Landed in https://trac.webkit.org/changeset/214908/webkit 306210 2017-04-04 15:06:37 -0700 2017-04-04 15:08:15 -0700 the patch blah.patch text/plain 4392 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjE0OTAxKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBA CisyMDE3LTA0LTA0ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg QjM6Okxvd2VyVG9BaXIgaW5jb3JyZWN0bHkgc2VsZWN0cyBCaXRYb3IoQXRvbWljU3Ryb25nQ0FT KC4uLiksICQxKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTY5ODY3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAg IAorICAgICAgICBUaGUgQml0WG9yKEF0b21pY1dlYWtDQVMoLi4uKSwgJDEpIG9wdGltaXphdGlv biBtYWtlcyBhIGxvdCBvZiBzZW5zZSBiZWNhdXNlIHdlIGFuIGZvbGQgdGhlCisgICAgICAgIEJp dFhvciBpbnRvIHRoZSBDQVMgY29uZGl0aW9uIHJlYWQtb3V0LiBCdXQgdGhlcmUgaXMgbm8gdmVy c2lvbiBvZiB0aGlzIHRoYXQgaXMgcHJvZml0YWJsZSBvcgorICAgICAgICBjb3JyZWN0IGZvciBB dG9taWNTdHJvbmdDQVMuIFRoZSBpbnZlcnNpb24gY2FzZSBpcyBoYW5kbGVkIGJ5IEVxdWFsKEF0 b21pY1N0cm9uZ0NBUyguLi4pLCAuLi4pCisgICAgICAgIGJlY29taW5nIE5vdEVxdWFsKEF0b21p Y1N0cm9uZ0NBUyguLi4pLCAuLi4pLCBhbmQgd2UgYWxyYWVkeSBoYW5kbGUgdGhhdCBzZXBhcmF0 ZWx5LgorICAgICAgICAKKyAgICAgICAgU28sIHRoZSBmaXggaGVyZSBpcyB0byBtYWtlIHRoZSBC aXRYb3IgQ0FTIHBhdHRlcm4gb25seSByZWNvZ25pemUgQXRvbWljV2Vha0NBUy4KKworICAgICAg ICAqIGIzL0IzTG93ZXJUb0Fpci5jcHA6CisgICAgICAgIChKU0M6OkIzOjpBaXI6Okxvd2VyVG9B aXI6Omxvd2VyKToKKyAgICAgICAgKiBiMy90ZXN0YjMuY3BwOgorICAgICAgICAoSlNDOjpCMzo6 dGVzdEF0b21pY1N0cm9uZ0NBUyk6CisKIDIwMTctMDQtMDQgIEZpbGlwIFBpemxvICA8ZnBpemxv QGFwcGxlLmNvbT4KIAogICAgICAgICBBaXI6Omxvd2VyQWZ0ZXJSZWdBbGxvYyBzaG91bGQgYmFp bCBlYXJseSBpZiBpdCBmaW5kcyBubyBTaHVmZmxlcyBvciBDb2xkQ0NhbGxzCkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYjMvQjNMb3dlclRvQWlyLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvYjMvQjNMb3dlclRvQWlyLmNwcAkocmV2aXNpb24gMjE0ODgzKQor KysgU291cmNlL0phdmFTY3JpcHRDb3JlL2IzL0IzTG93ZXJUb0Fpci5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTI1OTcsMTAgKzI1OTcsOCBAQCBwcml2YXRlOgogICAgICAgICAgICAgLy8gVGhpcyBw YXR0ZXJuIGlzIHN1cGVyIHVzZWZ1bCBvbiBib3RoIHg4NiBhbmQgQVJNNjQsIHNpbmNlIHRoZSBp bnZlcnNpb24gb2YgdGhlIENBUyByZXN1bHQKICAgICAgICAgICAgIC8vIGNhbiBiZSBkb25lIHdp dGggemVybyBjb3N0IG9uIHg4NiAoanVzdCBmbGlwIHRoZSBzZXQgZnJvbSBFIHRvIE5FKSBhbmQg aXQncyBhIHByb2dyZXNzaW9uCiAgICAgICAgICAgICAvLyBvbiBBUk02NCAoc2luY2UgU1RYIHJl dHVybnMgMCBvbiBzdWNjZXNzLCBzbyBvcmRpbmFyaWx5IHdlIGhhdmUgdG8gZmxpcCBpdCkuCi0g ICAgICAgICAgICAvLyBGSVhNRTogVGhpcyBsb29rcyB3cm9uZyBmb3IgQXRvbWljU3Ryb25nQ0FT Ci0gICAgICAgICAgICAvLyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTY5ODY3CiAgICAgICAgICAgICBpZiAobV92YWx1ZS0+Y2hpbGQoMSktPmlzSW50KDEpCi0gICAg ICAgICAgICAgICAgJiYgaXNBdG9taWNDQVMobV92YWx1ZS0+Y2hpbGQoMCktPm9wY29kZSgpKQor ICAgICAgICAgICAgICAgICYmIG1fdmFsdWUtPmNoaWxkKDApLT5vcGNvZGUoKSA9PSBBdG9taWNX ZWFrQ0FTCiAgICAgICAgICAgICAgICAgJiYgY2FuQmVJbnRlcm5hbChtX3ZhbHVlLT5jaGlsZCgw KSkpIHsKICAgICAgICAgICAgICAgICBjb21taXRJbnRlcm5hbChtX3ZhbHVlLT5jaGlsZCgwKSk7 CiAgICAgICAgICAgICAgICAgYXBwZW5kQ0FTKG1fdmFsdWUtPmNoaWxkKDApLCB0cnVlKTsKSW5k ZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9iMy90ZXN0YjMuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9iMy90ZXN0YjMuY3BwCShyZXZpc2lvbiAyMTQ4ODMpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvdGVzdGIzLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTQ4 NzAsNiArMTQ4NzAsNDIgQEAgdm9pZCB0ZXN0QXRvbWljU3Ryb25nQ0FTKCkKICAgICB9CiAgICAg CiAgICAgeworICAgICAgICAvLyBUZXN0IGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTY5ODY3LgorICAgICAgICAKKyAgICAgICAgUHJvY2VkdXJlIHByb2M7Cisg ICAgICAgIEJhc2ljQmxvY2sqIHJvb3QgPSBwcm9jLmFkZEJsb2NrKCk7CisgICAgICAgIHJvb3Qt PmFwcGVuZE5ldzxWYWx1ZT4oCisgICAgICAgICAgICBwcm9jLCBSZXR1cm4sIE9yaWdpbigpLAor ICAgICAgICAgICAgcm9vdC0+YXBwZW5kTmV3PFZhbHVlPigKKyAgICAgICAgICAgICAgICBwcm9j LCBCaXRYb3IsIE9yaWdpbigpLAorICAgICAgICAgICAgICAgIHJvb3QtPmFwcGVuZE5ldzxBdG9t aWNWYWx1ZT4oCisgICAgICAgICAgICAgICAgICAgIHByb2MsIEF0b21pY1N0cm9uZ0NBUywgT3Jp Z2luKCksIHdpZHRoLAorICAgICAgICAgICAgICAgICAgICByb290LT5hcHBlbmRJbnRDb25zdGFu dChwcm9jLCBPcmlnaW4oKSwgdHlwZSwgNDIpLAorICAgICAgICAgICAgICAgICAgICByb290LT5h cHBlbmRJbnRDb25zdGFudChwcm9jLCBPcmlnaW4oKSwgdHlwZSwgMHhiZWVmKSwKKyAgICAgICAg ICAgICAgICAgICAgcm9vdC0+YXBwZW5kTmV3PEFyZ3VtZW50UmVnVmFsdWU+KHByb2MsIE9yaWdp bigpLCBHUFJJbmZvOjphcmd1bWVudEdQUjApKSwKKyAgICAgICAgICAgICAgICByb290LT5hcHBl bmRJbnRDb25zdGFudChwcm9jLCBPcmlnaW4oKSwgdHlwZSwgMSkpKTsKKyAgICAgICAgCisgICAg ICAgIHR5cGVuYW1lIE5hdGl2ZVRyYWl0czxUPjo6Q2Fub25pY2FsVHlwZSBvbmUgPSAxOworICAg ICAgICAKKyAgICAgICAgYXV0byBjb2RlID0gY29tcGlsZVByb2MocHJvYyk7CisgICAgICAgIFQg dmFsdWVbMl07CisgICAgICAgIHZhbHVlWzBdID0gNDI7CisgICAgICAgIHZhbHVlWzFdID0gMTM7 CisgICAgICAgIENIRUNLX0VRKGludm9rZTx0eXBlbmFtZSBOYXRpdmVUcmFpdHM8VD46OkNhbm9u aWNhbFR5cGU+KCpjb2RlLCB2YWx1ZSksIDQyIF4gb25lKTsKKyAgICAgICAgQ0hFQ0tfRVEodmFs dWVbMF0sIHN0YXRpY19jYXN0PFQ+KDB4YmVlZikpOworICAgICAgICBDSEVDS19FUSh2YWx1ZVsx XSwgMTMpOworICAgICAgICB2YWx1ZVswXSA9IHN0YXRpY19jYXN0PFQ+KDMwMCk7CisgICAgICAg IENIRUNLX0VRKGludm9rZTx0eXBlbmFtZSBOYXRpdmVUcmFpdHM8VD46OkNhbm9uaWNhbFR5cGU+ KCpjb2RlLCB2YWx1ZSksIHN0YXRpY19jYXN0PHR5cGVuYW1lIE5hdGl2ZVRyYWl0czxUPjo6Q2Fu b25pY2FsVHlwZT4oc3RhdGljX2Nhc3Q8VD4oMzAwKSkgXiBvbmUpOworICAgICAgICBDSEVDS19F USh2YWx1ZVswXSwgc3RhdGljX2Nhc3Q8VD4oMzAwKSk7CisgICAgICAgIENIRUNLX0VRKHZhbHVl WzFdLCAxMyk7CisgICAgICAgIHZhbHVlWzBdID0gc3RhdGljX2Nhc3Q8VD4oLTEpOworICAgICAg ICBDSEVDS19FUShpbnZva2U8dHlwZW5hbWUgTmF0aXZlVHJhaXRzPFQ+OjpDYW5vbmljYWxUeXBl PigqY29kZSwgdmFsdWUpLCBzdGF0aWNfY2FzdDx0eXBlbmFtZSBOYXRpdmVUcmFpdHM8VD46OkNh bm9uaWNhbFR5cGU+KHN0YXRpY19jYXN0PFQ+KC0xKSkgXiBvbmUpOworICAgICAgICBDSEVDS19F USh2YWx1ZVswXSwgc3RhdGljX2Nhc3Q8VD4oLTEpKTsKKyAgICAgICAgQ0hFQ0tfRVEodmFsdWVb MV0sIDEzKTsKKyAgICAgICAgY2hlY2tNeURpc2Fzc2VtYmx5KCpjb2RlLCB0cnVlKTsKKyAgICB9 CisgICAgCisgICAgewogICAgICAgICBQcm9jZWR1cmUgcHJvYzsKICAgICAgICAgQmFzaWNCbG9j ayogcm9vdCA9IHByb2MuYWRkQmxvY2soKTsKICAgICAgICAgcm9vdC0+YXBwZW5kTmV3PFZhbHVl PigK