169852 2017-03-18 14:43:30 -0700 Web Inspector: Clicking on Clear Network Items icon throws an exception if timing popover is visible 2017-03-20 18:01:29 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev nvasilyev commit-queue inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1289312 0 nvasilyev 2017-03-18 14:43:30 -0700 Uncaught Exceptions: - TypeError: null is not an object (evaluating 'this.dataGrid._popover') (at ResourceTimelineDataGridNode.js:424:82) ? @ ResourceTimelineDataGridNode.js:424:82 * STEPS TO REPRODUCE 1. In Web Inspector, open Network tab 2. Open http://webkit.org/ 3. Hover over the timing bar at the right side of the content view to show the timing information popover. 4. Quickly click on the Clear Network Items icon. 1289313 1 webkit-bug-importer 2017-03-18 14:44:44 -0700 <rdar://problem/31132652> 1289314 2 304879 nvasilyev 2017-03-18 14:55:38 -0700 Created attachment 304879 Patch 1289631 3 304879 joepeck 2017-03-20 16:48:02 -0700 Comment on attachment 304879 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304879&action=review r=me > Source/WebInspectorUI/UserInterface/Views/ResourceTimelineDataGridNode.js:430 > + let dismissPopover = () => { > + if (this.dataGrid) > + this.dataGrid._popover.dismiss(); > + }; > + > + this.dataGrid._dismissPopoverTimeout = setTimeout(dismissPopover, WebInspector.ResourceTimelineDataGridNode.DelayedPopoverDismissalTimeout); Style: We normally inline arrow functions used in only one place: this.dataGrid._dismissPopoverTimeout = setTimeout(() => { if (this.dataGrid) this.dataGrid._popover.dismiss(); }, WebInspector.ResourceTimelineDataGridNode.DelayedPopoverDismissalTimeout); 1289651 4 304974 nvasilyev 2017-03-20 17:20:24 -0700 Created attachment 304974 Patch 1289665 5 304974 commit-queue 2017-03-20 18:01:25 -0700 Comment on attachment 304974 Patch Clearing flags on attachment: 304974 Committed r214199: <http://trac.webkit.org/changeset/214199> 1289666 6 commit-queue 2017-03-20 18:01:29 -0700 All reviewed patches have been landed. Closing bug. 304879 2017-03-18 14:55:38 -0700 2017-03-20 17:20:24 -0700 Patch patch.txt text/plain 2067 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDg2YzJhMGUuLmNjZGRiOTcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTAzLTE4ICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IENsaWNr aW5nIG9uIENsZWFyIE5ldHdvcmsgSXRlbXMgaWNvbiB0aHJvd3MgYW4gZXhjZXB0aW9uIGlmIHRp bWluZyBwb3BvdmVyIGlzIHZpc2libGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE2OTg1MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzExMzI2NTI+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2Vy SW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlVGltZWxpbmVEYXRhR3JpZE5vZGUuanM6CisgICAgICAg IChXZWJJbnNwZWN0b3IuUmVzb3VyY2VUaW1lbGluZURhdGFHcmlkTm9kZS5wcm90b3R5cGUuX21v dXNlb3ZlclJlY29yZEJhcik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVzb3VyY2VUaW1lbGlu ZURhdGFHcmlkTm9kZSk6CisKIDIwMTctMDMtMTYgIERldmluIFJvdXNzbyAgPHdlYmtpdEBkZXZp bnJvdXNzby5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogbWVtb3J5IGNhdGVnb3J5IHRp bWVsaW5lcyB3b3VsZCBsb29rIGJldHRlciB3aXRoIHJ1bGVyIHRpY2stYWxpZ25lZCBndWlkZXMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1Jl c291cmNlVGltZWxpbmVEYXRhR3JpZE5vZGUuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZVRpbWVsaW5lRGF0YUdyaWROb2RlLmpzCmluZGV4IDBm YzE1YTAuLjNkZDYxMjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL1Jlc291cmNlVGltZWxpbmVEYXRhR3JpZE5vZGUuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVzb3VyY2VUaW1lbGluZURhdGFH cmlkTm9kZS5qcwpAQCAtNDIxLDcgKzQyMSwxMyBAQCBXZWJJbnNwZWN0b3IuUmVzb3VyY2VUaW1l bGluZURhdGFHcmlkTm9kZSA9IGNsYXNzIFJlc291cmNlVGltZWxpbmVEYXRhR3JpZE5vZGUgZQog ICAgICAgICByZWNvcmRCYXIuZWxlbWVudC5hZGRFdmVudExpc3RlbmVyKCJtb3VzZWxlYXZlIiwg KCkgPT4gewogICAgICAgICAgICAgaWYgKCF0aGlzLmRhdGFHcmlkKQogICAgICAgICAgICAgICAg IHJldHVybjsKLSAgICAgICAgICAgIHRoaXMuZGF0YUdyaWQuX2Rpc21pc3NQb3BvdmVyVGltZW91 dCA9IHNldFRpbWVvdXQoKCkgPT4gdGhpcy5kYXRhR3JpZC5fcG9wb3Zlci5kaXNtaXNzKCksIFdl Ykluc3BlY3Rvci5SZXNvdXJjZVRpbWVsaW5lRGF0YUdyaWROb2RlLkRlbGF5ZWRQb3BvdmVyRGlz bWlzc2FsVGltZW91dCk7CisKKyAgICAgICAgICAgIGxldCBkaXNtaXNzUG9wb3ZlciA9ICgpID0+ IHsKKyAgICAgICAgICAgICAgICBpZiAodGhpcy5kYXRhR3JpZCkKKyAgICAgICAgICAgICAgICAg ICAgdGhpcy5kYXRhR3JpZC5fcG9wb3Zlci5kaXNtaXNzKCk7CisgICAgICAgICAgICB9OworCisg ICAgICAgICAgICB0aGlzLmRhdGFHcmlkLl9kaXNtaXNzUG9wb3ZlclRpbWVvdXQgPSBzZXRUaW1l b3V0KGRpc21pc3NQb3BvdmVyLCBXZWJJbnNwZWN0b3IuUmVzb3VyY2VUaW1lbGluZURhdGFHcmlk Tm9kZS5EZWxheWVkUG9wb3ZlckRpc21pc3NhbFRpbWVvdXQpOwogICAgICAgICB9LCB7b25jZTog dHJ1ZX0pOwogCiAgICAgICAgIHRoaXMuZGF0YUdyaWQuX3BvcG92ZXIucHJlc2VudE5ld0NvbnRl bnRXaXRoRnJhbWUocG9wb3ZlckNvbnRlbnRFbGVtZW50LCB0YXJnZXRGcmFtZS5wYWQoMiksIHBy ZWZlcnJlZEVkZ2VzKTsK 304974 2017-03-20 17:20:24 -0700 2017-03-20 18:01:25 -0700 Patch patch.txt text/plain 2014 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGY3ZDgxZTIuLjM5ZGRiZWUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTAzLTE4ICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IENsaWNr aW5nIG9uIENsZWFyIE5ldHdvcmsgSXRlbXMgaWNvbiB0aHJvd3MgYW4gZXhjZXB0aW9uIGlmIHRp bWluZyBwb3BvdmVyIGlzIHZpc2libGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE2OTg1MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzExMzI2NTI+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSm9zZXBoIFBlY29yYXJvLgorCisgICAgICAgICogVXNl ckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZVRpbWVsaW5lRGF0YUdyaWROb2RlLmpzOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLlJlc291cmNlVGltZWxpbmVEYXRhR3JpZE5vZGUucHJvdG90eXBlLl9t b3VzZW92ZXJSZWNvcmRCYXIpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlJlc291cmNlVGltZWxp bmVEYXRhR3JpZE5vZGUpOgorCiAyMDE3LTAzLTE5ICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFw cGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSRUdSRVNTSU9OIChyMjEyOTEwKTog QWN0aXZlIGNhbGwgZnJhbWUgc3RhdHVzIGljb24gaGFzIGluY29ycmVjdCBsZWZ0IG1hcmdpbgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvUmVz b3VyY2VUaW1lbGluZURhdGFHcmlkTm9kZS5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1Jlc291cmNlVGltZWxpbmVEYXRhR3JpZE5vZGUuanMKaW5kZXggMGZj MTVhMC4uMmEzNmIzMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvUmVzb3VyY2VUaW1lbGluZURhdGFHcmlkTm9kZS5qcworKysgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9SZXNvdXJjZVRpbWVsaW5lRGF0YUdy aWROb2RlLmpzCkBAIC00MjEsNyArNDIxLDExIEBAIFdlYkluc3BlY3Rvci5SZXNvdXJjZVRpbWVs aW5lRGF0YUdyaWROb2RlID0gY2xhc3MgUmVzb3VyY2VUaW1lbGluZURhdGFHcmlkTm9kZSBlCiAg ICAgICAgIHJlY29yZEJhci5lbGVtZW50LmFkZEV2ZW50TGlzdGVuZXIoIm1vdXNlbGVhdmUiLCAo KSA9PiB7CiAgICAgICAgICAgICBpZiAoIXRoaXMuZGF0YUdyaWQpCiAgICAgICAgICAgICAgICAg cmV0dXJuOwotICAgICAgICAgICAgdGhpcy5kYXRhR3JpZC5fZGlzbWlzc1BvcG92ZXJUaW1lb3V0 ID0gc2V0VGltZW91dCgoKSA9PiB0aGlzLmRhdGFHcmlkLl9wb3BvdmVyLmRpc21pc3MoKSwgV2Vi SW5zcGVjdG9yLlJlc291cmNlVGltZWxpbmVEYXRhR3JpZE5vZGUuRGVsYXllZFBvcG92ZXJEaXNt aXNzYWxUaW1lb3V0KTsKKworICAgICAgICAgICAgdGhpcy5kYXRhR3JpZC5fZGlzbWlzc1BvcG92 ZXJUaW1lb3V0ID0gc2V0VGltZW91dCgoKSA9PiB7CisgICAgICAgICAgICAgICAgaWYgKHRoaXMu ZGF0YUdyaWQpCisgICAgICAgICAgICAgICAgICAgIHRoaXMuZGF0YUdyaWQuX3BvcG92ZXIuZGlz bWlzcygpOworICAgICAgICAgICAgfSwgV2ViSW5zcGVjdG9yLlJlc291cmNlVGltZWxpbmVEYXRh R3JpZE5vZGUuRGVsYXllZFBvcG92ZXJEaXNtaXNzYWxUaW1lb3V0KTsKICAgICAgICAgfSwge29u Y2U6IHRydWV9KTsKIAogICAgICAgICB0aGlzLmRhdGFHcmlkLl9wb3BvdmVyLnByZXNlbnROZXdD b250ZW50V2l0aEZyYW1lKHBvcG92ZXJDb250ZW50RWxlbWVudCwgdGFyZ2V0RnJhbWUucGFkKDIp LCBwcmVmZXJyZWRFZGdlcyk7Cg==