169830 2017-03-17 13:24:05 -0700 Disable per-region boxes for multicolumn 2017-03-17 14:59:45 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hyatt hyatt oldest_to_newest 1289124 0 hyatt 2017-03-17 13:24:05 -0700 Disable per-region boxes for multicolumn 1289125 1 304816 hyatt 2017-03-17 13:26:32 -0700 Created attachment 304816 Patch 1289127 2 304816 zalan 2017-03-17 13:36:37 -0700 Comment on attachment 304816 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304816&action=review > Source/WebCore/rendering/RenderBox.cpp:2732 > + if (isRenderFlowThread() || !flowThread || !is<RenderNamedFlowThread>(flowThread) || !canHaveBoxInfoInRegion() || flowThread->style().writingMode() != style().writingMode()) !is<RenderNamedFlowThread>(flowThread) covers !flowThread too -> if (isRenderFlowThread() || !is<RenderNamedFlowThread>(flowThread) || ... 1289165 3 hyatt 2017-03-17 14:59:45 -0700 Landed in r214126. 304816 2017-03-17 13:26:32 -0700 2017-03-17 13:36:37 -0700 Patch bug-169830-20170317152631.patch text/plain 6634 hyatt SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNDExMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDE3LTAzLTE3ICBEYXZlIEh5 YXR0ICA8aHlhdHRAYXBwbGUuY29tPgorCisgICAgICAgIERpc2FibGUgcGVyLXJlZ2lvbiBib3hl cyBmb3IgbXVsdGljb2x1bW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE2OTgzMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRlc3Q6IGZhc3QvbXVsdGljb2wvZmxvYXQtYWRqYWNlbnQtdG8tb3ZlcmZsb3ct YmxvY2suaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJsb2NrRmxvdy5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9ja0Zsb3c6OmRldGVybWluZUxvZ2ljYWxMZWZ0UG9z aXRpb25Gb3JDaGlsZCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJveC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJCb3g6OmJvcmRlckJveFJlY3RJblJlZ2lvbik6CisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJCb3g6OnJlbmRlckJveFJlZ2lvbkluZm8pOgorICAgICAgICBMaW1p dCBhbGwgb2YgdGhlIHBlci1yZWdpb24gYm94IGNvZGUgdG8gUmVuZGVyTmFtZWRGbG93VGhyZWFk cy4KKyAgICAgICAgVGhpcyBjb2RlIHNob3VsZCBuZXZlciBiZSB1c2VkIGJ5IG11bHRpY29sdW1u IGxheW91dC4KKwogMjAxNy0wMy0xNyAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+ CiAKICAgICAgICAgQWRkIGEgcmVsb2FkIHBvbGljeSB3aGVyZSBvbmx5IGV4cGlyZWQgc3VicmVz b3VyY2VzIGFyZSByZXZhbGlkYXRlZApJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckJsb2NrRmxvdy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJsb2NrRmxvdy5jcHAJKHJldmlzaW9uIDIxNDExMCkKKysrIFNvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNiw3ICsz Niw2IEBACiAjaW5jbHVkZSAiTGF5b3V0UmVwYWludGVyLmgiCiAjaW5jbHVkZSAiTG9nZ2luZy5o IgogI2luY2x1ZGUgIlJlbmRlckNvbWJpbmVUZXh0LmgiCi0jaW5jbHVkZSAiUmVuZGVyRmxvd1Ro cmVhZC5oIgogI2luY2x1ZGUgIlJlbmRlcklubGluZS5oIgogI2luY2x1ZGUgIlJlbmRlckl0ZXJh dG9yLmgiCiAjaW5jbHVkZSAiUmVuZGVyTGF5ZXIuaCIKQEAgLTQ2LDYgKzQ1LDcgQEAKICNpbmNs dWRlICJSZW5kZXJNdWx0aUNvbHVtbkZsb3dUaHJlYWQuaCIKICNpbmNsdWRlICJSZW5kZXJNdWx0 aUNvbHVtblNldC5oIgogI2luY2x1ZGUgIlJlbmRlck5hbWVkRmxvd0ZyYWdtZW50LmgiCisjaW5j bHVkZSAiUmVuZGVyTmFtZWRGbG93VGhyZWFkLmgiCiAjaW5jbHVkZSAiUmVuZGVyVGFibGVDZWxs LmgiCiAjaW5jbHVkZSAiUmVuZGVyVGV4dC5oIgogI2luY2x1ZGUgIlJlbmRlclZpZXcuaCIKQEAg LTg3Niw4ICs4NzYsMTEgQEAgdm9pZCBSZW5kZXJCbG9ja0Zsb3c6OmRldGVybWluZUxvZ2ljYWxM ZQogICAgICAgICAKICAgICAvLyBTb21lIG9iamVjdHMgKGUuZy4sIHRhYmxlcywgaG9yaXpvbnRh bCBydWxlcywgb3ZlcmZsb3c6YXV0byBibG9ja3MpIGF2b2lkIGZsb2F0cy4gVGhleSBuZWVkCiAg ICAgLy8gdG8gc2hpZnQgb3ZlciBhcyBuZWNlc3NhcnkgdG8gZG9kZ2UgYW55IGZsb2F0cyB0aGF0 IG1pZ2h0IGdldCBpbiB0aGUgd2F5LgotICAgIGlmIChjaGlsZC5hdm9pZHNGbG9hdHMoKSAmJiBj b250YWluc0Zsb2F0cygpICYmICFmbG93VGhyZWFkQ29udGFpbmluZ0Jsb2NrKCkpCi0gICAgICAg IG5ld1Bvc2l0aW9uICs9IGNvbXB1dGVTdGFydFBvc2l0aW9uRGVsdGFGb3JDaGlsZEF2b2lkaW5n RmxvYXRzKGNoaWxkLCBtYXJnaW5TdGFydEZvckNoaWxkKGNoaWxkKSk7CisgICAgaWYgKGNoaWxk LmF2b2lkc0Zsb2F0cygpICYmIGNvbnRhaW5zRmxvYXRzKCkpIHsKKyAgICAgICAgYXV0byBmbG93 VGhyZWFkID0gZmxvd1RocmVhZENvbnRhaW5pbmdCbG9jaygpOworICAgICAgICBpZiAoIWZsb3dU aHJlYWQgfHwgIWlzPFJlbmRlck5hbWVkRmxvd1RocmVhZD4oZmxvd1RocmVhZCkpCisgICAgICAg ICAgICBuZXdQb3NpdGlvbiArPSBjb21wdXRlU3RhcnRQb3NpdGlvbkRlbHRhRm9yQ2hpbGRBdm9p ZGluZ0Zsb2F0cyhjaGlsZCwgbWFyZ2luU3RhcnRGb3JDaGlsZChjaGlsZCkpOworICAgIH0KIAog ICAgIHNldExvZ2ljYWxMZWZ0Rm9yQ2hpbGQoY2hpbGQsIHN0eWxlKCkuaXNMZWZ0VG9SaWdodERp cmVjdGlvbigpID8gbmV3UG9zaXRpb24gOiB0b3RhbEF2YWlsYWJsZUxvZ2ljYWxXaWR0aCAtIG5l d1Bvc2l0aW9uIC0gbG9naWNhbFdpZHRoRm9yQ2hpbGQoY2hpbGQpLCBhcHBseURlbHRhKTsKIH0K SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guY3BwCShyZXZpc2lvbiAyMTQx MTApCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAkod29ya2luZyBj b3B5KQpAQCAtMjExLDggKzIxMSw4IEBAIExheW91dFJlY3QgUmVuZGVyQm94Ojpib3JkZXJCb3hS ZWN0SW5SZWcKICAgICBpZiAoIXJlZ2lvbikKICAgICAgICAgcmV0dXJuIGJvcmRlckJveFJlY3Qo KTsKIAotICAgIFJlbmRlckZsb3dUaHJlYWQqIGZsb3dUaHJlYWQgPSBmbG93VGhyZWFkQ29udGFp bmluZ0Jsb2NrKCk7Ci0gICAgaWYgKCFmbG93VGhyZWFkKQorICAgIGF1dG8qIGZsb3dUaHJlYWQg PSBmbG93VGhyZWFkQ29udGFpbmluZ0Jsb2NrKCk7CisgICAgaWYgKCFmbG93VGhyZWFkIHx8ICFp czxSZW5kZXJOYW1lZEZsb3dUaHJlYWQ+KGZsb3dUaHJlYWQpKQogICAgICAgICByZXR1cm4gYm9y ZGVyQm94UmVjdCgpOwogCiAgICAgUmVuZGVyUmVnaW9uKiBzdGFydFJlZ2lvbiA9IG51bGxwdHI7 CkBAIC0yNzI5LDcgKzI3MjksNyBAQCBSZW5kZXJCb3hSZWdpb25JbmZvKiBSZW5kZXJCb3g6OnJl bmRlckJvCiAgICAgLy8gRklYTUU6IEZvciBub3cgd2UgbGltaXQgdGhpcyBjb21wdXRhdGlvbiB0 byBub3JtYWwgUmVuZGVyQmxvY2tzLiBGdXR1cmUgcGF0Y2hlcyB3aWxsIGV4cGFuZAogICAgIC8v IHN1cHBvcnQgdG8gY292ZXIgYWxsIGJveGVzLgogICAgIFJlbmRlckZsb3dUaHJlYWQqIGZsb3dU aHJlYWQgPSBmbG93VGhyZWFkQ29udGFpbmluZ0Jsb2NrKCk7Ci0gICAgaWYgKGlzUmVuZGVyRmxv d1RocmVhZCgpIHx8ICFmbG93VGhyZWFkIHx8ICFjYW5IYXZlQm94SW5mb0luUmVnaW9uKCkgfHwg Zmxvd1RocmVhZC0+c3R5bGUoKS53cml0aW5nTW9kZSgpICE9IHN0eWxlKCkud3JpdGluZ01vZGUo KSkKKyAgICBpZiAoaXNSZW5kZXJGbG93VGhyZWFkKCkgfHwgIWZsb3dUaHJlYWQgfHwgIWlzPFJl bmRlck5hbWVkRmxvd1RocmVhZD4oZmxvd1RocmVhZCkgfHwgIWNhbkhhdmVCb3hJbmZvSW5SZWdp b24oKSB8fCBmbG93VGhyZWFkLT5zdHlsZSgpLndyaXRpbmdNb2RlKCkgIT0gc3R5bGUoKS53cml0 aW5nTW9kZSgpKQogICAgICAgICByZXR1cm4gbnVsbHB0cjsKIAogICAgIExvZ2ljYWxFeHRlbnRD b21wdXRlZFZhbHVlcyBjb21wdXRlZFZhbHVlczsKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNDExMCkK KysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE3LTAzLTE3ICBEYXZlIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgorCisgICAgICAgIERp c2FibGUgcGVyLXJlZ2lvbiBib3hlcyBmb3IgbXVsdGljb2x1bW4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2OTgzMAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC9tdWx0aWNvbC9mbG9hdC1hZGph Y2VudC10by1vdmVyZmxvdy1ibG9jay1leHBlY3RlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBm YXN0L211bHRpY29sL2Zsb2F0LWFkamFjZW50LXRvLW92ZXJmbG93LWJsb2NrLmh0bWw6IEFkZGVk LgorCiAyMDE3LTAzLTE3ICBEYXZlIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAg IEluaXRpYWwgbGV0dGVyIGRvZXMgbm90IHBhZ2luYXRlIHByb3Blcmx5LgpJbmRleDogTGF5b3V0 VGVzdHMvZmFzdC9tdWx0aWNvbC9mbG9hdC1hZGphY2VudC10by1vdmVyZmxvdy1ibG9jay1leHBl Y3RlZC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvbXVsdGljb2wvZmxvYXQt YWRqYWNlbnQtdG8tb3ZlcmZsb3ctYmxvY2stZXhwZWN0ZWQuaHRtbAkobm9uZXhpc3RlbnQpCisr KyBMYXlvdXRUZXN0cy9mYXN0L211bHRpY29sL2Zsb2F0LWFkamFjZW50LXRvLW92ZXJmbG93LWJs b2NrLWV4cGVjdGVkLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwyNSBAQAorPCFET0NU WVBFIGh0bWw+PGh0bWwgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiPgorICAg IDxoZWFkPgorICAgICAgICA8c3R5bGU+CisgICAgICAgICAgICBodG1sIHsgd2lkdGg6IDI1MHB4 OyBoZWlnaHQ6NTAwcHg7IH0KKyAgICAgICAgICAgIGJvZHkgeyBtYXJnaW46IDAgfQorICAgICAg ICAgICAgLmZsb2F0IHsKKyAgICAgICAgICAgICAgICB3aWR0aDo4MHB4OworICAgICAgICAgICAg ICAgIGhlaWdodDo4MHB4OworICAgICAgICAgICAgICAgIGJvcmRlcjo1cHggc29saWQgbWFyb29u OworICAgICAgICAgICAgICAgIG1hcmdpbjowOworICAgICAgICAgICAgfQorICAgICAgICAubGVm dCB7ZmxvYXQ6bGVmdDt9CisgICAgICAgIC5oZWFkaW5nIHsKKyAgICAgICAgICAgIG92ZXJmbG93 OmhpZGRlbjsKKyAgICAgICAgICAgIGJvcmRlcjo1cHggc29saWQgYmx1ZTsKKyAgICAgICAgfQor ICAgICAgICA8L3N0eWxlPgorICAgIDwvaGVhZD4KKyAgICA8aHRtbD4KKyAgICAgICAgPGJvZHk+ CisgICAgICAgICAgICA8ZGl2IGNsYXNzPSJmbG9hdCBsZWZ0Ij48L2Rpdj4KKyAgICAgICAgICAg IDxoMSBjbGFzcz0iaGVhZGluZyI+VGV4dCB0aGF0IHNob3VsZCBub3QgYmUgY2xpcHBlZCBvdXQu PC9oMT4KKyAgICAgICAgICAgIAorICAgICAgICA8L2JvZHk+CisgICAgPC9odG1sPgpJbmRleDog TGF5b3V0VGVzdHMvZmFzdC9tdWx0aWNvbC9mbG9hdC1hZGphY2VudC10by1vdmVyZmxvdy1ibG9j ay5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvbXVsdGljb2wvZmxvYXQtYWRq YWNlbnQtdG8tb3ZlcmZsb3ctYmxvY2suaHRtbAkobm9uZXhpc3RlbnQpCisrKyBMYXlvdXRUZXN0 cy9mYXN0L211bHRpY29sL2Zsb2F0LWFkamFjZW50LXRvLW92ZXJmbG93LWJsb2NrLmh0bWwJKHdv cmtpbmcgY29weSkKQEAgLTAsMCArMSwyNSBAQAorPCFET0NUWVBFIGh0bWw+PGh0bWwgeG1sbnM9 Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiPgorICAgIDxoZWFkPgorICAgICAgICA8c3R5 bGU+CisgICAgICAgICAgICBodG1sIHsgY29sdW1uLXdpZHRoOjI1MHB4OyBjb2x1bW4tZ2FwOjA7 IGhlaWdodDo1MDBweDsgd2lkdGg6NTAwcHg7IGNvbHVtbi1maWxsOmF1dG8gfQorICAgICAgICAg ICAgYm9keSB7IG1hcmdpbjogMCB9CisgICAgICAgICAgICAuZmxvYXQgeworICAgICAgICAgICAg ICAgIHdpZHRoOjgwcHg7CisgICAgICAgICAgICAgICAgaGVpZ2h0OjgwcHg7CisgICAgICAgICAg ICAgICAgYm9yZGVyOjVweCBzb2xpZCBtYXJvb247CisgICAgICAgICAgICAgICAgbWFyZ2luOjA7 CisgICAgICAgICAgICB9CisgICAgICAgIC5sZWZ0IHtmbG9hdDpsZWZ0O30KKyAgICAgICAgLmhl YWRpbmcgeworICAgICAgICAgICAgb3ZlcmZsb3c6aGlkZGVuOworICAgICAgICAgICAgYm9yZGVy OjVweCBzb2xpZCBibHVlOworICAgICAgICB9CisgICAgICAgIDwvc3R5bGU+CisgICAgPC9oZWFk PgorICAgIDxodG1sPgorICAgICAgICA8Ym9keT4KKyAgICAgICAgICAgIDxkaXYgY2xhc3M9ImZs b2F0IGxlZnQiPjwvZGl2PgorICAgICAgICAgICAgPGgxIGNsYXNzPSJoZWFkaW5nIj5UZXh0IHRo YXQgc2hvdWxkIG5vdCBiZSBjbGlwcGVkIG91dC48L2gxPgorICAgICAgICAgICAgCisgICAgICAg IDwvYm9keT4KKyAgICA8L2h0bWw+Cg==