169804 2017-03-16 18:41:34 -0700 Web Inspector: showing the Find banner doesn't immediately focus it 2017-04-03 17:41:24 -0700 1 1 1 Unclassified WebKit Web Inspector Other All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue inspector-bugzilla-changes joepeck mattbaker nvasilyev webkit-bug-importer oldest_to_newest 1288894 0 hi 2017-03-16 18:41:34 -0700 . 1288895 1 304737 hi 2017-03-16 18:46:12 -0700 Created attachment 304737 Patch 1289075 2 304737 joepeck 2017-03-17 11:32:46 -0700 Comment on attachment 304737 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304737&action=review > Source/WebInspectorUI/ChangeLog:11 > + If the FindBanner was now showing before, focus it before selecting. Typo: "now" => "not" > Source/WebInspectorUI/UserInterface/Views/FindBanner.js:207 > this._inputField.select(); Select should focus, right?! Seems this could be a WebCore regression if that is not the case. 1289078 3 joepeck 2017-03-17 11:43:21 -0700 This regressed somewhere in this range: https://trac.webkit.org/log/trunk/?mode=follow_copy&rev=213695&stop_rev=213686 1289079 4 joepeck 2017-03-17 11:47:06 -0700 This sounds super suspicious: https://trac.webkit.org/changeset/213689/trunk The ChangeLog says: This subtly changed the behavior of WebInspector._focusChanged, which expected all editable fields to be backed by a CodeMirror instance. I don't believe that statement is true. In any case, I don't know which is the better place to fix this. I feel like if we take a fix like yours we will need to do this in a lot of places. 1289080 5 304737 joepeck 2017-03-17 11:48:15 -0700 Comment on attachment 304737 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304737&action=review >> Source/WebInspectorUI/UserInterface/Views/FindBanner.js:207 >> this._inputField.select(); > > Select should focus, right?! Seems this could be a WebCore regression if that is not the case. Further, since we expect select() to focus(), then we can just always call focus() regardless of if we were showing or not. The keyboard shortcut should always focus the field. 1289557 6 304737 mattbaker 2017-03-20 13:29:37 -0700 Comment on attachment 304737 Patch r-, as the fix doesn't seem to address the root cause of the regression (the suspicious patch Joe mentioned). The fix should probably be in WebInspector._focusChanged. 1293812 7 joepeck 2017-04-03 14:35:22 -0700 *** Bug 170372 has been marked as a duplicate of this bug. *** 1293813 8 joepeck 2017-04-03 14:36:28 -0700 <rdar://problem/31383181> 1293824 9 306119 hi 2017-04-03 14:50:26 -0700 Created attachment 306119 Patch 1293831 10 306119 mattbaker 2017-04-03 15:00:20 -0700 Comment on attachment 306119 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306119&action=review > Source/WebInspectorUI/UserInterface/Base/Main.js:1341 > + // will also get run when WebInspector.startEditing is called on an element. We do not want Nit: use single-space after period. 1293912 11 306119 mattbaker 2017-04-03 17:07:35 -0700 Comment on attachment 306119 Patch Nice fix! r=me with a minor nit. 1293915 12 306144 hi 2017-04-03 17:13:18 -0700 Created attachment 306144 Patch 1293932 13 306144 commit-queue 2017-04-03 17:41:22 -0700 Comment on attachment 306144 Patch Clearing flags on attachment: 306144 Committed r214856: <http://trac.webkit.org/changeset/214856> 1293933 14 commit-queue 2017-04-03 17:41:24 -0700 All reviewed patches have been landed. Closing bug. 304737 2017-03-16 18:46:12 -0700 2017-04-03 14:50:24 -0700 Patch bug-169804-20170316194611.patch text/plain 2020 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGU3ZjNkYmI2MGNiYTcxYjc3OTE2ODdmOWY5NzBi MzhjM2MzMGNkYWEuLjlhODI4ZmJmNWI1MGU3NDBmODk4ZDAwNDU5MzdlZTI0MWM3N2Y2N2MgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTAzLTE2ICBEZXZp biBSb3Vzc28gIDx3ZWJraXRAZGV2aW5yb3Vzc28uY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IHNob3dpbmcgdGhlIEZpbmQgYmFubmVyIGRvZXNuJ3QgaW1tZWRpYXRlbHkgZm9jdXMgaXQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2OTgwNAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlcklu dGVyZmFjZS9WaWV3cy9GaW5kQmFubmVyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkZpbmRC YW5uZXIucHJvdG90eXBlLnNob3cuZGVsYXllZFdvcmspOgorICAgICAgICAoV2ViSW5zcGVjdG9y LkZpbmRCYW5uZXIucHJvdG90eXBlLnNob3cpOgorICAgICAgICBJZiB0aGUgRmluZEJhbm5lciB3 YXMgbm93IHNob3dpbmcgYmVmb3JlLCBmb2N1cyBpdCBiZWZvcmUgc2VsZWN0aW5nLgorCiAyMDE3 LTAzLTE2ICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiBSRUdSRVNTSU9OIChyMjEzNjkxKTogU2F2aW5nIERPTSBicmVha3BvaW50cyBi cm9rZW4gYWZ0ZXIgcmVmYWN0b3JpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JV SS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0ZpbmRCYW5uZXIuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9GaW5kQmFubmVyLmpzCmluZGV4IDVjN2FmYTExY2U3NzYz NWYzYTdmMjI1NDQ2MGYxOTljYTU0ODZiMDUuLmViY2U4OWQzMThkNTA4NTI0NzNlNDczNTQ4NDU1 MGZiNTIyOWMxNTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL0ZpbmRCYW5uZXIuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvRmluZEJhbm5lci5qcwpAQCAtMTkxLDYgKzE5MSw4IEBAIFdlYkluc3Bl Y3Rvci5GaW5kQmFubmVyID0gY2xhc3MgRmluZEJhbm5lciBleHRlbmRzIFdlYkluc3BlY3Rvci5O YXZpZ2F0aW9uSXRlbQogICAgICAgICBpZiAoIXRoaXMuX3RhcmdldEVsZW1lbnQucGFyZW50Tm9k ZSkKICAgICAgICAgICAgIHJldHVybjsKIAorICAgICAgICBsZXQgc2hvd2luZyA9IHRoaXMuc2hv d2luZzsKKwogICAgICAgICBpZiAodGhpcy5lbGVtZW50LnBhcmVudE5vZGUgIT09IHRoaXMuX3Rh cmdldEVsZW1lbnQucGFyZW50Tm9kZSkKICAgICAgICAgICAgIHRoaXMuX3RhcmdldEVsZW1lbnQu cGFyZW50Tm9kZS5pbnNlcnRCZWZvcmUodGhpcy5lbGVtZW50LCB0aGlzLl90YXJnZXRFbGVtZW50 KTsKIApAQCAtMTk5LDYgKzIwMSw5IEBAIFdlYkluc3BlY3Rvci5GaW5kQmFubmVyID0gY2xhc3Mg RmluZEJhbm5lciBleHRlbmRzIFdlYkluc3BlY3Rvci5OYXZpZ2F0aW9uSXRlbQogICAgICAgICAg ICAgdGhpcy5fdGFyZ2V0RWxlbWVudC5jbGFzc0xpc3QuYWRkKFdlYkluc3BlY3Rvci5GaW5kQmFu bmVyLlNob3dpbmdGaW5kQmFubmVyU3R5bGVDbGFzc05hbWUpOwogICAgICAgICAgICAgdGhpcy5l bGVtZW50LmNsYXNzTGlzdC5hZGQoV2ViSW5zcGVjdG9yLkZpbmRCYW5uZXIuU2hvd2luZ1N0eWxl Q2xhc3NOYW1lKTsKIAorICAgICAgICAgICAgaWYgKCFzaG93aW5nKQorICAgICAgICAgICAgICAg IHRoaXMuX2lucHV0RmllbGQuZm9jdXMoKTsKKwogICAgICAgICAgICAgdGhpcy5faW5wdXRGaWVs ZC5zZWxlY3QoKTsKICAgICAgICAgfQogCg== 306119 2017-04-03 14:50:26 -0700 2017-04-03 17:13:18 -0700 Patch bug-169804-20170403145033.patch text/plain 2031 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGNjNmE4MDMwYWJiZDQ2YWM1MDk1OWRkM2U5Y2Fk OWEwMDVhOTZkZTYuLmYzZjViOWEwOTk0YjYxMTQwNjFhYTE2ZDNjNjc5YTgyZmE2NmVlMTQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA0LTAzICBEZXZp biBSb3Vzc28gIDx3ZWJraXRAZGV2aW5yb3Vzc28uY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IHNob3dpbmcgdGhlIEZpbmQgYmFubmVyIGRvZXNuJ3QgaW1tZWRpYXRlbHkgZm9jdXMgaXQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2OTgwNAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVXNlcklu dGVyZmFjZS9CYXNlL01haW4uanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuX2ZvY3VzQ2hhbmdl ZCk6CisgICAgICAgIFNsaWdodGx5IGNoYW5nZSB0aGUgbG9naWMgZnJvbSA8aHR0cHM6Ly93ZWJr aXQub3JnL2IvMTY4MTE5PiAocjIxMzY4OSkgdG8gbm90IHByZXZlbnQgYSBuZXcKKyAgICAgICAg c2VsZWN0aW9uIGlmIHRoZSBmb2N1cyBjaGFuZ2UgdGFyZ2V0IGlzIGFuIGVsZW1lbnQgZnJvbSBX ZWJJbnNwZWN0b3Iuc3RhcnRFZGl0aW5nLgorCiAyMDE3LTA0LTAxICBKb24gTGVlICA8am9ubGVl QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgbWlzc2luZyB0ZXh0IHN0eWxlcwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCmluZGV4IDg3MDFh ODM5OWMxNmQzMDU3NDUxMjcwYjg1MGNjN2ExYTE1MGRhZjEuLmQ1MTc0NjdlZWVlYmExNWRlMjlj NzRjMjkwYjdjMWZlMTI4ZjRiMDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9CYXNlL01haW4uanMKQEAgLTEzMzUsOCArMTMzNSwxNCBAQCBXZWJJbnNwZWN0 b3IuX2ZvY3VzQ2hhbmdlZCA9IGZ1bmN0aW9uKGV2ZW50KQogICAgICAgICBpZiAoY29kZU1pcnJv ckVkaXRvckVsZW1lbnQgJiYgY29kZU1pcnJvckVkaXRvckVsZW1lbnQgIT09IHRoaXMuY3VycmVu dEZvY3VzRWxlbWVudCkgewogICAgICAgICAgICAgdGhpcy5wcmV2aW91c0ZvY3VzRWxlbWVudCA9 IHRoaXMuY3VycmVudEZvY3VzRWxlbWVudDsKICAgICAgICAgICAgIHRoaXMuY3VycmVudEZvY3Vz RWxlbWVudCA9IGNvZGVNaXJyb3JFZGl0b3JFbGVtZW50OwotICAgICAgICAgICAgcmV0dXJuOwog ICAgICAgICB9CisKKyAgICAgICAgLy8gRHVlIHRvIHRoZSBjaGFuZ2UgaW4gV2ViSW5zcGVjdG9y LmlzRXZlbnRUYXJnZXRBbkVkaXRhYmxlRmllbGQgKHIxOTYyNzEpLCB0aGlzIHJldHVybgorICAg ICAgICAvLyB3aWxsIGFsc28gZ2V0IHJ1biB3aGVuIFdlYkluc3BlY3Rvci5zdGFydEVkaXRpbmcg aXMgY2FsbGVkIG9uIGFuIGVsZW1lbnQuICBXZSBkbyBub3Qgd2FudAorICAgICAgICAvLyB0byBy ZXR1cm4gZWFybHkgaW4gdGhpcyBjYXNlLCBhcyBXZWJJbnNwZWN0b3IuRWRpdGluZ0NvbmZpZyBo YW5kbGVzIGl0cyBvd24gZWRpdGluZworICAgICAgICAvLyBjb21wbGV0aW9uLCBzbyBvbmx5IHJl dHVybiBlYXJseSBpZiB0aGUgZm9jdXMgY2hhbmdlIHRhcmdldCBpcyBub3QgZnJvbSBXZWJJbnNw ZWN0b3Iuc3RhcnRFZGl0aW5nLgorICAgICAgICBpZiAoIVdlYkluc3BlY3Rvci5pc0JlaW5nRWRp dGVkKGV2ZW50LnRhcmdldCkpCisgICAgICAgICAgICByZXR1cm47CiAgICAgfQogCiAgICAgdmFy IHNlbGVjdGlvbiA9IHdpbmRvdy5nZXRTZWxlY3Rpb24oKTsK 306144 2017-04-03 17:13:18 -0700 2017-04-03 17:41:22 -0700 Patch 169804.diff text/plain 1987 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDQ5N2FiNWViYjM5Li5iZDZkNjZmYzNmYyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTctMDQtMDMgIERldmlu IFJvdXNzbyAgPHdlYmtpdEBkZXZpbnJvdXNzby5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogc2hvd2luZyB0aGUgRmluZCBiYW5uZXIgZG9lc24ndCBpbW1lZGlhdGVseSBmb2N1cyBpdAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY5ODA0CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTWF0dCBCYWtlci4KKworICAgICAgICAqIFVzZXJJbnRlcmZh Y2UvQmFzZS9NYWluLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLl9mb2N1c0NoYW5nZWQpOgor ICAgICAgICBTbGlnaHRseSBjaGFuZ2UgdGhlIGxvZ2ljIGZyb20gPGh0dHBzOi8vd2Via2l0Lm9y Zy9iLzE2ODExOT4gKHIyMTM2ODkpIHRvIG5vdCBwcmV2ZW50IGEgbmV3CisgICAgICAgIHNlbGVj dGlvbiBpZiB0aGUgZm9jdXMgY2hhbmdlIHRhcmdldCBpcyBhbiBlbGVtZW50IGZyb20gV2ViSW5z cGVjdG9yLnN0YXJ0RWRpdGluZy4KKwogMjAxNy0wNC0wMyAgTmlraXRhIFZhc2lseWV2ICA8bnZh c2lseWV2QGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBXZWJTb2NrZXRzOiBE b24ndCBzdG9yZSBiaW5hcnkgZnJhbWVzIGluIG1lbW9yeSBzaW5jZSB0aGV5IGFyZSBuZXZlciBz aG93bgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFz ZS9NYWluLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWlu LmpzCmluZGV4IDI0ZmE3NGZhYjBiLi42ZGE5NmNjYmMyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwpAQCAtMTMxMSw4ICsxMzExLDE0 IEBAIFdlYkluc3BlY3Rvci5fZm9jdXNDaGFuZ2VkID0gZnVuY3Rpb24oZXZlbnQpCiAgICAgICAg IGlmIChjb2RlTWlycm9yRWRpdG9yRWxlbWVudCAmJiBjb2RlTWlycm9yRWRpdG9yRWxlbWVudCAh PT0gdGhpcy5jdXJyZW50Rm9jdXNFbGVtZW50KSB7CiAgICAgICAgICAgICB0aGlzLnByZXZpb3Vz Rm9jdXNFbGVtZW50ID0gdGhpcy5jdXJyZW50Rm9jdXNFbGVtZW50OwogICAgICAgICAgICAgdGhp cy5jdXJyZW50Rm9jdXNFbGVtZW50ID0gY29kZU1pcnJvckVkaXRvckVsZW1lbnQ7Ci0gICAgICAg ICAgICByZXR1cm47CiAgICAgICAgIH0KKworICAgICAgICAvLyBEdWUgdG8gdGhlIGNoYW5nZSBp biBXZWJJbnNwZWN0b3IuaXNFdmVudFRhcmdldEFuRWRpdGFibGVGaWVsZCAocjE5NjI3MSksIHRo aXMgcmV0dXJuCisgICAgICAgIC8vIHdpbGwgYWxzbyBnZXQgcnVuIHdoZW4gV2ViSW5zcGVjdG9y LnN0YXJ0RWRpdGluZyBpcyBjYWxsZWQgb24gYW4gZWxlbWVudC4gV2UgZG8gbm90IHdhbnQKKyAg ICAgICAgLy8gdG8gcmV0dXJuIGVhcmx5IGluIHRoaXMgY2FzZSwgYXMgV2ViSW5zcGVjdG9yLkVk aXRpbmdDb25maWcgaGFuZGxlcyBpdHMgb3duIGVkaXRpbmcKKyAgICAgICAgLy8gY29tcGxldGlv biwgc28gb25seSByZXR1cm4gZWFybHkgaWYgdGhlIGZvY3VzIGNoYW5nZSB0YXJnZXQgaXMgbm90 IGZyb20gV2ViSW5zcGVjdG9yLnN0YXJ0RWRpdGluZy4KKyAgICAgICAgaWYgKCFXZWJJbnNwZWN0 b3IuaXNCZWluZ0VkaXRlZChldmVudC50YXJnZXQpKQorICAgICAgICAgICAgcmV0dXJuOwogICAg IH0KIAogICAgIHZhciBzZWxlY3Rpb24gPSB3aW5kb3cuZ2V0U2VsZWN0aW9uKCk7Cg==