169793 2017-03-16 15:30:10 -0700 buildbot: run-webkit-tests should display test failures and run exceptions differently 2017-03-23 14:45:21 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbedard jbedard ap clopez commit-queue lforschler oldest_to_newest 1288792 0 jbedard 2017-03-16 15:30:10 -0700 Right now, failing to run LayoutTests because of a simulator or test harness bug is treated the same way a single test failure is. Simulator bugs and test harness bugs, as well as any exception thrown and not managed in run-webkit-tests should cause an exception in build-bot. 1288798 1 304707 jbedard 2017-03-16 15:37:49 -0700 Created attachment 304707 Patch 1289070 2 ap 2017-03-17 11:23:42 -0700 Is this happening on bots? Do you have an example link? 1289095 3 jbedard 2017-03-17 12:35:00 -0700 (In reply to comment #2) > Is this happening on bots? Do you have an example link? Currently, the WebKit bots are in a stable state, so we are not experiencing these issues at the moment. 1289486 4 304707 commit-queue 2017-03-20 10:11:06 -0700 Comment on attachment 304707 Patch Clearing flags on attachment: 304707 Committed r214172: <http://trac.webkit.org/changeset/214172> 1289487 5 commit-queue 2017-03-20 10:11:12 -0700 All reviewed patches have been landed. Closing bug. 1290603 6 clopez 2017-03-23 14:45:21 -0700 Committed r214318: <http://trac.webkit.org/changeset/214318> 304707 2017-03-16 15:37:49 -0700 2017-03-20 10:11:06 -0700 Patch bug-169793-20170316153748.patch text/plain 1872 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNDA3MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE3LTAzLTE2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBidWlsZGJvdDogcnVuLXdlYmtpdC10ZXN0cyBzaG91bGQgZGlzcGxheSB0 ZXN0IGZhaWx1cmVzIGFuZCBydW4gZXhjZXB0aW9ucyBkaWZmZXJlbnRseQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTY5NzkzCisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8zMDk4Nzg2Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmln L21hc3Rlci5jZmc6CisgICAgICAgIChSdW5XZWJLaXRUZXN0cy5ldmFsdWF0ZUNvbW1hbmQpOiBS ZXR1cm4gRVhDRVBUSU9OIHdoZW4gcnVuLXdlYmtpdC10ZXN0cyByZXR1cm5zIHdpdGggYSBjb2Rl IG9mIDI1NC4KKwogMjAxNy0wMy0xNiAgS29jc2VuIENodW5nICA8a29jc2VuX2NodW5nQGFwcGxl LmNvbT4KIAogICAgICAgICBGaXggcXVvdGVzIGFyb3VuZCAtLXByZXR0eSBmb3JtYXQgZ2l0IGZs YWcuCkluZGV4OiBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZp Zy9tYXN0ZXIuY2ZnCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxk LndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcJKHJldmlzaW9uIDIxNDA0MykKKysrIFRvb2xz L0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcJKHdv cmtpbmcgY29weSkKQEAgLTEwLDcgKzEwLDcgQEAgZnJvbSBidWlsZGJvdC5zdGF0dXMgaW1wb3J0 IGh0bWwKIGZyb20gYnVpbGRib3Quc3RhdHVzLndlYi5hdXRoeiBpbXBvcnQgQXV0aHoKIGZyb20g YnVpbGRib3QucHJvY2VzcyBpbXBvcnQgYnVpbGRzdGVwLCBmYWN0b3J5LCBwcm9wZXJ0aWVzCiBm cm9tIGJ1aWxkYm90LnN0ZXBzIGltcG9ydCBtYXN0ZXIsIHNoZWxsLCBzb3VyY2UsIHRyYW5zZmVy LCB0cmlnZ2VyCi1mcm9tIGJ1aWxkYm90LnN0YXR1cy5idWlsZGVyIGltcG9ydCBTVUNDRVNTLCBG QUlMVVJFLCBXQVJOSU5HUywgU0tJUFBFRAorZnJvbSBidWlsZGJvdC5zdGF0dXMuYnVpbGRlciBp bXBvcnQgU1VDQ0VTUywgRkFJTFVSRSwgV0FSTklOR1MsIFNLSVBQRUQsIEVYQ0VQVElPTgogCiBm cm9tIHR3aXN0ZWQuaW50ZXJuZXQgaW1wb3J0IGRlZmVyCiAKQEAgLTQxMSw2ICs0MTEsMTEgQEAg Y2xhc3MgUnVuV2ViS2l0VGVzdHMoc2hlbGwuVGVzdCk6CiAgICAgICAgICAgICAgICAgZWxzZToK ICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIEZBSUxVUkUKIAorICAgICAgICAjIFJldHVybiBj b2RlIGZyb20gVG9vbHMvU2NyaXB0cy9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weS4K KyAJICAgICMgVGhpcyBtZWFucyB0aGF0IGFuIGV4Y2VwdGlvbiB3YXMgcmFpc2VkIHdoZW4gcnVu bmluZyBydW4td2Via2l0LXRlc3RzIGFuZAorIAkgICAgIyB3YXMgbmV2ZXIgaGFuZGxlZC4KKyAJ ICAgIGlmIGNtZC5yYyA9PSAyNTQ6CisgCSAgICAgICAgcmV0dXJuIEVYQ0VQVElPTgogICAgICAg ICBpZiBjbWQucmMgIT0gMDoKICAgICAgICAgICAgIHJldHVybiBGQUlMVVJFCiAK