169779 2017-03-16 13:32:25 -0700 Web Inspector: REGRESSION (r213691): Saving DOM breakpoints broken after refactoring 2017-03-16 17:23:54 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 mattbaker mattbaker commit-queue inspector-bugzilla-changes oldest_to_newest 1288704 0 mattbaker 2017-03-16 13:32:25 -0700 DOMDebuggerManager.prototype._saveBreakpoints should be "_saveDOMBreakpoints". 1288707 1 304684 mattbaker 2017-03-16 13:35:34 -0700 Created attachment 304684 Patch 1288760 2 304684 joepeck 2017-03-16 14:39:41 -0700 Comment on attachment 304684 Patch This isn't exactly a typo, its a real bug fix. I'm actually surprised no tests cause this, I'd expect any test using addDOMBreakpoint to trigger an uncaught exception and show up in test results. 1288794 3 304705 mattbaker 2017-03-16 15:32:27 -0700 Created attachment 304705 Patch 1288861 4 304705 commit-queue 2017-03-16 17:23:48 -0700 Comment on attachment 304705 Patch Clearing flags on attachment: 304705 Committed r214083: <http://trac.webkit.org/changeset/214083> 1288862 5 commit-queue 2017-03-16 17:23:54 -0700 All reviewed patches have been landed. Closing bug. 304684 2017-03-16 13:35:34 -0700 2017-03-16 15:32:23 -0700 Patch bug-169779-20170316133535.patch text/plain 1717 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0MDYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA0 MDljY2RmNmJmMGFiZDNhY2IyMDRkZjM3OGVlNTVjYzNiMGM2YjMzLi40MzEwNDk4ZDU0NjdmMzMy NTkxYzRkMTIwMWM0MzQxY2JiMjdiMmRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNy0wMy0xNiAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogZml4IHR5cG8gaW4gRE9NRGVidWdnZXJNYW5hZ2Vy CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjk3NzkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggdHlw by4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRE9NRGVidWdnZXJNYW5h Z2VyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRPTURlYnVnZ2VyTWFuYWdlci5wcm90b3R5 cGUuYWRkRE9NQnJlYWtwb2ludCk6CisgICAgICAgIFJlbW92ZSBjaGVjayBiZWZvcmUgc2F2aW5n IHRvIGJlIGNvbnNpc3RlbnQgd2l0aCBzaW1pbGFyIGNvZGUgaW4KKyAgICAgICAgRGVidWdnZXJN YW5hZ2VyIGFuZCBET01EZWJ1Z2dlck1hbmFnZXIuCisKIDIwMTctMDMtMTYgIERldmluIFJvdXNz byAgPHdlYmtpdEBkZXZpbnJvdXNzby5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUlRM OiBnb3RvIGFycm93IGZvciBzb3VyY2UgbG9jYXRpb25zIGlzIHBvaW50aW5nIHdyb25nIHdheSBp biBUaW1lbGluZSBkYXRhIGdyaWRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9Db250cm9sbGVycy9ET01EZWJ1Z2dlck1hbmFnZXIuanMgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9ET01EZWJ1Z2dlck1hbmFn ZXIuanMKaW5kZXggY2FmN2UzOTczMGNiNmFhMWUwYzc4YjAxZGY4ZGFiYjY2YjA2ZWI0Mi4uYzNj ZjUxM2JjNWU2MDQ2YTYzNTA4NDQ1ODkxZWFmZDI1NGI1OTE1NCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRE9NRGVidWdnZXJNYW5h Z2VyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xs ZXJzL0RPTURlYnVnZ2VyTWFuYWdlci5qcwpAQCAtMTUxLDggKzE1MSw3IEBAIFdlYkluc3BlY3Rv ci5ET01EZWJ1Z2dlck1hbmFnZXIgPSBjbGFzcyBET01EZWJ1Z2dlck1hbmFnZXIgZXh0ZW5kcyBX ZWJJbnNwZWN0b3IuCiAKICAgICAgICAgdGhpcy5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoV2Vi SW5zcGVjdG9yLkRPTURlYnVnZ2VyTWFuYWdlci5FdmVudC5ET01CcmVha3BvaW50QWRkZWQsIHti cmVha3BvaW50fSk7CiAKLSAgICAgICAgaWYgKCF0aGlzLl9yZXN0b3JpbmdCcmVha3BvaW50cykK LSAgICAgICAgICAgIHRoaXMuX3NhdmVCcmVha3BvaW50cygpOworICAgICAgICB0aGlzLl9zYXZl RE9NQnJlYWtwb2ludHMoKTsKICAgICB9CiAKICAgICByZW1vdmVET01CcmVha3BvaW50KGJyZWFr cG9pbnQpCg== 304705 2017-03-16 15:32:27 -0700 2017-03-16 17:23:48 -0700 Patch bug-169779-20170316153226.patch text/plain 1808 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0MDYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA0 MDljY2RmNmJmMGFiZDNhY2IyMDRkZjM3OGVlNTVjYzNiMGM2YjMzLi5lMGI4MzI1NDZhNWY5NTRk MmQxZTUxNTA3YjhhOGQwMDg0OGFhYzYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNy0wMy0xNiAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTiAocjIxMzY5MSk6IFNhdmluZyBE T00gYnJlYWtwb2ludHMgYnJva2VuIGFmdGVyIHJlZmFjdG9yaW5nCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjk3NzkKKworICAgICAgICBSZXZpZXdl ZCBieSBKb3NlcGggUGVjb3Jhcm8uCisKKyAgICAgICAgVXNlIGNvcnJlY3QgbWV0aG9kOiBfc2F2 ZUJyZWFrcG9pbnRzIC0+IF9zYXZlRE9NQnJlYWtwb2ludHMuCisKKyAgICAgICAgKiBVc2VySW50 ZXJmYWNlL0NvbnRyb2xsZXJzL0RPTURlYnVnZ2VyTWFuYWdlci5qczoKKyAgICAgICAgKFdlYklu c3BlY3Rvci5ET01EZWJ1Z2dlck1hbmFnZXIucHJvdG90eXBlLmFkZERPTUJyZWFrcG9pbnQpOgor ICAgICAgICBSZW1vdmUgY2hlY2sgYmVmb3JlIHNhdmluZyB0byBiZSBjb25zaXN0ZW50IHdpdGgg c2ltaWxhciBjb2RlIGluCisgICAgICAgIERlYnVnZ2VyTWFuYWdlciBhbmQgRE9NRGVidWdnZXJN YW5hZ2VyLgorCiAyMDE3LTAzLTE2ICBEZXZpbiBSb3Vzc28gIDx3ZWJraXRAZGV2aW5yb3Vzc28u Y29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFJUTDogZ290byBhcnJvdyBmb3Igc291cmNl IGxvY2F0aW9ucyBpcyBwb2ludGluZyB3cm9uZyB3YXkgaW4gVGltZWxpbmUgZGF0YSBncmlkcwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxl cnMvRE9NRGVidWdnZXJNYW5hZ2VyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvQ29udHJvbGxlcnMvRE9NRGVidWdnZXJNYW5hZ2VyLmpzCmluZGV4IGNhZjdlMzk3MzBj YjZhYTFlMGM3OGIwMWRmOGRhYmI2NmIwNmViNDIuLmMzY2Y1MTNiYzVlNjA0NmE2MzUwODQ0NTg5 MWVhZmQyNTRiNTkxNTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL0NvbnRyb2xsZXJzL0RPTURlYnVnZ2VyTWFuYWdlci5qcworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9ET01EZWJ1Z2dlck1hbmFnZXIu anMKQEAgLTE1MSw4ICsxNTEsNyBAQCBXZWJJbnNwZWN0b3IuRE9NRGVidWdnZXJNYW5hZ2VyID0g Y2xhc3MgRE9NRGVidWdnZXJNYW5hZ2VyIGV4dGVuZHMgV2ViSW5zcGVjdG9yLgogCiAgICAgICAg IHRoaXMuZGlzcGF0Y2hFdmVudFRvTGlzdGVuZXJzKFdlYkluc3BlY3Rvci5ET01EZWJ1Z2dlck1h bmFnZXIuRXZlbnQuRE9NQnJlYWtwb2ludEFkZGVkLCB7YnJlYWtwb2ludH0pOwogCi0gICAgICAg IGlmICghdGhpcy5fcmVzdG9yaW5nQnJlYWtwb2ludHMpCi0gICAgICAgICAgICB0aGlzLl9zYXZl QnJlYWtwb2ludHMoKTsKKyAgICAgICAgdGhpcy5fc2F2ZURPTUJyZWFrcG9pbnRzKCk7CiAgICAg fQogCiAgICAgcmVtb3ZlRE9NQnJlYWtwb2ludChicmVha3BvaW50KQo=